Re: Poppler-qt4
Am Donnerstag, 29. Juni 2006 23:18 schrieb Pino Toscano: Alle 22:06, giovedì 29 giugno 2006, Wilfried Huss ha scritto: Besides, okular's fork of the DVI code has thrown away 9 years of commit history. This is also a problem. I thougt KDE switched to SVN so that such things would not happen again. Now the files are really copied, and no history is lost. Luckly SVN is smart enough. Thank, you. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Poppler-qt4
Hi, There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Regards ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 (yes, I have to update it) and this dependancy could raise if there will be new features needed for okular, while any other application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. And if the minimum version for okular will be raised, should we keeping the kdelibs one updated? Regards, -- Pino Toscano pgpJh2pZXXraF.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
On Thursday 29 June 2006 13:57, Pino Toscano wrote: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. If Pino will merge oKular into kdegraphics, the FindPoppler[Qt4].cmake file is only used there, so I object to move it to kdelibs. In general I don't think it makes much sense to merge cmake files of playground/ as the code there is experimental/not released. Regards, Stefan pgpofBwpYTVUX.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
On Thursday 29 June 2006 14:16, Stefan Nikolaus wrote: On Thursday 29 June 2006 13:57, Pino Toscano wrote: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. If Pino will merge oKular into kdegraphics, the FindPoppler[Qt4].cmake file is only used there, so I object to move it to kdelibs. Normal to not move into kdelibs if it will merge into it. In general I don't think it makes much sense to merge cmake files of playground/ as the code there is experimental/not released. It's cmake file :) not a lib. I don't think that cmake file can be experimental (and difference between two cmake file is just search poppler version. Regards, Stefan ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
On Thursday 29 June 2006 13:57, Pino Toscano wrote: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 (yes, I have to update it) and this dependancy could raise if there will be new features needed for okular, while any other application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. And if the minimum version for okular will be raised, should we keeping the kdelibs one updated? The version difference isn't a problem if it's passed via a variable to the FindPopplerQt4.cmake module, much like what's done in FindQt4.cmake. And since the kpdf filter in koffice will use poppler one day too, moving the check to kdelibs makes sense to me. -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 (yes, I have to update it) and this dependancy could raise if there will be new features needed for okular, while any other application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. kviewshell also needs the latest cvs snapshot of poppler, but the version is not checked in the cmake file in kdegraphics. Greetings, Wilfried Huss. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
A Dijous 29 Juny 2006 17:45, Wilfried Huss va escriure: Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 (yes, I have to update it) and this dependancy could raise if there will be new features needed for okular, while any other application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. kviewshell also needs the latest cvs snapshot of poppler, but the version is not checked in the cmake file in kdegraphics. But the pdf kfile-plugin does not, it would not make sense disabling its compilation when you have poppler 0.5 for example. Can this be done with the cmake framework? And if it can, how? Anyway i obviously agree duplication is bad. Albert Greetings, Wilfried Huss. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
Am Donnerstag, 29. Juni 2006 19:38 schrieb Albert Astals Cid: A Dijous 29 Juny 2006 17:45, Wilfried Huss va escriure: Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 (yes, I have to update it) and this dependancy could raise if there will be new features needed for okular, while any other application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. kviewshell also needs the latest cvs snapshot of poppler, but the version is not checked in the cmake file in kdegraphics. But the pdf kfile-plugin does not, it would not make sense disabling its compilation when you have poppler 0.5 for example. Can this be done with the cmake framework? And if it can, how? I don't think that is really an issue. Until KDE4 is released there is most likely a stable poppler 0.6 or even 0.8. And anyone that wants to install KDE4 will need to have a very uptodate base system anyway. Anyway i obviously agree duplication is bad. Well, the duplication that is happening with kviewshell and okular is much worse than having the same cmake file in two places. But this is a different topic. Greetings, Wilfried Huss. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
A Dijous 29 Juny 2006 20:23, Wilfried Huss va escriure: Am Donnerstag, 29. Juni 2006 19:38 schrieb Albert Astals Cid: A Dijous 29 Juny 2006 17:45, Wilfried Huss va escriure: Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano: Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto: There is two cmake file which allows to search poppler-qt4: One into kdegraphics/cmake/module/FindPopplerQt4.cmake one into playground/graphics/cmake/modules/FindPoppler.cmake I am the author of the latter, and I planned to do that merge in case of a moving of okular to kdegraphics. I will want to move one into kdelibs (because it duplicates) One which is into playground search poppler-qt4 = 0.5.2 so I will add it into kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a better name for it (and renamed variable to add qt4 suffix) Can I make it ? Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 (yes, I have to update it) and this dependancy could raise if there will be new features needed for okular, while any other application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. kviewshell also needs the latest cvs snapshot of poppler, but the version is not checked in the cmake file in kdegraphics. But the pdf kfile-plugin does not, it would not make sense disabling its compilation when you have poppler 0.5 for example. Can this be done with the cmake framework? And if it can, how? I don't think that is really an issue. Until KDE4 is released there is most likely a stable poppler 0.6 or even 0.8. And anyone that wants to install KDE4 will need to have a very uptodate base system anyway. Anyway i obviously agree duplication is bad. Well, the duplication that is happening with kviewshell and okular is much worse than having the same cmake file in two places. But this is a different topic. Yeah i think i should inmediately stop coding okular (not that i do much really, Pino is the master at the moment), i might even write some mails to tell gnome dudes to stop doing gnome because we have KDE and freebsd, netbsd, openbsd hackers to stop because we already have linux so who wants to have another kernel, dude, probably i even will send a polite mail to yahoo CEO to tell them to shup up their business because Google is doing better than them in all aspects. BTW this is not the right mailing list to discuss that. Albert Greetings, Wilfried Huss. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
On Thursday 29 June 2006 19:38, Albert Astals Cid wrote: ... But the pdf kfile-plugin does not, it would not make sense disabling its compilation when you have poppler 0.5 for example. Can this be done with the cmake framework? And if it can, how? Yes. The cmake file can use e.g. CHECK_SYMBOL_EXISTS() or something like this to check whether some function exists in a given header. The result can the be used from the outside. find_package(PopplerQt4) if (POPPLERQT4_HAVE_FANCY_NEW_FEATURE) ... endif (POPPLERQT4_HAVE_FANCY_NEW_FEATURE) Bye Alex -- Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de Home: neundorf AT kde.org- http://www.kde.org alex AT neundorf.net - http://www.neundorf.net ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Poppler-qt4
Alle 22:06, giovedì 29 giugno 2006, Wilfried Huss ha scritto: Besides, okular's fork of the DVI code has thrown away 9 years of commit history. This is also a problem. I thougt KDE switched to SVN so that such things would not happen again. Now the files are really copied, and no history is lost. Luckly SVN is smart enough. Regards, -- Pino Toscano pgpmv3141BNyR.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
