Splitting Craft, move the recipes to GitHub
Hi everyone, We have been thinking about splitting the Craft recipes into a separate repository for some time now. To have a Craft core and the recipes separated would enable us to provide more stable user experience. It would allow us to use the latest recipes with the stable core. At the same time Craft tries to get rid of the image as the KDE Windows build tool. Craft offers recipes for many libraries and non KDE applications. Additionally Craft offers support for Mac, Linux and FreeBSD. In order to reach more people we intend to move the recipes to GitHub to enable non KDE contributors to add their recipes. Craft would continue to be a KDE Project on the KDE infrastructure, only the recipes would move. Cheers, Hannah signature.asc Description: OpenPGP digital signature
Re: Splitting Craft, move the recipes to GitHub
On Wednesday, 23 August 2017 15:33:09 CEST Hannah von Reth wrote: > Hi everyone, > > We have been thinking about splitting the Craft recipes into a separate > repository for some time now. > To have a Craft core and the recipes separated would enable us to > provide more stable user experience. It would allow us to use the latest > recipes with the stable core. > > At the same time Craft tries to get rid of the image as the KDE Windows > build tool. > > Craft offers recipes for many libraries and non KDE applications. > Additionally Craft offers support for Mac, Linux and FreeBSD. > > In order to reach more people we intend to move the recipes to GitHub to > enable non KDE contributors to add their recipes. > Craft would continue to be a KDE Project on the KDE infrastructure, only > the recipes would move. Does it mean that people who want to contribute to recipes for applications developed by KDE should go to github? This is more or less the same as saying "so to get rid the image of kdelibs, let's put Frameworks on github only". I'm a bit sad. -- Luigi
Re: Splitting Craft, move the recipes to GitHub
Recipes could still be accepted in Phabricator. On 23/08/2017 15:38, Luigi Toscano wrote: > On Wednesday, 23 August 2017 15:33:09 CEST Hannah von Reth wrote: >> Hi everyone, >> >> We have been thinking about splitting the Craft recipes into a separate >> repository for some time now. >> To have a Craft core and the recipes separated would enable us to >> provide more stable user experience. It would allow us to use the latest >> recipes with the stable core. >> >> At the same time Craft tries to get rid of the image as the KDE Windows >> build tool. >> >> Craft offers recipes for many libraries and non KDE applications. >> Additionally Craft offers support for Mac, Linux and FreeBSD. >> >> In order to reach more people we intend to move the recipes to GitHub to >> enable non KDE contributors to add their recipes. >> Craft would continue to be a KDE Project on the KDE infrastructure, only >> the recipes would move. > Does it mean that people who want to contribute to recipes for applications > developed by KDE should go to github? > > > This is more or less the same as saying "so to get rid the image of kdelibs, > let's put Frameworks on github only". > > > I'm a bit sad. > > signature.asc Description: OpenPGP digital signature
Re: Splitting Craft, move the recipes to GitHub
On Wed, 23 Aug 2017 15:33:09 +0200 Hannah von Reth wrote: > Hi everyone, > > We have been thinking about splitting the Craft recipes into a separate > repository for some time now. > To have a Craft core and the recipes separated would enable us to > provide more stable user experience. It would allow us to use the latest > recipes with the stable core. > sounds good. -- - Shlomi Fish http://www.shlomifish.org/ Best Introductory Programming Language - http://shlom.in/intro-lang The Blues Brothers are on a mission from God. God is on a mission from Chuck Norris. — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/ Please reply to list if it's a mailing list post - http://shlom.in/reply .
Re: Splitting Craft, move the recipes to GitHub
On woensdag 23 augustus 2017 15:38:38 CEST Luigi Toscano wrote: > On Wednesday, 23 August 2017 15:33:09 CEST Hannah von Reth wrote: > > We have been thinking about splitting the Craft recipes into a separate > > repository for some time now. > > To have a Craft core and the recipes separated would enable us to > > provide more stable user experience. It would allow us to use the latest > > recipes with the stable core. > > > > At the same time Craft tries to get rid of the image as the KDE Windows > > build tool. > > > > Craft offers recipes for many libraries and non KDE applications. > > Additionally Craft offers support for Mac, Linux and FreeBSD. > > > > In order to reach more people we intend to move the recipes to GitHub to > > enable non KDE contributors to add their recipes. > > Craft would continue to be a KDE Project on the KDE infrastructure, only > > the recipes would move. > > Does it mean that people who want to contribute to recipes for applications > developed by KDE should go to github? > > This is more or less the same as saying "so to get rid the image of kdelibs, > let's put Frameworks on github only". > > I'm a bit sad. I agree, these things should really be on KDE infrastructure. I won't repeat the long discussion we had about github for KDE or not, but most of the arguments also apply here. I think this case is really stretching where what we want to achieve with KDE's manifesto, and as a community. Moreover, it seems counter-productive to have code and recipes split on two services. Could you not merge these things from github somehow, so that we can keep the canonical copy on KDE's git, or perhaps also pull recipes from github, *in addition to* KDE's git? -- sebas http://www.kde.org | http://vizZzion.org
Re: Splitting Craft, move the recipes to GitHub
Hi, Really I don't think it's a good think. It's very easy to contribute to craft recipe on git kde It's too bad to have another access for develop recipe for kde. How we will get recipe now ? We need to download on 2 different repo ? So if it's the case why we don"t have a repo kde + a repo for other apps in githup ? Regards Le mercredi 23 août 2017, 15:33:09 CEST Hannah von Reth a écrit : > Hi everyone, > > We have been thinking about splitting the Craft recipes into a separate > repository for some time now. > To have a Craft core and the recipes separated would enable us to > provide more stable user experience. It would allow us to use the latest > recipes with the stable core. > > At the same time Craft tries to get rid of the image as the KDE Windows > build tool. > > Craft offers recipes for many libraries and non KDE applications. > Additionally Craft offers support for Mac, Linux and FreeBSD. > > In order to reach more people we intend to move the recipes to GitHub to > enable non KDE contributors to add their recipes. > Craft would continue to be a KDE Project on the KDE infrastructure, only > the recipes would move. > > > Cheers, > > Hannah -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Splitting Craft, move the recipes to GitHub
The recipes would be pulled in by a recipe so not complicated on the usage side. I also thought about using multiple sources for recipes, but I guess things could become even more complicated that way. But what I see is, if we want to evolve Craft we need to reach out to non KDE devs. On 23/08/2017 16:38, laurent Montel wrote: > Hi, > Really I don't think it's a good think. > It's very easy to contribute to craft recipe on git kde > > It's too bad to have another access for develop recipe for kde. > > How we will get recipe now ? > We need to download on 2 different repo ? > > So if it's the case why we don"t have a repo kde + a repo for other apps in > githup ? > > Regards > > Le mercredi 23 août 2017, 15:33:09 CEST Hannah von Reth a écrit : >> Hi everyone, >> >> We have been thinking about splitting the Craft recipes into a separate >> repository for some time now. >> To have a Craft core and the recipes separated would enable us to >> provide more stable user experience. It would allow us to use the latest >> recipes with the stable core. >> >> At the same time Craft tries to get rid of the image as the KDE Windows >> build tool. >> >> Craft offers recipes for many libraries and non KDE applications. >> Additionally Craft offers support for Mac, Linux and FreeBSD. >> >> In order to reach more people we intend to move the recipes to GitHub to >> enable non KDE contributors to add their recipes. >> Craft would continue to be a KDE Project on the KDE infrastructure, only >> the recipes would move. >> >> >> Cheers, >> >> Hannah > signature.asc Description: OpenPGP digital signature
Re: Splitting Craft, move the recipes to GitHub
Is there any chance for bidirectional mirroring, so that KDE projects could easily apply pull request of non KDE members? The KDE bot reply to pull request is more than discouraging. On 23/08/2017 16:24, Sebastian Kügler wrote: > On woensdag 23 augustus 2017 15:38:38 CEST Luigi Toscano wrote: >> On Wednesday, 23 August 2017 15:33:09 CEST Hannah von Reth wrote: >>> We have been thinking about splitting the Craft recipes into a separate >>> repository for some time now. >>> To have a Craft core and the recipes separated would enable us to >>> provide more stable user experience. It would allow us to use the latest >>> recipes with the stable core. >>> >>> At the same time Craft tries to get rid of the image as the KDE Windows >>> build tool. >>> >>> Craft offers recipes for many libraries and non KDE applications. >>> Additionally Craft offers support for Mac, Linux and FreeBSD. >>> >>> In order to reach more people we intend to move the recipes to GitHub to >>> enable non KDE contributors to add their recipes. >>> Craft would continue to be a KDE Project on the KDE infrastructure, only >>> the recipes would move. >> Does it mean that people who want to contribute to recipes for applications >> developed by KDE should go to github? >> >> This is more or less the same as saying "so to get rid the image of kdelibs, >> let's put Frameworks on github only". >> >> I'm a bit sad. > I agree, these things should really be on KDE infrastructure. I won't repeat > the long discussion we had about github for KDE or not, but most of the > arguments also apply here. I think this case is really stretching where what > we want to achieve with KDE's manifesto, and as a community. Moreover, it > seems counter-productive to have code and recipes split on two services. > > Could you not merge these things from github somehow, so that we can keep the > canonical copy on KDE's git, or perhaps also pull recipes from github, *in > addition to* KDE's git? signature.asc Description: OpenPGP digital signature
Re: Splitting Craft, move the recipes to GitHub
On Wed, Aug 23, 2017 at 4:24 PM, Sebastian Kügler wrote: > Could you not merge these things from github somehow, so that we can keep the > canonical copy on KDE's git, or perhaps also pull recipes from github, *in > addition to* KDE's git? 2 cents: some people already do that one simply needs to whitelist the repo from bot autoreply and handle pull requests manually. Git being what it is, there really is no technical reason against github being an additional UI on top. HS
Re: Splitting Craft, move the recipes to GitHub
On Wednesday, 23 August 2017 16:38:56 CEST laurent Montel wrote: > Hi, Heya, > Really I don't think it's a good think. > It's very easy to contribute to craft recipe on git kde Right. For us. > It's too bad to have another access for develop recipe for kde. > > How we will get recipe now ? > We need to download on 2 different repo ? Yes, and looking at ongoing splitting of repositories people usually don't mind more repositories, no? :) More realistically: Another famous manager solved this nicely, you can simply add 'recipe repos' by running a special command in the package manager itself. I'm hinting at homebrew, there adding another 'tap' (recipe repo) is as simply as doing: brew tap user/repo In craft, I could envision something similar (but less Github centric): craft --add-repo git://anongit.kde.org/kde-projects, or craft --add-repo ssh://g...@my.company.com/craft-recipes > So if it's the case why we don"t have a repo kde + a repo for other apps in > githup ? I think that's another solution (worse in my book), but something I could live with as well. But I think having at least one Github recipe repo where externals can easily contribute to non-KDE-related recipes is essential in getting Craft being used outside the KDE bubble. This repository should probably also contain (at least) all the recipes for the dependencies required to build KDE applications. Regards, Kevin > Regards > > Le mercredi 23 août 2017, 15:33:09 CEST Hannah von Reth a écrit : > > Hi everyone, > > > > We have been thinking about splitting the Craft recipes into a separate > > repository for some time now. > > To have a Craft core and the recipes separated would enable us to > > provide more stable user experience. It would allow us to use the latest > > recipes with the stable core. > > > > At the same time Craft tries to get rid of the image as the KDE Windows > > build tool. > > > > Craft offers recipes for many libraries and non KDE applications. > > Additionally Craft offers support for Mac, Linux and FreeBSD. > > > > In order to reach more people we intend to move the recipes to GitHub to > > enable non KDE contributors to add their recipes. > > Craft would continue to be a KDE Project on the KDE infrastructure, only > > the recipes would move. > > > > > > Cheers, > > > > Hannah -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.
Re: Splitting Craft, move the recipes to GitHub
Le mercredi 23 août 2017, 16:51:24 CEST Kevin Funk a écrit : > On Wednesday, 23 August 2017 16:38:56 CEST laurent Montel wrote: > > Hi, > > Heya, > > > Really I don't think it's a good think. > > It's very easy to contribute to craft recipe on git kde > > Right. For us. yep for us indeed :) (I have already qt codereview access, kdab access, kde access, and another one for kde contribution ? :) ) But how many external contributor do you have at the moment ?:) > > > It's too bad to have another access for develop recipe for kde. > > > > How we will get recipe now ? > > We need to download on 2 different repo ? > > Yes, and looking at ongoing splitting of repositories people usually don't > mind more repositories, no? :) Indeed. > > More realistically: Another famous manager solved this nicely, you can > simply add 'recipe repos' by running a special command in the package > manager itself. > > I'm hinting at homebrew, there adding another 'tap' (recipe repo) is as > simply as doing: > brew tap user/repo > > > In craft, I could envision something similar (but less Github centric): > craft --add-repo git://anongit.kde.org/kde-projects, or > craft --add-repo ssh://g...@my.company.com/craft-recipes for me it's a good idea. > > So if it's the case why we don"t have a repo kde + a repo for other apps > > in > > githup ? > > I think that's another solution (worse in my book), but something I could > live with as well. But I think having at least one Github recipe repo where > externals can easily contribute to non-KDE-related recipes is essential in > getting Craft being used outside the KDE bubble. > > This repository should probably also contain (at least) all the recipes for > the dependencies required to build KDE applications. a sync between git kde + github why not. > > Regards, > Kevin > > > Regards > > > > Le mercredi 23 août 2017, 15:33:09 CEST Hannah von Reth a écrit : > > > Hi everyone, > > > > > > We have been thinking about splitting the Craft recipes into a separate > > > repository for some time now. > > > To have a Craft core and the recipes separated would enable us to > > > provide more stable user experience. It would allow us to use the latest > > > recipes with the stable core. > > > > > > At the same time Craft tries to get rid of the image as the KDE Windows > > > build tool. > > > > > > Craft offers recipes for many libraries and non KDE applications. > > > Additionally Craft offers support for Mac, Linux and FreeBSD. > > > > > > In order to reach more people we intend to move the recipes to GitHub to > > > enable non KDE contributors to add their recipes. > > > Craft would continue to be a KDE Project on the KDE infrastructure, only > > > the recipes would move. > > > > > > > > > Cheers, > > > > > > Hannah -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Splitting Craft, move the recipes to GitHub
On Wed, Aug 23, 2017, at 03:33 PM, Hannah von Reth wrote: > Hi everyone, > Hey, > We have been thinking about splitting the Craft recipes into a separate > repository for some time now. > To have a Craft core and the recipes separated would enable us to > provide more stable user experience. It would allow us to use the latest > recipes with the stable core. > I think that is an excellent idea =) It would allow people like me to maintain a stable set of buildscripts while being able to use the latest of the buildtool itself. > At the same time Craft tries to get rid of the image as the KDE Windows > build tool. > > Craft offers recipes for many libraries and non KDE applications. > Additionally Craft offers support for Mac, Linux and FreeBSD. Neat! > In order to reach more people we intend to move the recipes to GitHub to > enable non KDE contributors to add their recipes. > Craft would continue to be a KDE Project on the KDE infrastructure, only > the recipes would move. Enough has probably been said about that. Maintaining the KDE buildscript on KDE infrastructure makes a ton of sense to me. Having a separate repository on github for more github focused projects also makes a lot of sense to me (the alternative being to have a read/write mirror). I think having to deal with multiple repositories will introduce some additional complexity as you might need to allow dependencies between them, but I also think it would be a very valuable feature. Anyways, I'd just put the KDE buildscripts on the KDE infra, create a github mirror for now, and then in the long run work on repository dependencies so it's not necessary to duplicate buildscripts in all repositories. Cheers, Christian
Re: Splitting Craft, move the recipes to GitHub
El dimecres, 23 d’agost de 2017, a les 16:45:12 CEST, Hannah von Reth va escriure: > Is there any chance for bidirectional mirroring, so that KDE projects > could easily apply > pull request of non KDE members? > The KDE bot reply to pull request is more than discouraging. It's technically *my* reply bot, not KDE's one, though I'm running it under the agreement we had on kde-devel that having unreviewed merge requests in an unofficial "web service" made no sense. Various people have complained about the message but very few have actually contributed a better wording. Not that it has been a problem for Craft since it has had exactly 0 pull requests. Cheers, Albert > > On 23/08/2017 16:24, Sebastian Kügler wrote: > > On woensdag 23 augustus 2017 15:38:38 CEST Luigi Toscano wrote: > >> On Wednesday, 23 August 2017 15:33:09 CEST Hannah von Reth wrote: > >>> We have been thinking about splitting the Craft recipes into a separate > >>> repository for some time now. > >>> To have a Craft core and the recipes separated would enable us to > >>> provide more stable user experience. It would allow us to use the latest > >>> recipes with the stable core. > >>> > >>> At the same time Craft tries to get rid of the image as the KDE Windows > >>> build tool. > >>> > >>> Craft offers recipes for many libraries and non KDE applications. > >>> Additionally Craft offers support for Mac, Linux and FreeBSD. > >>> > >>> In order to reach more people we intend to move the recipes to GitHub to > >>> enable non KDE contributors to add their recipes. > >>> Craft would continue to be a KDE Project on the KDE infrastructure, only > >>> the recipes would move. > >> > >> Does it mean that people who want to contribute to recipes for > >> applications > >> developed by KDE should go to github? > >> > >> This is more or less the same as saying "so to get rid the image of > >> kdelibs, let's put Frameworks on github only". > >> > >> I'm a bit sad. > > > > I agree, these things should really be on KDE infrastructure. I won't > > repeat the long discussion we had about github for KDE or not, but most > > of the arguments also apply here. I think this case is really stretching > > where what we want to achieve with KDE's manifesto, and as a community. > > Moreover, it seems counter-productive to have code and recipes split on > > two services. > > > > Could you not merge these things from github somehow, so that we can keep > > the canonical copy on KDE's git, or perhaps also pull recipes from > > github, *in addition to* KDE's git?
Re: Splitting Craft, move the recipes to GitHub
On Wed, Aug 23, 2017 at 7:43 PM, Albert Astals Cid wrote: > El dimecres, 23 d’agost de 2017, a les 16:45:12 CEST, Hannah von Reth va > escriure: >> Is there any chance for bidirectional mirroring, so that KDE projects >> could easily apply >> pull request of non KDE members? >> The KDE bot reply to pull request is more than discouraging. > > It's technically *my* reply bot, not KDE's one, though I'm running it under > the agreement we had on kde-devel that having unreviewed merge requests in an > unofficial "web service" made no sense. > > Various people have complained about the message but very few have actually > contributed a better wording. Not that it has been a problem for Craft since > it has had exactly 0 pull requests. If you point me to the text I'd be happy to go over it and see if I have some suggestions for improvements. Cheers Lydia -- Lydia Pintscher - http://about.me/lydia.pintscher KDE e.V. Board of Directors / KDE Community Working Group http://kde.org - http://open-advice.org
Re: Splitting Craft, move the recipes to GitHub
El dimecres, 23 d’agost de 2017, a les 20:12:54 CEST, Lydia Pintscher va escriure: > On Wed, Aug 23, 2017 at 7:43 PM, Albert Astals Cid wrote: > > El dimecres, 23 d’agost de 2017, a les 16:45:12 CEST, Hannah von Reth va > > > > escriure: > >> Is there any chance for bidirectional mirroring, so that KDE projects > >> could easily apply > >> pull request of non KDE members? > >> The KDE bot reply to pull request is more than discouraging. > > > > It's technically *my* reply bot, not KDE's one, though I'm running it > > under > > the agreement we had on kde-devel that having unreviewed merge requests in > > an unofficial "web service" made no sense. > > > > Various people have complained about the message but very few have > > actually > > contributed a better wording. Not that it has been a problem for Craft > > since it has had exactly 0 pull requests. > > If you point me to the text I'd be happy to go over it and see if I > have some suggestions for improvements. https://github.com/tsdgeos/nopullrequests/blob/master/nopr.go#L432 Note line 435 is longer than what the github UI shows. Cheers, Albert > > > Cheers > Lydia
Re: Splitting Craft, move the recipes to GitHub
On Thu, Aug 24, 2017 at 2:45 AM, Hannah von Reth wrote: > Is there any chance for bidirectional mirroring, so that KDE projects > could easily apply > pull request of non KDE members? > The KDE bot reply to pull request is more than discouraging. In theory one can still take pull requests from Github, as long as they're pushed first to git.kde.org. Our systems will then mirror it to Github automatically. A full bi-directional mirror setup could potentially run into race conditions if both change at the same time. >From my understanding of how Github's systems work, they'll automatically close pull requests as merged when they see the commits appear in the actual repository, so this should work fine once the auto-reply bot is switched off. Cheers, Ben > > > On 23/08/2017 16:24, Sebastian Kügler wrote: >> On woensdag 23 augustus 2017 15:38:38 CEST Luigi Toscano wrote: >>> On Wednesday, 23 August 2017 15:33:09 CEST Hannah von Reth wrote: We have been thinking about splitting the Craft recipes into a separate repository for some time now. To have a Craft core and the recipes separated would enable us to provide more stable user experience. It would allow us to use the latest recipes with the stable core. At the same time Craft tries to get rid of the image as the KDE Windows build tool. Craft offers recipes for many libraries and non KDE applications. Additionally Craft offers support for Mac, Linux and FreeBSD. In order to reach more people we intend to move the recipes to GitHub to enable non KDE contributors to add their recipes. Craft would continue to be a KDE Project on the KDE infrastructure, only the recipes would move. >>> Does it mean that people who want to contribute to recipes for applications >>> developed by KDE should go to github? >>> >>> This is more or less the same as saying "so to get rid the image of kdelibs, >>> let's put Frameworks on github only". >>> >>> I'm a bit sad. >> I agree, these things should really be on KDE infrastructure. I won't repeat >> the long discussion we had about github for KDE or not, but most of the >> arguments also apply here. I think this case is really stretching where what >> we want to achieve with KDE's manifesto, and as a community. Moreover, it >> seems counter-productive to have code and recipes split on two services. >> >> Could you not merge these things from github somehow, so that we can keep the >> canonical copy on KDE's git, or perhaps also pull recipes from github, *in >> addition to* KDE's git? > >
Re: Splitting Craft, move the recipes to GitHub
Thanks for all input. We will split the recipes from the Core to a new KDE repository. When multiple repositories and cross repository dependencies are properly implemented in Craft, the recipes will be split again. One repository containing non KDE recipes, this repository will be located on GitHub. A second repository will be located on the KDE infrastructure, containing KDE recipes. On the user side nothing should change. Cheers, Hannah On 23/08/2017 17:42, Christian Mollekopf wrote: > On Wed, Aug 23, 2017, at 03:33 PM, Hannah von Reth wrote: >> Hi everyone, >> > Hey, > >> We have been thinking about splitting the Craft recipes into a separate >> repository for some time now. >> To have a Craft core and the recipes separated would enable us to >> provide more stable user experience. It would allow us to use the latest >> recipes with the stable core. >> > I think that is an excellent idea =) It would allow people like me to > maintain a stable > set of buildscripts while being able to use the latest of the buildtool > itself. > >> At the same time Craft tries to get rid of the image as the KDE Windows >> build tool. >> >> Craft offers recipes for many libraries and non KDE applications. >> Additionally Craft offers support for Mac, Linux and FreeBSD. > Neat! > >> In order to reach more people we intend to move the recipes to GitHub to >> enable non KDE contributors to add their recipes. >> Craft would continue to be a KDE Project on the KDE infrastructure, only >> the recipes would move. > Enough has probably been said about that. > Maintaining the KDE buildscript on KDE infrastructure makes a ton of > sense to me. Having a separate repository on github for more github > focused projects also makes a lot of sense to me (the alternative being > to have a read/write mirror). > > I think having to deal with multiple repositories will introduce some > additional complexity as you might need to allow dependencies between > them, but I also think it would be a very valuable feature. > > Anyways, I'd just put the KDE buildscripts on the KDE infra, create a > github mirror for now, and then in the long run work on repository > dependencies so it's not necessary to duplicate buildscripts in all > repositories. > > Cheers, > Christian signature.asc Description: OpenPGP digital signature
Re: Splitting Craft, move the recipes to GitHub
On Thu, Aug 24, 2017 at 9:47 AM, Ben Cooksley wrote: > On Thu, Aug 24, 2017 at 2:45 AM, Hannah von Reth wrote: >> Is there any chance for bidirectional mirroring, so that KDE projects >> could easily apply >> pull request of non KDE members? >> The KDE bot reply to pull request is more than discouraging. > > In theory one can still take pull requests from Github, as long as > they're pushed first to git.kde.org. > Our systems will then mirror it to Github automatically. In practice, many people on github don't use proper names as author. As a consequence, pushing a github pull request is often rejected by KDE git commit hooks. I ran into exactly this problem several times by now, which is the reason why I gave up on merging github pull requests this way. So in practice, it does not work. Greetings Dominik PS: I think enforcing a proper author naming style is important for KDE, especially since sometimes we need to contact authors years later. So I am not proposing to remove the KDE commit hooks...
Re: Splitting Craft, move the recipes to GitHub
On Wed, Aug 23, 2017 at 10:04 PM, Albert Astals Cid wrote: > El dimecres, 23 d’agost de 2017, a les 20:12:54 CEST, Lydia Pintscher va > escriure: >> If you point me to the text I'd be happy to go over it and see if I >> have some suggestions for improvements. > > https://github.com/tsdgeos/nopullrequests/blob/master/nopr.go#L432 > > Note line 435 is longer than what the github UI shows. Here is a first go at improving the message: Thanks for your contribution :smiley: This repository is a mirror of a KDE repository. Unfortunately we are not able to monitor pull requests created in GitHub at this point, so I'm closing this pull request (actually a bot is doing it). However we'd love to have your contribution in KDE's software. Please see https://community.kde.org/Infrastructure/Github_Mirror for details on how to contribute to this and other KDE projects.`) Cheers Lydia -- Lydia Pintscher - http://about.me/lydia.pintscher KDE e.V. Board of Directors / KDE Community Working Group http://kde.org - http://open-advice.org
Re: Splitting Craft, move the recipes to GitHub
El dissabte, 26 d’agost de 2017, a les 20:02:27 CEST, Lydia Pintscher va escriure: > On Wed, Aug 23, 2017 at 10:04 PM, Albert Astals Cid wrote: > > El dimecres, 23 d’agost de 2017, a les 20:12:54 CEST, Lydia Pintscher va > > > > escriure: > >> If you point me to the text I'd be happy to go over it and see if I > >> have some suggestions for improvements. > > > > https://github.com/tsdgeos/nopullrequests/blob/master/nopr.go#L432 > > > > Note line 435 is longer than what the github UI shows. > > Here is a first go at improving the message: > > Thanks for your contribution :smiley: > This repository is a mirror of a KDE repository. Unfortunately we are > not able to monitor pull requests created in GitHub at this point, so > I'm closing this pull request (actually a bot is doing it). > However we'd love to have your contribution in KDE's software. Please > see https://community.kde.org/Infrastructure/Github_Mirror for details > on how to contribute to this and other KDE projects.`) I don't like the change, you replaced "This repository is a mirror of a KDE repository. This means that developers are not looking at pull requests created in GitHub" with "This repository is a mirror of a KDE repository. Unfortunately we are not able to monitor pull requests created in GitHub at this point" If you write that, people will ask "why are you not able to monitor pull requests, just star the repo, bla bla", mine is more correct, it's a mirror and thus developers are not looking at stuff that happens in the mirror. Cheers, Albert > > > Cheers > Lydia