Re: Season of KDE project on speed optimization
On Fri, Apr 29, 2011 at 12:52, Lydia Pintscher ly...@kde.org wrote: Hi :) Aaditya applied for a Season of KDE slot. He wants to work on speed optimization. Do we have a nice project for him? Ok this case is settled now. Thanks everyone! However I'd be really grateful if some more mentors can step up. I have 55 applications now and am trying to match them up with projects and mentors and I expect more to come. Helping hands are needed :D Cheers Lydia -- Lydia Pintscher Amarok community manager kde.org - amarok.kde.org - kubuntu.org claimid.com/nightrose
Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3003 --- Also, I wanted to add that Gtk already has a widget similar to your idea, called GtkInfoBar, and which is rendered by oxygen-gtk like in the screenshot below: http://simplest-image-hosting.net/jpg-0-plasma-desktopou9644 Now I must say it is not widely used in gtk land. - Hugo On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Summary --- KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ). The class documentation should make it clear how and when it can be used. This widget could be used by: - Browsers to implement their remember password widgets (Konqueror, Rekonq...) - Forms to provide feedback on validation errors - Bluedevil KCM to replace its custom No Bluetooth adapter have been found message widget - Nepomuk/Strigi KCM to indicate status of their services - Gwenview to replace its custom save bar - ... I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good. I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example. Diffs - kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e kdeui/widgets/kmessagewidget.h PRE-CREATION kdeui/widgets/kmessagewidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101249/diff Testing --- Screenshots --- Montage from kmessagewidgetdemo http://git.reviewboard.kde.org/r/101249/s/141/ Thanks, Aurélien
Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3007 --- You seem to be missing the addition of the uppercase include in kdelibs/includes kdeui/widgets/kmessagewidget.h http://git.reviewboard.kde.org/r/101249/#comment2569 Do we really need this include here? kdeui/widgets/kmessagewidget.h http://git.reviewboard.kde.org/r/101249/#comment2568 I personally prefer all the variables having a name in the header too even if in this case it's pretty obvious what they do i think it won't hurt adding them either. - Albert On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Summary --- KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ). The class documentation should make it clear how and when it can be used. This widget could be used by: - Browsers to implement their remember password widgets (Konqueror, Rekonq...) - Forms to provide feedback on validation errors - Bluedevil KCM to replace its custom No Bluetooth adapter have been found message widget - Nepomuk/Strigi KCM to indicate status of their services - Gwenview to replace its custom save bar - ... I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good. I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example. Diffs - kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e kdeui/widgets/kmessagewidget.h PRE-CREATION kdeui/widgets/kmessagewidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101249/diff Testing --- Screenshots --- Montage from kmessagewidgetdemo http://git.reviewboard.kde.org/r/101249/s/141/ Thanks, Aurélien
Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote: You seem to be missing the addition of the uppercase include in kdelibs/includes i already fixed that :) On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote: kdeui/widgets/kmessagewidget.h, line 26 http://git.reviewboard.kde.org/r/101249/diff/3/?file=15637#file15637line26 Do we really need this include here? fixed - Aaron J. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3007 --- On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Summary --- KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ). The class documentation should make it clear how and when it can be used. This widget could be used by: - Browsers to implement their remember password widgets (Konqueror, Rekonq...) - Forms to provide feedback on validation errors - Bluedevil KCM to replace its custom No Bluetooth adapter have been found message widget - Nepomuk/Strigi KCM to indicate status of their services - Gwenview to replace its custom save bar - ... I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good. I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example. Diffs - kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e kdeui/widgets/kmessagewidget.h PRE-CREATION kdeui/widgets/kmessagewidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101249/diff Testing --- Screenshots --- Montage from kmessagewidgetdemo http://git.reviewboard.kde.org/r/101249/s/141/ Thanks, Aurélien
Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: Hello Aurelien, Though I have nothing to say against the current design of your kmessagebox widget, something I miss in your implementation is the possibility for a widget style to override/replace your rendering. I can indeed imagine some styles (not oxygen though) for which your design might not integrate that well, notably skulpture for which all widgets have square corners, that won't match your nice rounded one. There is a mechanism to register custom style primitives that widget styles may or may not support, and for your custom widget to test whether the style supports the new primitive or not, allowing it to fallback to its own rendering, when not supported. I think it would be nice for your widget (and other 'custom' widgets that you'd plan to implement) to use this mechanism, for better future integration. kdeui/kdelibs/kcapacitybar implements this mechanism (the widget appears in the statusbar of dolphin to give the available space on a given device), and oxygen (as well as bespin) actually uses it to render the capacity bar as a regular progress bar, instead of the default implementation (which you can see by using any style but oxygen, or bespin, e.g. plastique). Tell me that you think, and also if needed I can help implementing if you agree with the above but are short of time to work on it. Cheers, Hugo note that this widget exposes a bug in oxygen style where when fading between two strings in a QLabel, the background is not updated. so when the text changes as well as the background color, the old background color remains. this is easily seen if you run kmessagewidgetdemo from kdeexamples/kmessagewidget/ and switch between the Information and Positive messages. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3002 --- On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Summary --- KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ). The class documentation should make it clear how and when it can be used. This widget could be used by: - Browsers to implement their remember password widgets (Konqueror, Rekonq...) - Forms to provide feedback on validation errors - Bluedevil KCM to replace its custom No Bluetooth adapter have been found message widget - Nepomuk/Strigi KCM to indicate status of their services - Gwenview to replace its custom save bar - ... I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good. I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example. Diffs - kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e kdeui/widgets/kmessagewidget.h PRE-CREATION kdeui/widgets/kmessagewidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101249/diff Testing --- Screenshots --- Montage from kmessagewidgetdemo http://git.reviewboard.kde.org/r/101249/s/141/ Thanks, Aurélien
Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: Hello Aurelien, Though I have nothing to say against the current design of your kmessagebox widget, something I miss in your implementation is the possibility for a widget style to override/replace your rendering. I can indeed imagine some styles (not oxygen though) for which your design might not integrate that well, notably skulpture for which all widgets have square corners, that won't match your nice rounded one. There is a mechanism to register custom style primitives that widget styles may or may not support, and for your custom widget to test whether the style supports the new primitive or not, allowing it to fallback to its own rendering, when not supported. I think it would be nice for your widget (and other 'custom' widgets that you'd plan to implement) to use this mechanism, for better future integration. kdeui/kdelibs/kcapacitybar implements this mechanism (the widget appears in the statusbar of dolphin to give the available space on a given device), and oxygen (as well as bespin) actually uses it to render the capacity bar as a regular progress bar, instead of the default implementation (which you can see by using any style but oxygen, or bespin, e.g. plastique). Tell me that you think, and also if needed I can help implementing if you agree with the above but are short of time to work on it. Cheers, Hugo Aaron J. Seigo wrote: note that this widget exposes a bug in oxygen style where when fading between two strings in a QLabel, the background is not updated. so when the text changes as well as the background color, the old background color remains. this is easily seen if you run kmessagewidgetdemo from kdeexamples/kmessagewidget/ and switch between the Information and Positive messages. Thanks Aaron. Its now fixed (in a temporary way) in trunk. Note: I've been planing to re-implement the label text transition for a looong time now, in a much more robust way, to avoid these kind of issues -that occur elsewhere in kde- ... But have not found time so far :( - Hugo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3002 --- On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Summary --- KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ). The class documentation should make it clear how and when it can be used. This widget could be used by: - Browsers to implement their remember password widgets (Konqueror, Rekonq...) - Forms to provide feedback on validation errors - Bluedevil KCM to replace its custom No Bluetooth adapter have been found message widget - Nepomuk/Strigi KCM to indicate status of their services - Gwenview to replace its custom save bar - ... I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good. I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example. Diffs - kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e kdeui/widgets/kmessagewidget.h PRE-CREATION kdeui/widgets/kmessagewidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101249/diff Testing --- Screenshots --- Montage from kmessagewidgetdemo http://git.reviewboard.kde.org/r/101249/s/141/ Thanks, Aurélien
Re: Top 15 Mailinglists with messages in moderation May 1st
[Tom Albers - Sonntag, 1. Mai 2011 16:00:57] Hi, New month, new list. If lists are unused, let me know, I will delete them. If someone wants to help with moderation for any of these list, let me know as well. 19 kde-news-de You can put me in change here. I will look into the moderation list ... but the list itself seems pretty dead so, let's see how it turns out. I will contact you, if I figured it out. Regards
Re: Top 15 Mailinglists with messages in moderation May 1st
- Original Message - [Tom Albers - Sonntag, 1. Mai 2011 16:00:57] Hi, New month, new list. If lists are unused, let me know, I will delete them. If someone wants to help with moderation for any of these list, let me know as well. 19 kde-news-de You can put me in change here. I will look into the moderation list ... but the list itself seems pretty dead so, let's see how it turns out. I will contact you, if I figured it out. Great, password sent in a private mail. Best. -- Tom Albers KDE Sysadmin
Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
On April 29, 2011, 7:09 p.m., Jarosław Staniek wrote: Ship it! PS: the callouts I have implemented: http://simplest-image-hosting.net/jpg-0-plasma-desktophm4013 It's BC with your API. Interesting! I am not sure however using a KMessageWidget is the best choice here: it looks like a modal choice, isn't it? At least I think the No button should be changed to Cancel. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review2970 --- On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Summary --- KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ). The class documentation should make it clear how and when it can be used. This widget could be used by: - Browsers to implement their remember password widgets (Konqueror, Rekonq...) - Forms to provide feedback on validation errors - Bluedevil KCM to replace its custom No Bluetooth adapter have been found message widget - Nepomuk/Strigi KCM to indicate status of their services - Gwenview to replace its custom save bar - ... I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good. I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example. Diffs - kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e kdeui/widgets/kmessagewidget.h PRE-CREATION kdeui/widgets/kmessagewidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101249/diff Testing --- Screenshots --- Montage from kmessagewidgetdemo http://git.reviewboard.kde.org/r/101249/s/141/ Thanks, Aurélien
