Review Request: Add a FindQtMobility.cmake file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101568/ --- Review request for kdelibs and Sebastian Kügler. Summary --- As requested by Sebas, this patch adds a FindQtMobililty.cmake that can be used to find QtMobility related files. It has support for minimum versions and searching for individual components. Diffs - cmake/modules-tests/QtMobility/CMakeLists.txt PRE-CREATION cmake/modules/FindQtMobility.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101568/diff Testing --- There is a simple testcase included. Furthermore I have tested the minimum version and component related options with a local test file. Thanks, Arjen
Review Request: New Date/Time Widgets in kdelibs/kdeui
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/ --- Review request for kdelibs, KDEPIM, KPhotoAlbum, Skrooge, Zanshin, Kevin Ottens, and David Jarvie. Summary --- [Sorry this is a post-commit review and took so long to remember to post. Bad coder, no cookie for you!] This review is for some new replacement widgets for the popular KDEPIM KDateEdit and KTimeEdit widgets which were copied into a number of other projects. These new widgets are clean rewrites (the original widgets have history back to KDE2 days) with slightly changed api but otherwise should replicate the same functionality with a couple of new features. They will be available for use by any apps using kdelibs 4.7. The 3 new widgets are: KDateComboBox: A date entry widget derived from KComboBox, the drop-down menu can display a date picker and list of fancy dates to choose from. The list of dates can be configured. KTimeComboBox: A time entry widget derived from KComboBox, the drop-down menu can display a list of times to choose from. The list of times can be configured. KDateTimeEdit: A KDateTime entry widget combining KDateComboBox and KTimeComboBox with optional combo's to select the calendar system and time spec as well. This widget should only be used if you want time spec aware data entry. All widgets can accept a null or invalid input, it is up to the coder to check for validity of input using isValid() if required. All feature options of the widgets can be configured. All widgets can optionally display a warning box on focus out if the entry is invalid. All widgets can be used in Qt Designer. I'm particularly looking for input on the api, and what QWidget event virtual methods I should be reimplementing to make the classes BIC future-proof. Diffs - kdeui/CMakeLists.txt 1e8b259 includes/KDateComboBox PRE-CREATION includes/KDateTimeEdit PRE-CREATION includes/KTimeComboBox PRE-CREATION includes/CMakeLists.txt 7a8bc5c kdeui/tests/CMakeLists.txt c7b8026 kdeui/tests/kdatecomboboxtest.h PRE-CREATION kdeui/tests/kdatecomboboxtest.cpp PRE-CREATION kdeui/tests/kdatetimeedittest.h PRE-CREATION kdeui/tests/kdatetimeedittest.cpp PRE-CREATION kdeui/tests/ktimecomboboxtest.h PRE-CREATION kdeui/tests/ktimecomboboxtest.cpp PRE-CREATION kdeui/widgets/kdatecombobox.h PRE-CREATION kdeui/widgets/kdatecombobox.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.h PRE-CREATION kdeui/widgets/kdatetimeedit.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.ui PRE-CREATION kdeui/widgets/ktimecombobox.h PRE-CREATION kdeui/widgets/ktimecombobox.cpp PRE-CREATION kdewidgets/kde.widgets 9040538 Diff: http://git.reviewboard.kde.org/r/101575/diff Testing --- Unit tests written for non-gui functionality. Gui functionality tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs, but I didn't want to hold the review up any longer. Screenshots --- Qt Designer Preview http://git.reviewboard.kde.org/r/101575/s/180/ KDateComboBox http://git.reviewboard.kde.org/r/101575/s/181/ KTimeComboBox http://git.reviewboard.kde.org/r/101575/s/182/ Thanks, John
Re: Review Request: Use the port number in the filename when caching favicons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101577/#review3830 --- Ship it! Looks ok. - Valentin On June 10, 2011, 8:34 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101577/ --- (Updated June 10, 2011, 8:34 p.m.) Review request for KDE Base Apps. Summary --- The attached patch uses the port number of a favicon's url when creating its local cache name. This helps distinguish two severs running on the same host as pointed out in the bug report listed above. This addresses bug 124482. http://bugs.kde.org/show_bug.cgi?id=124482 Diffs - lib/konq/favicons/favicons.cpp 8ba9258 Diff: http://git.reviewboard.kde.org/r/101577/diff Testing --- Thanks, Dawit
Re: Review Request: Add a FindQtMobility.cmake file
Am Freitag, 10. Juni 2011, 19:18:55 schrieb Arjen Hiemstra: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101568/ --- Review request for kdelibs and Sebastian Kügler. This should of course include our build system maintainer. Adding CC to Alex. Summary --- As requested by Sebas, this patch adds a FindQtMobililty.cmake that can be used to find QtMobility related files. It has support for minimum versions and searching for individual components. Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/#review3840 --- This review has been submitted with commit 9e1de272620da40fead11dfdb705cfc3d9a90f10 by Lukas Sommer. - Commit On June 1, 2011, 10:54 a.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated June 1, 2011, 10:54 a.m.) Review request for KDE Base Apps, KDE Runtime and kdelibs. Summary --- I've been experimenting a little bit with custom font dpi sizes in $HOME/.kde4/share/config/kcmfonts There, you can set custom font dpi value. Although the user interface (systemsettings/fonts) only provides 0 (don't force a dpi, use the system default instead), 96 and 120 as choice, in the config file you can put (manually) arbitrary values. This works mostly fine because kcontrol/krdb/krdb.cpp simply processes the dpi value of the config file as is. However, startkde.cmake doesn't. It checks if the value is 96 or 120. If not, the value is ignored and the system default is used. Result: When you use e.g. 200 as dpi value and restart KDE, then KWin uses the default value (96 dpi on my system) for the window title, while the applications themself are displayed using 200 dpi. So the applications fonts are as big as desired, but the window title is too small. See the attached screenshot. This behaviour is inconsistent. startkde.cmake should follow the same police as kcontrol/krdb/krdb.cpp does. This patch fixes this. (The user interface could be adopted in another patch.) (Make this work would benefit people who need a high display resolution. Example: You connect your computer to your plasma tv and you want to be still be able to read the text although you are at a distance of 5 meters from the tv monitor. See also bug 272266) This addresses bug 190489. http://bugs.kde.org/show_bug.cgi?id=190489 Diffs - kcontrol/fonts/fonts.h 2c722d4 kcontrol/fonts/fonts.cpp 0cd2666 startkde.cmake dde9c23 Diff: http://git.reviewboard.kde.org/r/101410/diff Testing --- I've applied the patch to my local /usr/bin/startkde file, and it works fine. Screenshots --- http://git.reviewboard.kde.org/r/101410/s/171/ Thanks, Lukas
Re: Review Request: New Date/Time Widgets in kdelibs/kdeui
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/#review3844 --- kdeui/widgets/kdatecombobox.h http://git.reviewboard.kde.org/r/101575/#comment3118 const kdeui/widgets/kdatecombobox.h http://git.reviewboard.kde.org/r/101575/#comment3119 const kdeui/widgets/kdatecombobox.cpp http://git.reviewboard.kde.org/r/101575/#comment3120 Use if ( format != d-m_displayFormat ). And similiar in other setters kdeui/widgets/kdatetimeedit.h http://git.reviewboard.kde.org/r/101575/#comment3114 const kdeui/widgets/kdatetimeedit.h http://git.reviewboard.kde.org/r/101575/#comment3115 const kdeui/widgets/kdatetimeedit.h http://git.reviewboard.kde.org/r/101575/#comment3116 const kdeui/widgets/kdatetimeedit.h http://git.reviewboard.kde.org/r/101575/#comment3117 const I recommend using virtual hooks, to help with BC/BIC issues: ( grep virtual_hook kdepimlibs/kcalcore/* ) - Sergio Luis On June 10, 2011, 9:18 p.m., John Layt wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/ --- (Updated June 10, 2011, 9:18 p.m.) Review request for kdelibs, KDEPIM, KPhotoAlbum, Skrooge, Zanshin, Kevin Ottens, and David Jarvie. Summary --- [Sorry this is a post-commit review and took so long to remember to post. Bad coder, no cookie for you!] This review is for some new replacement widgets for the popular KDEPIM KDateEdit and KTimeEdit widgets which were copied into a number of other projects. These new widgets are clean rewrites (the original widgets have history back to KDE2 days) with slightly changed api but otherwise should replicate the same functionality with a couple of new features. They will be available for use by any apps using kdelibs 4.7. The 3 new widgets are: KDateComboBox: A date entry widget derived from KComboBox, the drop-down menu can display a date picker and list of fancy dates to choose from. The list of dates can be configured. KTimeComboBox: A time entry widget derived from KComboBox, the drop-down menu can display a list of times to choose from. The list of times can be configured. KDateTimeEdit: A KDateTime entry widget combining KDateComboBox and KTimeComboBox with optional combo's to select the calendar system and time spec as well. This widget should only be used if you want time spec aware data entry. All widgets can accept a null or invalid input, it is up to the coder to check for validity of input using isValid() if required. All feature options of the widgets can be configured. All widgets can optionally display a warning box on focus out if the entry is invalid. All widgets can be used in Qt Designer. I'm particularly looking for input on the api, and what QWidget event virtual methods I should be reimplementing to make the classes BIC future-proof. Diffs - kdeui/CMakeLists.txt 1e8b259 includes/KDateComboBox PRE-CREATION includes/KDateTimeEdit PRE-CREATION includes/KTimeComboBox PRE-CREATION includes/CMakeLists.txt 7a8bc5c kdeui/tests/CMakeLists.txt c7b8026 kdeui/tests/kdatecomboboxtest.h PRE-CREATION kdeui/tests/kdatecomboboxtest.cpp PRE-CREATION kdeui/tests/kdatetimeedittest.h PRE-CREATION kdeui/tests/kdatetimeedittest.cpp PRE-CREATION kdeui/tests/ktimecomboboxtest.h PRE-CREATION kdeui/tests/ktimecomboboxtest.cpp PRE-CREATION kdeui/widgets/kdatecombobox.h PRE-CREATION kdeui/widgets/kdatecombobox.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.h PRE-CREATION kdeui/widgets/kdatetimeedit.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.ui PRE-CREATION kdeui/widgets/ktimecombobox.h PRE-CREATION kdeui/widgets/ktimecombobox.cpp PRE-CREATION kdewidgets/kde.widgets 9040538 Diff: http://git.reviewboard.kde.org/r/101575/diff Testing --- Unit tests written for non-gui functionality. Gui functionality tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs, but I didn't want to hold the review up any longer. Screenshots --- Qt Designer Preview http://git.reviewboard.kde.org/r/101575/s/180/ KDateComboBox http://git.reviewboard.kde.org/r/101575/s/181/ KTimeComboBox http://git.reviewboard.kde.org/r/101575/s/182/ Thanks, John
Review Request: Fix paste operation using mouse middle click in KLineEdit, when selected text is not cleared before paste
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101583/ --- Review request for kdelibs. Summary --- KLineEdit : Clear selected text when middle click occurs to prepare for paste operation. Diffs - kdeui/widgets/klineedit.cpp 0dd3690 Diff: http://git.reviewboard.kde.org/r/101583/diff Testing --- Thanks, Valentin
Review Request: add some currentView 0-pointer checks in konqueror/src/konqmainwindow.cp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101586/ --- Review request for KDE Base Apps. Summary --- add some currentView 0-pointer checks in konqueror/src/konqmainwindow.cpp to avoid crashes like #272557 This addresses bug 272557. http://bugs.kde.org/show_bug.cgi?id=272557 Diffs - konqueror/src/konqmainwindow.cpp a309f48 Diff: http://git.reviewboard.kde.org/r/101586/diff Testing --- Thanks, Martin
Re: Review Request: New Date/Time Widgets in kdelibs/kdeui
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/#review3846 --- kdeui/widgets/kdatecombobox.h http://git.reviewboard.kde.org/r/101575/#comment3121 missing space before const here and 4 other places kdeui/widgets/ktimecombobox.cpp http://git.reviewboard.kde.org/r/101575/#comment3123 perhaps no need to have m_ prefix for attributes in the private impl class? d-m_* looks a bit too verbose kdeui/widgets/ktimecombobox.cpp http://git.reviewboard.kde.org/r/101575/#comment3122 couldn't ki18nc() be used in such places and then KLocalizedString::subs() instead of QString::replace()? - Jarosław On June 10, 2011, 9:18 p.m., John Layt wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/ --- (Updated June 10, 2011, 9:18 p.m.) Review request for kdelibs, KDEPIM, KPhotoAlbum, Skrooge, Zanshin, Kevin Ottens, and David Jarvie. Summary --- [Sorry this is a post-commit review and took so long to remember to post. Bad coder, no cookie for you!] This review is for some new replacement widgets for the popular KDEPIM KDateEdit and KTimeEdit widgets which were copied into a number of other projects. These new widgets are clean rewrites (the original widgets have history back to KDE2 days) with slightly changed api but otherwise should replicate the same functionality with a couple of new features. They will be available for use by any apps using kdelibs 4.7. The 3 new widgets are: KDateComboBox: A date entry widget derived from KComboBox, the drop-down menu can display a date picker and list of fancy dates to choose from. The list of dates can be configured. KTimeComboBox: A time entry widget derived from KComboBox, the drop-down menu can display a list of times to choose from. The list of times can be configured. KDateTimeEdit: A KDateTime entry widget combining KDateComboBox and KTimeComboBox with optional combo's to select the calendar system and time spec as well. This widget should only be used if you want time spec aware data entry. All widgets can accept a null or invalid input, it is up to the coder to check for validity of input using isValid() if required. All feature options of the widgets can be configured. All widgets can optionally display a warning box on focus out if the entry is invalid. All widgets can be used in Qt Designer. I'm particularly looking for input on the api, and what QWidget event virtual methods I should be reimplementing to make the classes BIC future-proof. Diffs - kdeui/CMakeLists.txt 1e8b259 includes/KDateComboBox PRE-CREATION includes/KDateTimeEdit PRE-CREATION includes/KTimeComboBox PRE-CREATION includes/CMakeLists.txt 7a8bc5c kdeui/tests/CMakeLists.txt c7b8026 kdeui/tests/kdatecomboboxtest.h PRE-CREATION kdeui/tests/kdatecomboboxtest.cpp PRE-CREATION kdeui/tests/kdatetimeedittest.h PRE-CREATION kdeui/tests/kdatetimeedittest.cpp PRE-CREATION kdeui/tests/ktimecomboboxtest.h PRE-CREATION kdeui/tests/ktimecomboboxtest.cpp PRE-CREATION kdeui/widgets/kdatecombobox.h PRE-CREATION kdeui/widgets/kdatecombobox.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.h PRE-CREATION kdeui/widgets/kdatetimeedit.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.ui PRE-CREATION kdeui/widgets/ktimecombobox.h PRE-CREATION kdeui/widgets/ktimecombobox.cpp PRE-CREATION kdewidgets/kde.widgets 9040538 Diff: http://git.reviewboard.kde.org/r/101575/diff Testing --- Unit tests written for non-gui functionality. Gui functionality tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs, but I didn't want to hold the review up any longer. Screenshots --- Qt Designer Preview http://git.reviewboard.kde.org/r/101575/s/180/ KDateComboBox http://git.reviewboard.kde.org/r/101575/s/181/ KTimeComboBox http://git.reviewboard.kde.org/r/101575/s/182/ Thanks, John
