Re: Review Request: Fix bug : now KDE widges are shown in Qt Designer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101804/ --- (Updated July 30, 2011, 1:01 p.m.) Review request for kdelibs. Changes --- Could you please look at the following patch ? I think it is better the previous one, althougn not as straight forward. This way we depends less from any possible further changes in QDesignerCustomWidgetInterface. But I can ship previous one, if you found it better. Summary --- Qt designer requires that subclasses of QDesignerCustomWidgetInterface return non-empty, valid XML in domXML() function. makewidges generated empty string in this function by default. Because of this, kde widges are not shown in qt designer. This patch fix this bug. Diffs (updated) - kdewidgets/makekdewidgets.cpp cb53c04 Diff: http://git.reviewboard.kde.org/r/101804/diff Testing --- My system. Designer now see plugins generated with makewidges. Other plugins must be changed by their authors. Thanks, Artem
Re: Review Request: Fix bug : now KDE widges are shown in Qt Designer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101804/#review5234 --- To be honest, I have no clue how that file works. I was happy that my Designer worked again (only tested rev 2), and you should commit whichever you find cleaner or better. - Christoph On July 30, 2011, 1:01 p.m., Artem Serebriyskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101804/ > --- > > (Updated July 30, 2011, 1:01 p.m.) > > > Review request for kdelibs. > > > Summary > --- > > Qt designer requires that subclasses of QDesignerCustomWidgetInterface > return non-empty, valid XML in domXML() function. makewidges generated empty > string in this function by default. Because of this, kde widges are not shown > in qt designer. This patch fix this bug. > > > Diffs > - > > kdewidgets/makekdewidgets.cpp cb53c04 > > Diff: http://git.reviewboard.kde.org/r/101804/diff > > > Testing > --- > > My system. Designer now see plugins generated with makewidges. Other plugins > must be changed by their authors. > > > Thanks, > > Artem > >
Re: My Plans, Your Plans: Berlin Desktop Summit
Alex Fiestas wrote: > · Draft a plan for colord integration (next thing after krandr is fixed) That better be optional at runtime :) There aren't that many people who care about color profiles (but we really need the functionality for those who do). > · Draft a plan for systemd kde-workspace integration (there are a couple > of things we can do I think) Yes, please! :) -- Nicolas
Review Request: Improve Calculate/Stop buttons when folder Size is being calculated
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- Review request for kdelibs. Summary --- This patch improves the Calculate and Stop buttons in folder properties. Instead of having two buttons that are enabled/disabled accordingly, we only have one that toggles (technically there are still two buttons but it looks as if there was one) I removed that "Calculating..." label when there is already a size shown, instead the stop button says "Stop Calculating" and somehow serves as "indicator". Also, I added a line-break after the "Calculating..." so the label doesn't change its size making the other elements moving around. I don't know if the additional icons (view-refresh and process-cancel) add too much clutter to the visual interface since this features is not sooo important/frequently used(?) that the buttons need an icon. Diffs - kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: http://git.reviewboard.kde.org/r/102149/diff Testing --- Compiles and the buttons toggle (and react) fine. Thanks, Kai Uwe
Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- (Updated July 30, 2011, 2:51 p.m.) Review request for kdelibs. Changes --- Sorry for the noise again. Forgot a screenshot :) Summary --- This patch improves the Calculate and Stop buttons in folder properties. Instead of having two buttons that are enabled/disabled accordingly, we only have one that toggles (technically there are still two buttons but it looks as if there was one) I removed that "Calculating..." label when there is already a size shown, instead the stop button says "Stop Calculating" and somehow serves as "indicator". Also, I added a line-break after the "Calculating..." so the label doesn't change its size making the other elements moving around. I don't know if the additional icons (view-refresh and process-cancel) add too much clutter to the visual interface since this features is not sooo important/frequently used(?) that the buttons need an icon. Diffs - kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: http://git.reviewboard.kde.org/r/102149/diff Testing --- Compiles and the buttons toggle (and react) fine. Screenshots --- Screenshot of the dialog while it is calculating http://git.reviewboard.kde.org/r/102149/s/213/ Thanks, Kai Uwe
