Re: synching kactivities in kdelibs/4.7
On Tuesday, September 20, 2011 15:23:50 Christoph Feck wrote: On Tuesday 20 September 2011 14:10:54 Ivan Čukić wrote: Both kactivities/master and kdelibs/4.7 install the file lib/libkactivities.so, preventing package generation, so something has to change. kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. We release 4.8 together with kdelibs/4.7. That case is covered by the proposal to sync up kdelibs/experimental/kactivities with kde:kactivities, as you then basically do not need a separate kactivities, so nothing changes here. Conversely, not synching on our side, but users wanting to use kactivities, they'd either rely on the outdated version we're shipping in kdelibs/experimental, or have to remove the kactivities stuff from the packages, add dependencies to all the users, and add a separate package for kactivities. In my second life as packager, I've gone through exactly this process, and it made me realize how much pain we cause to packagers with this. That's why I want to avoid it by synching up. So, any objections against it keeping those two in sync? (That would mean that we'd basically do development in the separate repo, and move over the changes on a regular basis, when we've given it sufficient testing to be comfortable using it on real machines. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
Re: Building kde-workspace with latest checkout
Adding kde-core-devel, which is better suited for these kind of emails.
Seems to me that trunk is actually not up to date for kdelibs, and that
accessor to
resizeMethodHint is missing from plasma/wallpaper.h / .cpp
See patch attached. (can someone fix/commit this ?)
At least it made things compile again for me.
Hugo
Hi guys,
I keep getting this error while trying to build kde-workspace module:
[ 57%] Building CXX object
plasma/generic/wallpapers/image/CMakeFiles/plasma_wallpaper_image.dir/backgroundlistmodel.o
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:
In member function ‘virtual void Image::save(KConfigGroup)’:
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:130:66:
error: ‘resizeMethodHint’ was not declared in this scope
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:
In member function ‘virtual QWidget*
Image::createConfigurationInterface(QWidget*)’:
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:152:51:
error: ‘resizeMethodHint’ was not declared in this scope
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:241:34:
error: ‘resizeMethodHint’ was not declared in this scope
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:251:60:
error: ‘resizeMethodHint’ was not declared in this scope
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:
In member function ‘void Image::positioningChanged(int)’:
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:630:47:
error: ‘resizeMethodHint’ was not declared in this scope
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:
In member function ‘void Image::renderWallpaper(const QString)’:
/home/ggorosito/kde/kdesrc/kde/kde-workspace/plasma/generic/wallpapers/image/image.cpp:783:44:
error: ‘resizeMethodHint’ was not declared in this scope
make[2]: ***
[plasma/generic/wallpapers/image/CMakeFiles/plasma_wallpaper_image.dir/image.o]
Error 1
Full log: http://pastebin.com/UnE2m3Am
Today I talked with Aaron about this, he told me to make sure that
kdelibs is up to date and is setted up to branch KDE/4.7.. and it is:
ggorosito@glaptop:~/kde/kdesrc/kde/kdelibs$ git config --get-all
remote.origin.url
http://anongit.kde.org/kdelibs.git
ggorosito@glaptop:~/kde/kdesrc/kde/kdelibs$ git branch
* KDE/4.7
master
Any ideas!?
###
# Gonzalo Gorosito
# Programador sysadmin
#
# http://www.tutorialesdebian.com - Tutoriales para debianeros,
scripts, info, notícias y mucho mas.
# http://www.ggorosito.com.ar - Website personal
###
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
diff --git a/plasma/wallpaper.cpp b/plasma/wallpaper.cpp
index 97ec7e8..16cf3a7 100644
--- a/plasma/wallpaper.cpp
+++ b/plasma/wallpaper.cpp
@@ -421,6 +421,9 @@ void Wallpaper::setResizeMethodHint(Wallpaper::ResizeMethod
resizeMethod)
emit renderHintsChanged();
}
+Wallpaper::ResizeMethod Wallpaper::resizeMethodHint( void ) const
+{ return d-lastResizeMethod; }
+
void Wallpaper::setTargetSizeHint(const QSizeF targetSize)
{
d-targetSize = targetSize;
diff --git a/plasma/wallpaper.h b/plasma/wallpaper.h
index e1e9891..3086517 100644
--- a/plasma/wallpaper.h
+++ b/plasma/wallpaper.h
@@ -416,12 +416,17 @@ class PLASMA_EXPORT Wallpaper : public QObject
/**
* This method is invoked by setUrls(KUrl::List)
* Can be Overriden by Plugins which want to support setting Image URLs
- * Will be changed to virtual method in libplasma2/KDE5
+ * Will be changed to virtual method in libplasma2/KDE5
* @since 4.7
*/
void addUrls(const KUrl::List urls);
protected:
+
+
+Wallpaper::ResizeMethod resizeMethodHint( void ) const;
+
+
/**
* This constructor is to be used with the plugin loading systems
* found in KPluginInfo and KService. The argument list is expected
Re: Building kde-workspace with latest checkout
On Wednesday, September 21, 2011 12:07:36 Hugo Pereira Da Costa wrote: Adding kde-core-devel, which is better suited for these kind of emails. Seems to me that trunk is actually not up to date for kdelibs, and that accessor to master is dead. do not use it. use the KDE/4.7 branch for building other KDE software, or frameworks for development of kdleibs.. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part.
Re: Review Request: Show removable media in Dolphin's Copy To and Move To context menus
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102657/#review6692
---
Nice idea, but if you really want to use the Places instead, have a look at
http://api.kde.org/4.x-api/kdelibs-apidocs/kfile/html/classKFilePlacesModel.html
Basically you would only have to iterate over all rows, and get the text, icon,
and url for each model index.
- Christoph
On Sept. 18, 2011, 12:51 p.m., Rajeesh K Nambiar wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102657/
---
(Updated Sept. 18, 2011, 12:51 p.m.)
Review request for Dolphin and KDE Base Apps.
Summary
---
The most common usage for {Copy,Move} To dolphin context menus is that a
user wants to copy/move a selected file to plugged in USB drive. Show the
mounted removable media also along with Root Folder and recently used
entries.
It would be nice to have Places sidebar instead of the current
implementation, which includes Root Folder, Home Folder, Desktop Folder,
other drives including removable media like USB drives etc. See bugs 140475,
251151 et al. This should also help in scenario where plugged in removable
media is not automatically mounted (which is the default setup at least in
Fedora). I couldn't find a way to easily extend that functionality, though.
This addresses bug 251151.
http://bugs.kde.org/show_bug.cgi?id=251151
Diffs
-
lib/konq/CMakeLists.txt 8ecbfa9
lib/konq/konq_copytomenu.cpp ca1d963
Diff: http://git.reviewboard.kde.org/r/102657/diff
Testing
---
Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user.
Thanks,
Rajeesh
Re: synching kactivities in kdelibs/4.7
On Tuesday 20 September 2011 12:55:45 Christoph Feck wrote: Both kactivities/master and kdelibs/4.7 install the file lib/libkactivities.so, preventing package generation, so something has to change. The full list of collisions between kdelibs/4.7 and kactivities on my system: * /usr/bin/kactivitymanagerd * /usr/lib/debug/usr/bin/kactivitymanagerd.debug * /usr/lib/debug/usr/lib64/kde4/activitymanager_plugin_dummy.so.debug * /usr/lib/debug/usr/lib64/kde4/activitymanager_plugin_slc.so.debug * /usr/lib/debug/usr/lib64/kde4/activitymanager_plugin_nepomuk.so.debug * /usr/lib64/kde4/activitymanager_plugin_slc.so * /usr/lib64/kde4/activitymanager_plugin_nepomuk.so * /usr/lib64/kde4/activitymanager_plugin_dummy.so * /usr/share/kde4/servicetypes/activitymanager-plugin.desktop * /usr/share/kde4/services/activitymanager-plugin-slc.desktop * /usr/share/kde4/services/activitymanager-plugin-dummy.desktop * /usr/share/kde4/services/activitymanager-plugin-nepomuk.desktop * /usr/share/kde4/services/kactivitymanagerd.desktop * /usr/share/kde4/services/kded/activitymanager.desktop * /usr/lib64/libkactivities.so Regards, ~ Sput -- Manuel Sputnick Nickschas (Sput on Freenode) | (o Member of the Quassel IRC Project - http://quassel-irc.org| //\ Come visit us in #quassel!| V_/_
Re: Review Request: systemsettings/fonts: DPI setting is X11-only
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102527/#review6696 --- Ship it! - Christoph On Sept. 4, 2011, 9:37 a.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102527/ --- (Updated Sept. 4, 2011, 9:37 a.m.) Review request for KDE Base Apps, KDE Runtime and kdewin. Summary --- In systemsettings/fonts, the DPI setting affects only X11. Therefor, this setting should only be enabled when compiling on X11 (and not for compiling on MS Windows or other non-X11 window systems). Diffs - kcontrol/fonts/fonts.h 7f1c2d0 kcontrol/fonts/fonts.cpp 5a1728d Diff: http://git.reviewboard.kde.org/r/102527/diff Testing --- Tested on X11, adding an #undef Q_WS_X11 for testing purpose. Thanks, Lukas
kdelibs/master: zap it? (Was: Building kde-workspace with latest checkout)
On Wednesday 21 September 2011 7:51:50 AM Aaron J. Seigo wrote: On Wednesday, September 21, 2011 12:07:36 Hugo Pereira Da Costa wrote: Adding kde-core-devel, which is better suited for these kind of emails. Seems to me that trunk is actually not up to date for kdelibs, and that accessor to master is dead. do not use it. use the KDE/4.7 branch for building other KDE software, or frameworks for development of kdleibs.. Perhaps we should remove all of the files in the master branch? then commit a MASTER_IS_DEAD_USE_4.7 file?
Re: synching kactivities in kdelibs/4.7
kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun
Re: Review Request: Make mouse cursor size configurable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review6697 --- What I dislike is the position of the size combo box. Either it should be below the list, or, when above the list, share the space with the preview. Regarding the use DPI depended size, what we could do if we use a slider, is to have a small Revert/Default button next to the slider, like what the new Locale KCM does. Then we can have both the slider, and a way to use the automatic size. I really would like to see this in 4.8, so if this feature isn't on the feature plan yet, please add it, if you need more time for changes. Fredrik, further comments? - Christoph On Sept. 2, 2011, 4:40 p.m., Lukas Sommer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated Sept. 2, 2011, 4:40 p.m.) Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck. Summary --- X11 mouse cursor themes can contain cursors in multiple sizes, making them pseudo-scalable. It is yet possible in KDE to configure manually the mouse cursor size (editing kcminput.rc). However, the GUI of the corresponding KControl module didn't provide support to change this. This patch add support for changing the mouse cursor size to the GUI. This are mostly GUI related changes. The underlying data structure XCursorTheme did yet provide support for choosing different sizes and only needed some adjustments. This addresses bug 90444. http://bugs.kde.org/show_bug.cgi?id=90444 Diffs - kcontrol/input/xcursor/cursortheme.h 586ccba kcontrol/input/xcursor/cursortheme.cpp 92abea5 kcontrol/input/xcursor/legacytheme.h 846bf9b kcontrol/input/xcursor/previewwidget.h f4d2c4e kcontrol/input/xcursor/previewwidget.cpp 3c264fc kcontrol/input/xcursor/themepage.h 38ca893 kcontrol/input/xcursor/themepage.cpp 6c9f29a kcontrol/input/xcursor/themepage.ui 2e38054 kcontrol/input/xcursor/xcursortheme.h b474086 kcontrol/input/xcursor/xcursortheme.cpp 2ecb9ba Diff: http://git.reviewboard.kde.org/r/101701/diff Testing --- Tested locally. Works fine for me. Also when using non-standard font DPI values. Screenshots --- http://git.reviewboard.kde.org/r/101701/s/248/ Thanks, Lukas
Re: Review Request: new kded daemon to check .thumbnail directory space usage
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/#review6698 --- This review may be incomplete, I mainly did it so that you get more feedback, ideally from others, too. directoryusagenotifier/cleanupdirectory.h http://git.reviewboard.kde.org/r/102083/#comment5919 This should be the only constructor. If someone really needs to pass a QString, he can use CleanUpDirectory(KUrl(string)). This stresses the fact that he actually should have used KUrl in the first place. directoryusagenotifier/cleanupdirectory.h http://git.reviewboard.kde.org/r/102083/#comment5920 To be consistent, add m_ directoryusagenotifier/cleanupdirectory.cpp http://git.reviewboard.kde.org/r/102083/#comment5922 This if has Space inside the braces. Since this is all new code, the coding style should be consistent. Since there are other style inconsistencies, I suggest to run it through astyle-kdelibs, which can be found in kdesdk/scripts. directoryusagenotifier/directoryusagenotifier.h http://git.reviewboard.kde.org/r/102083/#comment5923 #include KDE/KJob etc. directoryusagenotifier/directoryusagenotifier.cpp http://git.reviewboard.kde.org/r/102083/#comment5925 My kdebugdialog says that 7020 is used for kded4, you either need a different ID, or switch to dynamic IDs. directoryusagenotifier/directoryusagenotifier.desktop http://git.reviewboard.kde.org/r/102083/#comment5924 It's nice that you want to help translating, but those translations are deleted on next scripty run :) Remove translations. directoryusagenotifier/directoryusagenotifier.kcfg http://git.reviewboard.kde.org/r/102083/#comment5928 If the default is to check every 2 minutes, then this is way too often. I cannot recommend a good default, but having my system cause disk contention by scanning for directory space usage every two minutes is inacceptable. directoryusagenotifier/directoryusagenotifier_prefs_base.ui http://git.reviewboard.kde.org/r/102083/#comment5927 Is there a way to get the localized/customized suffix? I have my KDE set to MB. directoryusagenotifier/directoryusagenotifier_prefs_base.ui http://git.reviewboard.kde.org/r/102083/#comment5926 Please don't use HTML strings here. It specifies a fixed font and is horrible for translators. It is okey to add simple formatting using qt br b etc. - Christoph On Sept. 2, 2011, 3:35 p.m., Jaime Torres Amate wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ --- (Updated Sept. 2, 2011, 3:35 p.m.) Review request for kdelibs. Summary --- This is not yet complete, it is missing the code to delete the files, trailing spaces and comments in spanish. (coming in next patch version) There are also some things I'm not sure how should be done... The translations in .notifyrc and .desktop files, should be removed or just keep the lines with an empty traslation? Classes names, method names and variable names are OK? This addresses bug 79943. http://bugs.kde.org/show_bug.cgi?id=79943 Diffs - CMakeLists.txt baf36cc directoryusagenotifier/CMakeLists.txt PRE-CREATION directoryusagenotifier/COPYING PRE-CREATION directoryusagenotifier/Messages.sh PRE-CREATION directoryusagenotifier/README PRE-CREATION directoryusagenotifier/cleanupdirectory.h PRE-CREATION directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION directoryusagenotifier/directoryusagenotifier.h PRE-CREATION directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION directoryusagenotifier/module.h PRE-CREATION directoryusagenotifier/module.cpp PRE-CREATION directoryusagenotifier/settings.kcfgc PRE-CREATION directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102083/diff Testing --- It works as expected. Thanks, Jaime Torres
Re: Review Request: GSoC: Errors handling during file transfer.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102388/#review6699 --- I did not review the code, so I cannot comment on it. What I am concerned about is how/when this code should be committed. I certainly believe this is 4.8 material, so it should not be committed to kdelibs/4.7, on the other hand, we have no master repo now, so developers/distributions wanting to test this would have to apply it manually, which is unfortunate for such a big feature. - Christoph On Aug. 24, 2011, 4:29 p.m., Cyril Oblikov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102388/ --- (Updated Aug. 24, 2011, 4:29 p.m.) Review request for kdelibs and David Faure. Summary --- Modeless dialog to handle interactions and modifications in CopyJob. Diffs - kio/CMakeLists.txt b517621 kio/kio/copyjob.h eb88c7a kio/kio/copyjob.cpp eff7825 kio/kio/interactiondialog/abstractinteractionitem_p.h PRE-CREATION kio/kio/interactiondialog/abstractinteractionmodel.cpp PRE-CREATION kio/kio/interactiondialog/abstractinteractionmodel_p.h PRE-CREATION kio/kio/interactiondialog/allinteractionitem.cpp PRE-CREATION kio/kio/interactiondialog/allinteractionitem_p.h PRE-CREATION kio/kio/interactiondialog/allinteractionmodel.cpp PRE-CREATION kio/kio/interactiondialog/allinteractionmodel_p.h PRE-CREATION kio/kio/interactiondialog/existinginteractionitem.cpp PRE-CREATION kio/kio/interactiondialog/existinginteractionitem_p.h PRE-CREATION kio/kio/interactiondialog/existinginteractionmodel.cpp PRE-CREATION kio/kio/interactiondialog/existinginteractionmodel_p.h PRE-CREATION kio/kio/interactiondialog/interactiondialog.h PRE-CREATION kio/kio/interactiondialog/interactiondialog.cpp PRE-CREATION kio/kio/interactiondialog/interactiondialogtab.cpp PRE-CREATION kio/kio/interactiondialog/interactiondialogtab_p.h PRE-CREATION kio/kio/interactiondialog/renameinteractionwidget.h PRE-CREATION kio/kio/interactiondialog/renameinteractionwidget.cpp PRE-CREATION kio/kio/interactiondialog/requestitemmodel.cpp PRE-CREATION kio/kio/interactiondialog/requestitemmodel_p.h PRE-CREATION kio/kio/interactiondialog/unreadableinteractionitem.cpp PRE-CREATION kio/kio/interactiondialog/unreadableinteractionitem_p.h PRE-CREATION kio/kio/interactiondialog/unreadableinteractionmodel.cpp PRE-CREATION kio/kio/interactiondialog/unreadableinteractionmodel_p.h PRE-CREATION kio/kio/jobuidelegate.h 25e0728 kio/kio/jobuidelegate.cpp 85679c2 Diff: http://git.reviewboard.kde.org/r/102388/diff Testing --- Thanks, Cyril
Re: Review Request: Speed limit in ftp kio slave
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review6700 --- Tushar, did you have time yet to update the code to reflect the review comments? - Christoph On Aug. 9, 2011, 7:16 p.m., Tushar Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/ --- (Updated Aug. 9, 2011, 7:16 p.m.) Review request for kdelibs. Summary --- - This patch contains the basic code which will put the limit on download speed of the ftp data transfer. - It is looking for speed-limit meta-data for deciding how much speed control is required. - If this meta-data is not found, code will work as it was before and no speed control related code will come into picture. - This patch is the most basic one which I have testing on my system and to the extent it is controlling the speed. - Lets say if speed limit is 30 KBps then mostly will get the avg speed around 30 to 35 KBps. - I am using QTime for measuring time elapsed between two socket read call and its precision is in millisecond. Looping is taking place in microsecond and thats why I am getting almost all the time 0 as time elapsed in between two calls. - To solve the above problem usleep is introduced to make it sync with the timer. Diffs - kioslave/ftp/CMakeLists.txt e080b02 kioslave/ftp/ftp.h 0bd375b kioslave/ftp/ftp.cpp 655524a kioslave/ftp/speedController.h PRE-CREATION kioslave/ftp/speedController.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102267/diff Testing --- Thanks, Tushar
Re: Review Request: Dolphin's preview configuration doesn't support over 2 GB files.
On Aug. 14, 2011, 10:31 a.m., Peter Penz wrote: Thanks for the patch, looks fine! Please push it to master (if you don't have a git-account please let me know and I'll push it for you) Jussi Judin wrote: No I don't so you need to do it. Peter Penz wrote: I've pushed it to master now :-) Jussi, please close this review as committed. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102319/#review5683 --- On Aug. 13, 2011, 10:03 p.m., Jussi Judin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102319/ --- (Updated Aug. 13, 2011, 10:03 p.m.) Review request for KDE Base Apps. Summary --- Fix Dolphin's preview settings to support larger preview sizes than 2 GB in size. Reported as KDE bug 280034. Diffs - dolphin/src/settings/general/previewssettingspage.cpp 590a51d Diff: http://git.reviewboard.kde.org/r/102319/diff Testing --- Steps to Reproduce: Input megabytes to maximum preview size and save configuration. Then close configuration and go to the preview settings again and notice that the maximum preview size is not megabytes. Expected Results: Maximum preview size should be the one entered in the input box after saving Dolphin's configuration. Thanks, Jussi
Re: Review Request: rate control in ftp kio slave with review comments fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102307/#review6703 --- Oh, you opened a new review instead of updating it :) Please close/discard the old review request. - Christoph On Aug. 11, 2011, 4:16 p.m., Tushar Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102307/ --- (Updated Aug. 11, 2011, 4:16 p.m.) Review request for kdelibs, Dawit Alemayehu, David Faure, Thiago Macieira, Thomas Zander, and Lukas Appelhans. Summary --- This patch is trying to clear the comments of the previous patch.(https://git.reviewboard.kde.org/r/102307/) Diffs - kioslave/ftp/CMakeLists.txt e080b02 kioslave/ftp/ftp.cpp 655524a kioslave/ftp/ratecontroller.h PRE-CREATION kioslave/ftp/ratecontroller.cpp PRE-CREATION kioslave/ftp/speedController.h PRE-CREATION kioslave/ftp/speedController.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102307/diff Testing --- Thanks, Tushar
Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated
On Aug. 9, 2011, 9:40 a.m., David Faure wrote: What I don't like about a single button, is that it creates a race. The calculation takes too long, you want to abort it. You click on the button, and half a second before, the calculation actually ended. So your click triggers a Calculate again, and the annoying calculation that you wanted to stop, is starting again. It can be stopped a second time of course, but this still makes for an annoying user experience. Thomas Lübking wrote: Simple solution: disarm (or just disable) the button for about a second after the calculation has ended, ie. clicking the button leads to no action (should be fine since recalculating after a second has no point?) Ideally the mousebuttonpress event would be eaten but the button doesn't look disabled. (click - click failed - click again) Just disconnecting from the slot for that timeframe is suboptimal, since the function might appear to be broken (click - push - nothing happens?) Setting it disabled serves that functionality but causes visual flicker and raises the question why the button was disabled. You could install an eventfilter to return true on mousepress/release events on the button and remove it from a timerevent or singleshot timer (just QTimer::singleShot() should be fine as well if you can ensure that you won't run two of them at once) Christoph Feck wrote: Calculating... (time goes on) Calculation Done (clicking has no effect, then about 2 seconds later) Refresh Kai, did you have time yet to address the comments? - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/#review5534 --- On July 30, 2011, 2:51 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102149/ --- (Updated July 30, 2011, 2:51 p.m.) Review request for kdelibs. Summary --- This patch improves the Calculate and Stop buttons in folder properties. Instead of having two buttons that are enabled/disabled accordingly, we only have one that toggles (technically there are still two buttons but it looks as if there was one) I removed that Calculating... label when there is already a size shown, instead the stop button says Stop Calculating and somehow serves as indicator. Also, I added a line-break after the Calculating... so the label doesn't change its size making the other elements moving around. I don't know if the additional icons (view-refresh and process-cancel) add too much clutter to the visual interface since this features is not sooo important/frequently used(?) that the buttons need an icon. Diffs - kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: http://git.reviewboard.kde.org/r/102149/diff Testing --- Compiles and the buttons toggle (and react) fine. Screenshots --- Screenshot of the dialog while it is calculating http://git.reviewboard.kde.org/r/102149/s/213/ Thanks, Kai Uwe
Re: Building kde-workspace with latest checkout
On Wednesday, September 21, 2011 11:56:59 Gorosito Gonzalo wrote: My kdelibs its already on KDE/4.7: it was part of commit 6ef2c70949c0188f72789b924d9d88b8fb72459e -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part.
Re: kdelibs/master: zap it? (Was: Building kde-workspace with latest checkout)
On Wed, Sep 21, 2011 at 09:02:53AM -0400, Allen Winter wrote: On Wednesday 21 September 2011 7:51:50 AM Aaron J. Seigo wrote: On Wednesday, September 21, 2011 12:07:36 Hugo Pereira Da Costa wrote: Adding kde-core-devel, which is better suited for these kind of emails. Seems to me that trunk is actually not up to date for kdelibs, and that accessor to master is dead. do not use it. use the KDE/4.7 branch for building other KDE software, or frameworks for development of kdleibs.. Perhaps we should remove all of the files in the master branch? then commit a MASTER_IS_DEAD_USE_4.7 file? you know, one can simply remove the master branch and point HEAD to something else ... ;)
Re: synching kactivities in kdelibs/4.7
Hello! kde-workspace cannot be build because cmake requests: Adjust CMAKE_MODULE_PATH to find FindKActivities.cmake or set KActivities_DIR to the directory containing a CMake configuration file for KActivities. The file will have one of the following names: KActivitiesConfig.cmake kactivities-config.cmake what is to do? On Wed, 21 Sep 2011 11:57:33 +0200, Sebastian Kügler se...@kde.org wrote: On Tuesday, September 20, 2011 15:23:50 Christoph Feck wrote: On Tuesday 20 September 2011 14:10:54 Ivan Čukić wrote: Both kactivities/master and kdelibs/4.7 install the file Thanks -- guy-kde
Re: synching kactivities in kdelibs/4.7
On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1
Re: synching kactivities in kdelibs/4.7
I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1 It could even be with a switch like phonon in Qt (but default = disabled) -- The bleeding hearts and artists, Make their stand. -- Pink Floyd
Re: Review Request: New Date/Time Widgets in kdelibs/kdeui
On Aug. 15, 2011, 6:11 p.m., Torgny Nyblom wrote: Any progress? This is the monthly reminder that you cannot disable :P - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/#review5719 --- On June 10, 2011, 9:18 p.m., John Layt wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/ --- (Updated June 10, 2011, 9:18 p.m.) Review request for kdelibs, KDEPIM, KPhotoAlbum, Skrooge, Zanshin, Kevin Ottens, and David Jarvie. Summary --- [Sorry this is a post-commit review and took so long to remember to post. Bad coder, no cookie for you!] This review is for some new replacement widgets for the popular KDEPIM KDateEdit and KTimeEdit widgets which were copied into a number of other projects. These new widgets are clean rewrites (the original widgets have history back to KDE2 days) with slightly changed api but otherwise should replicate the same functionality with a couple of new features. They will be available for use by any apps using kdelibs 4.7. The 3 new widgets are: KDateComboBox: A date entry widget derived from KComboBox, the drop-down menu can display a date picker and list of fancy dates to choose from. The list of dates can be configured. KTimeComboBox: A time entry widget derived from KComboBox, the drop-down menu can display a list of times to choose from. The list of times can be configured. KDateTimeEdit: A KDateTime entry widget combining KDateComboBox and KTimeComboBox with optional combo's to select the calendar system and time spec as well. This widget should only be used if you want time spec aware data entry. All widgets can accept a null or invalid input, it is up to the coder to check for validity of input using isValid() if required. All feature options of the widgets can be configured. All widgets can optionally display a warning box on focus out if the entry is invalid. All widgets can be used in Qt Designer. I'm particularly looking for input on the api, and what QWidget event virtual methods I should be reimplementing to make the classes BIC future-proof. Diffs - kdeui/CMakeLists.txt 1e8b259 includes/KDateComboBox PRE-CREATION includes/KDateTimeEdit PRE-CREATION includes/KTimeComboBox PRE-CREATION includes/CMakeLists.txt 7a8bc5c kdeui/tests/CMakeLists.txt c7b8026 kdeui/tests/kdatecomboboxtest.h PRE-CREATION kdeui/tests/kdatecomboboxtest.cpp PRE-CREATION kdeui/tests/kdatetimeedittest.h PRE-CREATION kdeui/tests/kdatetimeedittest.cpp PRE-CREATION kdeui/tests/ktimecomboboxtest.h PRE-CREATION kdeui/tests/ktimecomboboxtest.cpp PRE-CREATION kdeui/widgets/kdatecombobox.h PRE-CREATION kdeui/widgets/kdatecombobox.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.h PRE-CREATION kdeui/widgets/kdatetimeedit.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.ui PRE-CREATION kdeui/widgets/ktimecombobox.h PRE-CREATION kdeui/widgets/ktimecombobox.cpp PRE-CREATION kdewidgets/kde.widgets 9040538 Diff: http://git.reviewboard.kde.org/r/101575/diff Testing --- Unit tests written for non-gui functionality. Gui functionality tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs, but I didn't want to hold the review up any longer. Screenshots --- Qt Designer Preview http://git.reviewboard.kde.org/r/101575/s/180/ KDateComboBox http://git.reviewboard.kde.org/r/101575/s/181/ KTimeComboBox http://git.reviewboard.kde.org/r/101575/s/182/ Thanks, John
Re: synching kactivities in kdelibs/4.7
Hi guys, Just add this to your .kdesrc-buildrc file, right before the kde-workspace module-set: module-set repository kde-projects use-modules kactivities end module-set then ./kdesrc-build kactivities ./kdesrc-build kde-workspace Enjoy ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### 2011/9/21 Rodrigo Belém rclbe...@gmail.com: On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1
Re: Review Request: New Date/Time Widgets in kdelibs/kdeui
On Aug. 15, 2011, 6:11 p.m., Torgny Nyblom wrote: Any progress? Christoph Feck wrote: This is the monthly reminder that you cannot disable :P Hee hee :-) Sorry, long since implemented, was in the 4.7 release. I just need to finish the apidox which are a bit sparse, but I won't keep it open just for that. - John --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/#review5719 --- On June 10, 2011, 9:18 p.m., John Layt wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101575/ --- (Updated June 10, 2011, 9:18 p.m.) Review request for kdelibs, KDEPIM, KPhotoAlbum, Skrooge, Zanshin, Kevin Ottens, and David Jarvie. Summary --- [Sorry this is a post-commit review and took so long to remember to post. Bad coder, no cookie for you!] This review is for some new replacement widgets for the popular KDEPIM KDateEdit and KTimeEdit widgets which were copied into a number of other projects. These new widgets are clean rewrites (the original widgets have history back to KDE2 days) with slightly changed api but otherwise should replicate the same functionality with a couple of new features. They will be available for use by any apps using kdelibs 4.7. The 3 new widgets are: KDateComboBox: A date entry widget derived from KComboBox, the drop-down menu can display a date picker and list of fancy dates to choose from. The list of dates can be configured. KTimeComboBox: A time entry widget derived from KComboBox, the drop-down menu can display a list of times to choose from. The list of times can be configured. KDateTimeEdit: A KDateTime entry widget combining KDateComboBox and KTimeComboBox with optional combo's to select the calendar system and time spec as well. This widget should only be used if you want time spec aware data entry. All widgets can accept a null or invalid input, it is up to the coder to check for validity of input using isValid() if required. All feature options of the widgets can be configured. All widgets can optionally display a warning box on focus out if the entry is invalid. All widgets can be used in Qt Designer. I'm particularly looking for input on the api, and what QWidget event virtual methods I should be reimplementing to make the classes BIC future-proof. Diffs - kdeui/CMakeLists.txt 1e8b259 includes/KDateComboBox PRE-CREATION includes/KDateTimeEdit PRE-CREATION includes/KTimeComboBox PRE-CREATION includes/CMakeLists.txt 7a8bc5c kdeui/tests/CMakeLists.txt c7b8026 kdeui/tests/kdatecomboboxtest.h PRE-CREATION kdeui/tests/kdatecomboboxtest.cpp PRE-CREATION kdeui/tests/kdatetimeedittest.h PRE-CREATION kdeui/tests/kdatetimeedittest.cpp PRE-CREATION kdeui/tests/ktimecomboboxtest.h PRE-CREATION kdeui/tests/ktimecomboboxtest.cpp PRE-CREATION kdeui/widgets/kdatecombobox.h PRE-CREATION kdeui/widgets/kdatecombobox.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.h PRE-CREATION kdeui/widgets/kdatetimeedit.cpp PRE-CREATION kdeui/widgets/kdatetimeedit.ui PRE-CREATION kdeui/widgets/ktimecombobox.h PRE-CREATION kdeui/widgets/ktimecombobox.cpp PRE-CREATION kdewidgets/kde.widgets 9040538 Diff: http://git.reviewboard.kde.org/r/101575/diff Testing --- Unit tests written for non-gui functionality. Gui functionality tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs, but I didn't want to hold the review up any longer. Screenshots --- Qt Designer Preview http://git.reviewboard.kde.org/r/101575/s/180/ KDateComboBox http://git.reviewboard.kde.org/r/101575/s/181/ KTimeComboBox http://git.reviewboard.kde.org/r/101575/s/182/ Thanks, John
Re: synching kactivities in kdelibs/4.7
Please don't tell me a binary incompatible change in a stable branch is seriously being considered. Flabbergasted, Maks On 9/21/11, Gorosito Gonzalo xgonz...@gmail.com wrote: Hi guys, Just add this to your .kdesrc-buildrc file, right before the kde-workspace module-set: module-set repository kde-projects use-modules kactivities end module-set then ./kdesrc-build kactivities ./kdesrc-build kde-workspace Enjoy ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### 2011/9/21 Rodrigo Belém rclbe...@gmail.com: On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1
Re: Review Request: Speed limit in ftp kio slave
On Sept. 21, 2011, 1:50 p.m., Christoph Feck wrote: Tushar, did you have time yet to update the code to reflect the review comments? ya all are closed. I actually opened new request for it. As I was doing it first time, instead of updating this I added new request. - Tushar --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review6700 --- On Aug. 9, 2011, 7:16 p.m., Tushar Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/ --- (Updated Aug. 9, 2011, 7:16 p.m.) Review request for kdelibs. Summary --- - This patch contains the basic code which will put the limit on download speed of the ftp data transfer. - It is looking for speed-limit meta-data for deciding how much speed control is required. - If this meta-data is not found, code will work as it was before and no speed control related code will come into picture. - This patch is the most basic one which I have testing on my system and to the extent it is controlling the speed. - Lets say if speed limit is 30 KBps then mostly will get the avg speed around 30 to 35 KBps. - I am using QTime for measuring time elapsed between two socket read call and its precision is in millisecond. Looping is taking place in microsecond and thats why I am getting almost all the time 0 as time elapsed in between two calls. - To solve the above problem usleep is introduced to make it sync with the timer. Diffs - kioslave/ftp/CMakeLists.txt e080b02 kioslave/ftp/ftp.h 0bd375b kioslave/ftp/ftp.cpp 655524a kioslave/ftp/speedController.h PRE-CREATION kioslave/ftp/speedController.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102267/diff Testing --- Thanks, Tushar
Re: Review Request: new kded daemon to check .thumbnail directory space usage
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ --- (Updated Sept. 21, 2011, 7:37 p.m.) Review request for kdelibs. Changes --- Done a lot of improvements, like: * I was using a QList as a queue, now use a Queue. * It is now ready to handle more than one directory to check. (the previous patch had some problems :-(). I know now what the Notify Contexts are. They need a little more information in the documentation :-) * It only deletes regular files, otherwise it is too risky (I've deleted my home directory in the development process some times, not anymore). * fixed Christoph warnings, except one. * The suffix MiB or MB because as you have seen in all this years, I'm not good at GUI programming (yet). If someone is able to create a configuration to add/remove/select more than one directory, the maximum space allowed, and if it will be deleted automatically or not, and also change the configuration read/save, it will be able to work with more than one directory. At the moment, only $HOME/.thumbnails. Summary (updated) --- Checks the head of a queue of directories every x minutes (default 30) to see if this directory (and children) use more space than the allowed (default 512 Mib). If so, it shows a notification allowing the user to clean the oldest files, open the file manager, or configure the daemon (time to wait for the next directory, delete automatically...). This addresses bug 79943. http://bugs.kde.org/show_bug.cgi?id=79943 Diffs (updated) - CMakeLists.txt 1d7c637 directoryusagenotifier/CMakeLists.txt PRE-CREATION directoryusagenotifier/COPYING PRE-CREATION directoryusagenotifier/Messages.sh PRE-CREATION directoryusagenotifier/README PRE-CREATION directoryusagenotifier/cleanupdirectory.h PRE-CREATION directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION directoryusagenotifier/directoryusagenotifier.h PRE-CREATION directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION directoryusagenotifier/directoryusagenotifier_config.cpp PRE-CREATION directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION directoryusagenotifier/module.h PRE-CREATION directoryusagenotifier/module.cpp PRE-CREATION directoryusagenotifier/settings.kcfgc PRE-CREATION directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102083/diff Testing (updated) --- It works as expected. It shows the notification, and deletes the oldest files in the .thumbnail directory until the files left use less or equal space than the specified. Thanks, Jaime Torres
Re: synching kactivities in kdelibs/4.7
On Wednesday 21 September 2011, Maksim Orlovich wrote: Please don't tell me a binary incompatible change in a stable branch is seriously being considered. Well, I guess it depends how you look at it. kactivities is definitely marked as experimental in kdelibs/4.7. Do we give any guarantees for experimental libraries? If yes, where? Do we promise that an experimental library does not change in a BIC way from one minor release to the next? If yes, where? Regards, Ingo On 9/21/11, Gorosito Gonzalo xgonz...@gmail.com wrote: Hi guys, Just add this to your .kdesrc-buildrc file, right before the kde-workspace module-set: module-set repository kde-projects use-modules kactivities end module-set then ./kdesrc-build kactivities ./kdesrc-build kde-workspace Enjoy ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### 2011/9/21 Rodrigo Belém rclbe...@gmail.com: On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1 signature.asc Description: This is a digitally signed message part.
Re: synching kactivities in kdelibs/4.7
No, Its that the kdesrc-build script automatically attempts to build all from master and Aaron's change on kde-workspace's master is only compatible with kdelibs stable (KDE/4.7). ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### On Wed, Sep 21, 2011 at 3:42 PM, Maksim Orlovich m...@cornell.edu wrote: Please don't tell me a binary incompatible change in a stable branch is seriously being considered. Flabbergasted, Maks On 9/21/11, Gorosito Gonzalo xgonz...@gmail.com wrote: Hi guys, Just add this to your .kdesrc-buildrc file, right before the kde-workspace module-set: module-set repository kde-projects use-modules kactivities end module-set then ./kdesrc-build kactivities ./kdesrc-build kde-workspace Enjoy ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### 2011/9/21 Rodrigo Belém rclbe...@gmail.com: On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1
I like KDE and I write code, therefore ...
So guys, Earlier I was taking a look into the KDE bugs pool, so, what if I want to fix any? Should I fix here in my machine and upload a patch to the ticket and see if any authorized developer aprooves it? is there any simple path to start fixing things by myself? I know, there is the getting started page, but I want to know if its any practical way to get involved for me, because in my case, I'm not good writting documentation or translating things, I just like to write code. Thanks ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ###
Re: synching kactivities in kdelibs/4.7
On Thu, Sep 22, 2011 at 7:01 AM, Gorosito Gonzalo xgonz...@gmail.com wrote: No, Its that the kdesrc-build script automatically attempts to build all from master and Aaron's change on kde-workspace's master is only compatible with kdelibs stable (KDE/4.7). The following change to your ~/.kdesrc-buildrc file should fix this: module-set repository kde-projects use-modules kdelibs branch KDE/4.7 end module-set module-set repository kde-projects use-modules kactivities kde-runtime end module-set ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### Regards, Ben On Wed, Sep 21, 2011 at 3:42 PM, Maksim Orlovich m...@cornell.edu wrote: Please don't tell me a binary incompatible change in a stable branch is seriously being considered. Flabbergasted, Maks On 9/21/11, Gorosito Gonzalo xgonz...@gmail.com wrote: Hi guys, Just add this to your .kdesrc-buildrc file, right before the kde-workspace module-set: module-set repository kde-projects use-modules kactivities end module-set then ./kdesrc-build kactivities ./kdesrc-build kde-workspace Enjoy ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ### 2011/9/21 Rodrigo Belém rclbe...@gmail.com: On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1
Re: I like KDE and I write code, therefore ...
A Dimecres, 21 de setembre de 2011, Gorosito Gonzalo vàreu escriure: So guys, Earlier I was taking a look into the KDE bugs pool, so, what if I want to fix any? Should I fix here in my machine and upload a patch to the ticket and see if any authorized developer aprooves it? That should work, but for some projects it is recommended to use reviewboard (https://git.reviewboard.kde.org/ or https://svn.reviewboard.kde.org/). If after posting the patch and waiting a sensible time you get no answer you can go to IRC and/or mail some mailing list saying that you did this nice patch and got no answer on it. Albert P.S: Welcome to KDE :-) P.S.2: In IRC we have #kde-devel-es in case you are interested is there any simple path to start fixing things by myself? I know, there is the getting started page, but I want to know if its any practical way to get involved for me, because in my case, I'm not good writting documentation or translating things, I just like to write code. Thanks ### # Gonzalo Gorosito # Programador sysadmin # # http://www.tutorialesdebian.com - Tutoriales para debianeros, scripts, info, notícias y mucho mas. # http://www.ggorosito.com.ar - Website personal ###
Re: I like KDE and I write code, therefore ...
On Sep 22 00:01, Albert Astals Cid wrote: A Dimecres, 21 de setembre de 2011, Gorosito Gonzalo vàreu escriure: So guys, Earlier I was taking a look into the KDE bugs pool, so, what if I want to fix any? Should I fix here in my machine and upload a patch to the ticket and see if any authorized developer aprooves it? That should work, but for some projects it is recommended to use reviewboard (https://git.reviewboard.kde.org/ or https://svn.reviewboard.kde.org/). If after posting the patch and waiting a sensible time you get no answer you can go to IRC and/or mail some mailing list saying that you did this nice patch and got no answer on it. Albert P.S: Welcome to KDE :-) P.S.2: In IRC we have #kde-devel-es in case you are interested On the lines of what Albert suggested, this is what I did to get involved (quite recent): - Found a small improvement which I thought would be good to have. - Read up http://techbase.kde.org/Getting_Started - Dug the code, developed a small patch. - Read http://techbase.kde.org/Contribute - Submitted it to reviewboard marking the project maintainer. - Had a discussion on it. - He suggested a few changes, which I incorporated. - And my patch was there in the repository. :) After this, there is a lot to explore, a lot to learn, a lot to fix and a lot to write! :) Thanks Albert for the IRC channel, I didn't know about that. -- Chirag Anand http://atvariance.in
Re: Re: I like KDE and I write code, therefore ...
A Dijous, 22 de setembre de 2011, Chirag Anand vàreu escriure: On Sep 22 00:01, Albert Astals Cid wrote: A Dimecres, 21 de setembre de 2011, Gorosito Gonzalo vàreu escriure: So guys, Earlier I was taking a look into the KDE bugs pool, so, what if I want to fix any? snip P.S.2: In IRC we have #kde-devel-es in case you are interested snip Thanks Albert for the IRC channel, I didn't know about that. #kde-devel-es is the Spanish channel(since i recognized Gorosito as probably being a Spanish speaker), if you drop the -es and go #kde-devel that is the English one :-) Albert -- Chirag Anand http://atvariance.in
Re: Re: I like KDE and I write code, therefore ...
On Sep 22 00:29, Albert Astals Cid wrote: A Dijous, 22 de setembre de 2011, Chirag Anand vàreu escriure: On Sep 22 00:01, Albert Astals Cid wrote: A Dimecres, 21 de setembre de 2011, Gorosito Gonzalo vàreu escriure: So guys, Earlier I was taking a look into the KDE bugs pool, so, what if I want to fix any? snip P.S.2: In IRC we have #kde-devel-es in case you are interested snip Thanks Albert for the IRC channel, I didn't know about that. #kde-devel-es is the Spanish channel(since i recognized Gorosito as probably being a Spanish speaker), if you drop the -es and go #kde-devel that is the English one :-) Yeah I did, at the English channel now. :) -- Chirag Anand http://atvariance.in
Re: synching kactivities in kdelibs/4.7
On Wednesday, September 21, 2011 21:55:49 Ingo Klöcker wrote: On Wednesday 21 September 2011, Maksim Orlovich wrote: Please don't tell me a binary incompatible change in a stable branch is seriously being considered. Well, I guess it depends how you look at it. kactivities is definitely marked as experimental in kdelibs/4.7. Do we give any guarantees for experimental libraries? If yes, where? Do we promise that an experimental library does not change in a BIC way from one minor release to the next? If yes, where? My understanding is that binary compatibility is explicitly disclaimed for experimental libs. Of course, there's still the argument that such a break should only occur across new feature releases, not bugfix releases. I'm not sure if that case is accounted for in whatever we published when we came up with kdelibs/experimental Either way I believe the end result should still be binary compatible if you replace kdelibs 4.7.1 with kactivities+kdelibs 4.7.2, no? Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.
Re: synching kactivities in kdelibs/4.7
On Thursday, September 22, 2011 09:43:46 Ben Cooksley wrote: On Thu, Sep 22, 2011 at 7:01 AM, Gorosito Gonzalo xgonz...@gmail.com wrote: No, Its that the kdesrc-build script automatically attempts to build all from master and Aaron's change on kde-workspace's master is only compatible with kdelibs stable (KDE/4.7). The following change to your ~/.kdesrc-buildrc file should fix this: module-set repository kde-projects use-modules kdelibs branch KDE/4.7 end module-set module-set repository kde-projects use-modules kactivities kde-runtime end module-set In addition if you already have kdelibs in a module-set and don't feel like splitting it out into its own module set just to change an option, you can do something like this: module-set kde-meta repository kde-projects use-modules kdelibs kactivities kde-runtime end module-set module kdelibs branch KDE/4.7 end module kdesrc-build will then feed that option into its internal definition with kdelibs while leaving the build order unchanged. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.
