Re: Review Request: Copy files instead of moving if parent dir is not writable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/#review11942 --- I don't mind this approach - some things need to be related to the private activity that can't be encapsulated in it. The things that should be added here are (something I forgot) is first to check whether url is a local file or not. If not, it should act like it is unmovable. (web pages...) - Ivan Čukić On March 27, 2012, 2:22 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated March 27, 2012, 2:22 p.m.) Review request for KDE Runtime and Plasma. Description --- When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent permission denied messages for every resource being added. This addresses bug 296808. http://bugs.kde.org/show_bug.cgi?id=296808 Diffs - service/jobs/nepomuk/Move.h 8a8afd1 service/jobs/nepomuk/Move.cpp 08a3cc2 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing --- Works on Meego devel image. The file is copied and no error message is shown. Thanks, Lamarque Vieira Souza
Re: simon: Review for move to extragear/accessibility
Hi again, More than two weeks have pased since the last report (3.3.) against Simon in kdereview. If there are no objections, I'll file the sysadmin request to move it to extragear/accessibility tomorrow. Thanks. Best regards, Peter
Re: Review Request: Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104322/ --- (Updated March 28, 2012, 8:32 p.m.) Review request for kdelibs. Changes --- Move styleOption setup in a method Description --- Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate Diffs (updated) - kdeui/itemviews/kwidgetitemdelegate_p.h 7c1d2174ea32245ea8bc92ea3efc589e0166cc41 kdeui/itemviews/kwidgetitemdelegate.cpp 4378e417af2469bb52896648cce70bc523a07a16 Diff: http://git.reviewboard.kde.org/r/104322/diff/ Testing --- Thanks, Daniele Elmo Domenichelli
Re: Review Request: Copy files instead of moving if parent dir is not writable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated March 29, 2012, 2:37 a.m.) Review request for KDE Runtime and Plasma. Changes --- Fix some errors. Description --- When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent permission denied messages for every resource being added. This addresses bug 296808. http://bugs.kde.org/show_bug.cgi?id=296808 Diffs (updated) - service/jobs/nepomuk/Move.h 8a8afd1 service/jobs/nepomuk/Move.cpp 08a3cc2 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing (updated) --- Works for resources of type app, it does not work for image yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is image. Thanks, Lamarque Vieira Souza
Re: Review Request: Copy files instead of moving if parent dir is not writable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated March 29, 2012, 1:58 a.m.) Review request for KDE Runtime and Plasma. Changes --- QFileInfo does not work with urls like file:///path/to/file, we must use /path/to/file. Only urls with scheme file can be moved now. Owning a folder and not having permission to write to it is a bit suspecious, so let's allow kio show the permission denied dialog when trying to move a file/folder in such situation. Description --- When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent permission denied messages for every resource being added. This addresses bug 296808. http://bugs.kde.org/show_bug.cgi?id=296808 Diffs (updated) - service/jobs/nepomuk/Move.h 8a8afd1 service/jobs/nepomuk/Move.cpp 08a3cc2 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing --- Works on Meego devel image. The file is copied and no error message is shown. Thanks, Lamarque Vieira Souza
