Fwd: import kde-thumbnail-po into kdesdk
Hi, My friend ask me to forward this mail since maillist seems to think his mail is spam. -- Forwarded message -- From: nihui Date: 2012/4/20 Subject: import kde-thumbnail-po into kdesdk To: kde-core-devel hi all I think it is the time to import kde-thumbnailer-po[1] into kdesdk. There was a same plugin in the old kde3 days, but got removed with kbabel altogether. this plugin depends on gettext-po library Though I have already implemented lots of kde thumbnailer plugins and made some releases on kde-apps.org, this po plugin is the most popular and got high voting. I think it should be quite useful for many users, especially the translators using KDE. [1]http://kde-apps.org/content/show.php/KDE+PO+Thumbnailer?content=142036 regards, nihui
Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 20, 2012, 11:55 a.m.) Review request for kdelibs. Changes --- Fix ArrayInstance::defineOwnProperty (ECMAScript Edition 5.1r6 - 15.4.5.1) Step 3d, return after Exception While ECMAScript explicitly tells to return in all other situations, it does not in this case. But it only makes sense to not apply the invalid new length, otherwise we can define any invalid array length. + Some tests show that we must not continue Description --- KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty This is a pretty big patch, to get Object.defineProperty perfect for ecmascript (for all tests that only use implemented stuff, all test that use Object.create for example will fail, as its not implemented) PropertyDescriptor: Necessary for collectiong data, this introduce new CommonIdentifiers.h, this might requiere to rebuild khtml against new kjs, otherwise it might cause weird crashes (at least for me) object.h: Beside from adding new getPropertyDescriptor & getOwnPropertyDescriptor & defineOwnProperty, the important changes are making getPropertyAttributes, put/get/remove-Direct virtual. Why do I need that? Because put checks if the prototype already has property XYZ and uses it. Now imagine an array that got a setter-only property via a prototype. DefineProperty would try to use put, which uses the prototype property and it would fail. So all custom-data classes like Array need to implement/use put/get/remove-Direct. object.cpp: currently put on a setter-only property would always throw an exception, this is only correct for strict-mode, as we currently do not check for strict-mode it would make more sense to change it to default not throwing an exception. array.cpp/h: The old Array implementation did not store attributes for array indexes, I rewrote it to also store the attributes. + Bonus: also fix getOwnPropertyNames, as we now store attributes. + use new attributes, reject put/delete/enum if set function.cpp (Arguments) changed the default attributes how parameter are stored, according to ECMA 10.6.11.b Rest is "just" the defineProperty implementation Diffs (updated) - kjs/CMakeLists.txt 1188064 kjs/CommonIdentifiers.h 8ee40e8 kjs/array_instance.h 3f2b630 kjs/array_instance.cpp fe9b8b4 kjs/function.h 3757fe8 kjs/function.cpp 5f39ae6 kjs/object.h 047c242 kjs/object.cpp c19122f kjs/object_object.cpp 986f03f kjs/operations.h f8a28c8 kjs/operations.cpp d4c0066 kjs/propertydescriptor.h PRE-CREATION kjs/propertydescriptor.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104515/diff/ Testing --- ecmascript & daily surfing used valgrind on many array testcases to check for possible memleaks Thanks, Bernd Buschinski
Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/ --- (Updated April 20, 2012, 11:48 a.m.) Review request for kdelibs. Changes --- Fix return type of Object.keys & Object.getOwnPropertyNames to be a proper Array Description --- KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames NOTE: Array was left out on purpose, as currentl imeplementation does not save attributes (next patch will fix this) keys&GetOwnPropertyNames requieres to change the JSObject::getOwnPropertyNames implementation, for future use a enum is better than than a bool, maybe there will be more ways to include/exclude properties. All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings Diffs (updated) - khtml/ecma/kjs_css.h aba44b8 khtml/ecma/kjs_css.cpp e3e7417 khtml/ecma/kjs_dom.h d0433c3 khtml/ecma/kjs_dom.cpp 5fff7e3 khtml/ecma/kjs_html.h 0f3f544c khtml/ecma/kjs_html.cpp e3da95c khtml/ecma/kjs_scriptable.h af5343c khtml/ecma/kjs_scriptable.cpp 5d4ea68 kjs/JSVariableObject.h a8f01eb kjs/JSVariableObject.cpp b00ef76 kjs/array_instance.h 3f2b630 kjs/array_instance.cpp fe9b8b4 kjs/function.h 3757fe8 kjs/function.cpp 5f39ae6 kjs/object.h 047c242 kjs/object.cpp c19122f kjs/object_object.cpp 986f03f kjs/property_map.h 6b127ff kjs/property_map.cpp b2ff08e kjs/string_object.h e890d52 kjs/string_object.cpp 170e2f7 Diff: http://git.reviewboard.kde.org/r/104511/diff/ Testing --- ecma script & daily surfing Thanks, Bernd Buschinski
Re: Review Request: make folderview icons translucent if composite is enabled
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/ --- (Updated April 19, 2012, 11:29 p.m.) Review request for KDE Base Apps. Changes --- I know that this won't get merged (I agree, it is a total hack), but maybe someone is still interested and want's to use this patch. So I rebased it on current KDE 4.8 GIT (=4.8.2). Description --- This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine. The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows: http://bugreports.qt.nokia.com/browse/QTBUG-8519 This addresses bug 256475. http://bugs.kde.org/show_bug.cgi?id=256475 Diffs (updated) - plasma/applets/folderview/iconview.h e648ff0 plasma/applets/folderview/iconview.cpp 3186b18 Diff: http://git.reviewboard.kde.org/r/101463/diff/ Testing --- Thanks, Mathias Stephan Panzenböck
Re: Pairs going to KDE Edu
On Thu, Apr 19, 2012 at 4:45 PM, Andrius da Costa Ribas wrote: > Hello, > > Please find attached suggested patches to fix/improve Windows build. > > (ps: I'm not in kde-edu mailing list, so this e-mail will probably be > blocked there). > > Thanks, > Andrius. > > > 2012/4/17 Albert Astals Cid >> >> El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure: >> > Hi, >> > Last friday Pairs [1] was moved from playground/edu to kdereview >> > because we want it to be moved to kdeedu. We have been working on it >> > for a while already and we would like it to move to kde edu and to be >> > included in the next KDE release. >> > >> > If someone is interested, please take a look into it and tell us what >> > you >> > think. >> >> More problems: >> * The repo is marked as inactive in projects.kde.org, so scripty doesn't >> run >> over it >> * The desktop file has X-DocPath but you removed the doc >> * The desktop file has X-Ubuntu-Gettext-Domain=desktop_kdesdk >> >> Albert >> >> > >> > Thanks! >> > Aleix >> > >> > PS: It has a notable artwork lacking that's being worked on, slowly. >> > Although if anybody is interested in joining, we are welcoming people >> > >> > :). >> > >> > [1] https://projects.kde.org/projects/kdereview/pairs > > > > ___ > kde-edu mailing list > kde-...@mail.kde.org > https://mail.kde.org/mailman/listinfo/kde-edu > Hi Andrius, Thanks for your patches, I'll review and integrate them ASAP. Thanks for the effort :) Aleix
