Re: KDELibsNightly.cmake
On Sunday 20 May 2012 21:28:51 Alexander Neundorf wrote: > On Sunday 20 May 2012, Rolf Eike Beer wrote: > > Am Sonntag, 20. Mai 2012, 12:55:54 schrieb Volker Krause: > > > On Sunday 20 May 2012 10:08:11 Andreas Pakulat wrote: > > > > Anyway, I guess the guys ultimately knowning how this is done for > > > > kdelibs are Alex or Volker... > > techbase doesn't seem to answer today. > This script should be fine, it supports git too. > If not, we can fix this, but AFAIK it should be working with git. > > This is like the minimal generic ctest script for running a nightly build. > It handles all the generic stuff like the bootstrapping problem, setting the > directories, finding make, etc. > > In some not-KDE project I use it everyday (with svn) and it works without > problems. > > I was working quite active on this until Akademy last year, but since then > I've been completely busy with cmake/KDE frameworks. > > You may want to have a look at cdash@home, which is an extension to cdash to > schedule builds, so clients have to do less: > http://www.kitware.com/products/html/TheCDashHomeCloud.html > > > > I'm not using those scripts either. My nightly build just calls ctest > > > directly, similar to what you have done. Instead of the -D shortcut I > > > use > > > -M/- T though, to also enable the coverage upload and valgrinded test > > > run > > > steps. > > > > CTest on what? An already build tree? How do you get the build results > > then? Or which CTest script do you use? Would you mind updating that > > techbase page on how that works? > > I'm not sure what Volker does really produces "Nightly build" results and > not "just" a snapshot of the current build tree. It also does not solve the > bootstrap problem. Right, I did the bootstrapping manually back then (the build pre-dates the script IIRC). So, it's just a cron job running cmake and ctest on an existing checkout. regards, Volker signature.asc Description: This is a digitally signed message part.
Re: Review Request: kjs: Introduce & use leftFirst parameter in relation check, according to Ecmascript 5.1r6.
> On May 13, 2012, 2:07 p.m., Maks Orlovich wrote: > > Any performance effect? With sunspider, out of 10x10 runs with and without the patch, this turns out to be a small performance improvement. As I really couldn't believe it I reverted everything and tested again, but the results are the same. with this patch, after 10x10 runs AVG: 2790.5875ms without this patch, after 10x10 runs AVG: 2846.6625ms diff: 56.075ms So... at least for sunspider its a small performance improvement - Bernd --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104906/#review13780 --- On May 10, 2012, 7:01 p.m., Bernd Buschinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104906/ > --- > > (Updated May 10, 2012, 7:01 p.m.) > > > Review request for kdelibs. > > > Description > --- > > kjs: Introduce & use leftFirst parameter in relation check, according to > Ecmascript 5.1r6. > > This fixes the access order for Greater-than and Less-than-or-equal Operator > > > NOTE: please ignore patch r1, it was the wrong patch, luckily normal View > Diff always points to the latest version :) > > > Diffs > - > > kjs/bytecode/codes.def bcd2e3a > kjs/operations.h f8a28c8 > kjs/operations.cpp d4c0066 > > Diff: http://git.reviewboard.kde.org/r/104906/diff/ > > > Testing > --- > > ecma 11.8.2 tests > > > Thanks, > > Bernd Buschinski > >
Re: Review Request: kjs: Fix Errorprototype inheritance
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104908/#review14002 --- This review has been submitted with commit b99b48e7e71b3e7a48557bed6a8809fc405cfdba by Bernd Buschinski to branch KDE/4.8. - Commit Hook On May 10, 2012, 7:01 p.m., Bernd Buschinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104908/ > --- > > (Updated May 10, 2012, 7:01 p.m.) > > > Review request for kdelibs. > > > Description > --- > > kjs: Fix Errorprototype inheritance, it must inherit from ErrorInstance to > get the correct classInfo > > > Without the patch > > Error.prototype.toString=Object.prototype.toString; > print(Error.prototype.toString()); > > will tell us that Error is an Object, not an Error > > before: > [object Object] > > after: > [object Error] > > > Diffs > - > > kjs/error_object.h c3cd64d > kjs/error_object.cpp 1f176d7 > > Diff: http://git.reviewboard.kde.org/r/104908/diff/ > > > Testing > --- > > > Thanks, > > Bernd Buschinski > >
Re: Review Request: kjs: Update Error.prototype.toString to ECMA Edition 5.1r6 format
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104907/#review14001 --- This review has been submitted with commit bdf228b3b8c850ffdb56f67e4499e6c995c19bf6 by Bernd Buschinski to branch KDE/4.8. - Commit Hook On May 10, 2012, 7:01 p.m., Bernd Buschinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104907/ > --- > > (Updated May 10, 2012, 7:01 p.m.) > > > Review request for kdelibs. > > > Description > --- > > kjs: Update Error.prototype.toString to ECMA Edition 5.1r6 format > > only slightly different from existing format, but nicer in case name or > message is empty > > > Diffs > - > > kjs/error_object.cpp 1f176d7 > > Diff: http://git.reviewboard.kde.org/r/104907/diff/ > > > Testing > --- > > > Thanks, > > Bernd Buschinski > >
Re: KDELibsNightly.cmake
On Sunday 20 May 2012, Rolf Eike Beer wrote: > Am Sonntag, 20. Mai 2012, 12:55:54 schrieb Volker Krause: > > On Sunday 20 May 2012 10:08:11 Andreas Pakulat wrote: > > > Anyway, I guess the guys ultimately knowning how this is done for > > > kdelibs are Alex or Volker... techbase doesn't seem to answer today. This script should be fine, it supports git too. If not, we can fix this, but AFAIK it should be working with git. This is like the minimal generic ctest script for running a nightly build. It handles all the generic stuff like the bootstrapping problem, setting the directories, finding make, etc. In some not-KDE project I use it everyday (with svn) and it works without problems. I was working quite active on this until Akademy last year, but since then I've been completely busy with cmake/KDE frameworks. You may want to have a look at cdash@home, which is an extension to cdash to schedule builds, so clients have to do less: http://www.kitware.com/products/html/TheCDashHomeCloud.html > > I'm not using those scripts either. My nightly build just calls ctest > > directly, similar to what you have done. Instead of the -D shortcut I use > > -M/- T though, to also enable the coverage upload and valgrinded test run > > steps. > > CTest on what? An already build tree? How do you get the build results > then? Or which CTest script do you use? Would you mind updating that > techbase page on how that works? I'm not sure what Volker does really produces "Nightly build" results and not "just" a snapshot of the current build tree. It also does not solve the bootstrap problem. Alex
Re: KDELibsNightly.cmake
Am Sonntag, 20. Mai 2012, 12:55:54 schrieb Volker Krause: > On Sunday 20 May 2012 10:08:11 Andreas Pakulat wrote: > > Anyway, I guess the guys ultimately knowning how this is done for kdelibs > > are Alex or Volker... > > I'm not using those scripts either. My nightly build just calls ctest > directly, similar to what you have done. Instead of the -D shortcut I use > -M/- T though, to also enable the coverage upload and valgrinded test run > steps. CTest on what? An already build tree? How do you get the build results then? Or which CTest script do you use? Would you mind updating that techbase page on how that works? Eike signature.asc Description: This is a digitally signed message part.
Re: KDELibsNightly.cmake
On Sunday 20 May 2012 10:08:11 Andreas Pakulat wrote: > Hi, > > On Sat, May 19, 2012 at 8:07 PM, Rolf Eike Beer wrote: > > Am Donnerstag, 17. Mai 2012, 13:30:24 schrieb Andreas Pakulat: > > > Hi, > > > > > > I think this techbase article is pretty much up-to-date. I guess the > > > KDElibsNighly.cmake file should simply be deleted. > > > http://techbase.kde.org/Development/CMake/DashboardBuilds > > > > This points to quality/nightly-support/KDE/KDELibsNightly.cmake: > > > > # The VCS of KDE is "svn", also specify the repository > > set(KDE_CTEST_VCS svn) > > set(KDE_CTEST_VCS_REPOSITORY svn:// > > anonsvn.kde.org/home/kde/trunk/KDE/kdelibs) > > Ooops :| Should do my homework better I guess. I've meanwhile tried > kdevplatform (since I don't have kdelibs here) and for that one all thats > necessary today is running ctest -D Experimental or ctest -D Nightly to run > the tests and upload the results (and also build IIRC). > > Anyway, I guess the guys ultimately knowning how this is done for kdelibs > are Alex or Volker... I'm not using those scripts either. My nightly build just calls ctest directly, similar to what you have done. Instead of the -D shortcut I use -M/- T though, to also enable the coverage upload and valgrinded test run steps. regards, Volker signature.asc Description: This is a digitally signed message part.
Re: kio and frameworks 5
On Sat, 2012-05-19 at 10:52 -0400, Dawit A wrote: > > > On Fri, May 18, 2012 at 11:31 PM, Ben Martin > wrote: > I'm wondering if there is a timeframe for KIO refresh in KDE5? > > Getting improved metadata handling in there would be a great > benefit > IMHO. To the point where I might start attaching patches to > that > effect ;) > > > What does improved meta-data handling mean ? Sending additional > ioslave specific information to/from the ioslave and vise-versa ? If > that is the case, then it is already possible to do that right now to > some degree using KIO's meta data system. > Excellent. I'll have to dig into this to see how much of libferris' metadata I can expose for read/write if it was a kio slave. I'm thinking about metadata like KFileMetaInfo can offer: a collection of key-value pairs each of which has schema data associated. The schema for KFileMetaInfoItem::properties() gives the primary type related stuff I'm thinking about. signature.asc Description: This is a digitally signed message part
Re: KDELibsNightly.cmake
Hi, On Sat, May 19, 2012 at 8:07 PM, Rolf Eike Beer wrote: > Am Donnerstag, 17. Mai 2012, 13:30:24 schrieb Andreas Pakulat: > > Hi, > > > > I think this techbase article is pretty much up-to-date. I guess the > > KDElibsNighly.cmake file should simply be deleted. > > http://techbase.kde.org/Development/CMake/DashboardBuilds > > This points to quality/nightly-support/KDE/KDELibsNightly.cmake: > > # The VCS of KDE is "svn", also specify the repository > set(KDE_CTEST_VCS svn) > set(KDE_CTEST_VCS_REPOSITORY svn:// > anonsvn.kde.org/home/kde/trunk/KDE/kdelibs) Ooops :| Should do my homework better I guess. I've meanwhile tried kdevplatform (since I don't have kdelibs here) and for that one all thats necessary today is running ctest -D Experimental or ctest -D Nightly to run the tests and upload the results (and also build IIRC). Anyway, I guess the guys ultimately knowning how this is done for kdelibs are Alex or Volker... Andreas
