Re: Review Request 110330: Make Prompt on access kwalletd setting apply in more situations
On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: I'd like to enable this by default, most people I know from the community thinks alike. Code wise it makes sense. For clarification: Do you mean enable (= prompt, already the default) or disable (be silent)? - Eike --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32224 --- On May 6, 2013, 5:28 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 6, 2013, 5:28 p.m.) Review request for KDE Runtime and Harald Sitter. Description --- kwalletd has a Prompt when an application accesses an open wallet config option. If this option is enabled (it is by default) any such access attempt opens a dialog box asking the user to approve or deny the attempt, and optionally remember the decision for the future. This patch moves the evaluation of this config option into the codepath taken by any app authorization check, in effect turning it into a Prompt when an application accesses a wallet setting. The purpose is to allow distributions such as Kubuntu and Netrunner which want to make KWallet mostly invisible during routine operations to disable this setting by default and so avoid the user being prompted to grant applications wallet access rights in more situations. (It should be pointed out that application identity is apparently based on KAboutData information anyway, and so the security of this system is dubious to begin with.) In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up. This diff is to be applied after the diff in: https://git.reviewboard.kde.org/r/110328/ A patch rewording the checkbox label in kwalletmanager has been posted for review here: https://git.reviewboard.kde.org/r/110331/ Diffs - kwalletd/kwalletd.cpp fa9fc11 Diff: http://git.reviewboard.kde.org/r/110330/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
Re: Review Request 110330: Make Prompt on access kwalletd setting apply in more situations
On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: I'd like to enable this by default, most people I know from the community thinks alike. Code wise it makes sense. Eike Hein wrote: For clarification: Do you mean enable (= prompt, already the default) or disable (be silent)? Silent. App identification on wallet are as secure as nothing, so we better have nothing and with that a better user experience. - Àlex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32224 --- On May 6, 2013, 5:28 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 6, 2013, 5:28 p.m.) Review request for KDE Runtime and Harald Sitter. Description --- kwalletd has a Prompt when an application accesses an open wallet config option. If this option is enabled (it is by default) any such access attempt opens a dialog box asking the user to approve or deny the attempt, and optionally remember the decision for the future. This patch moves the evaluation of this config option into the codepath taken by any app authorization check, in effect turning it into a Prompt when an application accesses a wallet setting. The purpose is to allow distributions such as Kubuntu and Netrunner which want to make KWallet mostly invisible during routine operations to disable this setting by default and so avoid the user being prompted to grant applications wallet access rights in more situations. (It should be pointed out that application identity is apparently based on KAboutData information anyway, and so the security of this system is dubious to begin with.) In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up. This diff is to be applied after the diff in: https://git.reviewboard.kde.org/r/110328/ A patch rewording the checkbox label in kwalletmanager has been posted for review here: https://git.reviewboard.kde.org/r/110331/ Diffs - kwalletd/kwalletd.cpp fa9fc11 Diff: http://git.reviewboard.kde.org/r/110330/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
Re: libs/kworkspace/kdisplaymanager.cpp mess
Am Dienstag, 7. Mai 2013, 22:21:46 schrieb Àlex Fiestas: Would be nice to have some kind of unittests on this, that will make a different with the current implementation (which afaik it has none) Even better would be to have them first to prove that nothing changed afterwards ;) Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request 110090: Clean up kickoff from stale bits
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110090/#review32262 --- Ship it! Thanks for the cleanup. You might also want to remove the references to Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated anyway. Please include a descriptive commit message explaining that this patch also fixes build problems for people without Strigi. - Raphael Kubo da Costa On April 20, 2013, 1:13 a.m., Max Brazhnikov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110090/ --- (Updated April 20, 2013, 1:13 a.m.) Review request for kde-workspace. Description --- kickoff links to strigiqtdbusclient, but Strigi is not used since svn r1018482. Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e2888 plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake cecf380 Diff: http://git.reviewboard.kde.org/r/110090/diff/ Testing --- Thanks, Max Brazhnikov
Re: Review Request 110330: Make Prompt on access kwalletd setting apply in more situations
On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: I'd like to enable this by default, most people I know from the community thinks alike. Code wise it makes sense. Eike Hein wrote: For clarification: Do you mean enable (= prompt, already the default) or disable (be silent)? Àlex Fiestas wrote: Silent. App identification on wallet are as secure as nothing, so we better have nothing and with that a better user experience. Yes, please! - Volker --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32224 --- On May 6, 2013, 5:28 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 6, 2013, 5:28 p.m.) Review request for KDE Runtime and Harald Sitter. Description --- kwalletd has a Prompt when an application accesses an open wallet config option. If this option is enabled (it is by default) any such access attempt opens a dialog box asking the user to approve or deny the attempt, and optionally remember the decision for the future. This patch moves the evaluation of this config option into the codepath taken by any app authorization check, in effect turning it into a Prompt when an application accesses a wallet setting. The purpose is to allow distributions such as Kubuntu and Netrunner which want to make KWallet mostly invisible during routine operations to disable this setting by default and so avoid the user being prompted to grant applications wallet access rights in more situations. (It should be pointed out that application identity is apparently based on KAboutData information anyway, and so the security of this system is dubious to begin with.) In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up. This diff is to be applied after the diff in: https://git.reviewboard.kde.org/r/110328/ A patch rewording the checkbox label in kwalletmanager has been posted for review here: https://git.reviewboard.kde.org/r/110331/ Diffs - kwalletd/kwalletd.cpp fa9fc11 Diff: http://git.reviewboard.kde.org/r/110330/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
Re: Review Request 110330: Make Prompt on access kwalletd setting apply in more situations
On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: I'd like to enable this by default, most people I know from the community thinks alike. Code wise it makes sense. Eike Hein wrote: For clarification: Do you mean enable (= prompt, already the default) or disable (be silent)? Àlex Fiestas wrote: Silent. App identification on wallet are as secure as nothing, so we better have nothing and with that a better user experience. Volker Krause wrote: Yes, please! +10 - Harald --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32224 --- On May 6, 2013, 5:28 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 6, 2013, 5:28 p.m.) Review request for KDE Runtime and Harald Sitter. Description --- kwalletd has a Prompt when an application accesses an open wallet config option. If this option is enabled (it is by default) any such access attempt opens a dialog box asking the user to approve or deny the attempt, and optionally remember the decision for the future. This patch moves the evaluation of this config option into the codepath taken by any app authorization check, in effect turning it into a Prompt when an application accesses a wallet setting. The purpose is to allow distributions such as Kubuntu and Netrunner which want to make KWallet mostly invisible during routine operations to disable this setting by default and so avoid the user being prompted to grant applications wallet access rights in more situations. (It should be pointed out that application identity is apparently based on KAboutData information anyway, and so the security of this system is dubious to begin with.) In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up. This diff is to be applied after the diff in: https://git.reviewboard.kde.org/r/110328/ A patch rewording the checkbox label in kwalletmanager has been posted for review here: https://git.reviewboard.kde.org/r/110331/ Diffs - kwalletd/kwalletd.cpp fa9fc11 Diff: http://git.reviewboard.kde.org/r/110330/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
Review Request 110367: Add JoinTheGame menu entry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/ --- Review request for kdelibs. Description --- Patch by Pau ages ago, Lydia wants to push for it again. Note that i still find it ugly, but i'm not the kdeui maintainer, so i'll leave it to someone else to discuss. Not sure if the StandardAction enum addition should be at the end in case someone is storing those enums in a file or something. Diffs - kdecore/doc/README.kiosk b95002d kdeui/CMakeLists.txt b439e04 kdeui/actions/kstandardaction.h 3064301 kdeui/actions/kstandardaction.cpp 7de0c6f kdeui/actions/kstandardaction_p.h b8f8df1 kdeui/dialogs/jointhegame.png PRE-CREATION kdeui/dialogs/kaboutkdedialog_p.cpp b9728bf kdeui/dialogs/kjointhegamedialog_p.h PRE-CREATION kdeui/dialogs/kjointhegamedialog_p.cpp PRE-CREATION kdeui/shortcuts/kstandardshortcut.h b31e45c kdeui/shortcuts/kstandardshortcut.cpp 669f750 kdeui/widgets/khelpmenu.h 3389068 kdeui/widgets/khelpmenu.cpp f547c46 kdeui/xmlgui/ui_standards.rc a0f5bed Diff: http://git.reviewboard.kde.org/r/110367/diff/ Testing --- Ran okular, saw the new menu entry, it did stuff. Ran ksnapshot (that doesn't use xmlgui), saw the new menu entry, it did the same stuff. Thanks, Albert Astals Cid
Re: Requesting freeze exception for JtG
El Dimarts, 7 de maig de 2013, a les 19:10:15, Lydia Pintscher va escriure: On Tue, May 7, 2013 at 12:41 AM, Albert Astals Cid aa...@kde.org wrote: I guess now that we have a not totally frozen kdelibs you could just commit it to master and merge to frameworks and be done with it. Obviously needs to happen before the Soft/Hard Freeze. Is there anyone willing and able to do this? I can't unfortunately. Personally I don't think it looks nice in our menus, but i'm not the kdeui maintainer. I'll let people with an opinion discuss if we want it in or not. Meanwhile i've done the grunt work. https://git.reviewboard.kde.org/r/110367/ Cheers, Albert Cheers Lydia -- Lydia Pintscher - http://about.me/lydia.pintscher KDE Community Working Group / KDE e.V. board member http://kde.org - http://open-advice.org
Re: Requesting freeze exception for JtG
On Thu, May 9, 2013 at 12:23 AM, Albert Astals Cid aa...@kde.org wrote: Personally I don't think it looks nice in our menus, but i'm not the kdeui maintainer. I'll let people with an opinion discuss if we want it in or not. Meanwhile i've done the grunt work. https://git.reviewboard.kde.org/r/110367/ Thank you! Much appreciated. Cheers Lydia -- Lydia Pintscher - http://about.me/lydia.pintscher KDE Community Working Group / KDE e.V. board member http://kde.org - http://open-advice.org
Re: Review Request 110330: Make Prompt on access kwalletd setting apply in more situations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 8, 2013, 11:12 p.m.) Review request for KDE Runtime and Harald Sitter. Changes --- Changed the setting default as requested. Note: I most likely won't be available for further updates until Monday. Description --- kwalletd has a Prompt when an application accesses an open wallet config option. If this option is enabled (it is by default) any such access attempt opens a dialog box asking the user to approve or deny the attempt, and optionally remember the decision for the future. This patch moves the evaluation of this config option into the codepath taken by any app authorization check, in effect turning it into a Prompt when an application accesses a wallet setting. The purpose is to allow distributions such as Kubuntu and Netrunner which want to make KWallet mostly invisible during routine operations to disable this setting by default and so avoid the user being prompted to grant applications wallet access rights in more situations. (It should be pointed out that application identity is apparently based on KAboutData information anyway, and so the security of this system is dubious to begin with.) In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up. This diff is to be applied after the diff in: https://git.reviewboard.kde.org/r/110328/ A patch rewording the checkbox label in kwalletmanager has been posted for review here: https://git.reviewboard.kde.org/r/110331/ Diffs (updated) - kwalletd/kwalletd.cpp fa9fc11 Diff: http://git.reviewboard.kde.org/r/110330/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
Re: Review Request 110331: Sync kwalletmanager settings UI to kwalletd changes proposed in review 110330
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110331/ --- (Updated May 8, 2013, 11:16 p.m.) Review request for KDE Runtime and Harald Sitter. Changes --- This updated diff syncs the default value of the setting to the changed default in the parent review. Note: I most likely won't be available for further updates until Monday. Description --- This adapts the checkbox label to the kwalletd behavior change proposed in: https://git.reviewboard.kde.org/r/110330/ Diffs (updated) - konfigurator/konfigurator.cpp 3cc1b3f konfigurator/walletconfigwidget.ui bbb006d Diff: http://git.reviewboard.kde.org/r/110331/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
