Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110423/#review8
---

Ship it!


Ship It!


kurifilter-plugins/ikws/searchproviderdlg.cpp


Please remove this whitespace though it was already there.


- Dawit Alemayehu


On May 28, 2013, 6:37 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110423/
> ---
> 
> (Updated May 28, 2013, 6:37 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> ---
> 
> This adds a 'Insert query placeholder' button to the add/modify web shortcut 
> dialog.
> -Clicking this button inserts \{@} in the shortcut URL lineEdit.
> -The button is only enabled when the shortcut URL lineEdit has focus.
> 
> This makes it easy to add new web shortcuts. Users don't have to remember and 
> type the query placeholder.
> 
> The eventfilter complicates this patch a lot. But there is no slot to detect 
> if a lineedit has focus.
> We could drop it but it looks messy when the button is always enabled.
> I feel the tooltip text can be improved. Any suggestions from a native 
> English speaker?
> 
> 
> This addresses bug 146879.
> http://bugs.kde.org/show_bug.cgi?id=146879
> 
> 
> Diffs
> -
> 
>   kurifilter-plugins/ikws/searchproviderdlg.h e931e11 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp 5f40f5f 
>   kurifilter-plugins/ikws/searchproviderdlg_ui.ui d75ac5b 
> 
> Diff: http://git.reviewboard.kde.org/r/110423/diff/
> 
> 
> Testing
> ---
> 
> Added a new shortcut.
> Changed focus to and from different widgets.
> Inserted placeholder at the end of the link and in the middle.
> Modified a shortcut.
> 
> 
> File Attachments
> 
> 
> Berfore vs After
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png
> Alternative look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/After3.png
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109245/#review33326
---


This review has been submitted with commit 
22bc09c62bc3f305907d7270c650db9d291e5e6a by Sergio Martins to branch master.

- Commit Hook


On March 2, 2013, 2:12 p.m., Sergio Luis Martins wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109245/
> ---
> 
> (Updated March 2, 2013, 2:12 p.m.)
> 
> 
> Review request for kde-workspace and John Layt.
> 
> 
> Description
> ---
> 
> kde-workspace had a few classes that were duplicated in kdepim.
> In 4.10 they were moved from kdepim to kdepimlibs, so now kde-workspace can 
> use that instead of duplicating.
> 
> 
> Diffs
> -
> 
>   plasma/generic/dataengines/calendar/CMakeLists.txt 5539f99 
>   plasma/generic/dataengines/calendar/akonadi/README.txt dc1d36c 
>   plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.h 71c8284 
>   plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.cpp 
> 28dff0c 
>   plasma/generic/dataengines/calendar/akonadi/calendar.h 364fc81 
>   plasma/generic/dataengines/calendar/akonadi/calendar.cpp 8ff81ef 
>   plasma/generic/dataengines/calendar/akonadi/calendar_p.h f9b92de 
>   plasma/generic/dataengines/calendar/akonadi/calendarmodel.h 1acbfdd 
>   plasma/generic/dataengines/calendar/akonadi/calendarmodel.cpp 251a615 
>   plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.h fe62155 
>   plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.cpp 1820084 
>   plasma/generic/dataengines/calendar/akonadi/collectionselection.h 4447afb 
>   plasma/generic/dataengines/calendar/akonadi/collectionselection.cpp 41e03da 
>   plasma/generic/dataengines/calendar/akonadi/utils.h d923594 
>   plasma/generic/dataengines/calendar/akonadi/utils.cpp 895edf9 
>   plasma/generic/dataengines/calendar/calendarengine.h 18ae774 
>   plasma/generic/dataengines/calendar/calendarengine.cpp 7235f74 
>   plasma/generic/dataengines/calendar/eventdatacontainer.h b170a14 
>   plasma/generic/dataengines/calendar/eventdatacontainer.cpp 63db4df 
> 
> Diff: http://git.reviewboard.kde.org/r/109245/diff/
> 
> 
> Testing
> ---
> 
> Used "plasmoidviewer calendar" to test.
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

Re: Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109245/
---

(Updated May 28, 2013, 9:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and John Layt.


Description
---

kde-workspace had a few classes that were duplicated in kdepim.
In 4.10 they were moved from kdepim to kdepimlibs, so now kde-workspace can use 
that instead of duplicating.


Diffs
-

  plasma/generic/dataengines/calendar/CMakeLists.txt 5539f99 
  plasma/generic/dataengines/calendar/akonadi/README.txt dc1d36c 
  plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.h 71c8284 
  plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.cpp 28dff0c 
  plasma/generic/dataengines/calendar/akonadi/calendar.h 364fc81 
  plasma/generic/dataengines/calendar/akonadi/calendar.cpp 8ff81ef 
  plasma/generic/dataengines/calendar/akonadi/calendar_p.h f9b92de 
  plasma/generic/dataengines/calendar/akonadi/calendarmodel.h 1acbfdd 
  plasma/generic/dataengines/calendar/akonadi/calendarmodel.cpp 251a615 
  plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.h fe62155 
  plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.cpp 1820084 
  plasma/generic/dataengines/calendar/akonadi/collectionselection.h 4447afb 
  plasma/generic/dataengines/calendar/akonadi/collectionselection.cpp 41e03da 
  plasma/generic/dataengines/calendar/akonadi/utils.h d923594 
  plasma/generic/dataengines/calendar/akonadi/utils.cpp 895edf9 
  plasma/generic/dataengines/calendar/calendarengine.h 18ae774 
  plasma/generic/dataengines/calendar/calendarengine.cpp 7235f74 
  plasma/generic/dataengines/calendar/eventdatacontainer.h b170a14 
  plasma/generic/dataengines/calendar/eventdatacontainer.cpp 63db4df 

Diff: http://git.reviewboard.kde.org/r/109245/diff/


Testing
---

Used "plasmoidviewer calendar" to test.


Thanks,

Sergio Luis Martins

Re: Review Request 110625: Make it possible to disable KAbstractFileItemActionPlugins by default

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110625/
---

(Updated May 28, 2013, 9:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs.


Description
---

Currently, all KAbstractFileItemActionPlugins which are installed are embedded 
into file management-related context menus unless the user explicitly disables 
them in the settings.

This becomes problematic if the plugin's actions() method executes code that is 
not guaranteed to return very fast - the user will notice that the host 
application freezes without even knowing that one of the plugins is the culprit.

In a perfect world, all code executed by plugins would be perfect and the 
problem would not exist at all. Unfortunately, the world is not perfect, and 
there are plugins which do things that succeed most of the time, but cause 
trouble sometimes: https://bugs.kde.org/show_bug.cgi?id=314575

It seems that what Activities is trying to achieve cannot easily be solved 
using a safer approach which is equally user-friendly for Activities users. On 
the other hand, I don't think that people who do not use the plugin at all 
should suffer from the freezes caused by the plugin, so I thought that we could 
give developers of plugins which execute some "fragile" code the chance to 
declare that only users who enable the plugin explicitly in the settings should 
see the plugin's actions in their context menu.

For further information, please see https://bugs.kde.org/show_bug.cgi?id=314575.

Unfortunately, the original author of KAbstractFileItemActionPlugin chose to 
not add a d-pointer, so I had to use a hack to make it work.

I have patches that make this work:

kactivities (includes another change that fixes a build failure for me): 
http://paste.kde.org/749834/
kde-baseapps: http://paste.kde.org/749846/


Diffs
-

  kio/kio/kabstractfileitemactionplugin.h 6af7396 
  kio/kio/kabstractfileitemactionplugin.cpp 07f15f6 

Diff: http://git.reviewboard.kde.org/r/110625/diff/


Testing
---

Deleted kservicemenurc -> Activities not shown in Konqueror/Dolphin context 
menus, and the plugin is shown as disabled in the settings.

Enabled the plugin in the settings dialog of either Konqueror or Dolphin -> 
plugin is shown, and disabling it in the dialog hides it again.


Thanks,

Frank Reininghaus

Re: Review Request 110625: Make it possible to disable KAbstractFileItemActionPlugins by default

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110625/#review33324
---


This review has been submitted with commit 
b97dad72c39edd27450e999b8042e1d7e85231a3 by Frank Reininghaus to branch master.

- Commit Hook


On May 23, 2013, 8:55 p.m., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110625/
> ---
> 
> (Updated May 23, 2013, 8:55 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> ---
> 
> Currently, all KAbstractFileItemActionPlugins which are installed are 
> embedded into file management-related context menus unless the user 
> explicitly disables them in the settings.
> 
> This becomes problematic if the plugin's actions() method executes code that 
> is not guaranteed to return very fast - the user will notice that the host 
> application freezes without even knowing that one of the plugins is the 
> culprit.
> 
> In a perfect world, all code executed by plugins would be perfect and the 
> problem would not exist at all. Unfortunately, the world is not perfect, and 
> there are plugins which do things that succeed most of the time, but cause 
> trouble sometimes: https://bugs.kde.org/show_bug.cgi?id=314575
> 
> It seems that what Activities is trying to achieve cannot easily be solved 
> using a safer approach which is equally user-friendly for Activities users. 
> On the other hand, I don't think that people who do not use the plugin at all 
> should suffer from the freezes caused by the plugin, so I thought that we 
> could give developers of plugins which execute some "fragile" code the chance 
> to declare that only users who enable the plugin explicitly in the settings 
> should see the plugin's actions in their context menu.
> 
> For further information, please see 
> https://bugs.kde.org/show_bug.cgi?id=314575.
> 
> Unfortunately, the original author of KAbstractFileItemActionPlugin chose to 
> not add a d-pointer, so I had to use a hack to make it work.
> 
> I have patches that make this work:
> 
> kactivities (includes another change that fixes a build failure for me): 
> http://paste.kde.org/749834/
> kde-baseapps: http://paste.kde.org/749846/
> 
> 
> Diffs
> -
> 
>   kio/kio/kabstractfileitemactionplugin.h 6af7396 
>   kio/kio/kabstractfileitemactionplugin.cpp 07f15f6 
> 
> Diff: http://git.reviewboard.kde.org/r/110625/diff/
> 
> 
> Testing
> ---
> 
> Deleted kservicemenurc -> Activities not shown in Konqueror/Dolphin context 
> menus, and the plugin is shown as disabled in the settings.
> 
> Enabled the plugin in the settings dialog of either Konqueror or Dolphin -> 
> plugin is shown, and disabling it in the dialog hides it again.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

[Maarten De Meyer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110423/
---

(Updated May 28, 2013, 6:37 p.m.)


Review request for KDE Runtime.


Changes
---

Ping?
I added an alternative look of the button (icon only) that we could use.


Description
---

This adds a 'Insert query placeholder' button to the add/modify web shortcut 
dialog.
-Clicking this button inserts \{@} in the shortcut URL lineEdit.
-The button is only enabled when the shortcut URL lineEdit has focus.

This makes it easy to add new web shortcuts. Users don't have to remember and 
type the query placeholder.

The eventfilter complicates this patch a lot. But there is no slot to detect if 
a lineedit has focus.
We could drop it but it looks messy when the button is always enabled.
I feel the tooltip text can be improved. Any suggestions from a native English 
speaker?


This addresses bug 146879.
http://bugs.kde.org/show_bug.cgi?id=146879


Diffs
-

  kurifilter-plugins/ikws/searchproviderdlg.h e931e11 
  kurifilter-plugins/ikws/searchproviderdlg.cpp 5f40f5f 
  kurifilter-plugins/ikws/searchproviderdlg_ui.ui d75ac5b 

Diff: http://git.reviewboard.kde.org/r/110423/diff/


Testing
---

Added a new shortcut.
Changed focus to and from different widgets.
Inserted placeholder at the end of the link and in the middle.
Modified a shortcut.


File Attachments (updated)


Berfore vs After
  
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png
Alternative look
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/After3.png


Thanks,

Maarten De Meyer

KF5 Update Meeting Minutes 2013-w22

[David Faure]

Today we had the 3rd update meeting for KF5, on #kde-devel.

Attendees: 287 people in the IRC channel :-)

Announcements:

* qt5.git has been updated, everyone should pull and recompile at some point 
this week
* the "Building" wiki page has been updated; if you don't have a working 
setup, I strongly recommend switching to the newly described setup
(uninstalled Qt, kdesrc-build for everything else)

On-going work:

* David Edmundson (d_ed_), Wojciech Kapuscinski (wojtask9_), Maarten De Meyer 
(mdemeyer), Anne-Marie Mahfouf (annma_) are all working on tasks from the 
KDEUI crumble.
* alimg (didn't grab your real name, sorry) will join the effort and pick a 
task after setup
* David Gil (dgilo) will start on the task of porting from time_t to QDateTime

Topics discussed:

* the kdesrc-build setup has the issue that changes to the kdesrc-buildrc 
recipe on my website won't propagate automatically to its users. Aaron found a 
solution: a global recipe in git (I suggested the kdesrc-build git) which we 
can include from our kdesrc-buildrc

Achievements:

* Congratulations to Benjamin Port (ben2367) who got the QTextEdit placeholder 
feature merged into Qt !

Closed action items from last time:

> * [wojtask9_] Get a KDE account to be able to push his patches himself
-> done
> * [ervin + dfaure] Send meeting reminders on mondays
-> I sent it one hour before, instead.
> * [ervin] Talk to Ben about having our own qt5.git with a kf5 branch
-> not needed anymore (for now), given that qt5.git got updated upstream
> * [notmart + aseigo] Investigate the dbusmenu breakage
-> was a local issue on notmart's computer, all ok now
> * [dfaure] Document the unixisms which should be cleaned up to get people
> to help
-> done, added a task on kdelibs_cleanup
> * [ervin + dfaure] Review the build instructions
-> done

Action items still open:

> * [sandsmark] Finish the work on KPtyProcess
> * [steveire] Write a "CMake for frameworks" guideline in the wiki
> * [notmart] Look at cleaning up the CMake files in plasma-framework (if time 
permits)

New action items:

* [ben2367] update QTextEdit placeholder feature to match QLineEdit's
* [dfaure] extract kf5 module definitions from kdesrc-buildrc into a file in 
git
* [steveire] investigate why kde4support isn't usable from outside kdelibs
(issue with the cmake file)

Next meeting will be Tuesday 4 June. Exact time to be announced later (I won't 
be available at the usual 4pm CEST).

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

Re: Review Request 110670: fixes for qml import paths order

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110670/#review33306
---


This review has been submitted with commit 
af2bf8c3dd8231a10a7e1d1a6321cf981fc602df by Oliver Henshaw to branch KDE/4.10.

- Commit Hook


On May 27, 2013, 1:14 p.m., Oliver Henshaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110670/
> ---
> 
> (Updated May 27, 2013, 1:14 p.m.)
> 
> 
> Review request for kde-workspace, kwin and Plasma.
> 
> 
> Description
> ---
> 
> QDeclarativeImportDatabase::addImportPath() prepends paths to the list, so 
> paths must be added in reverse order (lowest preference -> highest 
> preference).
> 
> To further complicate things, only paths not already in the list are added - 
> hopefully this behaviour can be corrected in qt at some point. Nevertheless, 
> these fixes should give the desired results with or without the further qt 
> fix.
> 
> 
> NB: kwin/kcmkwin/kwintabbox/layoutpreview.cpp is also affected by this issue 
> but is not yet included in this RR, as it needs extra fixes and proper 
> testing.
> 
> NB #2: there may be other files affected outside kde-workspace, but I haven't 
> checked.
> 
> 
> Branch for this RR can be found at 
> clones/kde-workspace/oliverhenshaw/kde-workspace at review/qml-imports-v1 
> which comprises:
> 
> [1/3] Drop unneeded duplicate addImportPath
> 
> Let KDeclarative::setupBindings() add the import paths: it too takes
> paths from KGlobal::dirs()->findDirs("module", "imports"); it adds paths
> in the correct (reverse) order.
> 
> [2/3] Replace foreach with java-style iterator
> 
> In preparation for reversing the loop.
> 
> [3/3] add qml import paths in correct order
> 
> addImportPath prepends the path to importPathList so we must add our
> paths in reverse order.
> 
> Based on the fix for kdeclarative.cpp in kdelibs
> 400b9f2e9d10386bb175b6123fe0cdaafeaffe61
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b70c9d6c005aa66d2f85a42ef4f1dcb04ea44667 
>   ksmserver/shutdowndlg.cpp 247c8777f060a614436b4f757ba5d588035f3bf5 
>   kwin/clients/aurorae/src/aurorae.cpp 
> f7771c4cbee34194dcc8987a789712ab41898ec0 
>   kwin/kcmkwin/kwindecoration/kwindecoration.cpp 
> 591a913c4032885474040e93e75d5f6f91bb9535 
>   kwin/scripting/scripting.cpp 13a77bc346b09f4b99f782370e8e0873332fad3d 
>   kwin/tabbox/declarative.cpp f759512c76a2b589323614b412844a0ce8e4dd54 
>   plasma/screensaver/shell/savercorona.cpp 
> 9cd207ffc8039cd1e41fdbbf9a4095426824f694 
> 
> Diff: http://git.reviewboard.kde.org/r/110670/diff/
> 
> 
> Testing
> ---
> 
> Compiles and runs. Checked that the resulting importPathList is correct for 
> ksmserver/screenlocker/greeter/greeterapp.cpp and for 
> kwin/clients/aurorae/src/aurorae.cpp
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

Re: Review Request 110670: fixes for qml import paths order

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110670/
---

(Updated May 28, 2013, 4:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace, kwin and Plasma.


Description
---

QDeclarativeImportDatabase::addImportPath() prepends paths to the list, so 
paths must be added in reverse order (lowest preference -> highest preference).

To further complicate things, only paths not already in the list are added - 
hopefully this behaviour can be corrected in qt at some point. Nevertheless, 
these fixes should give the desired results with or without the further qt fix.


NB: kwin/kcmkwin/kwintabbox/layoutpreview.cpp is also affected by this issue 
but is not yet included in this RR, as it needs extra fixes and proper testing.

NB #2: there may be other files affected outside kde-workspace, but I haven't 
checked.


Branch for this RR can be found at 
clones/kde-workspace/oliverhenshaw/kde-workspace at review/qml-imports-v1 which 
comprises:

[1/3] Drop unneeded duplicate addImportPath

Let KDeclarative::setupBindings() add the import paths: it too takes
paths from KGlobal::dirs()->findDirs("module", "imports"); it adds paths
in the correct (reverse) order.

[2/3] Replace foreach with java-style iterator

In preparation for reversing the loop.

[3/3] add qml import paths in correct order

addImportPath prepends the path to importPathList so we must add our
paths in reverse order.

Based on the fix for kdeclarative.cpp in kdelibs
400b9f2e9d10386bb175b6123fe0cdaafeaffe61


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.cpp 
b70c9d6c005aa66d2f85a42ef4f1dcb04ea44667 
  ksmserver/shutdowndlg.cpp 247c8777f060a614436b4f757ba5d588035f3bf5 
  kwin/clients/aurorae/src/aurorae.cpp f7771c4cbee34194dcc8987a789712ab41898ec0 
  kwin/kcmkwin/kwindecoration/kwindecoration.cpp 
591a913c4032885474040e93e75d5f6f91bb9535 
  kwin/scripting/scripting.cpp 13a77bc346b09f4b99f782370e8e0873332fad3d 
  kwin/tabbox/declarative.cpp f759512c76a2b589323614b412844a0ce8e4dd54 
  plasma/screensaver/shell/savercorona.cpp 
9cd207ffc8039cd1e41fdbbf9a4095426824f694 

Diff: http://git.reviewboard.kde.org/r/110670/diff/


Testing
---

Compiles and runs. Checked that the resulting importPathList is correct for 
ksmserver/screenlocker/greeter/greeterapp.cpp and for 
kwin/clients/aurorae/src/aurorae.cpp


Thanks,

Oliver Henshaw

Re: Review Request 110670: fixes for qml import paths order

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110670/#review33305
---


This review has been submitted with commit 
a41f4c800f909d4c5e5a9ed8af57482295cccace by Oliver Henshaw to branch KDE/4.10.

- Commit Hook


On May 27, 2013, 1:14 p.m., Oliver Henshaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110670/
> ---
> 
> (Updated May 27, 2013, 1:14 p.m.)
> 
> 
> Review request for kde-workspace, kwin and Plasma.
> 
> 
> Description
> ---
> 
> QDeclarativeImportDatabase::addImportPath() prepends paths to the list, so 
> paths must be added in reverse order (lowest preference -> highest 
> preference).
> 
> To further complicate things, only paths not already in the list are added - 
> hopefully this behaviour can be corrected in qt at some point. Nevertheless, 
> these fixes should give the desired results with or without the further qt 
> fix.
> 
> 
> NB: kwin/kcmkwin/kwintabbox/layoutpreview.cpp is also affected by this issue 
> but is not yet included in this RR, as it needs extra fixes and proper 
> testing.
> 
> NB #2: there may be other files affected outside kde-workspace, but I haven't 
> checked.
> 
> 
> Branch for this RR can be found at 
> clones/kde-workspace/oliverhenshaw/kde-workspace at review/qml-imports-v1 
> which comprises:
> 
> [1/3] Drop unneeded duplicate addImportPath
> 
> Let KDeclarative::setupBindings() add the import paths: it too takes
> paths from KGlobal::dirs()->findDirs("module", "imports"); it adds paths
> in the correct (reverse) order.
> 
> [2/3] Replace foreach with java-style iterator
> 
> In preparation for reversing the loop.
> 
> [3/3] add qml import paths in correct order
> 
> addImportPath prepends the path to importPathList so we must add our
> paths in reverse order.
> 
> Based on the fix for kdeclarative.cpp in kdelibs
> 400b9f2e9d10386bb175b6123fe0cdaafeaffe61
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b70c9d6c005aa66d2f85a42ef4f1dcb04ea44667 
>   ksmserver/shutdowndlg.cpp 247c8777f060a614436b4f757ba5d588035f3bf5 
>   kwin/clients/aurorae/src/aurorae.cpp 
> f7771c4cbee34194dcc8987a789712ab41898ec0 
>   kwin/kcmkwin/kwindecoration/kwindecoration.cpp 
> 591a913c4032885474040e93e75d5f6f91bb9535 
>   kwin/scripting/scripting.cpp 13a77bc346b09f4b99f782370e8e0873332fad3d 
>   kwin/tabbox/declarative.cpp f759512c76a2b589323614b412844a0ce8e4dd54 
>   plasma/screensaver/shell/savercorona.cpp 
> 9cd207ffc8039cd1e41fdbbf9a4095426824f694 
> 
> Diff: http://git.reviewboard.kde.org/r/110670/diff/
> 
> 
> Testing
> ---
> 
> Compiles and runs. Checked that the resulting importPathList is correct for 
> ksmserver/screenlocker/greeter/greeterapp.cpp and for 
> kwin/clients/aurorae/src/aurorae.cpp
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

Re: Review Request 110670: fixes for qml import paths order

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110670/#review33304
---


This review has been submitted with commit 
03f439dbb72d7b38f23298a3e3f303a8b772c0b9 by Oliver Henshaw to branch KDE/4.10.

- Commit Hook


On May 27, 2013, 1:14 p.m., Oliver Henshaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110670/
> ---
> 
> (Updated May 27, 2013, 1:14 p.m.)
> 
> 
> Review request for kde-workspace, kwin and Plasma.
> 
> 
> Description
> ---
> 
> QDeclarativeImportDatabase::addImportPath() prepends paths to the list, so 
> paths must be added in reverse order (lowest preference -> highest 
> preference).
> 
> To further complicate things, only paths not already in the list are added - 
> hopefully this behaviour can be corrected in qt at some point. Nevertheless, 
> these fixes should give the desired results with or without the further qt 
> fix.
> 
> 
> NB: kwin/kcmkwin/kwintabbox/layoutpreview.cpp is also affected by this issue 
> but is not yet included in this RR, as it needs extra fixes and proper 
> testing.
> 
> NB #2: there may be other files affected outside kde-workspace, but I haven't 
> checked.
> 
> 
> Branch for this RR can be found at 
> clones/kde-workspace/oliverhenshaw/kde-workspace at review/qml-imports-v1 
> which comprises:
> 
> [1/3] Drop unneeded duplicate addImportPath
> 
> Let KDeclarative::setupBindings() add the import paths: it too takes
> paths from KGlobal::dirs()->findDirs("module", "imports"); it adds paths
> in the correct (reverse) order.
> 
> [2/3] Replace foreach with java-style iterator
> 
> In preparation for reversing the loop.
> 
> [3/3] add qml import paths in correct order
> 
> addImportPath prepends the path to importPathList so we must add our
> paths in reverse order.
> 
> Based on the fix for kdeclarative.cpp in kdelibs
> 400b9f2e9d10386bb175b6123fe0cdaafeaffe61
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b70c9d6c005aa66d2f85a42ef4f1dcb04ea44667 
>   ksmserver/shutdowndlg.cpp 247c8777f060a614436b4f757ba5d588035f3bf5 
>   kwin/clients/aurorae/src/aurorae.cpp 
> f7771c4cbee34194dcc8987a789712ab41898ec0 
>   kwin/kcmkwin/kwindecoration/kwindecoration.cpp 
> 591a913c4032885474040e93e75d5f6f91bb9535 
>   kwin/scripting/scripting.cpp 13a77bc346b09f4b99f782370e8e0873332fad3d 
>   kwin/tabbox/declarative.cpp f759512c76a2b589323614b412844a0ce8e4dd54 
>   plasma/screensaver/shell/savercorona.cpp 
> 9cd207ffc8039cd1e41fdbbf9a4095426824f694 
> 
> Diff: http://git.reviewboard.kde.org/r/110670/diff/
> 
> 
> Testing
> ---
> 
> Compiles and runs. Checked that the resulting importPathList is correct for 
> ksmserver/screenlocker/greeter/greeterapp.cpp and for 
> kwin/clients/aurorae/src/aurorae.cpp
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Rolf Eike Beer]

Martin Gräßlin wrote:


Could you please get some feedback from packagers. I'm not sure
whether they like words like "unmaintained" and "upgrade". The fact
that we as upstream don't accept bugs doesn't mean it's unmaintained
by the distro and it's not said that one could upgrade (think of
Debian Stable).


I suggest something like "try out a more recent version, maybe the bug 
has already been fixed".


Eike

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/#review33285
---



drkonqi/reportassistantdialog.cpp


There should be a space after the comma.



drkonqi/reportassistantpages_bugzilla_versioncheck.h


Wrong copyright date.



drkonqi/reportassistantpages_bugzilla_versioncheck.h


This should be "State" not "Stage".



drkonqi/reportassistantpages_bugzilla_versioncheck.h


Why add a commented method? This should be removed.



drkonqi/reportassistantpages_bugzilla_versioncheck.h


"m_state" instead of "m_stage"



drkonqi/reportassistantpages_bugzilla_versioncheck.cpp


Shouldn't this be a translatable string?



drkonqi/reportassistantpages_bugzilla_versioncheck.cpp


Translatable string?



drkonqi/reportassistantpages_bugzilla_versioncheck.cpp


Translatable string?



drkonqi/reportinterface.h


Code style, there should be just one space between the "*" and the pointer 
name. Actually I think the current code style says there should be no space 
between the "*" and the pointer name. I am not sure if the maintainer of this 
code is ok with mixing code style until everything is converted to the new one.



drkonqi/reportinterface.cpp


same here.


- Lamarque Souza


On May 28, 2013, 11:01 a.m., Jekyll Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110687/
> ---
> 
> (Updated May 28, 2013, 11:01 a.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Description
> ---
> 
> As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3 ,  
> Bugzilla's new and nice behavior (since 4.2.5) of rejecting reports against 
> disabled versions brings a new usability problem to DrKonqi: users spend 
> value time in downloading debug symbols, generating the backtrace, writing 
> all information he/she can recall, but in the end only to find an error 
> dialog telling them (in a not so clear and friendly way) that bugs.kde.org 
> won't accept his/her report. 
> 
> I would propose making version checking the very first step in the reporting 
> assistant: a perfect bug report against an outdated version is still useless. 
> 
> The patch has been created for sometime and works, but unfortunately I don't 
> have much time for coding since then, so it is not as good as what I have 
> planned to make it to be. Nevertheless, I think it is still a good 
> improvement of the current situation.
>  
> 
> 
> This addresses bug 315073.
> http://bugs.kde.org/show_bug.cgi?id=315073
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt 39833d7 
>   drkonqi/drkonqi_globals.h d5f098a 
>   drkonqi/productmapping.h f926c9d 
>   drkonqi/productmapping.cpp f4e59e5 
>   drkonqi/reportassistantdialog.cpp c296059 
>   drkonqi/reportassistantpages_bugzilla_versioncheck.h PRE-CREATION 
>   drkonqi/reportassistantpages_bugzilla_versioncheck.cpp PRE-CREATION 
>   drkonqi/reportinterface.h c7e374e 
>   drkonqi/reportinterface.cpp 4190c40 
>   drkonqi/ui/assistantpage_versioncheck.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110687/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> rejecting disabled version
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/drkonqi-version-checking.png
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

Re: KDE Workspace broken due to upstream CMake changes

[Stephen Kelly]

Ben Cooksley wrote:

> Hi Alex,
> 
> Can someone more familiar with the CMake community please inform them
> of this regression?


http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/46742/focus=46776

Re: Review Request 110670: fixes for qml import paths order

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110670/#review33282
---

Ship it!


Ship It!

- Aaron J. Seigo


On May 27, 2013, 1:14 p.m., Oliver Henshaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110670/
> ---
> 
> (Updated May 27, 2013, 1:14 p.m.)
> 
> 
> Review request for kde-workspace, kwin and Plasma.
> 
> 
> Description
> ---
> 
> QDeclarativeImportDatabase::addImportPath() prepends paths to the list, so 
> paths must be added in reverse order (lowest preference -> highest 
> preference).
> 
> To further complicate things, only paths not already in the list are added - 
> hopefully this behaviour can be corrected in qt at some point. Nevertheless, 
> these fixes should give the desired results with or without the further qt 
> fix.
> 
> 
> NB: kwin/kcmkwin/kwintabbox/layoutpreview.cpp is also affected by this issue 
> but is not yet included in this RR, as it needs extra fixes and proper 
> testing.
> 
> NB #2: there may be other files affected outside kde-workspace, but I haven't 
> checked.
> 
> 
> Branch for this RR can be found at 
> clones/kde-workspace/oliverhenshaw/kde-workspace at review/qml-imports-v1 
> which comprises:
> 
> [1/3] Drop unneeded duplicate addImportPath
> 
> Let KDeclarative::setupBindings() add the import paths: it too takes
> paths from KGlobal::dirs()->findDirs("module", "imports"); it adds paths
> in the correct (reverse) order.
> 
> [2/3] Replace foreach with java-style iterator
> 
> In preparation for reversing the loop.
> 
> [3/3] add qml import paths in correct order
> 
> addImportPath prepends the path to importPathList so we must add our
> paths in reverse order.
> 
> Based on the fix for kdeclarative.cpp in kdelibs
> 400b9f2e9d10386bb175b6123fe0cdaafeaffe61
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b70c9d6c005aa66d2f85a42ef4f1dcb04ea44667 
>   ksmserver/shutdowndlg.cpp 247c8777f060a614436b4f757ba5d588035f3bf5 
>   kwin/clients/aurorae/src/aurorae.cpp 
> f7771c4cbee34194dcc8987a789712ab41898ec0 
>   kwin/kcmkwin/kwindecoration/kwindecoration.cpp 
> 591a913c4032885474040e93e75d5f6f91bb9535 
>   kwin/scripting/scripting.cpp 13a77bc346b09f4b99f782370e8e0873332fad3d 
>   kwin/tabbox/declarative.cpp f759512c76a2b589323614b412844a0ce8e4dd54 
>   plasma/screensaver/shell/savercorona.cpp 
> 9cd207ffc8039cd1e41fdbbf9a4095426824f694 
> 
> Diff: http://git.reviewboard.kde.org/r/110670/diff/
> 
> 
> Testing
> ---
> 
> Compiles and runs. Checked that the resulting importPathList is correct for 
> ksmserver/screenlocker/greeter/greeterapp.cpp and for 
> kwin/clients/aurorae/src/aurorae.cpp
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109611/#review33281
---

Ship it!


Ship It!

- David Faure


On May 28, 2013, 10:31 a.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109611/
> ---
> 
> (Updated May 28, 2013, 10:31 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> ---
> 
> (This comes from a patch included in openSUSE)
> 
> This patch makes kickoff remember all the .desktop files it sees (in 
> kickoffrc). 
> New ones are additionally shown in a seperate submenu named "Recently 
> Installed" (for 3 days).
> 
> The seen entries are saved as "id=date" pairs in the "Seen Applications" 
> group.
> Entries older than 3 days get their date set to empty, which means "don't 
> show this entry anymore".
> Also if there have no entries been saved yet, the date of all found entries 
> is set to empty as well. This prevents that all menu entries are shown in the 
> "Recently Installed" submenu on first start.
> 
> The "Recently Installed" submenu can be toggled on and off in the plasmoid's 
> settings.
> 
> 
> This addresses bug 316916.
> http://bugs.kde.org/show_bug.cgi?id=316916
> 
> 
> Diffs
> -
> 
>   plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 
>   plasma/desktop/applets/kickoff/applet/kickoffConfig.ui 8664ac8 
>   plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872 
>   plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba5 
>   plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 
>   plasma/desktop/applets/kickoff/ui/launcher.h 2a234c3 
>   plasma/desktop/applets/kickoff/ui/launcher.cpp 4425bcc 
> 
> Diff: http://git.reviewboard.kde.org/r/109611/diff/
> 
> 
> Testing
> ---
> 
> Created a new .desktop file in ~/.local/share/applications, ran kbuildsycoca4 
> and the menu "Recently Installed" appeared with this entry.
> After logout/login this is still present.
> Deleted the .desktop file again, ran kbuildsycoca4 and the menu "Recently 
> Installed" disappeared again.
> 
> I have been using the (vanilla KDE) kickoff applet with this patch for about 
> a week now.
> 
> Also this patch is already part of openSUSE for several years...
> 
> 
> File Attachments
> 
> 
> Settings dialog (kickoff style) with patch
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/kickoff-settings.png
> Plasmoid (kickoff style) showing the "Recently Installed" submenu
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/kickoff.png
> Settings dialog (classic style) with patch
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/classic-settings.png
> Plasmoid (classic style) showing the "Recently Installed" submenu
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/classic.png
> sample kickoffrc written by this patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/19/kickoffrc
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/#review33280
---


Could you please get some feedback from packagers. I'm not sure whether they 
like words like "unmaintained" and "upgrade". The fact that we as upstream 
don't accept bugs doesn't mean it's unmaintained by the distro and it's not 
said that one could upgrade (think of Debian Stable).

- Martin Gräßlin


On May 28, 2013, 1:01 p.m., Jekyll Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110687/
> ---
> 
> (Updated May 28, 2013, 1:01 p.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Description
> ---
> 
> As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3 ,  
> Bugzilla's new and nice behavior (since 4.2.5) of rejecting reports against 
> disabled versions brings a new usability problem to DrKonqi: users spend 
> value time in downloading debug symbols, generating the backtrace, writing 
> all information he/she can recall, but in the end only to find an error 
> dialog telling them (in a not so clear and friendly way) that bugs.kde.org 
> won't accept his/her report. 
> 
> I would propose making version checking the very first step in the reporting 
> assistant: a perfect bug report against an outdated version is still useless. 
> 
> The patch has been created for sometime and works, but unfortunately I don't 
> have much time for coding since then, so it is not as good as what I have 
> planned to make it to be. Nevertheless, I think it is still a good 
> improvement of the current situation.
>  
> 
> 
> This addresses bug 315073.
> http://bugs.kde.org/show_bug.cgi?id=315073
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt 39833d7 
>   drkonqi/drkonqi_globals.h d5f098a 
>   drkonqi/productmapping.h f926c9d 
>   drkonqi/productmapping.cpp f4e59e5 
>   drkonqi/reportassistantdialog.cpp c296059 
>   drkonqi/reportassistantpages_bugzilla_versioncheck.h PRE-CREATION 
>   drkonqi/reportassistantpages_bugzilla_versioncheck.cpp PRE-CREATION 
>   drkonqi/reportinterface.h c7e374e 
>   drkonqi/reportinterface.cpp 4190c40 
>   drkonqi/ui/assistantpage_versioncheck.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110687/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> rejecting disabled version
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/drkonqi-version-checking.png
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Jekyll Wu]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/
---

(Updated May 28, 2013, 11:01 a.m.)


Review request for KDE Runtime and George Kiagiadakis.


Changes
---

upload the patch and screenshot 


Description (updated)
---

As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3 ,  Bugzilla's 
new and nice behavior (since 4.2.5) of rejecting reports against disabled 
versions brings a new usability problem to DrKonqi: users spend value time in 
downloading debug symbols, generating the backtrace, writing all information 
he/she can recall, but in the end only to find an error dialog telling them (in 
a not so clear and friendly way) that bugs.kde.org won't accept his/her report. 

I would propose making version checking the very first step in the reporting 
assistant: a perfect bug report against an outdated version is still useless. 

The patch has been created for sometime and works, but unfortunately I don't 
have much time for coding since then, so it is not as good as what I have 
planned to make it to be. Nevertheless, I think it is still a good improvement 
of the current situation.
 


This addresses bug 315073.
http://bugs.kde.org/show_bug.cgi?id=315073


Diffs (updated)
-

  drkonqi/CMakeLists.txt 39833d7 
  drkonqi/drkonqi_globals.h d5f098a 
  drkonqi/productmapping.h f926c9d 
  drkonqi/productmapping.cpp f4e59e5 
  drkonqi/reportassistantdialog.cpp c296059 
  drkonqi/reportassistantpages_bugzilla_versioncheck.h PRE-CREATION 
  drkonqi/reportassistantpages_bugzilla_versioncheck.cpp PRE-CREATION 
  drkonqi/reportinterface.h c7e374e 
  drkonqi/reportinterface.cpp 4190c40 
  drkonqi/ui/assistantpage_versioncheck.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110687/diff/


Testing
---


File Attachments (updated)


rejecting disabled version
  
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/drkonqi-version-checking.png


Thanks,

Jekyll Wu

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Jekyll Wu]

> On May 28, 2013, 10:19 a.m., Àlex Fiestas wrote:
> > Maybe I'm blind, but I don't see any patch attached to the review :s

Oops, I didn't realize the review had been accidentally published. Will attach 
the patch and screenshot soon. 


- Jekyll


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/#review33274
---


On May 28, 2013, 8:03 a.m., Jekyll Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110687/
> ---
> 
> (Updated May 28, 2013, 8:03 a.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Description
> ---
> 
> As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3,  Bugzilla's 
> new and nice behavior (since 4.2.5) of rejecting reports against disabled 
> versions brings a new usability problem to DrKonqi: users spend value time in 
> downloading debug symbols, generating the backtrace, writing all information 
> he/she can recall, but in the end only to find an error dialog which tells 
> them (in a not so clear and friendly way) that bugs.kde.org won't receive 
> his/her report. 
> 
> I would propose making version checking the very first step in the reporting 
> assistant: a perfect bug report against a outdated version is still useless. 
> 
> 
>  
> 
> 
> This addresses bug 315073.
> http://bugs.kde.org/show_bug.cgi?id=315073
> 
> 
> Diffs
> -
> 
> 
> Diff: http://git.reviewboard.kde.org/r/110687/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

[Wolfgang Bauer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109611/
---

(Updated May 28, 2013, 12:31 p.m.)


Review request for kde-workspace.


Changes
---

fixed the mentioned style issues


Description
---

(This comes from a patch included in openSUSE)

This patch makes kickoff remember all the .desktop files it sees (in 
kickoffrc). 
New ones are additionally shown in a seperate submenu named "Recently 
Installed" (for 3 days).

The seen entries are saved as "id=date" pairs in the "Seen Applications" group.
Entries older than 3 days get their date set to empty, which means "don't show 
this entry anymore".
Also if there have no entries been saved yet, the date of all found entries is 
set to empty as well. This prevents that all menu entries are shown in the 
"Recently Installed" submenu on first start.

The "Recently Installed" submenu can be toggled on and off in the plasmoid's 
settings.


This addresses bug 316916.
http://bugs.kde.org/show_bug.cgi?id=316916


Diffs (updated)
-

  plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 
  plasma/desktop/applets/kickoff/applet/kickoffConfig.ui 8664ac8 
  plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872 
  plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba5 
  plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 
  plasma/desktop/applets/kickoff/ui/launcher.h 2a234c3 
  plasma/desktop/applets/kickoff/ui/launcher.cpp 4425bcc 

Diff: http://git.reviewboard.kde.org/r/109611/diff/


Testing
---

Created a new .desktop file in ~/.local/share/applications, ran kbuildsycoca4 
and the menu "Recently Installed" appeared with this entry.
After logout/login this is still present.
Deleted the .desktop file again, ran kbuildsycoca4 and the menu "Recently 
Installed" disappeared again.

I have been using the (vanilla KDE) kickoff applet with this patch for about a 
week now.

Also this patch is already part of openSUSE for several years...


File Attachments


Settings dialog (kickoff style) with patch
  
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/kickoff-settings.png
Plasmoid (kickoff style) showing the "Recently Installed" submenu
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/kickoff.png
Settings dialog (classic style) with patch
  
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/classic-settings.png
Plasmoid (classic style) showing the "Recently Installed" submenu
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/classic.png
sample kickoffrc written by this patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/19/kickoffrc


Thanks,

Wolfgang Bauer

Re: KDE Workspace broken due to upstream CMake changes

[Ben Cooksley]

Hi Alex,

Can someone more familiar with the CMake community please inform them
of this regression?
It is breaking the KDE Continuous Integration system - i'd appreciate
being informed once the fix has landed in their Git repository, so we
can deploy it.

Regards,
Ben

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/#review33274
---


Maybe I'm blind, but I don't see any patch attached to the review :s

- Àlex Fiestas


On May 28, 2013, 8:03 a.m., Jekyll Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110687/
> ---
> 
> (Updated May 28, 2013, 8:03 a.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Description
> ---
> 
> As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3,  Bugzilla's 
> new and nice behavior (since 4.2.5) of rejecting reports against disabled 
> versions brings a new usability problem to DrKonqi: users spend value time in 
> downloading debug symbols, generating the backtrace, writing all information 
> he/she can recall, but in the end only to find an error dialog which tells 
> them (in a not so clear and friendly way) that bugs.kde.org won't receive 
> his/her report. 
> 
> I would propose making version checking the very first step in the reporting 
> assistant: a perfect bug report against a outdated version is still useless. 
> 
> 
>  
> 
> 
> This addresses bug 315073.
> http://bugs.kde.org/show_bug.cgi?id=315073
> 
> 
> Diffs
> -
> 
> 
> Diff: http://git.reviewboard.kde.org/r/110687/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

[Jekyll Wu]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110687/
---

Review request for KDE Runtime and George Kiagiadakis.


Description
---

As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3,  Bugzilla's 
new and nice behavior (since 4.2.5) of rejecting reports against disabled 
versions brings a new usability problem to DrKonqi: users spend value time in 
downloading debug symbols, generating the backtrace, writing all information 
he/she can recall, but in the end only to find an error dialog which tells them 
(in a not so clear and friendly way) that bugs.kde.org won't receive his/her 
report. 

I would propose making version checking the very first step in the reporting 
assistant: a perfect bug report against a outdated version is still useless. 


 


This addresses bug 315073.
http://bugs.kde.org/show_bug.cgi?id=315073


Diffs
-


Diff: http://git.reviewboard.kde.org/r/110687/diff/


Testing
---


Thanks,

Jekyll Wu