Re: KF5 Update Meeting Minutes 2013-w24
On Tuesday 11 June 2013 10:07:53 Thiago Macieira wrote: On terça-feira, 11 de junho de 2013 17.29.30, Kevin Ottens wrote: * Thiago still blocking some QUrl changes due to his unavailability; Thiago is back this week and will review soon. Thiago will also contact the people behind the std::networking::uri proposal so that the two APIs are harmonised. Thiago makes me happy. :-) Looking forward to all that. Cheers! -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part.
Re: Review Request 110951: Save icon size in the same place other settings are saved
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/#review34210 --- Is there any configuration to update ? as in those kind of updates we do after upgrading. - Àlex Fiestas On June 11, 2013, 1:36 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/ --- (Updated June 11, 2013, 1:36 p.m.) Review request for kdelibs and Àlex Fiestas. Description --- Save icon size in the same place other settings are saved This ensures icon size changes in KFileDialog are correctly stored in kdeglobals. Diffs - kfile/kdiroperator.cpp d7bd4cfb44952f917c3d42a7794e0b7e7cbfb5bd Diff: http://git.reviewboard.kde.org/r/110951/diff/ Testing --- 1. Started KWrite 2. Opened file dialog 3. Changed icon size 4. Closed file dialog 5. Started Gwenview 6. Opened file dialog = same icon size as the one set on step 3. Thanks, Aurélien Gâteau
Re: Review Request 110951: Save icon size in the same place other settings are saved
On June 12, 2013, 11:31 a.m., Àlex Fiestas wrote:
Is there any configuration to update ? as in those kind of updates we do
after upgrading.
I don't think it can be done because right now icon size is saved in each
${app}rc file. The patch changes this so that it is saved in kdeglobals. There
is no way we can know if we should copy the setting from kwriterc, gwenviewrc,
kdeveloprc or any other file.
- Aurélien
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110951/#review34210
---
On June 11, 2013, 3:36 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110951/
---
(Updated June 11, 2013, 3:36 p.m.)
Review request for kdelibs and Àlex Fiestas.
Description
---
Save icon size in the same place other settings are saved
This ensures icon size changes in KFileDialog are correctly stored in
kdeglobals.
Diffs
-
kfile/kdiroperator.cpp d7bd4cfb44952f917c3d42a7794e0b7e7cbfb5bd
Diff: http://git.reviewboard.kde.org/r/110951/diff/
Testing
---
1. Started KWrite
2. Opened file dialog
3. Changed icon size
4. Closed file dialog
5. Started Gwenview
6. Opened file dialog = same icon size as the one set on step 3.
Thanks,
Aurélien Gâteau
