Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40494 --- kdeui/colors/kcolorschemetoken.h http://git.reviewboard.kde.org/r/112880/#comment29808 trailing whitespace kdeui/colors/kcolorschemetoken.h http://git.reviewboard.kde.org/r/112880/#comment29809 needs an @since version line kdeui/colors/kcolorschemetoken.h http://git.reviewboard.kde.org/r/112880/#comment29810 while not wrong, I would put it below the main description. kdeui/colors/kcolorschemetoken.cpp http://git.reviewboard.kde.org/r/112880/#comment29811 opening block brace for function body on separate line kdeui/colors/kcolorschemetoken.cpp http://git.reviewboard.kde.org/r/112880/#comment29812 I think we prefer C++ style casts over C style casts - Kevin Krammer On Sept. 22, 2013, 4:09 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 22, 2013, 4:09 p.m.) Review request for kdelibs. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs - kdeui/colors/kcolorschemetoken.cpp PRE-CREATION kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorscheme.h 17570fd kdeui/CMakeLists.txt b439e04 Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 109551: port KPtyProcess to QProcess
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- (Updated Sept. 23, 2013, 8:31 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks, kdelibs, David Faure, and Oswald Buddenhagen. Description --- Just a simple port of KPtyProcess away from using KProcess. Diffs - kpty/kptyprocess.h 5e0df96 kpty/kptyprocess.cpp 015a58c kpty/tests/kptyprocesstest.cpp 04990a0 Diff: http://git.reviewboard.kde.org/r/109551/diff/ Testing --- builds and tests pass. Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review40505 --- Any reason why this patch isn't committed yet? Please do so ASAP. - Kevin Ottens On May 22, 2013, 3:31 p.m., Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/ --- (Updated May 22, 2013, 3:31 p.m.) Review request for KDE Frameworks, kdelibs and Patrick von Reth. Description --- This change implements cpu feature checks for MSVC. While at it, I added support SSSE3 and SSE4.2 to the InstructionSets. I took the new values from http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits . Diffs - tier1/solid/src/solid/processor.h ce4f0e1 tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin
Re: Review Request 112367: Include the icon's theme in the cache key
On Aug. 31, 2013, 7:11 a.m., David Faure wrote: I disagree. Making things slow to cover a really really corner case (mixing kde4 and kde5), while the solution already exists (clearing the cache when switching icon themes), doesn't seem very sensible to me. The point is really that you can only use one icon theme at a time. Àlex Fiestas wrote: While it is a corner case I think we should find a solution to make this more solid. Perhaps we could set the theme name in the cache, and then check if it has changed, if so remove cache. What is a bug imho is that theme can be changed without the cache getting cleaned somehow, corner case if you want but a bug. David Faure wrote: There's a *lot* of things that break if you run two separate DBus sessions and do things in one session and expect the other session to react. IMHO it's actually a feature that this isn't the case ;) But indeed we get into bugs when we have such broken dbus communication because of using two sessions, but these two sessions share some files, e.g. config files. Because then they see the changed files at some point, but didn't get change notification. However fixing all such occurences is a HUGE amount of work, and it's not worth it IMHO. But first, am I right that this is the case you're having? Different dbus sessions between your kde4 and kde5 code, but shared config files? (or symlinks, if the chosen icon theme is a symlink - I forgot how that works exactly) Àlex Fiestas wrote: I think it is much simpler than that: -Theme is changed but cache is not nuked, we get wrong icons. My case is, KIconLoader should realize that the theme has changed and nuke it without any external help. What is happening is, that KSharedDataCache::deleteCache(icon-cache); is removing the cache from KDE4 (in /tmp/... I guess) instead of using the new standard paths which is what it should do. Are you sure about that? It uses QStandardPaths internally... - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38986 --- On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- (Updated Aug. 29, 2013, 8 p.m.) Review request for KDE Frameworks, kdelibs and Michael Pyne. Description --- If we make no difference between an icon from oxygen and an icon from gnome, when we change themes for example from oxygen to gnome, the icon will be found in the cache and won't be upgraded. Diffs - kdeui/icons/kiconloader.cpp ce6aeea Diff: http://git.reviewboard.kde.org/r/112367/diff/ Testing --- Thanks, Àlex Fiestas
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 11:55 a.m.) Review request for kdelibs. Changes --- Fixed comments, C-style casts, formatting and trailing whitespace. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs (updated) - kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40547 --- Are you sure you've uploaded a new diff? Reviewboard shows no changes between r2 and r3. As for the Camel Case include, you have to add a forwarding header in kdelibs/include - Kevin Krammer On Sept. 23, 2013, 11:55 a.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 11:55 a.m.) Review request for kdelibs. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs - kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112869: Do not leak sockets in kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/#review40556 --- Ship it! Ship It! - Lukáš Tinkl On Sept. 22, 2013, 2:21 p.m., Lamarque Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/ --- (Updated Sept. 22, 2013, 2:21 p.m.) Review request for kdelibs and Solid. Description --- NetworkInterface::isWireless() in kdelibs/solid/solid/backends/udev/udevnetworkinterface.cpp does not close the socket it opens to call an ioctl leading to problem to kded4 that can affect plasma-desktop as well (temporary freezing plasma-desktop as described in the bug entry). This addresses bug 324954. http://bugs.kde.org/show_bug.cgi?id=324954 Diffs - solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907 Diff: http://git.reviewboard.kde.org/r/112869/diff/ Testing --- Tested by the bug reporter and it fixes the problem for him. Thanks, Lamarque Souza
Re: Review Request 112869: Do not leak sockets in kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/ --- (Updated Sept. 23, 2013, 12:43 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs and Solid. Description --- NetworkInterface::isWireless() in kdelibs/solid/solid/backends/udev/udevnetworkinterface.cpp does not close the socket it opens to call an ioctl leading to problem to kded4 that can affect plasma-desktop as well (temporary freezing plasma-desktop as described in the bug entry). This addresses bug 324954. http://bugs.kde.org/show_bug.cgi?id=324954 Diffs - solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907 Diff: http://git.reviewboard.kde.org/r/112869/diff/ Testing --- Tested by the bug reporter and it fixes the problem for him. Thanks, Lamarque Souza
Re: Review Request 112869: Do not leak sockets in kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/#review40558 --- This review has been submitted with commit 8791daf6c46e57c3760a564a7dfbe85513aba522 by Lamarque V. Souza to branch KDE/4.11. - Commit Hook On Sept. 22, 2013, 12:21 p.m., Lamarque Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/ --- (Updated Sept. 22, 2013, 12:21 p.m.) Review request for kdelibs and Solid. Description --- NetworkInterface::isWireless() in kdelibs/solid/solid/backends/udev/udevnetworkinterface.cpp does not close the socket it opens to call an ioctl leading to problem to kded4 that can affect plasma-desktop as well (temporary freezing plasma-desktop as described in the bug entry). This addresses bug 324954. http://bugs.kde.org/show_bug.cgi?id=324954 Diffs - solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907 Diff: http://git.reviewboard.kde.org/r/112869/diff/ Testing --- Tested by the bug reporter and it fixes the problem for him. Thanks, Lamarque Souza
Re: Review Request 112869: Do not leak sockets in kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/#review40559 --- This review has been submitted with commit 6e3827c37add0cb92cd5a05319911a0d175c1228 by Lamarque V. Souza to branch KDE/4.10. - Commit Hook On Sept. 23, 2013, 12:43 p.m., Lamarque Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/ --- (Updated Sept. 23, 2013, 12:43 p.m.) Review request for kdelibs and Solid. Description --- NetworkInterface::isWireless() in kdelibs/solid/solid/backends/udev/udevnetworkinterface.cpp does not close the socket it opens to call an ioctl leading to problem to kded4 that can affect plasma-desktop as well (temporary freezing plasma-desktop as described in the bug entry). This addresses bug 324954. http://bugs.kde.org/show_bug.cgi?id=324954 Diffs - solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907 Diff: http://git.reviewboard.kde.org/r/112869/diff/ Testing --- Tested by the bug reporter and it fixes the problem for him. Thanks, Lamarque Souza
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:04 p.m.) Review request for kdelibs. Changes --- Same fixes as r3 with @since 5.0 and Camel Case Include Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs (updated) - includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:04 p.m.) Review request for kdelibs. Changes --- Same fixes as r3 with @since 5.0 and Camel Case Include Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs - includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40565 --- kdeui/colors/kcolorschemetoken.h http://git.reviewboard.kde.org/r/112880/#comment29882 just QObject, see below kdeui/colors/kcolorschemetoken.h http://git.reviewboard.kde.org/r/112880/#comment29881 This isn't a visible item, so you can just derive from QObject kdeui/colors/kcolorschemetoken.h http://git.reviewboard.kde.org/r/112880/#comment29883 just QObject *parent = 0 - Kevin Krammer On Sept. 23, 2013, 1:04 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:04 p.m.) Review request for kdelibs. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs - includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:51 p.m.) Review request for kdelibs. Changes --- Changed QDeclarativeObject to QObject. Also deleted QT_DECLARATIVE from CMakeLists target libs. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs (updated) - includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40571 --- looks ok to me know. Better add the frameworks review group as well - Kevin Krammer On Sept. 23, 2013, 1:51 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:51 p.m.) Review request for kdelibs. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs - includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112880: Added KColorSchemeToken class.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 2:43 p.m.) Review request for KDE Frameworks and kdelibs. Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include KColorSchemeToken at KReversi's code, only kcolorschemetoken.h. Maybe I've missed something? Diffs - includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/CMakeLists.txt b439e04 kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: Review Request 112852: Proposed patch to enable compilation of nepomuk-core on Mac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112852/#review40585 --- I'm okay with this, but I'm not well versed with cmake magic. If no one else objects, feel free to push this. It can always be reverted. - Vishesh Handa On Sept. 21, 2013, 7:53 a.m., Nicolas Pavillon wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112852/ --- (Updated Sept. 21, 2013, 7:53 a.m.) Review request for kdelibs and Nepomuk. Description --- Patch to solve the bug reported at https://bugs.kde.org/show_bug.cgi?id=325058. This addresses bug https://bugs.kde.org/show_bug.cgi?id=325058. http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=325058 Diffs - tools/nepomukctl/main.cpp 9d350ea Diff: http://git.reviewboard.kde.org/r/112852/diff/ Testing --- Applied the patch on several OS X platforms to ensure that compilation does not crash. See https://trac.macports.org/ticket/40498 for details. Thanks, Nicolas Pavillon
Re: Review Request 112852: Proposed patch to enable compilation of nepomuk-core on Mac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112852/#review40588 --- Ship it! Ship It! - Sune Vuorela On Sept. 21, 2013, 7:53 a.m., Nicolas Pavillon wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112852/ --- (Updated Sept. 21, 2013, 7:53 a.m.) Review request for kdelibs and Nepomuk. Description --- Patch to solve the bug reported at https://bugs.kde.org/show_bug.cgi?id=325058. This addresses bug https://bugs.kde.org/show_bug.cgi?id=325058. http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=325058 Diffs - tools/nepomukctl/main.cpp 9d350ea Diff: http://git.reviewboard.kde.org/r/112852/diff/ Testing --- Applied the patch on several OS X platforms to ensure that compilation does not crash. See https://trac.macports.org/ticket/40498 for details. Thanks, Nicolas Pavillon
