Re: Review Request 113056: Port ksgrd library to KF5

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113056/#review41160
---



libs/ksysguard/ksgrd/SensorAgent.cpp


#include 

should work. 



libs/ksysguard/ksgrd/SensorAgent.cpp


This line is rather important as it makes translations work.

You are correct that it is now obsolete, but there is a new replacement 
that it should be ported to.

see 
http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide.html#link_cat

i.e 

#define TRANSLATION_DOMAIN "ksgrd"
#include 



- David Edmundson


On Oct. 3, 2013, 5:50 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113056/
> ---
> 
> (Updated Oct. 3, 2013, 5:50 a.m.)
> 
> 
> Review request for kde-workspace and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Port ksgrd library to KF5,
> 
> I already pushed kDebug > qDebug changes with commit 03681a90
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/CMakeLists.txt b00d9ff 
>   libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d 
>   libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 
>   libs/ksysguard/ksgrd/SensorManager.cpp f1657ee 
>   libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f 
>   libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 
> 
> Diff: http://git.reviewboard.kde.org/r/113056/diff/
> 
> 
> Testing
> ---
> 
> No tests, we can test this by porting systemmonitor dataengine later.
> 
> Tested, works as expected. https://git.reviewboard.kde.org/r/113072/
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

Re: Review Request 113056: Port ksgrd library to KF5

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113056/
---

(Updated Oct. 3, 2013, 11 a.m.)


Review request for kde-workspace and Sebastian Kügler.


Repository: kde-workspace


Description
---

Port ksgrd library to KF5,

I already pushed kDebug > qDebug changes with commit 03681a90


Diffs (updated)
-

  libs/ksysguard/CMakeLists.txt b00d9ff 
  libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d 
  libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 
  libs/ksysguard/ksgrd/SensorManager.cpp f1657ee 
  libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f 
  libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 

Diff: http://git.reviewboard.kde.org/r/113056/diff/


Testing
---

No tests, we can test this by porting systemmonitor dataengine later.

Tested, works as expected. https://git.reviewboard.kde.org/r/113072/


Thanks,

Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113056/#review41167
---

Ship it!


Ship It!

- Sebastian Kügler


On Oct. 3, 2013, 11 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113056/
> ---
> 
> (Updated Oct. 3, 2013, 11 a.m.)
> 
> 
> Review request for kde-workspace and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Port ksgrd library to KF5,
> 
> I already pushed kDebug > qDebug changes with commit 03681a90
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/CMakeLists.txt b00d9ff 
>   libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d 
>   libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 
>   libs/ksysguard/ksgrd/SensorManager.cpp f1657ee 
>   libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f 
>   libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 
> 
> Diff: http://git.reviewboard.kde.org/r/113056/diff/
> 
> 
> Testing
> ---
> 
> No tests, we can test this by porting systemmonitor dataengine later.
> 
> Tested, works as expected. https://git.reviewboard.kde.org/r/113072/
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

Re: Review Request 113056: Port ksgrd library to KF5

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113056/#review41168
---


This review has been submitted with commit 
0cfbe6ba886fff62857ac1d548eb352d3664fa0d by Bhushan Shah to branch master.

- Commit Hook


On Oct. 3, 2013, 11 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113056/
> ---
> 
> (Updated Oct. 3, 2013, 11 a.m.)
> 
> 
> Review request for kde-workspace and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Port ksgrd library to KF5,
> 
> I already pushed kDebug > qDebug changes with commit 03681a90
> 
> 
> Diffs
> -
> 
>   libs/ksysguard/CMakeLists.txt b00d9ff 
>   libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d 
>   libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 
>   libs/ksysguard/ksgrd/SensorManager.cpp f1657ee 
>   libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f 
>   libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 
> 
> Diff: http://git.reviewboard.kde.org/r/113056/diff/
> 
> 
> Testing
> ---
> 
> No tests, we can test this by porting systemmonitor dataengine later.
> 
> Tested, works as expected. https://git.reviewboard.kde.org/r/113072/
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

Re: Review Request 113056: Port ksgrd library to KF5

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113056/
---

(Updated Oct. 3, 2013, 11:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Sebastian Kügler.


Repository: kde-workspace


Description
---

Port ksgrd library to KF5,

I already pushed kDebug > qDebug changes with commit 03681a90


Diffs
-

  libs/ksysguard/CMakeLists.txt b00d9ff 
  libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d 
  libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 
  libs/ksysguard/ksgrd/SensorManager.cpp f1657ee 
  libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f 
  libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 

Diff: http://git.reviewboard.kde.org/r/113056/diff/


Testing
---

No tests, we can test this by porting systemmonitor dataengine later.

Tested, works as expected. https://git.reviewboard.kde.org/r/113072/


Thanks,

Bhushan Shah

Re: Review Request 112852: Proposed patch to enable compilation of nepomuk-core on Mac

[Nicolas Pavillon]

> On Sept. 23, 2013, 4:18 p.m., Sune Vuorela wrote:
> > Ship It!
> 
> Christoph Feck wrote:
> Nicolas, do you have or want to obtain commit rights? If not, Nepomuk 
> developers can commit it for you.

I do not have commit rights, but I am not sure that it would be relevant that I 
have them. Apart eventual bug reports such as this one (which are rare), I am 
not likely to provide much patches. Nepomuk developers can just commit it, 
unless it is inconvenient, in which case I could do it myself.


- Nicolas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112852/#review40588
---


On Sept. 21, 2013, 7:53 a.m., Nicolas Pavillon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112852/
> ---
> 
> (Updated Sept. 21, 2013, 7:53 a.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=325058
> 
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=325058
> 
> 
> Repository: nepomuk-core
> 
> 
> Description
> ---
> 
> Patch to solve the bug reported at 
> https://bugs.kde.org/show_bug.cgi?id=325058. 
> 
> 
> Diffs
> -
> 
>   tools/nepomukctl/main.cpp 9d350ea 
> 
> Diff: http://git.reviewboard.kde.org/r/112852/diff/
> 
> 
> Testing
> ---
> 
> Applied the patch on several OS X platforms to ensure that compilation does 
> not crash. See https://trac.macports.org/ticket/40498 for details.
> 
> 
> Thanks,
> 
> Nicolas Pavillon
> 
>

Re: Acquiring Google Mock libraries for tests

[Konrad Zemek]

On 02.10.2013 00:41, Sebastian Kügler wrote:

I was having a hard time searching for examples of Google Mock usage on
projects.kde.org, so my question is: how do other KDE projects deal with
acquiring Google Mock?

What is Google Mock and what's the deal about it? Your email describe a
concrete issue, without giving a problem description. For me, it's hard to
make sense of it, not knowing Google Mock. I understand you're talking about a
general problem with "precompiled libraries"? Another example is libspotify,
if I understand correctly?


Google Mock is a popular library for creating mock objects (for testing 
purposes) in C++. The reason for me being so specific is that when it 
comes to libraries, Google Mock is a very specific case - it needs to be 
compiled along with tests, with same flags, so it should not be 
precompiled. For this reason Kubuntu now ships sources instead of 
precompiled libraries, and some other distros don't provide any package 
whatsoever.


The discussion we have in amarok-devel is about how to acquire Google 
Mock's sources in order to compile them (bundle them in our repository, 
require distros to package them, etc). I asked here because I wanted to 
know how other KDE projects deal with the issue, the assumption being 
that there are other KDE projects using Google Mock.


Konrad

Re: Acquiring Google Mock libraries for tests

[Martin Klapetek]

On Wed, Oct 2, 2013 at 1:59 AM, Konrad Zemek  wrote:




> the assumption being that there are other KDE projects using Google Mock.


Fyi, none of the projects I've been working on in KDE (KDE Telepathy,
KPeople, DigiKam, KDE PIM (however that's huuge and I don't know every
corner of it) and recently KDE Frameworks and couple others) use Google
Mock. I, for one, also never heard of it before.

Cheers
-- 
Martin Klapetek | KDE Developer

Re: Acquiring Google Mock libraries for tests

[Thiago Macieira]

On quarta-feira, 2 de outubro de 2013 01:59:52, Konrad Zemek wrote:
> Google Mock is a popular library for creating mock objects (for testing
> purposes) in C++. The reason for me being so specific is that when it
> comes to libraries, Google Mock is a very specific case - it needs to be
> compiled along with tests, with same flags, so it should not be
> precompiled. For this reason Kubuntu now ships sources instead of
> precompiled libraries, and some other distros don't provide any package
> whatsoever.
> 
> The discussion we have in amarok-devel is about how to acquire Google
> Mock's sources in order to compile them (bundle them in our repository,
> require distros to package them, etc). I asked here because I wanted to
> know how other KDE projects deal with the issue, the assumption being
> that there are other KDE projects using Google Mock.

I think you answered your question: if it needs to be compiled alongside the 
source and tests it's supposed to run with, then it needs to be built by the 
same compilation unit (our CMake scripts).

That leaves only three options:
 a) bundle it
 b) require the sources from the builder
 c) download it on the fly.

Option (c) is a no-go since many build machines run in sandboxes or otherwise 
firewalled environments.

So the question is: is it acceptable to require Linux distributions to package 
the sources? If they do that, we'll still need a CMake FindPackage script to 
find it and set up the options.

I guess your question should go to the packagers mailing list.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
  PGP/GPG: 0x6EF45358; fingerprint:
  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358


signature.asc
Description: This is a digitally signed message part.