projects page dead ?
https://projects.kde.org/projects/ gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? Has the page moved ? Thanks in advance, Hugo
Re: projects page dead ?
same here... Gilles Caulier 2013/11/29 Hugo Pereira Da Costa hugo.pere...@free.fr: https://projects.kde.org/projects/ gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? Has the page moved ? Thanks in advance, Hugo
Review Request 114201: define property X-KDE-PluginKeyword in kdelibs/kio/kcmodule.desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114201/ --- Review request for kdelibs and David Faure. Repository: kdelibs Description --- This is required to make https://git.reviewboard.kde.org/r/111851/ work properly I don't know what to document here, the only hint I found in: http://websvn.kde.org/?view=revisionrevision=705672 Log Message: port to KPluginFactory Diffs - kio/kcmodule.desktop 2a978a5 Diff: http://git.reviewboard.kde.org/r/114201/diff/ Testing --- Thanks, Burkhard Lück
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 29, 2013, 12:37 p.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, David Faure, and Frank Reininghaus. Changes --- New patch with changes *only* in kde-runtime/khelpcenter which implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins No Web Shortcuts, because it is already in System Settings Modules 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. This patch requires another patch in kdelibs to work: see https://git.reviewboard.kde.org/r/114201/ --- a/kio/kcmodule.desktop +++ b/kio/kcmodule.desktop @@ -114,3 +114,8 @@ Type=QString # sets the order of the modules in the TreeList/IconList [PropertyDef::X-KDE-Weight] Type=int + +# TODO: document +[PropertyDef::X-KDE-PluginKeyword] +Type=QString Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs (updated) - khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/filemanagercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop PRE-CREATION khelpcenter/plugins/othercontrolmodules.desktop PRE-CREATION khelpcenter/plugintraverser.cpp b0b0e78 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree
Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44806 --- This review has been submitted with commit 40ded3efd3fa093247dd24e5b99d802536eda68a by Patrick von Reth to branch KDE/4.11. - Commit Hook On July 1, 2013, 5:17 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoCenter and kwin. Repository: kde-workspace Description --- make kinfocenter compile on non x11 systems and Windows Kinfocenter is quite useful to test a solid backend Diffs - CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 Diff: http://git.reviewboard.kde.org/r/111342/diff/ Testing --- windows Thanks, Patrick von Reth
Re: Review Request 112880: Added KColorSchemeToken class.
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many pre-exams in university. Kevin Ottens wrote: Any news? we need to get in or discard all the old patches now. Kevin Ottens wrote: Last warning before getting discarded. Patches will soon not be accepted in kdelibs/frameworks in preparation of the repository split. Denis Kuplyakov wrote: Sorry, but I'm still very busy. What is deadline, and can I submit changes after repo-split? Kevin Ottens wrote: Re-submitting *after* the repository is perfectly fine. It will have to be a new review though. If you're fine with that we can just discard that one, and you can resubmit at your convenience post-split. That's good, I think you can discard this. - Denis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 --- On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Oct. 6, 2013, 7:24 p.m.) Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description --- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for KDE theme colors API for QML thread at kdelibs and kdegames mailinglists * Diffs - kdeui/CMakeLists.txt b439e04 includes/CMakeLists.txt cdf0143 includes/KColorSchemeToken PRE-CREATION kdeui/colors/kcolorscheme.h 17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
Re: projects page dead ?
On Sat, Nov 30, 2013 at 1:25 AM, Hugo Pereira Da Costa hugo.pere...@free.fr wrote: https://projects.kde.org/projects/ gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? Has the page moved ? This was a temporary fault, which has now been resolved. Thanks for reporting. Thanks in advance, Hugo Thanks, Ben Cooksley KDE Sysadmin
Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44837 --- Patch looks fine to me, sucks a bit that the names have to be hardcoded for certain lists but not much can be done there if that is what the applications do... - Ben Cooksley On Nov. 29, 2013, 12:37 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 29, 2013, 12:37 p.m.) Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, David Faure, and Frank Reininghaus. Bugs: 262935 http://bugs.kde.org/show_bug.cgi?id=262935 Repository: kde-runtime Description --- The KHelpcenter navigation tree has a top level item Control Center Modules, an unsorted list of all KCModules (80 for a full kde main modules install from stable). This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935 This patch implements: A) Alphabetical sorting for Control Center Modules/Foo Settings Modules + KInfoCenter items B) New / changed top level categories in the navigation tree: 1) System Settings Modules - replaces old Control Center Modules items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html 2) Konqueror Settings Modules (see Konqueror settings dialog) items: General, Performance, Bookmarks 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog) items: File Management, View Modes, Navigation, Services, General, Trash No File Associations, because it is already in System Settings Modules 4) Browser Settings Modules (see Konqueror settings dialog) items: Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, History, Cookies, Browser Identification, Java JavaScript, Plugins 5) Other Settings Modules all other items like e.g. CGI Scripts from kde-runtime To make full use of these new/changed categories some kcm desktop files in other modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review. As long as not all desktop files are fixed according to this patch or a necessary change in a desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order. C) Change wording from Control Center Modules to System Settings Modules and using Foo Settings Modules for the new categories. Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. Diffs - khelpcenter/navigator.cpp 7460cc8 khelpcenter/plugins/CMakeLists.txt d09b869 khelpcenter/plugins/browsercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/filemanagercontrolmodules.desktop PRE-CREATION khelpcenter/plugins/kcontrolmodules.desktop 1813df3 khelpcenter/plugins/konquerorcontrolmodules.desktop PRE-CREATION khelpcenter/plugins/othercontrolmodules.desktop PRE-CREATION khelpcenter/plugintraverser.cpp b0b0e78 Diff: http://git.reviewboard.kde.org/r/111851/diff/ Testing --- Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol and othercontrol, see attached screenshot. File Attachments New Categories in KHelpcenter navigation tree http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png Thanks, Burkhard Lück
Re: Review Request 114214: remove QDesktopWidget global static
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114214/ --- (Updated Nov. 29, 2013, 9 p.m.) Review request for kdelibs and kdewin. Repository: kdelibs Description --- There is one global static for a QDesktopWidget in the code. We do not really need that, given that QApplication returns a static instance already. This also fixes a bug I have in when closing yakuake: Application: Yakuake (yakuake), signal: EXCEPTION_ACCESS_VIOLATION QtGuid4.dll!QScopedPointerQObjectData,QScopedPointerDeleterQObjectData ::data() [q:\qt-4.8.2\src\corelib\tools\qscopedpointer.h @ 135] at 0x54e6566a QtGuid4.dll!qGetPtrHelperQScopedPointerQObjectData,QScopedPointerDeleterQObjectData () [q:\qt-4.8.2\src\corelib\global\qglobal.h @ 2455] at 0x54e53d5b QtGuid4.dll!QApplication::d_func() [q:\qt-4.8.2\src\gui\kernel\qapplication.h @ 390] at 0x54e5e213 QtGuid4.dll!QWidget::~QWidget() [q:\qt-4.8.2\src\gui\kernel\qwidget.cpp @ 1634] at 0x54eeaa5b QtGuid4.dll!QDesktopWidget::~QDesktopWidget() [q:\qt-4.8.2\src\gui\kernel\qdesktopwidget_win.cpp @ 253] at 0x54f41002 kdeui.dll!QDesktopWidget::`scalar deleting destructor'() [[unknown] @ -1] at 0x5435921a kdeui.dll!_k_s_deskWidget__LINE__::destroy() [r:\build\kde\kdelibs-20110130\work\kdelibs-4.10.2\kdeui\windowmanagement\kwindowsystem_win.cpp @ 60] at 0x543591bb kdeui.dll!KCleanUpGlobalStatic::~KCleanUpGlobalStatic() [r:\build\kde\kdelibs-20110130\work\kdelibs-4.10.2\kdecore\kernel\kglobal.h @ 62] at 0x53f68498 kdeui.dll!`_k_s_deskWidget__LINE__::operator-'::`13'::`dynamic atexit destructor for 'cleanUpObject''() [[unknown] @ -1] at 0x543f76ad kdeui.dll!_CRT_INIT() [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 415] at 0x54372424 kdeui.dll!__DllMainCRTStartup() [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 526] at 0x54372630 ... I don't think it breaks anything. Diffs - kdeui/windowmanagement/kwindowsystem_win.cpp e5b3a23 Diff: http://git.reviewboard.kde.org/r/114214/diff/ Testing (updated) --- On Windows msvc2010 ;-) Thanks, Patrick Spendrin
Best practice for libraries supporting both Qt4 and Qt5
Hi, Is there an established best practice for libraries to support both Qt4 and Qt5? Currently, some libraries such as phonon rename their Qt5 versions, permitting full parallel installation and usage (even of development and CMake config files). Other libraries such as attica bump the major library version only with no change in development files. I personally prefer the phonon approach, simply because it makes it so easy to work with Qt4 and Qt5 consumers side-by-side. Any thoughts? Best regards, Michael
Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pereira Da Costa. Bugs: 327919 http://bugs.kde.org/show_bug.cgi?id=327919 Repository: kde-workspace Description --- list.join already returns a QString and there is no need to encode it and cast back to QString again P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, frameworks for kdelibs?) How should I submit review request? Should I add both in branch or submit two review request? (But often the patch cannot apply directly due to context or file path changes). Diffs - kcontrol/krdb/krdb.cpp 92d84e9 Diff: http://git.reviewboard.kde.org/r/114219/diff/ Testing --- Compiles. Waiting for bug reporter's test. Thanks, Yichao Yu
Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}
On Nov. 29, 2013, 7:45 p.m., Thomas Lübking wrote:
kcontrol/krdb/krdb.cpp, line 102
http://git.reviewboard.kde.org/r/114219/diff/1/?file=221836#file221836line102
QFile::encodeName() seems equal to QString::toLocal8Bit(),
::decodeName() to ::fromLocal8Bit()
I don't think one can just drop one of them and whether transcoding is
required probably depends on what is done to the string interim.
If at all KToolInvocation::klauncher()-setLaunchEnv() would perform
a second decode, so it probaly depends on what that does.
Was locale charmap determined by the reporter in the bug?
---
Secret world domination plan:
--
#1: classified
#2: classified
#3: force ASCII as global standard
#4: classified
#5: classified
#6: classified
#7: classified
#8: classified
#9: classified
#a: classified
Yichao Yu wrote:
encodeName/toLocal8Bit is used to encode a unicode string to a
c-string/byte-array representation and decodeName/fromLocal8Bit does the
reverse.
The proper decoding is already done in QFile::decodeName above and the
QString already has the right unicode string in it.
Basically, QString is not a wrapper of arbitrary c-string/byte-array,
rather a wrapper of a unicode string so whatever done to a QString before or
after should assume it is a valid unicode string and is independent of what
encoding (utf8 in the case of dbus) is needed afterward.
Encode to a byte array and cast it back can only cause wrong encoding in
the second conversion and will not affect what is done in setLaunchEnv.
Yichao Yu wrote:
Or in another word QString has no encoding (well, by which I mean the
internal encoding is trasparent to the user), only byte array and c-string
has encoding.
Thomas Lübking wrote:
QString(QByteArray) according to the API doc actually differs between Qt4
5 (fromAscii - fromUtf8) but an encoding should not happen nevertheless
because:
282 void KLauncher::setLaunchEnv(const QString name, const QString
value)
283 {
284 #ifndef USE_KPROCESS_FOR_KIOSLAVES
285klauncher_header request_header;
286QByteArray requestData;
287
requestData.append(name.toLocal8Bit()).append('\0').append(value.toLocal8Bit()).append('\0');
Also QString(QByteArray) is obvisouly problematic by itself for the
apparent 4/5 incompatibility.
Yichao Yu wrote:
I guess you can also put it in this this way (setLaunchEnv have
toLocal8Bit inside) although I still think the simplest way is to remember
QString -- encode -- QByteArray, QByteArray -- decode -- QString and always
to the necessary explicit conversion.
That's why I hate hate hate this constructor. (and I've already fixed 3-4
bugs in KDE due to this constructor.) It might actually be helpful to compile
KDE with it commented out and replace everything with explicit conversion.
Yichao Yu wrote:
I guess you can also put it in this this way (setLaunchEnv have
toLocal8Bit inside) although I still think the simplest way is to remember
QString -- encode -- QByteArray, QByteArray -- decode -- QString and always
to the necessary explicit conversion.
That's why I hate hate hate this constructor. (and I've already fixed 3-4
bugs in KDE due to this constructor.) It might actually be helpful to compile
KDE with it commented out and replace everything with explicit conversion.
Yichao Yu wrote:
I guess you can also put it in this this way (setLaunchEnv have
toLocal8Bit inside) although I still think the simplest way is to remember
QString -- encode -- QByteArray, QByteArray -- decode -- QString and always
to the necessary explicit conversion.
That's why I hate hate hate this constructor. (and I've already fixed 3-4
bugs in KDE due to this constructor.) It might actually be helpful to compile
KDE with it commented out and replace everything with explicit conversion.
ahh sth wrong with my network sorry for the duplicated post...
- Yichao
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114219/#review44857
---
On Nov. 29, 2013, 7:26 p.m., Yichao Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114219/
---
(Updated Nov. 29, 2013, 7:26 p.m.)
Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo
Pereira Da Costa.
Bugs: 327919
http://bugs.kde.org/show_bug.cgi?id=327919
Repository: kde-workspace
Description
---
