Re: Review Request 109609: disable session management for screensavers

2013-12-31 Thread Wolfgang Bauer

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109609/#review46471
---


Ping?
Any opinions/comments?

Btw, this patch is part of openSUSE's official KDE packages since September.

- Wolfgang Bauer


On Sept. 11, 2013, 1:15 a.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109609/
> ---
> 
> (Updated Sept. 11, 2013, 1:15 a.m.)
> 
> 
> Review request for kde-workspace and Oliver Henshaw.
> 
> 
> Bugs: 314859
> http://bugs.kde.org/show_bug.cgi?id=314859
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> This patch disables session management for screensavers.
> Therefore no screensaver windows popup anymore on login if processes keep on 
> running when the user logs out.
> 
> As proposed in https://bugs.kde.org/show_bug.cgi?id=314859#c18
> 
> This doesn't solve the underlying problem of bug#224200 of course, but 
> provides better user experience for now, so please accept.
> 
> And IMHO it doesn't make sense to restore screensavers on login, anyway.
> 
> 
> Diffs
> -
> 
>   kscreensaver/libkscreensaver/main.cpp 6851ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/109609/diff/
> 
> 
> Testing
> ---
> 
> - Turn on the "Blank Screen" (kblankscrn.kss) screensaver in systemsettings.
> - Wait for the screensaver to kick in
> - Verify that the process is still running (due to bug#224200)
> - log out
> - log in again
> Now no "kblankscrn.kss" window is opened anymore (without the patch, a window 
> should appear)
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>



Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-31 Thread Shantanu Tushar Jha
Though not listed, plasma-mediacenter will move to baloo as soon as it gets
a stable release. This is also a great excuse for us to spend time in
fixing the tight coupling between our media collection logic and Nepomuk.


On Fri, Dec 27, 2013 at 6:13 PM, Albert Astals Cid  wrote:

> El Divendres, 27 de desembre de 2013, a les 13:24:14, Vishesh Handa va
> escriure:
> > On Wednesday 25 Dec 2013 23:43:20 Albert Astals Cid wrote:
> > > The pim agent Messages.sh catalog name is wrong as discussed on IRC.
> >
> > Fixed
> >
> > > balooshow and baloosearch are missing Messages.sh
> >
> > Fixed
> >
> > > kio_tags is duplicated. What's the plan for it? Kill the old one? In
> that
> > > case, can the new one search tags created in nepomuk?
> > >
> > > Same question for kio_timeline.
> >
> > Kill both of them. Neither of them will be able to search through
> > information in Nepomuk. However, I do plan to write a simple application
> to
> > migrate nepomuk tags, ratings and config settings into Baloo.
> >
> > The only remaining Nepomuk bit in kde-runtime will be the kcm, which
> should
> > be removed as well.
> >
> > > I'm also concerned about what all the others are asking. In an ideal
> world
> > > the user should not care if he's using an app that uses baloo or uses
> > > nepomuk, since, as far as i understand, the "user exposed
> functionality"
> > > will be the same (even if the inner stuff is different), so if
> previously
> > > i
> > > did a tag somewhere and it showed somewhere else, i'd still expect
> this to
> > > work even if the stuff is using different "backends".
> >
> > That's the plan. The user continues to tag files how they used to
> > previously.
> > > As far as I understand, that's virtually impossible, but then it leads
> to
> > > the question. What's the plan? Just port *all* of nepomuk uses over to
> > > baloo for 4.13? What about the uses in kde-workspace?
> >
> > The most notable use cases of Nepomuk are -
> >
> > 1. Dolphin - Nearly ported, needs more testing.
> > 2. KMail - 80% done. Tags will be stored directly in Akonadi. Same for
> > comments. So the only thing that had to be ported was searching.
> > 3. GwenView - It'll be a simple port
> >
> > kde-workspace just has a runner and a dataengine. Both of those can be
> > provided by Baloo if required.
> >
> > Activities - Will need to be ported. From my perspective it is a simple
> port
> > that can be done during the Plasma sprint.
>
> What about the users of:
>  digikam
>  kphotoalbum
>  amarok
>  kamoso
>  kdenlive
>  rekonq
>  tellico
>  nepomuk-webminer
>  plasma-mobile
>  share-like-connect
> ?
>
> Cheers,
>   Albert
>



-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com


Re: KClasses vs. Qt5Classes

2013-12-31 Thread David Faure
On Tuesday 31 December 2013 09:47:59 Allen Winter wrote:
> Thanks for the detailed response. I will fix the krazy test accordingly.
> 
> Also: remember how in Qt4 there were a couple deprecated classes (QMdiArea,
> for example)? 

I guess you mean QWorkspace; QMdiArea is not deprecated.

> Does Qt5 also ship any deprecated classes?

Not that I can see.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5



KF5 Update Meeting Minutes Almost 2014

2013-12-31 Thread Kevin Ottens
Hello everyone,

This is the minutes of the last meeting of 2013. As usual it has been held on 
#kde-devel at 4pm Paris time.

Were present: apol and myself.

Announcement:
 * TP1 is almost ready, forwarding headers work missing

 * apol has been working on the header generation for KCoreAddons, KGuiAddons 
and KWidgetsAddons;
 * he'll cover KArchive and ThreadWeaver next which are blocking TP1;

 * ervin has been acting behind the scene to get things rolling for TP1;
 * feels like being a kind of manager, not doing terribly much on the 
technical front;

And that's it for today! Don't party too hard tonight, see you in 2014!

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.


Re: Review Request 109609: disable session management for screensavers

2013-12-31 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109609/#review46506
---

Ship it!


Ship It!

- Lukáš Tinkl


On Sept. 11, 2013, 1:15 a.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109609/
> ---
> 
> (Updated Sept. 11, 2013, 1:15 a.m.)
> 
> 
> Review request for kde-workspace and Oliver Henshaw.
> 
> 
> Bugs: 314859
> http://bugs.kde.org/show_bug.cgi?id=314859
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> This patch disables session management for screensavers.
> Therefore no screensaver windows popup anymore on login if processes keep on 
> running when the user logs out.
> 
> As proposed in https://bugs.kde.org/show_bug.cgi?id=314859#c18
> 
> This doesn't solve the underlying problem of bug#224200 of course, but 
> provides better user experience for now, so please accept.
> 
> And IMHO it doesn't make sense to restore screensavers on login, anyway.
> 
> 
> Diffs
> -
> 
>   kscreensaver/libkscreensaver/main.cpp 6851ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/109609/diff/
> 
> 
> Testing
> ---
> 
> - Turn on the "Blank Screen" (kblankscrn.kss) screensaver in systemsettings.
> - Wait for the screensaver to kick in
> - Verify that the process is still running (due to bug#224200)
> - log out
> - log in again
> Now no "kblankscrn.kss" window is opened anymore (without the patch, a window 
> should appear)
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>



Re: KClasses vs. Qt5Classes

2013-12-31 Thread Allen Winter
Thanks for the detailed response. I will fix the krazy test accordingly.

Also: remember how in Qt4 there were a couple deprecated classes (QMdiArea, for 
example)?
Does Qt5 also ship any deprecated classes?  
I'm being lazy now by asking and not looking myself.


On Tuesday, December 31, 2013 12:15:09 PM David Faure wrote:
> On Thursday 26 December 2013 16:46:59 Allen Winter wrote:
> > In KDE4 we had this list of KClasses we should be using instead of these
> > associated QClasses:
> > 
> > 
> > I know that some (or all?) of these QClasses in Qt5 are now cool for
> > frameworks and eventually KDE5
> > 
> > So my questions are:
> > * which of these Qt5 classes are cool and which ones do we need to continue
> > blacklisting from  frameworks+KDE5? 
> > * are there any known Qt5 classes that we should avoid in frameworks+KDE5?
> 
> > QColorDialog => KColorDialog
> 
> Deprecated, QColorDialog is now cool.
> 
> > QComboBox => KComboBox
> 
> Both are OK to use, depends on the use case
> (KComboBox provides KCompletion support)
> So, remove the krazy check.
> 
> > QMessageBox => KMessageBox
> 
> Both are OK to use. KMessageBox has additional features.
> Remove the krazy check.
> 
> > QErrorMessage => KMessageBox
> 
> QErrorMessage is still a weird beast which doesn't save the "don't show 
> again" 
> to disk. So yeah, keep this check.
> 
> > QInputDialog => KInputDialog
> 
> Deprecated, QInputDialog is now cool.
> 
> > QFileDialog => KFileDialog
> 
> Deprecated, QFileDialog is now cool.
> 
> > QProgressDialog => KProgressDialog
> 
> Same.
> 
> > QSplashScreen => KSplashScreen
> 
> Same.
> 
> > QSystemTrayIcon => KNotificationItem
> 
> No clue. I can't even find KNotificationItem in KF5 anywhere !?!?
> In fact it doesn't exist in kdelibs4 either.
> 
> I think it got replaced with KStatusNotifierItem since 4.4 ?
> That one is still valid in KF5 (framework "knotifications").
> I have no idea if/why it means QSystemTrayIcon is bad though.
> 
> > QDialog => KDialog
> 
> Deprecated, QDialog is now cool.
> 
> > QLineEdit => KLineEdit
> 
> Same as QComboBox: both are OK, remove check.
> 
> > QTabBar => KTabBar
> 
> Deprecated.
> 
> > QTabWidget => KTabWidget
> 
> Deprecated.
> 
> > QTextBrowser => KTextBrowser
> 
> Deprecated.
> 
> > QTextEdit => KTextEdit
> 
> Both are OK. E.g. KTextEdit provides spellchecking with its sonnet 
> integration, but if you don't need that, QTextEdit is fine.
> 
> > QUrl => KUrl
> 
> Deprecated.
> 
> > QNetworkAcessManager => KIO::AccessManager
> 
> Still true, keep this check.
> 
> 



Re: KClasses vs. Qt5Classes

2013-12-31 Thread Martin Graesslin
On Tuesday 31 December 2013 12:15:09 David Faure wrote: 
> > QSystemTrayIcon => KNotificationItem
> 
> No clue. I can't even find KNotificationItem in KF5 anywhere !?!?
> In fact it doesn't exist in kdelibs4 either.
> 
> I think it got replaced with KStatusNotifierItem since 4.4 ?
> That one is still valid in KF5 (framework "knotifications").
> I have no idea if/why it means QSystemTrayIcon is bad though.
QSystemTrayIcon uses XEmbed which is bad by definition ;-)

We have discussed this in the plasma team and think that the best solution 
would be to extend QSystemTrayIcon to use the status notifier API if available. 
Might need some hooks into the QPA as we probably cannot depend on D-Bus on 
that level. But as that doesn't exist yet, at the moment the proper suggestion 
should be to use KStatusNotifierItem.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.


Re: KClasses vs. Qt5Classes

2013-12-31 Thread David Faure
On Thursday 26 December 2013 16:46:59 Allen Winter wrote:
> In KDE4 we had this list of KClasses we should be using instead of these
> associated QClasses:
> 
> 
> I know that some (or all?) of these QClasses in Qt5 are now cool for
> frameworks and eventually KDE5
> 
> So my questions are:
> * which of these Qt5 classes are cool and which ones do we need to continue
> blacklisting from  frameworks+KDE5? 
> * are there any known Qt5 classes that we should avoid in frameworks+KDE5?

> QColorDialog => KColorDialog

Deprecated, QColorDialog is now cool.

> QComboBox => KComboBox

Both are OK to use, depends on the use case
(KComboBox provides KCompletion support)
So, remove the krazy check.

> QMessageBox => KMessageBox

Both are OK to use. KMessageBox has additional features.
Remove the krazy check.

> QErrorMessage => KMessageBox

QErrorMessage is still a weird beast which doesn't save the "don't show again" 
to disk. So yeah, keep this check.

> QInputDialog => KInputDialog

Deprecated, QInputDialog is now cool.

> QFileDialog => KFileDialog

Deprecated, QFileDialog is now cool.

> QProgressDialog => KProgressDialog

Same.

> QSplashScreen => KSplashScreen

Same.

> QSystemTrayIcon => KNotificationItem

No clue. I can't even find KNotificationItem in KF5 anywhere !?!?
In fact it doesn't exist in kdelibs4 either.

I think it got replaced with KStatusNotifierItem since 4.4 ?
That one is still valid in KF5 (framework "knotifications").
I have no idea if/why it means QSystemTrayIcon is bad though.

> QDialog => KDialog

Deprecated, QDialog is now cool.

> QLineEdit => KLineEdit

Same as QComboBox: both are OK, remove check.

> QTabBar => KTabBar

Deprecated.

> QTabWidget => KTabWidget

Deprecated.

> QTextBrowser => KTextBrowser

Deprecated.

> QTextEdit => KTextEdit

Both are OK. E.g. KTextEdit provides spellchecking with its sonnet 
integration, but if you don't need that, QTextEdit is fine.

> QUrl => KUrl

Deprecated.

> QNetworkAcessManager => KIO::AccessManager

Still true, keep this check.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5