Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Alexander Mezin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/
---

Review request for kde-workspace and Dario Freddi.


Repository: kde-workspace


Description
---

Some drivers report backlight brightness == 0 when display is switched off with 
DPMS (for example, Intel driver on my laptop).
If screen was switched off before dimming was started, it remembers 0 as 
previous backlight level. When I move mouse/press key, display doesn't switch 
on, because powerdevil sets brightness to 0.
This patch fixes the problem for me. It just doesn't change backlight 
brightness if it's already 0.


Diffs
-

  powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
  powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 

Diff: https://git.reviewboard.kde.org/r/114807/diff/


Testing
---

It works on my laptop.


Thanks,

Alexander Mezin

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46603
---

Ship it!


Looks good, I have been suffering from this too !

- Àlex Fiestas


On Jan. 2, 2014, 2:50 a.m., Alexander Mezin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> ---
> 
> (Updated Jan. 2, 2014, 2:50 a.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Some drivers report backlight brightness == 0 when display is switched off 
> with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as 
> previous backlight level. When I move mouse/press key, display doesn't switch 
> on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight 
> brightness if it's already 0.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> ---
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

Re: Review Request 114808: Fixes 305694 : Zoom Slider fails to show correct icon size on mouse over

2014-01-02 Thread Emmanuel Pescosta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114808/#review46608
---


Thanks for this patch, but this change brings in some unwanted sideeffects.

See Frank's comment in this review request for more information: 
https://git.reviewboard.kde.org/r/97/

- Emmanuel Pescosta


On Jan. 2, 2014, 8:31 a.m., Arjun Ak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114808/
> ---
> 
> (Updated Jan. 2, 2014, 8:31 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> fixes 305694 : Zoom Slider fails to show correct icon size on mouse over
> 
> 
> Diffs
> -
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 671ef4f 
> 
> Diff: https://git.reviewboard.kde.org/r/114808/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

Re: Review Request 114808: Fixes 305694 : Zoom Slider fails to show correct icon size on mouse over

2014-01-02 Thread Emmanuel Pescosta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114808/#review46609
---


Thanks for this patch, but this change brings in some unwanted sideeffects.

See Frank's comment in this review request for more information: 
https://git.reviewboard.kde.org/r/97/

- Emmanuel Pescosta


On Jan. 2, 2014, 8:31 a.m., Arjun Ak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114808/
> ---
> 
> (Updated Jan. 2, 2014, 8:31 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> fixes 305694 : Zoom Slider fails to show correct icon size on mouse over
> 
> 
> Diffs
> -
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 671ef4f 
> 
> Diff: https://git.reviewboard.kde.org/r/114808/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46610
---

Ship it!


Ship It!

- Lukáš Tinkl


On Jan. 2, 2014, 3:50 a.m., Alexander Mezin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> ---
> 
> (Updated Jan. 2, 2014, 3:50 a.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Some drivers report backlight brightness == 0 when display is switched off 
> with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as 
> previous backlight level. When I move mouse/press key, display doesn't switch 
> on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight 
> brightness if it's already 0.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> ---
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Alexander Mezin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/
---

(Updated Jan. 2, 2014, 12:14 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Dario Freddi.


Repository: kde-workspace


Description
---

Some drivers report backlight brightness == 0 when display is switched off with 
DPMS (for example, Intel driver on my laptop).
If screen was switched off before dimming was started, it remembers 0 as 
previous backlight level. When I move mouse/press key, display doesn't switch 
on, because powerdevil sets brightness to 0.
This patch fixes the problem for me. It just doesn't change backlight 
brightness if it's already 0.


Diffs
-

  powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
  powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 

Diff: https://git.reviewboard.kde.org/r/114807/diff/


Testing
---

It works on my laptop.


Thanks,

Alexander Mezin

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46617
---


This review has been submitted with commit 
6326ee72a1fd895b68d71e7da03b5e817b7be114 by Alexander Mezin to branch KDE/4.11.

- Commit Hook


On Jan. 2, 2014, 2:50 a.m., Alexander Mezin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> ---
> 
> (Updated Jan. 2, 2014, 2:50 a.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Some drivers report backlight brightness == 0 when display is switched off 
> with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as 
> previous backlight level. When I move mouse/press key, display doesn't switch 
> on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight 
> brightness if it's already 0.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> ---
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Alexander Mezin 


> On Jan. 2, 2014, 5:58 p.m., Àlex Fiestas wrote:
> > Looks good, I have been suffering from this too !

Most probably this patch won't solve your problem.

There is also a bug in Intel driver. It changes backlight brightness when 
queried with XRandr. It's fixed only in 2.99.905 and only for SNA backend. 
https://bugs.freedesktop.org/show_bug.cgi?id=73181


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46603
---


On Jan. 2, 2014, 7:14 p.m., Alexander Mezin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> ---
> 
> (Updated Jan. 2, 2014, 7:14 p.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Some drivers report backlight brightness == 0 when display is switched off 
> with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as 
> previous backlight level. When I move mouse/press key, display doesn't switch 
> on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight 
> brightness if it's already 0.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> ---
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114717/#review46626
---



README.md


Empty space



src/core/globals.cpp


The indentation seems slightly strange over here.



src/core/guesslanguage.cpp


Large parts of this file have a different coding style than the 
conventional one used in other places.

Maybe one could choose one coding style and stick to it?



src/core/languagefilter.cpp


You aren't deleting the d pointer. Also, you're not implementing a copy 
constructor.



src/core/languagefilter.cpp


Space between =

This (along with other coding style issues) need to be fixed in many other 
places all over the file.



src/core/settings.cpp


Does the case matter over here?



src/core/settings.cpp


Nepomuk? :P




src/plugins/CMakeLists.txt


We don't care about Enchant any more?


- Vishesh Handa


On Dec. 29, 2013, 4:49 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114717/
> ---
> 
> (Updated Dec. 29, 2013, 4:49 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> I started by merging in the old language detection branch from SVN, while 
> improving it as I went along. One improvement was to use QChar's unicode 
> information instead of shipping our own unicode code point information 
> tables. The old filter class also got replaced with a new tokenizer, which I 
> rewrote most of to simplify.
> 
> I added kdepim to the reviewers because I remember talking with someone 
> working on PIM stuff on IRC, and he was interested in this (a long time ago, 
> though).
> 
> 
> Diffs
> -
> 
>   data/trigrams/ja PRE-CREATION 
>   data/trigrams/kk PRE-CREATION 
>   data/trigrams/ko PRE-CREATION 
>   data/trigrams/ky PRE-CREATION 
>   data/trigrams/la PRE-CREATION 
>   data/trigrams/lt PRE-CREATION 
>   data/trigrams/lv PRE-CREATION 
>   data/trigrams/mk PRE-CREATION 
>   data/trigrams/mn PRE-CREATION 
>   data/trigrams/nb PRE-CREATION 
>   data/trigrams/ne PRE-CREATION 
>   data/trigrams/nl PRE-CREATION 
>   data/trigrams/nr PRE-CREATION 
>   data/trigrams/pl PRE-CREATION 
>   data/trigrams/ps PRE-CREATION 
>   data/trigrams/pt PRE-CREATION 
>   data/trigrams/pt_BR PRE-CREATION 
>   data/trigrams/pt_PT PRE-CREATION 
>   data/trigrams/ro PRE-CREATION 
>   data/trigrams/ru PRE-CREATION 
>   data/trigrams/sk PRE-CREATION 
>   data/trigrams/sl PRE-CREATION 
>   data/trigrams/so PRE-CREATION 
>   data/trigrams/sq PRE-CREATION 
>   data/trigrams/sr PRE-CREATION 
>   data/trigrams/ss PRE-CREATION 
>   data/trigrams/st PRE-CREATION 
>   data/trigrams/sv PRE-CREATION 
>   data/trigrams/sw PRE-CREATION 
>   data/trigrams/th PRE-CREATION 
>   data/trigrams/tl PRE-CREATION 
>   data/trigrams/tn PRE-CREATION 
>   data/trigrams/tr PRE-CREATION 
>   data/trigrams/ts PRE-CREATION 
>   data/trigrams/uk PRE-CREATION 
>   data/trigrams/ur PRE-CREATION 
>   data/trigrams/uz PRE-CREATION 
>   data/trigrams/ve PRE-CREATION 
>   data/trigrams/vi PRE-CREATION 
>   data/trigrams/xh PRE-CREATION 
>   data/trigrams/zu PRE-CREATION 
>   sonnet.yaml c54f87b 
>   src/CMakeLists.txt e79492f 
>   src/core/CMakeLists.txt 2f8a184 
>   src/core/backgroundchecker.cpp 8b9e983 
>   src/core/backgroundchecker_p.h PRE-CREATION 
>   src/core/backgroundengine.cpp 3a14d34 
>   src/core/backgroundengine_p.h 10f6a27 
>   src/core/client_p.h bd3e416 
>   src/core/filter.cpp e99d332 
>   src/core/filter_p.h 6c7d8c9 
>   src/core/globals.h 0c54c96 
>   src/core/globals.cpp e57450f 
>   src/core/guesslanguage.h PRE-CREATION 
>   src/core/guesslanguage.cpp PRE-CREATION 
>   src/core/languagefilter.cpp PRE-CREATION 
>   src/core/languagefilter_p.h PRE-CREATION 
>   src/core/loader.cpp ee8db0e 
>   src/core/settings.cpp 095eddb 
>   src/core/settings_p.h ee2d22c 
>   src/core/speller.h 7428339 
>   src/core/speller.cpp 8cc2a1e 
>   src/core/textbreaks.cpp PRE-CREATION 
>   src/core/textbreaks_p.h PRE-CREATION 
>   src/core/tokenizer.cpp PRE-CREATION 
>   src/core/tokenizer_p.h PRE-CREATION 
>   src/plugins/CMakeLists.txt fc33a97 
>   src/plugins/aspell/kspell_aspellclient.h eadb52a 
>   src/plugins/enchant/CMakeLists.tx

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2014-01-02 Thread Martin Bříza 


> On Nov. 5, 2013, 6:54 p.m., Oswald Buddenhagen wrote:
> > what exploit do you have in mind?

Originally I submitted it for avoiding leaving supplemental groups assigned to 
the process but it's not necessary in this case... discarding


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113518/#review43117
---


On Jan. 2, 2014, 3:28 p.m., Martin Bříza wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113518/
> ---
> 
> (Updated Jan. 2, 2014, 3:28 p.m.)
> 
> 
> Review request for kde-workspace and Oswald Buddenhagen.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Initialize the user's groups in between calling setegid and seteuid to have 
> the correct supplemental groups in place.
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/kgreeter.cpp 1bddab5 
> 
> Diff: https://git.reviewboard.kde.org/r/113518/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Bříza
> 
>

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2014-01-02 Thread Martin Bříza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113518/
---

(Updated Jan. 2, 2014, 3:28 p.m.)


Status
--

This change has been discarded.


Review request for kde-workspace and Oswald Buddenhagen.


Repository: kde-workspace


Description
---

Initialize the user's groups in between calling setegid and seteuid to have the 
correct supplemental groups in place.


Diffs
-

  kdm/kfrontend/kgreeter.cpp 1bddab5 

Diff: https://git.reviewboard.kde.org/r/113518/diff/


Testing
---


Thanks,

Martin Bříza

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46631
---


Please don't forget to submit it for the 4.12 branch as well

- Lukáš Tinkl


On Jan. 2, 2014, 1:14 p.m., Alexander Mezin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> ---
> 
> (Updated Jan. 2, 2014, 1:14 p.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Some drivers report backlight brightness == 0 when display is switched off 
> with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as 
> previous backlight level. When I move mouse/press key, display doesn't switch 
> on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight 
> brightness if it's already 0.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> ---
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114807/#review46632
---


This review has been submitted with commit 
b3db8b1407d45d0c3b63b4a54b6f76bcdc525d31 by Alexander Mezin to branch master.

- Commit Hook


On Jan. 2, 2014, 12:14 p.m., Alexander Mezin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114807/
> ---
> 
> (Updated Jan. 2, 2014, 12:14 p.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Some drivers report backlight brightness == 0 when display is switched off 
> with DPMS (for example, Intel driver on my laptop).
> If screen was switched off before dimming was started, it remembers 0 as 
> previous backlight level. When I move mouse/press key, display doesn't switch 
> on, because powerdevil sets brightness to 0.
> This patch fixes the problem for me. It just doesn't change backlight 
> brightness if it's already 0.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/actions/bundled/dimdisplay.h f917d71 
>   powerdevil/daemon/actions/bundled/dimdisplay.cpp 39e0636 
> 
> Diff: https://git.reviewboard.kde.org/r/114807/diff/
> 
> 
> Testing
> ---
> 
> It works on my laptop.
> 
> 
> Thanks,
> 
> Alexander Mezin
> 
>

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Martin Tobias Holmedahl Sandsmark 


> On Jan. 2, 2014, 2:47 p.m., Vishesh Handa wrote:
> > src/plugins/CMakeLists.txt, line 29
> > 
> >
> > We don't care about Enchant any more?

it's seems to be unmaintained, is just an abstraction library, and it spammed 
my stdout, so I dropped it.


> On Jan. 2, 2014, 2:47 p.m., Vishesh Handa wrote:
> > src/core/settings.cpp, line 229
> > 
> >
> > Does the case matter over here?

eh, it's just an internal, static function. I thought it looked prettier this 
way. :-)


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114717/#review46626
---


On Dec. 29, 2013, 4:49 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114717/
> ---
> 
> (Updated Dec. 29, 2013, 4:49 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> I started by merging in the old language detection branch from SVN, while 
> improving it as I went along. One improvement was to use QChar's unicode 
> information instead of shipping our own unicode code point information 
> tables. The old filter class also got replaced with a new tokenizer, which I 
> rewrote most of to simplify.
> 
> I added kdepim to the reviewers because I remember talking with someone 
> working on PIM stuff on IRC, and he was interested in this (a long time ago, 
> though).
> 
> 
> Diffs
> -
> 
>   data/trigrams/ja PRE-CREATION 
>   data/trigrams/kk PRE-CREATION 
>   data/trigrams/ko PRE-CREATION 
>   data/trigrams/ky PRE-CREATION 
>   data/trigrams/la PRE-CREATION 
>   data/trigrams/lt PRE-CREATION 
>   data/trigrams/lv PRE-CREATION 
>   data/trigrams/mk PRE-CREATION 
>   data/trigrams/mn PRE-CREATION 
>   data/trigrams/nb PRE-CREATION 
>   data/trigrams/ne PRE-CREATION 
>   data/trigrams/nl PRE-CREATION 
>   data/trigrams/nr PRE-CREATION 
>   data/trigrams/pl PRE-CREATION 
>   data/trigrams/ps PRE-CREATION 
>   data/trigrams/pt PRE-CREATION 
>   data/trigrams/pt_BR PRE-CREATION 
>   data/trigrams/pt_PT PRE-CREATION 
>   data/trigrams/ro PRE-CREATION 
>   data/trigrams/ru PRE-CREATION 
>   data/trigrams/sk PRE-CREATION 
>   data/trigrams/sl PRE-CREATION 
>   data/trigrams/so PRE-CREATION 
>   data/trigrams/sq PRE-CREATION 
>   data/trigrams/sr PRE-CREATION 
>   data/trigrams/ss PRE-CREATION 
>   data/trigrams/st PRE-CREATION 
>   data/trigrams/sv PRE-CREATION 
>   data/trigrams/sw PRE-CREATION 
>   data/trigrams/th PRE-CREATION 
>   data/trigrams/tl PRE-CREATION 
>   data/trigrams/tn PRE-CREATION 
>   data/trigrams/tr PRE-CREATION 
>   data/trigrams/ts PRE-CREATION 
>   data/trigrams/uk PRE-CREATION 
>   data/trigrams/ur PRE-CREATION 
>   data/trigrams/uz PRE-CREATION 
>   data/trigrams/ve PRE-CREATION 
>   data/trigrams/vi PRE-CREATION 
>   data/trigrams/xh PRE-CREATION 
>   data/trigrams/zu PRE-CREATION 
>   sonnet.yaml c54f87b 
>   src/CMakeLists.txt e79492f 
>   src/core/CMakeLists.txt 2f8a184 
>   src/core/backgroundchecker.cpp 8b9e983 
>   src/core/backgroundchecker_p.h PRE-CREATION 
>   src/core/backgroundengine.cpp 3a14d34 
>   src/core/backgroundengine_p.h 10f6a27 
>   src/core/client_p.h bd3e416 
>   src/core/filter.cpp e99d332 
>   src/core/filter_p.h 6c7d8c9 
>   src/core/globals.h 0c54c96 
>   src/core/globals.cpp e57450f 
>   src/core/guesslanguage.h PRE-CREATION 
>   src/core/guesslanguage.cpp PRE-CREATION 
>   src/core/languagefilter.cpp PRE-CREATION 
>   src/core/languagefilter_p.h PRE-CREATION 
>   src/core/loader.cpp ee8db0e 
>   src/core/settings.cpp 095eddb 
>   src/core/settings_p.h ee2d22c 
>   src/core/speller.h 7428339 
>   src/core/speller.cpp 8cc2a1e 
>   src/core/textbreaks.cpp PRE-CREATION 
>   src/core/textbreaks_p.h PRE-CREATION 
>   src/core/tokenizer.cpp PRE-CREATION 
>   src/core/tokenizer_p.h PRE-CREATION 
>   src/plugins/CMakeLists.txt fc33a97 
>   src/plugins/aspell/kspell_aspellclient.h eadb52a 
>   src/plugins/enchant/CMakeLists.txt 817db0c 
>   src/plugins/enchant/enchantclient.h 25f62eb 
>   src/plugins/hspell/CMakeLists.txt e128cb3 
>   src/plugins/hspell/kspell_hspellclient.h 966303f 
>   src/plugins/hunspell/CMakeLists.txt ccae7f7 
>   src/plugins/hunspell/kspell_hunspellclient.h 79638bb 
>   src/ui/configui.ui 6532552 
>   src/ui/configwidget.cpp 7a5cc99 
>   src/ui/dialog.cpp 13ad39d 
>   src/ui/highlighter.h 46418b9 
>   src/ui/highlighter.cpp 9f31268 
>   src/unicode/CMakeLists.txt 1be0a54 
>   src/unicode/README f9b8030 
>   src/unicode/data/GraphemeBreakProperty.txt 8805f36 
>   src/unicode/da

Re: Review Request 109609: disable session management for screensavers

2014-01-02 Thread Wolfgang Bauer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109609/
---

(Updated Jan. 2, 2014, 6:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Oliver Henshaw.


Bugs: 314859
http://bugs.kde.org/show_bug.cgi?id=314859


Repository: kde-workspace


Description
---

This patch disables session management for screensavers.
Therefore no screensaver windows popup anymore on login if processes keep on 
running when the user logs out.

As proposed in https://bugs.kde.org/show_bug.cgi?id=314859#c18

This doesn't solve the underlying problem of bug#224200 of course, but provides 
better user experience for now, so please accept.

And IMHO it doesn't make sense to restore screensavers on login, anyway.


Diffs
-

  kscreensaver/libkscreensaver/main.cpp 6851ba1 

Diff: https://git.reviewboard.kde.org/r/109609/diff/


Testing
---

- Turn on the "Blank Screen" (kblankscrn.kss) screensaver in systemsettings.
- Wait for the screensaver to kick in
- Verify that the process is still running (due to bug#224200)
- log out
- log in again
Now no "kblankscrn.kss" window is opened anymore (without the patch, a window 
should appear)


Thanks,

Wolfgang Bauer

Re: Review Request 109609: disable session management for screensavers

2014-01-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109609/#review46637
---


This review has been submitted with commit 
c014af7836a9fa7df8a17485f9337c35e6d535de by Wolfgang Bauer to branch KDE/4.11.

- Commit Hook


On Sept. 10, 2013, 11:15 p.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109609/
> ---
> 
> (Updated Sept. 10, 2013, 11:15 p.m.)
> 
> 
> Review request for kde-workspace and Oliver Henshaw.
> 
> 
> Bugs: 314859
> http://bugs.kde.org/show_bug.cgi?id=314859
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> This patch disables session management for screensavers.
> Therefore no screensaver windows popup anymore on login if processes keep on 
> running when the user logs out.
> 
> As proposed in https://bugs.kde.org/show_bug.cgi?id=314859#c18
> 
> This doesn't solve the underlying problem of bug#224200 of course, but 
> provides better user experience for now, so please accept.
> 
> And IMHO it doesn't make sense to restore screensavers on login, anyway.
> 
> 
> Diffs
> -
> 
>   kscreensaver/libkscreensaver/main.cpp 6851ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/109609/diff/
> 
> 
> Testing
> ---
> 
> - Turn on the "Blank Screen" (kblankscrn.kss) screensaver in systemsettings.
> - Wait for the screensaver to kick in
> - Verify that the process is still running (due to bug#224200)
> - log out
> - log in again
> Now no "kblankscrn.kss" window is opened anymore (without the patch, a window 
> should appear)
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

Re: KClasses vs. Qt5Classes

2014-01-02 Thread Kevin Krammer 
On Tuesday, 2013-12-31, 12:42:22, Martin Graesslin wrote:
> On Tuesday 31 December 2013 12:15:09 David Faure wrote:
> > > QSystemTrayIcon => KNotificationItem
> > 
> > No clue. I can't even find KNotificationItem in KF5 anywhere !?!?
> > In fact it doesn't exist in kdelibs4 either.
> > 
> > I think it got replaced with KStatusNotifierItem since 4.4 ?
> > That one is still valid in KF5 (framework "knotifications").
> > I have no idea if/why it means QSystemTrayIcon is bad though.
> 
> QSystemTrayIcon uses XEmbed which is bad by definition ;-)
> 
> We have discussed this in the plasma team and think that the best solution
> would be to extend QSystemTrayIcon to use the status notifier API if
> available. Might need some hooks into the QPA as we probably cannot depend
> on D-Bus on that level. But as that doesn't exist yet, at the moment the
> proper suggestion should be to use KStatusNotifierItem.

I faintly remember a discussion where it was deemed acceptable for QtWidgets 
to depend on QtDBus on Linux.
But it makes more sense to do it in the QPA in any case,  because this is 
where lots of the other plaform UI integration bits already went (native 
dialogs, menus, etc).

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114717/#review46650
---



src/core/settings.cpp


Does this really need to be hardcoded here? O.o


Thanks for working on this!

- Aleix Pol Gonzalez


On Dec. 29, 2013, 4:49 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114717/
> ---
> 
> (Updated Dec. 29, 2013, 4:49 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> I started by merging in the old language detection branch from SVN, while 
> improving it as I went along. One improvement was to use QChar's unicode 
> information instead of shipping our own unicode code point information 
> tables. The old filter class also got replaced with a new tokenizer, which I 
> rewrote most of to simplify.
> 
> I added kdepim to the reviewers because I remember talking with someone 
> working on PIM stuff on IRC, and he was interested in this (a long time ago, 
> though).
> 
> 
> Diffs
> -
> 
>   data/trigrams/ja PRE-CREATION 
>   data/trigrams/kk PRE-CREATION 
>   data/trigrams/ko PRE-CREATION 
>   data/trigrams/ky PRE-CREATION 
>   data/trigrams/la PRE-CREATION 
>   data/trigrams/lt PRE-CREATION 
>   data/trigrams/lv PRE-CREATION 
>   data/trigrams/mk PRE-CREATION 
>   data/trigrams/mn PRE-CREATION 
>   data/trigrams/nb PRE-CREATION 
>   data/trigrams/ne PRE-CREATION 
>   data/trigrams/nl PRE-CREATION 
>   data/trigrams/nr PRE-CREATION 
>   data/trigrams/pl PRE-CREATION 
>   data/trigrams/ps PRE-CREATION 
>   data/trigrams/pt PRE-CREATION 
>   data/trigrams/pt_BR PRE-CREATION 
>   data/trigrams/pt_PT PRE-CREATION 
>   data/trigrams/ro PRE-CREATION 
>   data/trigrams/ru PRE-CREATION 
>   data/trigrams/sk PRE-CREATION 
>   data/trigrams/sl PRE-CREATION 
>   data/trigrams/so PRE-CREATION 
>   data/trigrams/sq PRE-CREATION 
>   data/trigrams/sr PRE-CREATION 
>   data/trigrams/ss PRE-CREATION 
>   data/trigrams/st PRE-CREATION 
>   data/trigrams/sv PRE-CREATION 
>   data/trigrams/sw PRE-CREATION 
>   data/trigrams/th PRE-CREATION 
>   data/trigrams/tl PRE-CREATION 
>   data/trigrams/tn PRE-CREATION 
>   data/trigrams/tr PRE-CREATION 
>   data/trigrams/ts PRE-CREATION 
>   data/trigrams/uk PRE-CREATION 
>   data/trigrams/ur PRE-CREATION 
>   data/trigrams/uz PRE-CREATION 
>   data/trigrams/ve PRE-CREATION 
>   data/trigrams/vi PRE-CREATION 
>   data/trigrams/xh PRE-CREATION 
>   data/trigrams/zu PRE-CREATION 
>   sonnet.yaml c54f87b 
>   src/CMakeLists.txt e79492f 
>   src/core/CMakeLists.txt 2f8a184 
>   src/core/backgroundchecker.cpp 8b9e983 
>   src/core/backgroundchecker_p.h PRE-CREATION 
>   src/core/backgroundengine.cpp 3a14d34 
>   src/core/backgroundengine_p.h 10f6a27 
>   src/core/client_p.h bd3e416 
>   src/core/filter.cpp e99d332 
>   src/core/filter_p.h 6c7d8c9 
>   src/core/globals.h 0c54c96 
>   src/core/globals.cpp e57450f 
>   src/core/guesslanguage.h PRE-CREATION 
>   src/core/guesslanguage.cpp PRE-CREATION 
>   src/core/languagefilter.cpp PRE-CREATION 
>   src/core/languagefilter_p.h PRE-CREATION 
>   src/core/loader.cpp ee8db0e 
>   src/core/settings.cpp 095eddb 
>   src/core/settings_p.h ee2d22c 
>   src/core/speller.h 7428339 
>   src/core/speller.cpp 8cc2a1e 
>   src/core/textbreaks.cpp PRE-CREATION 
>   src/core/textbreaks_p.h PRE-CREATION 
>   src/core/tokenizer.cpp PRE-CREATION 
>   src/core/tokenizer_p.h PRE-CREATION 
>   src/plugins/CMakeLists.txt fc33a97 
>   src/plugins/aspell/kspell_aspellclient.h eadb52a 
>   src/plugins/enchant/CMakeLists.txt 817db0c 
>   src/plugins/enchant/enchantclient.h 25f62eb 
>   src/plugins/hspell/CMakeLists.txt e128cb3 
>   src/plugins/hspell/kspell_hspellclient.h 966303f 
>   src/plugins/hunspell/CMakeLists.txt ccae7f7 
>   src/plugins/hunspell/kspell_hunspellclient.h 79638bb 
>   src/ui/configui.ui 6532552 
>   src/ui/configwidget.cpp 7a5cc99 
>   src/ui/dialog.cpp 13ad39d 
>   src/ui/highlighter.h 46418b9 
>   src/ui/highlighter.cpp 9f31268 
>   src/unicode/CMakeLists.txt 1be0a54 
>   src/unicode/README f9b8030 
>   src/unicode/data/GraphemeBreakProperty.txt 8805f36 
>   src/unicode/data/SentenceBreakProperty.txt fc58820 
>   src/unicode/data/WordBreakProperty.txt 78c531c 
>   src/unicode/parseucd/parseucd.cpp a050140 
>   tests/test_dialog.cpp 0579bb2 
>   tests/test_highlighter.h 9cf5657 
>   tests/test_highlighter.cpp 695a2df 
>   tests/test_textedit.cpp 5c02809 
>   data/trigrams/fr PRE-CREATION 
>   data/trigrams/ha PRE-CREATION 
>   data/trigrams/hi PRE-CREATION 
>   data/trigrams/hr PRE-CREATION 
>   data/trigrams/hu PRE-CREATION 
>   data/trigrams/id P

Re: KClasses vs. Qt5Classes

2014-01-02 Thread Aleix Pol 
On Tue, Dec 31, 2013 at 12:42 PM, Martin Graesslin wrote:

> On Tuesday 31 December 2013 12:15:09 David Faure wrote:
> > > QSystemTrayIcon => KNotificationItem
> >
> > No clue. I can't even find KNotificationItem in KF5 anywhere !?!?
> > In fact it doesn't exist in kdelibs4 either.
> >
> > I think it got replaced with KStatusNotifierItem since 4.4 ?
> > That one is still valid in KF5 (framework "knotifications").
> > I have no idea if/why it means QSystemTrayIcon is bad though.
> QSystemTrayIcon uses XEmbed which is bad by definition ;-)
>
> We have discussed this in the plasma team and think that the best solution
> would be to extend QSystemTrayIcon to use the status notifier API if
> available.
> Might need some hooks into the QPA as we probably cannot depend on D-Bus on
> that level. But as that doesn't exist yet, at the moment the proper
> suggestion
> should be to use KStatusNotifierItem.
>
> Cheers
> Martin


FWIW, our QPA (or QPT, actually) already depends on QtDBus.

Aleix