Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117345/ --- Review request for kdelibs. Repository: kdelibs Description --- Fix crash in KIO due to exposing inconsistent views of internal data. This can be triggered by renaming a directory while one of the files in it is open in gwenview. It occurs because when KDirListerCache::emitRedirections is called, itemsInUse contains the old url. However, KDirLister::Private::redirect changes lstDirs to the new url. Thus at this point lstDirs contains an item not in itemsInUse, which causes an assertion if forgetDirs is called. In gwenview, the redirection signal is connected to openURL. This calls forgetDirs, and causes the assertion. The solution: update itemsInUse *before* emitting redirections. This fixes the crash, but gwenview opens the first file in the new directory instead of the file open before renaming. This is probably an unrelated gwenview bug. I wrote this for kdelibs 4, but the code seems unchanged in kdelibs 5. Diffs - kio/kio/kdirlister.cpp aad6893f47eba81c3f78ed1ca7327adf6fb587bb Diff: https://git.reviewboard.kde.org/r/117345/diff/ Testing --- It fixes the crash! It might break something else. Thanks, Simeon Bird
Re: Review Request 117157: Unlock session via DBus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117157/#review54849 --- Please see different approach in https://git.reviewboard.kde.org/r/117324/ to use logind as an authority to unlock. - Martin Gräßlin On March 29, 2014, 12:58 p.m., Kirill Elagin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117157/ > --- > > (Updated March 29, 2014, 12:58 p.m.) > > > Review request for kde-workspace. > > > Bugs: 314989 > http://bugs.kde.org/show_bug.cgi?id=314989 > > > Repository: kde-workspace > > > Description > --- > > Unlock session via DBus > > Make org.freedesktop.ScreenSaver.SetActive(false) unlock session. > > > Diffs > - > > plasma-workspace/ksmserver/screenlocker/interface.cpp > ecb30a37b1a207cf9dab8c53b1b879108a99a45b > plasma-workspace/ksmserver/screenlocker/ksldapp.h > b292b62f4df073fff31bcbfd0e39f4c4fe04c92d > plasma-workspace/ksmserver/screenlocker/ksldapp.cpp > f2e5262524447e8ae1df1fbf6543297c3be3e6b8 > > Diff: https://git.reviewboard.kde.org/r/117157/diff/ > > > Testing > --- > > I've tested this with KDE 4.11.5 which I'm currently running. > Rebasing to master was completely trivial; I've looked through the code and I > believe all the assumptions I made are still valid in master. > > > Thanks, > > Kirill Elagin > >
Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ --- (Updated April 2, 2014, 8:27 a.m.) Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and Ian Monroe. Bugs: 149479 http://bugs.kde.org/show_bug.cgi?id=149479 Repository: kdelibs Description (updated) --- Even though the bug appears RESOLVED it is not. Minor hack to packagestructure.cpp to search for the metadata.desktop file recursively. This helps with installing desktop themes and removing them. I have tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore SoftSand for example, it's metadata.desktop is not properly formatted. There are others too which are not formatted which I guess could be fixed by setting a new format standard, maybe even a check package script to check new uploads on kde-look.org. EDIT: It seems I was wrong regarding the specified bug , where it's stated that the fix was for the themes to be removed from khotnewstuff and it is correct, so the bug is fixed in that regard. But the theme is not removed from the system or the list in the kcm desktoptheme module, when removing it with ghns, it only is not listed as installed. This fixes the "remove", so the theme is correctly removed completely from share/apps/desktoptheme/$theme_name and ghns. The fix consists of making libplasma/packagestructure look in another subfolder for the metadata.desktop file if the file is not found in the specified current path. Diffs - plasma/packagestructure.cpp 71148e1 Diff: https://git.reviewboard.kde.org/r/117174/diff/ Testing --- Compiled, run systemsettings, go to Desktop Themes, install / remove away. Some themes are broken so they won't work (not install). Thanks, Andrei Amuraritei
