Re: Review Request 119572: Part: use correct slots for QStatusbar

2014-08-05 Thread Heiko Becker


 On Aug. 4, 2014, 12:50 nachm., Martin Tobias Holmedahl Sandsmark wrote:
  Ship It!

I don't have commit access. So if someone could please push that for me? Same 
for https://git.reviewboard.kde.org/r/119573/


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119572/#review63769
---


On Aug. 2, 2014, 10:19 vorm., Heiko Becker wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119572/
 ---
 
 (Updated Aug. 2, 2014, 10:19 vorm.)
 
 
 Review request for kdelibs and Martin Tobias Holmedahl Sandsmark.
 
 
 Repository: filelight
 
 
 Description
 ---
 
 Part: use correct slots for QStatusbar
 
 The correct names are showMessage(..) and clearMessage().
 
 
 Diffs
 -
 
   src/part/part.cpp e63c852151c54018dc5dee448b0bc1367d6ee149 
 
 Diff: https://git.reviewboard.kde.org/r/119572/diff/
 
 
 Testing
 ---
 
 Warning message is gone when running and file names start appearing in the 
 status bar.
 
 
 Thanks,
 
 Heiko Becker
 




Re: [kde-community] Closing the kde-core-devel mailing list

2014-08-05 Thread Albert Astals Cid
El Dilluns, 4 d'agost de 2014, a les 20:36:44, Vishesh Handa va escriure:
 Hello people
 
 Random Idea: How about we close the k-c-d mailing list? It's main purpose
 used to be to discuss kdelibs changes, but now since we have
 kde-frameworks, the mailing list seems less useful. We already have
 kde-devel for other generic kde stuff.

kde-core-devel main purpose may had been discuss kdelibs changes, but it has 
trascended that purspose a while ago.

Let's see email threads that were sent here that don't belong to frameworks-
devel, please tell me what list would replace k-c-d in this regard

 * Pushing AppStream data to KDE project's master branches
 * KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?
 * Oxygen Fonts kdereview
 * Default wallpapers should go in svn or git?
 * Move of KXStitch to Extragear/Graphics 
 * Kronometer now in KDE Review 
 * Move of SymbolEditor to Extragear/Graphics 
 * Moving plasma-nm to extragear  
 * Talks @Akademy  
 * KBibTeX in KDE Review   
 * Freedesktop summit 2014 
 * kde-workspace split incoming!   

As you see these have nothing to do with kdelibs. Sure i understand lib 
development moved to frameworks-devel, that's fine, but until you have a place 
to discuss core stuff I don't see why we should close our core-devel list.

Cheers,
  Albert


Re: [kde-community] Closing the kde-core-devel mailing list

2014-08-05 Thread Matthias Klumpp
2014-08-05 20:29 GMT+02:00 Albert Astals Cid aa...@kde.org:
 El Dilluns, 4 d'agost de 2014, a les 20:36:44, Vishesh Handa va escriure:
 Hello people

 Random Idea: How about we close the k-c-d mailing list? It's main purpose
 used to be to discuss kdelibs changes, but now since we have
 kde-frameworks, the mailing list seems less useful. We already have
 kde-devel for other generic kde stuff.

 kde-core-devel main purpose may had been discuss kdelibs changes, but it has
 trascended that purspose a while ago.

 Let's see email threads that were sent here that don't belong to frameworks-
 devel, please tell me what list would replace k-c-d in this regard

  * Pushing AppStream data to KDE project's master branches
  * KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?
  * Oxygen Fonts kdereview
  * Default wallpapers should go in svn or git?
  * Move of KXStitch to Extragear/Graphics
  * Kronometer now in KDE Review
  * Move of SymbolEditor to Extragear/Graphics
  * Moving plasma-nm to extragear
  * Talks @Akademy
  * KBibTeX in KDE Review
  * Freedesktop summit 2014
  * kde-workspace split incoming!

 As you see these have nothing to do with kdelibs. Sure i understand lib
 development moved to frameworks-devel, that's fine, but until you have a place
 to discuss core stuff I don't see why we should close our core-devel list.
I agree with this - but do we have a list where we can discuss
project-wide technical changes? The kde-core-devel list so far is one
of the few lists where you can reach most developers to discuss some
of this global stuff.
Cheers,
Matthias

-- 
Debian Developer | Freedesktop-Developer
I welcome VSRE emails. See http://vsre.info/


Re: [kde-community] Closing the kde-core-devel mailing list

2014-08-05 Thread Kevin Krammer
On Tuesday, 2014-08-05, 20:29:05, Albert Astals Cid wrote:
 El Dilluns, 4 d'agost de 2014, a les 20:36:44, Vishesh Handa va escriure:
  Hello people
  
  Random Idea: How about we close the k-c-d mailing list? It's main purpose
  used to be to discuss kdelibs changes, but now since we have
  kde-frameworks, the mailing list seems less useful. We already have
  kde-devel for other generic kde stuff.
 
 kde-core-devel main purpose may had been discuss kdelibs changes, but it has
 trascended that purspose a while ago.

I agree with Albert.

k-c-d is the list to for things that happen in development, like kde-review 
requests, inter-module coordination, etc.
It is more like a kde-community-technical list.

kde-devel is more a list for question regarding developing with the KDE 
platform.
If there is really a need to fold one list with kde-frameworks its this one.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.