Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/ --- (Updated Aug. 21, 2014, 5:10 a.m.) Status -- This change has been marked as submitted. Review request for KDE Runtime, Aaron J. Seigo, Ian Monroe, and Lamarque Souza. Bugs: 306279 and 325028 http://bugs.kde.org/show_bug.cgi?id=306279 http://bugs.kde.org/show_bug.cgi?id=325028 Repository: kde-runtime Description --- When installing a new .comic provider from GHNS, it doesn't appear in the installed list on the comic widget. This fixes it. Diffs - plasma/tools/plasmapkg/main.cpp 61492fe Diff: https://git.reviewboard.kde.org/r/117175/diff/ Testing --- Compile, add new comic widget, install new comic providers. Thanks, Andrei Amuraritei
Re: Review Request 119868: KConfig add DirectoryType support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 20, 2014, 10:34 p.m.) Review request for KDE Frameworks, kdelibs and Frank Reininghaus. Repository: kconfig Description --- Add a hasDirectoryType method to KDesktopFile. This is required for review request [119869](https://git.reviewboard.kde.org/r/119869/) Diffs - src/core/kdesktopfile.h 2190051 src/core/kdesktopfile.cpp 6278309 Diff: https://git.reviewboard.kde.org/r/119868/diff/ Testing --- Thanks, Maarten De Meyer
Re: Review Request 119869: KIO: Correctly handle .directory files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 20, 2014, 10:35 p.m.) Review request for KDE Frameworks, kdelibs and Frank Reininghaus. Bugs: 235457 https://bugs.kde.org/show_bug.cgi?id=235457 Repository: kio Description --- My attempt at fixing [bug 235457](https://bugs.kde.org/show_bug.cgi?id=235457) We give .directory the default Type 'Directory' and a way for KDesktopFileActions to handle .directory files. To do that we trick KRun in opening the file as plain text. hasDirectoryType is a new method in KConfig. see: [119868](https://git.reviewboard.kde.org/r/119868/) Anything I should look out for when commiting this to KConfig and KIO? Diffs - src/widgets/kdesktopfileactions.cpp 9486015 src/widgets/kpropertiesdialog.cpp 346cbe8 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarten De Meyer
Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration
> On août 20, 2014, 10:15 après-midi, Albert Astals Cid wrote: > > Why is this per repo? This should be in a place all repos get the nice > > stuff without having to do work. > > > > A static Makefile and a configure.sh seem like very bad ideas to me. Why do > > you need those over cmake? > Why is this per repo? Because i didn't know how to implement it in another way. Another idea is to implement it as a plugin in the krazy framework, so you can run it over any KDE repo without having them to implement it in their code. > Why do you need those over cmake? For new developers, it avoids them to learn some CMake specific variables like CMAKE_INSTALL_PREFIX and CMAKE_CXX_COMPILER. And for developers in general, it allows them to configure the project really quickly. It's like a very little abstraction to the CMake interface. - Mathieu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119875/#review64948 --- On août 20, 2014, 10:11 après-midi, Mathieu Tarral wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119875/ > --- > > (Updated août 20, 2014, 10:11 après-midi) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > --- > > This patch add the support of the Clang Static Analyzer > (http://clang-analyzer.llvm.org/) implemented using a CMake target. > For each project in the main tree, it creates a > _static_analysis target which sets the c++-analyzer compiler > and then call scan-build. (see the cmake module for details) > > As I couldn't find how to change the compiler for a specific target in CMake, > I had to create another a CMake sub-build tree > named static_analysis_named in the main CMake build tree, and then > reconfigure the project by forcing > the C++ compiler to c++-analyzer. > > Also I added a configure.sh script that allow to set the build options very > easily, using dialog. > So, new developers can change the compiler or set the install prefix without > having to know > the specific CMake variables. > > And finally i added a root Makefile, so you don't have to stay in the build > directory to > compile your targets. > > > Diffs > - > > CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 > Makefile PRE-CREATION > cmake/modules/clang_static_analysis.cmake PRE-CREATION > configure.sh PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119875/diff/ > > > Testing > --- > > For configure.sh : > ./configure.sh > ./configure.sh -c > ./configure.sh -b > ./configuer.sh -p > > for clang static analyzer > ./configure.sh > make dolphin_static_analysis > > > Thanks, > > Mathieu Tarral > >
Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119875/#review64948 --- Why is this per repo? This should be in a place all repos get the nice stuff without having to do work. A static Makefile and a configure.sh seem like very bad ideas to me. Why do you need those over cmake? - Albert Astals Cid On ago. 20, 2014, 10:11 p.m., Mathieu Tarral wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119875/ > --- > > (Updated ago. 20, 2014, 10:11 p.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > --- > > This patch add the support of the Clang Static Analyzer > (http://clang-analyzer.llvm.org/) implemented using a CMake target. > For each project in the main tree, it creates a > _static_analysis target which sets the c++-analyzer compiler > and then call scan-build. (see the cmake module for details) > > As I couldn't find how to change the compiler for a specific target in CMake, > I had to create another a CMake sub-build tree > named static_analysis_named in the main CMake build tree, and then > reconfigure the project by forcing > the C++ compiler to c++-analyzer. > > Also I added a configure.sh script that allow to set the build options very > easily, using dialog. > So, new developers can change the compiler or set the install prefix without > having to know > the specific CMake variables. > > And finally i added a root Makefile, so you don't have to stay in the build > directory to > compile your targets. > > > Diffs > - > > CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 > Makefile PRE-CREATION > cmake/modules/clang_static_analysis.cmake PRE-CREATION > configure.sh PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119875/diff/ > > > Testing > --- > > For configure.sh : > ./configure.sh > ./configure.sh -c > ./configure.sh -b > ./configuer.sh -p > > for clang static analyzer > ./configure.sh > make dolphin_static_analysis > > > Thanks, > > Mathieu Tarral > >
Review Request 119875: add support for Clang Static Analyzer and improve build configuration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119875/ --- Review request for KDE Base Apps. Repository: kde-baseapps Description --- This patch add the support of the Clang Static Analyzer (http://clang-analyzer.llvm.org/) implemented using a CMake target. For each project in the main tree, it creates a _static_analysis target which sets the c++-analyzer compiler and then call scan-build. (see the cmake module for details) As I couldn't find how to change the compiler for a specific target in CMake, I had to create another a CMake sub-build tree named static_analysis_named in the main CMake build tree, and then reconfigure the project by forcing the C++ compiler to c++-analyzer. Also I added a configure.sh script that allow to set the build options very easily, using dialog. So, new developers can change the compiler or set the install prefix without having to know the specific CMake variables. And finally i added a root Makefile, so you don't have to stay in the build directory to compile your targets. Diffs - CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 Makefile PRE-CREATION cmake/modules/clang_static_analysis.cmake PRE-CREATION configure.sh PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119875/diff/ Testing --- For configure.sh : ./configure.sh ./configure.sh -c ./configure.sh -b ./configuer.sh -p for clang static analyzer ./configure.sh make dolphin_static_analysis Thanks, Mathieu Tarral
Re: Review Request 119678: add a target named _doc for each project in the tree, to generate developer documention
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119678/#review64944 --- We have a standalone program in kde-dev-scripts called kdedoxygen.sh that might accomplish the same thing. We also have kdedoxyman.sh (for man pages) and kdedoxyqt.sh (for Qt assistant files) might be worth a look. - Allen Winter On Aug. 9, 2014, 12:43 a.m., Mathieu Tarral wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119678/ > --- > > (Updated Aug. 9, 2014, 12:43 a.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > --- > > add a target named _doc for each project in the tree, to generate > developer documention by extracting code structure, and creating useful call > graphs. It's very useful to new contributors, so they can find their way into > the source tree by exploring files and structures into their favorite browser. > > > Diffs > - > > CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 > cmake/in/Doxyfile.in.cmake PRE-CREATION > cmake/modules/doxygen.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119678/diff/ > > > Testing > --- > > mkdir _build > cd _build > cmake .. -DCMAKE_INSTALL_PREFIX=../_install > make dolphin_doc > make kdialog_doc > etc ... > > > Thanks, > > Mathieu Tarral > >
Re: Review Request 119678: add a target named _doc for each project in the tree, to generate developer documention
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119678/#review64940 --- Thanks for working on this! I agree that the generated documentation can be useful (even though some of the generated HTML pages are quite overwhelming). I'm not extremely familiar with Doxygen, but since this might be interesting also for other projects/repositories, I'm wondering if there is a way to achieve that without adding a huge new file to every single repository? - Frank Reininghaus On Aug. 9, 2014, 12:43 a.m., Mathieu Tarral wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119678/ > --- > > (Updated Aug. 9, 2014, 12:43 a.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > --- > > add a target named _doc for each project in the tree, to generate > developer documention by extracting code structure, and creating useful call > graphs. It's very useful to new contributors, so they can find their way into > the source tree by exploring files and structures into their favorite browser. > > > Diffs > - > > CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 > cmake/in/Doxyfile.in.cmake PRE-CREATION > cmake/modules/doxygen.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119678/diff/ > > > Testing > --- > > mkdir _build > cd _build > cmake .. -DCMAKE_INSTALL_PREFIX=../_install > make dolphin_doc > make kdialog_doc > etc ... > > > Thanks, > > Mathieu Tarral > >
Re: Review Request 119678: add a target named _doc for each project in the tree, to generate developer documention
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119678/#review64934 --- ping - Mathieu Tarral On août 9, 2014, 12:43 matin, Mathieu Tarral wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119678/ > --- > > (Updated août 9, 2014, 12:43 matin) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > --- > > add a target named _doc for each project in the tree, to generate > developer documention by extracting code structure, and creating useful call > graphs. It's very useful to new contributors, so they can find their way into > the source tree by exploring files and structures into their favorite browser. > > > Diffs > - > > CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 > cmake/in/Doxyfile.in.cmake PRE-CREATION > cmake/modules/doxygen.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119678/diff/ > > > Testing > --- > > mkdir _build > cd _build > cmake .. -DCMAKE_INSTALL_PREFIX=../_install > make dolphin_doc > make kdialog_doc > etc ... > > > Thanks, > > Mathieu Tarral > >
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated Aug. 20, 2014, 7:13 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison
