Re: Review Request 120064: Reset info panel and window caption when an archive fails to open
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120064/ --- (Updated Sept. 5, 2014, 11:29 a.m.) Review request for KDE Base Apps and Raphael Kubo da Costa. Bugs: 245705 http://bugs.kde.org/show_bug.cgi?id=245705 Repository: ark Description --- When opening an archive that for whatever reason fails to load (because it's corrupt, or an invalid format) the archive appears to be open when it is not in fact open. This patch fixes that by resetting the open archive, info panel name and window caption. Diffs - part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb Diff: https://git.reviewboard.kde.org/r/120064/diff/ Testing --- I have tried opening both archives that fail to load and ones that work. Thanks, Mathias Tillman
Re: About X11's WM_HINTS.UrgencyHint and KF5's NET::DemandsAttention
On Wednesday 03 September 2014 14:36:48 Paulo Lieuthier wrote: Hello everyone, I'm a LXQt contributor and I've been working on getting it rid of Xlib calls by using KF5's WindowSystem. It looks nice so far. The problem I'm having now is that I can't get the taskbar to indicate a window needs attention by using the KWindowInfo class. This is how it worked before: XWMHints *hints = XGetWMHints(QX11Info::display(), window); ... bool urgencyHint = hints-flags UrgencyHint; ... And that's how I've been trying: KWindowInfo info(window, NET::WMState | NET::XAWMState); bool urgencyHint = info.hasState(NET::DemandsAttention); Isn't NET::DemandsAttention supposed to be equal to WM_HINTS.UrgencyHint? What am I missing? no, it's the netwm state for demands attention, see [1]. I just also looked into KWin code and it doesn't use KWindowInfo or the underlying NET classes for reading the urgency hint. Cheers Martin [1] http://standards.freedesktop.org/wm-spec/wm-spec-1.4.html#idm139915842396784 signature.asc Description: This is a digitally signed message part.
Re: Review Request 119594: fix FileDialog size restorage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Sept. 5, 2014, 7:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek. Repository: frameworkintegration Description --- - saving in the deconstrutor is insufficient, the dialog might survive the runtime - needs to be saved when the dialog is finished or just closed (the closeEvent is not invoked if at least a sync dialog is finished) - ensure a windowHandle and then restore the window size before calling ::exec() - workaround an apparent QWidget QPA bug where even for a created platform window the QWindow geometry is not applied on the QWidget Diffs - src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 Diff: https://git.reviewboard.kde.org/r/119594/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking
