Changing the licence of parley's editor model classes from GPL to LGPL

[Rahul Chowdhury]

Hi,

I, and Inge Wallin ( CC'ed in this email ),
have been working on a project on moving
the editor of parley into libkeduvocdocument.
For that we have moved the model classes of
parley's editor into keduvoc, and used them in
the entire codebase of parley instead of the
old model classes.

But on doing so we have encountered a problem.
The old model classes of parley are GPL'ed ,
but the rest of the keduvoc classes are LGPL.
I think it would be better if the rest of the model classes
are also changed accordingly.
We would like to hear your suggestions on the same.

The branches of libkeduvocdocument and parley
where the task is implemented has been put up
on reviewboard, please find the links to them below
if you want to take a look :-
[1] https://git.reviewboard.kde.org/r/122877/
[2] https://git.reviewboard.kde.org/r/122878/

I have tried to get a list of all the people who
have worked on the old model classes,
and here is what I have come up with-

  * Frederik Gladhorn
  * Amarvir Singh
  * Avgoustinos Kadis* Javier Goday* Daniel Laidig
  * Andreas Xavier
  * David Capel
  * Christian Muschick
  * Albert Astals Cid


Thanks and Regards,

Rahul Chowdhury
( rahulch in IRC )

Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---

Review request for kdelibs.


Repository: sonnet


Description
---

Not on all systems myspell dictionaries are located in 
/usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. 
For instance, on Gentoo it is /usr/share/myspell/. So let the user define this 
path.


Diffs
-

  src/plugins/hunspell/CMakeLists.txt 098fb49 
  src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
  src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
  src/plugins/hunspell/hunspelldict.cpp 621113d 

Diff: https://git.reviewboard.kde.org/r/122987/diff/


Testing
---

hunspell plugin began to work on Gentoo


Thanks,

Eugene Shalygin

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77617
---



src/plugins/hunspell/CMakeLists.txt


you add a "/" at the end and in source code you use 
"MYSPELL_DICTS_PATH"/%1.dic" => it will create /usr/...//%1.dic

=> you need to remove a "/" somewhere.


- Laurent Montel


On mars 17, 2015, 11:16 matin, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated mars 17, 2015, 11:16 matin)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---

(Updated Березень 17, 2015, 1:22 після полудня)


Review request for kdelibs.


Changes
---

remove '/' from the default MYSPELL_DICTS_PATH


Repository: sonnet


Description
---

Not on all systems myspell dictionaries are located in 
/usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. 
For instance, on Gentoo it is /usr/share/myspell/. So let the user define this 
path.


Diffs (updated)
-

  src/plugins/hunspell/CMakeLists.txt 098fb49 
  src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
  src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
  src/plugins/hunspell/hunspelldict.cpp 621113d 

Diff: https://git.reviewboard.kde.org/r/122987/diff/


Testing
---

hunspell plugin began to work on Gentoo


Thanks,

Eugene Shalygin

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77619
---



src/plugins/hunspell/hunspellclient.cpp


#include "hunspell-plugin-conf.h"

and in all module we use config-*.h.cmake

=> better to rename it config-hunspellplugin.h.cmake



src/plugins/hunspell/hunspelldict.cpp


you can change this qDebug too :)
qDebug()<<" m_speller : "< 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated mars 17, 2015, 12:22 après-midi)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77622
---


(not entitled to give a ship it, but) have you checked if this is still 
relevant for the Sonnet framework?

- Luigi Toscano


On March 17, 2015, 1:22 p.m., Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated March 17, 2015, 1:22 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Luigi Toscano]

> On March 17, 2015, 1:41 p.m., Luigi Toscano wrote:
> > (not entitled to give a ship it, but) have you checked if this is still 
> > relevant for the Sonnet framework?

Ups, this review is for sonnet; I was confused by the group (please use 
kdeframeworks instead of kdelibs for Frameworks-related reviews)


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77622
---


On March 17, 2015, 1:22 p.m., Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated March 17, 2015, 1:22 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---

(Updated Березень 17, 2015, 1:50 після полудня)


Review request for KDE Frameworks and kdelibs.


Repository: sonnet


Description
---

Not on all systems myspell dictionaries are located in 
/usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. 
For instance, on Gentoo it is /usr/share/myspell/. So let the user define this 
path.


Diffs
-

  src/plugins/hunspell/CMakeLists.txt 098fb49 
  src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
  src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
  src/plugins/hunspell/hunspelldict.cpp 621113d 

Diff: https://git.reviewboard.kde.org/r/122987/diff/


Testing
---

hunspell plugin began to work on Gentoo


Thanks,

Eugene Shalygin

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---

(Updated Березень 17, 2015, 2:05 після полудня)


Review request for KDE Frameworks and kdelibs.


Changes
---

Implement requested changes


Repository: sonnet


Description
---

Not on all systems myspell dictionaries are located in 
/usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. 
For instance, on Gentoo it is /usr/share/myspell/. So let the user define this 
path.


Diffs (updated)
-

  src/plugins/hunspell/CMakeLists.txt 098fb49 
  src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
  src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
  src/plugins/hunspell/hunspelldict.cpp 621113d 

Diff: https://git.reviewboard.kde.org/r/122987/diff/


Testing
---

hunspell plugin began to work on Gentoo


Thanks,

Eugene Shalygin

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

> On Березень 17, 2015, 1:41 після полудня, Luigi Toscano wrote:
> > (not entitled to give a ship it, but) have you checked if this is still 
> > relevant for the Sonnet framework?
> 
> Luigi Toscano wrote:
> Ups, this review is for sonnet; I was confused by the group (please use 
> kdeframeworks instead of kdelibs for Frameworks-related reviews)

Oh, the name for the group is kdeframeworks! Thank you! I was not abl to find 
it.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77622
---


On Березень 17, 2015, 2:05 після полудня, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated Березень 17, 2015, 2:05 після полудня)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77630
---



src/plugins/hunspell/hunspellclient.cpp


#include "..."
we use local file.


- Laurent Montel


On mars 17, 2015, 1:05 après-midi, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated mars 17, 2015, 1:05 après-midi)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77631
---


I am not maintainer of this module but I can put a "+1"

- Laurent Montel


On mars 17, 2015, 1:05 après-midi, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated mars 17, 2015, 1:05 après-midi)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---

(Updated Березень 17, 2015, 2:09 після полудня)


Review request for KDE Frameworks and kdelibs.


Repository: sonnet


Description
---

Not on all systems myspell dictionaries are located in 
/usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. 
For instance, on Gentoo it is /usr/share/myspell/. So let the user define this 
path.


Diffs (updated)
-

  src/plugins/hunspell/CMakeLists.txt 098fb49 
  src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
  src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
  src/plugins/hunspell/hunspelldict.cpp 621113d 

Diff: https://git.reviewboard.kde.org/r/122987/diff/


Testing
---

hunspell plugin began to work on Gentoo


Thanks,

Eugene Shalygin

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77636
---


Ok for me.
Just wait that maintainer gives you a "Ship it"

- Laurent Montel


On mars 17, 2015, 1:09 après-midi, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated mars 17, 2015, 1:09 après-midi)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

[David Faure]

> On March 17, 2015, 4:38 p.m., David Faure wrote:
> > Ship It!

Yes, both in kdelibs 4 and in the kio framework.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
---


On March 17, 2015, 4:17 p.m., Stefan Brüns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122652/
> ---
> 
> (Updated March 17, 2015, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 339193
> http://bugs.kde.org/show_bug.cgi?id=339193
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem
> uses the special value KFileItem::Unknown == (mode_t) -1.
> 
> CCBUG: 339193
> 
> 
> Diffs
> -
> 
>   kio/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f 
> 
> Diff: https://git.reviewboard.kde.org/r/122652/diff/
> 
> 
> Testing
> ---
> 
> dolphin remote:
> -> no lock icon on smb:, mtp:, ... links
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
---

Ship it!


Ship It!

- David Faure


On March 17, 2015, 4:17 p.m., Stefan Brüns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122652/
> ---
> 
> (Updated March 17, 2015, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 339193
> http://bugs.kde.org/show_bug.cgi?id=339193
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem
> uses the special value KFileItem::Unknown == (mode_t) -1.
> 
> CCBUG: 339193
> 
> 
> Diffs
> -
> 
>   kio/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f 
> 
> Diff: https://git.reviewboard.kde.org/r/122652/diff/
> 
> 
> Testing
> ---
> 
> dolphin remote:
> -> no lock icon on smb:, mtp:, ... links
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
---



src/plugins/hunspell/CMakeLists.txt


So you change an hardcoded path by a user chosen hardcoded one ?

looking at the hunspell -D output, it looks like hunspell looks in more 
than one directory.

hunspell -D

[cut]

AVAILABLE DICTIONARIES (path is not mandatory for -d option):
/usr/share/hunspell/fr_FR
/usr/share/hunspell/fr
/usr/share/hunspell/en_US
/usr/share/myspell/fr_FR
/usr/share/myspell/hyph_en_US
/usr/share/myspell/hyph_fr
/usr/share/myspell/fr
/usr/share/myspell/hyph_fr_FR
/usr/share/myspell/en_US
LOADED DICTIONARY:
/usr/share/hunspell/fr_FR.aff
/usr/share/hunspell/fr_FR.dic



src/plugins/hunspell/CMakeLists.txt


endif()


- Christophe Giboudeaux


On March 17, 2015, 1:09 p.m., Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated March 17, 2015, 1:09 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote:
> > src/plugins/hunspell/CMakeLists.txt, line 7
> > 
> >
> > So you change an hardcoded path by a user chosen hardcoded one ?
> > 
> > looking at the hunspell -D output, it looks like hunspell looks in more 
> > than one directory.
> > 
> > hunspell -D
> > 
> > [cut]
> > 
> > AVAILABLE DICTIONARIES (path is not mandatory for -d option):
> > /usr/share/hunspell/fr_FR
> > /usr/share/hunspell/fr
> > /usr/share/hunspell/en_US
> > /usr/share/myspell/fr_FR
> > /usr/share/myspell/hyph_en_US
> > /usr/share/myspell/hyph_fr
> > /usr/share/myspell/fr
> > /usr/share/myspell/hyph_fr_FR
> > /usr/share/myspell/en_US
> > LOADED DICTIONARY:
> > /usr/share/hunspell/fr_FR.aff
> > /usr/share/hunspell/fr_FR.dic

On my system all dictionary files outside of /usr/share/hunspell/ are symlinks 
to files in this directory. Do you think it would be better to use (existent?) 
directories from 'SEARCH PATH:' section of hunspell -D output?


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
---


On Березень 17, 2015, 2:09 після полудня, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated Березень 17, 2015, 2:09 після полудня)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

[Rolf Eike Beer]

> On März 17, 2015, 1:07 nachm., Laurent Montel wrote:
> > src/plugins/hunspell/hunspellclient.cpp, line 27
> > 
> >
> > #include "..."
> > we use local file.

No, the file is in an include path, not in the same directory as the source 
file (binary vs. source dir).


- Rolf Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77630
---


On März 17, 2015, 1:09 nachm., Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> ---
> 
> (Updated März 17, 2015, 1:09 nachm.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Not on all systems myspell dictionaries are located in 
> /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin 
> sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user 
> define this path.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> ---
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>