Re: Review Request 123417: Prevent plasmashell from crashing on wayland

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/#review79171
---


Please use the kdeframeworks group, kdelibs is 4.x

- Kai Uwe Broulik


On April 18, 2015, 4:29 nachm., Nerdopolis Turfwalker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123417/
> ---
> 
> (Updated April 18, 2015, 4:29 nachm.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> kidletime makes an unchecked X call, which is used by plasmashell.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 5335bd5db171721635517a82829f54cd1b3f6326 
>   src/config-kidletime.h.cmake d3f0cfd78833d2b3acf90d0a068905676ceba586 
>   src/kidletime.cpp f38ae467d78d899b70b602a932482a39402793fb 
> 
> Diff: https://git.reviewboard.kde.org/r/123417/diff/
> 
> 
> Testing
> ---
> 
> Ran plasmashell with QT_QPA_PLATFORM=wayland, and got no more crashes
> 
> 
> Thanks,
> 
> Nerdopolis Turfwalker
> 
>

Review Request 123417: Prevent plasmashell from crashing on wayland

[Nerdopolis Turfwalker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/
---

Review request for kdelibs.


Repository: kidletime


Description
---

kidletime makes an unchecked X call, which is used by plasmashell.


Diffs
-

  CMakeLists.txt 5335bd5db171721635517a82829f54cd1b3f6326 
  src/config-kidletime.h.cmake d3f0cfd78833d2b3acf90d0a068905676ceba586 
  src/kidletime.cpp f38ae467d78d899b70b602a932482a39402793fb 

Diff: https://git.reviewboard.kde.org/r/123417/diff/


Testing
---

Ran plasmashell with QT_QPA_PLATFORM=wayland, and got no more crashes


Thanks,

Nerdopolis Turfwalker

Re: KF5-QT5 branchgroup - jobs that need developeer attention

[Scarlett Clark]

On Friday, April 17, 2015 12:47:05 AM Gregor Mi wrote:
> >> skanlite - all - wants a framework KF5Sane (does this exist?)
> >
> > 
> >  
> > 
> >
> > Gregor Mi ported both libksane and Skanlite to KF5 last year. They are
> > both in the frameworks branch. libksane is not yet a framework, but I
> > think he prepared libksane for it.>
> > 
> >  
> > 
> >
> > For me Skanlite compiles fine with kdesrc-build...
> 
> As I tried a few weeks ago, it compiled for me, too. Did not do a recent
> build though.
> > 
> >  
> > 
> >
> > I have plans to split libksane into a non-gui and a gui library and it
> > could be good to wait a bit with trying to get it into frameworks for BIC
> > reasons.
> >
> > 
> >  
> > 
> >
> > That said I think it would be nice to have a KF5 based release of both
> > libksane and skanlite ASAP.

skanlite is fine as far as developers go. There is a missing dep on Marko's 
OSX builder, as soon as he resolves that, the red should turn green.
Thanks !
Scarlett


signature.asc
Description: This is a digitally signed message part.

Re: KF5-QT5 branchgroup - jobs that need developeer attention

[Gregor Mi]

>> skanlite - all - wants a framework KF5Sane (does this exist?)
> 
>  
> 
> Gregor Mi ported both libksane and Skanlite to KF5 last year. They are both 
> in the
> frameworks branch. libksane is not yet a framework, but I think he prepared 
> libksane for it.
> 
>  
> 
> For me Skanlite compiles fine with kdesrc-build...

As I tried a few weeks ago, it compiled for me, too. Did not do a recent build 
though.

> 
>  
> 
> I have plans to split libksane into a non-gui and a gui library and it could 
> be good to
> wait a bit with trying to get it into frameworks for BIC reasons.
> 
>  
> 
> That said I think it would be nice to have a KF5 based release of both 
> libksane and
> skanlite ASAP.

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

[David Faure]

> On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
> > lib/konq/src/konq_historyentry.h, line 57
> > 
> >
> > const ref, no?
> 
> Andrius da Costa Ribas wrote:
> before I try to fix the pending issues: what are we going to decide?
> 
> - Should we create KDE_DUMMY_QHASH_FUNCTION macro again? (which header)
> - Should it apply to MSVC-only or should it be ifdef-free?

Clearly this is not KDE specific. Any QList requires this on MSVC, 
right? Then I would strongly suggest a solution within Qt itself, *if* a 
central solution such as a macro is indeed needed. But thinking about it, a 
one-line dummy impl that returns 0 doesn't really seem worth a macro to me.
I.e. why not do like qitemselectionmodel.h does, everywhere where this is 
needed?

But I am still surprised that Qt only needs this in qitemselectionmodel.h
Take this for instance:
src/corelib/io/qstorageinfo.h:static QList 
mountedVolumes();
Why doesn't this require a qHash(QStorageInfo)?
If I explicitly call toSet() on such a list, I do get a compile error (on 
Linux) due to the missing qHash implementation. 
http://www.davidfaure.fr/2015/storageview.diff
So MSVC doesn't *always* instanciate the toSet() method, but only in some cases?
Or are we looking at an old MSVC issue which doesn't exist anymore with more 
recent MSVC versions? i.e. did you try removing this block (in 
konq_historyentry.h) altogether to check it's still needed?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121080/
> ---
> 
> (Updated Nov. 8, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
> not available. Implement it instead.
> 
> 
> Diffs
> -
> 
>   lib/konq/src/konq_historyentry.h de34d6b 
> 
> Diff: https://git.reviewboard.kde.org/r/121080/diff/
> 
> 
> Testing
> ---
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
> sending to review today). Kdebase-apps is still not very functional, though 
> (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>