Re: Plasma Applet for Audio Volume for kdereview
Am Dienstag, 18. August 2015, 10:05:30 schrieb Mark Gaiser: > On Mon, Aug 17, 2015 at 3:10 PM, Sebastian Kügler wrote: > > I think we should be peachy now. Can plasma-pa be moved from kdereview to > > kde/workspace? > > Just my opinion as a plasma 5 user. > Yes, please! Kmix was great under KDE 4.xx, not so much under 5.xx. This > "feels" much better and cleaner to me (from limited testing). Two things I noticed: * The first channel from my soundcard is the HDMI-Output which I don't use. But I have not found any way to tell the applet to use the second channel as master. So the applets icon just shows 100% volume all the time while the interessting value is only visible after clicking it. * Global shortcuts for volume keys are assigned to kmix and I have not found an entry for the Audio Volume applet. So volume keys are not working for me when kmix is not running.
Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdelibs Description --- The recent removal of the code block from FindKDE4Internal.cmake starting with the `cmake_minimum_required` statement breaks configuring on OS X: ``` -- The C compiler identification is AppleClang 6.0.0.657 -- The CXX compiler identification is AppleClang 6.0.0.657 -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for Q_WS_X11 -- Looking for Q_WS_X11 - not found -- Looking for Q_WS_WIN -- Looking for Q_WS_WIN - not found -- Looking for Q_WS_QWS -- Looking for Q_WS_QWS - not found -- Looking for Q_WS_MAC -- Looking for Q_WS_MAC - found -- Looking for QT_MAC_USE_COCOA -- Looking for QT_MAC_USE_COCOA - found -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) -- Looking for include file pthread.h -- Looking for include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - found -- Found Threads: TRUE CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 (elseif): given arguments: "VERSION_LESS" "3.1" Unknown arguments specified Call Stack (most recent call first): /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 (_pkgconfig_parse_options) /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 (FIND_PACKAGE) /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 (find_package) /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) CMakeLists.txt:4 (find_package) -- Configuring incomplete, errors occurred! ``` The attached patch is the minimum reintroduction of the removed code that allows the cmake procedure to conclude successfully. CMake experts might be aware of other ways to address this issue more in line with the reason the block was removed. Diffs - cmake/modules/FindKDE4Internal.cmake 7d54b9b Diff: https://git.reviewboard.kde.org/r/124824/diff/ Testing --- On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake 3.0.1 . Thanks, René J.V. Bertin
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84061 --- Ship it! Ship It! - Jeremy Whiting On Aug. 19, 2015, 11:41 a.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124824/ > --- > > (Updated Aug. 19, 2015, 11:41 a.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > --- > > The recent removal of the code block from FindKDE4Internal.cmake starting > with the `cmake_minimum_required` statement breaks configuring on OS X: > > ``` > -- The C compiler identification is AppleClang 6.0.0.657 > -- The CXX compiler identification is AppleClang 6.0.0.657 > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - not found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - found > -- Looking for QT_MAC_USE_COCOA > -- Looking for QT_MAC_USE_COCOA - found > -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) > -- Looking for include file pthread.h > -- Looking for include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - found > -- Found Threads: TRUE > CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 > (elseif): > given arguments: > > "VERSION_LESS" "3.1" > > Unknown arguments specified > Call Stack (most recent call first): > /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 > (_pkgconfig_parse_options) > /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) > /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 > (FIND_PACKAGE) > /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) > /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 > (find_package) > /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) > CMakeLists.txt:4 (find_package) > > > -- Configuring incomplete, errors occurred! > ``` > > The attached patch is the minimum reintroduction of the removed code that > allows the cmake procedure to conclude successfully. > > CMake experts might be aware of other ways to address this issue more in line > with the reason the block was removed. > > > Diffs > - > > cmake/modules/FindKDE4Internal.cmake 7d54b9b > > Diff: https://git.reviewboard.kde.org/r/124824/diff/ > > > Testing > --- > > On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . > > The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake > 3.0.1 . > > > Thanks, > > René J.V. Bertin > >
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84062 --- This patch is not correct. What repo were you trying to build? Add cmake_minimum_required(VERSION 2.8.9) there. - Stephen Kelly On Aug. 19, 2015, 5:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124824/ > --- > > (Updated Aug. 19, 2015, 5:41 p.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > --- > > The recent removal of the code block from FindKDE4Internal.cmake starting > with the `cmake_minimum_required` statement breaks configuring on OS X: > > ``` > -- The C compiler identification is AppleClang 6.0.0.657 > -- The CXX compiler identification is AppleClang 6.0.0.657 > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - not found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - found > -- Looking for QT_MAC_USE_COCOA > -- Looking for QT_MAC_USE_COCOA - found > -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) > -- Looking for include file pthread.h > -- Looking for include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - found > -- Found Threads: TRUE > CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 > (elseif): > given arguments: > > "VERSION_LESS" "3.1" > > Unknown arguments specified > Call Stack (most recent call first): > /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 > (_pkgconfig_parse_options) > /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) > /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 > (FIND_PACKAGE) > /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) > /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 > (find_package) > /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) > CMakeLists.txt:4 (find_package) > > > -- Configuring incomplete, errors occurred! > ``` > > The attached patch is the minimum reintroduction of the removed code that > allows the cmake procedure to conclude successfully. > > CMake experts might be aware of other ways to address this issue more in line > with the reason the block was removed. > > > Diffs > - > > cmake/modules/FindKDE4Internal.cmake 7d54b9b > > Diff: https://git.reviewboard.kde.org/r/124824/diff/ > > > Testing > --- > > On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . > > The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake > 3.0.1 . > > > Thanks, > > René J.V. Bertin > >
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
> On Aug. 19, 2015, 6:03 p.m., Jeremy Whiting wrote: > > Ship It! Don't ship it :). - Stephen --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84061 --- On Aug. 19, 2015, 5:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124824/ > --- > > (Updated Aug. 19, 2015, 5:41 p.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > --- > > The recent removal of the code block from FindKDE4Internal.cmake starting > with the `cmake_minimum_required` statement breaks configuring on OS X: > > ``` > -- The C compiler identification is AppleClang 6.0.0.657 > -- The CXX compiler identification is AppleClang 6.0.0.657 > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - not found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - found > -- Looking for QT_MAC_USE_COCOA > -- Looking for QT_MAC_USE_COCOA - found > -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) > -- Looking for include file pthread.h > -- Looking for include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - found > -- Found Threads: TRUE > CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 > (elseif): > given arguments: > > "VERSION_LESS" "3.1" > > Unknown arguments specified > Call Stack (most recent call first): > /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 > (_pkgconfig_parse_options) > /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) > /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 > (FIND_PACKAGE) > /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) > /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 > (find_package) > /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) > CMakeLists.txt:4 (find_package) > > > -- Configuring incomplete, errors occurred! > ``` > > The attached patch is the minimum reintroduction of the removed code that > allows the cmake procedure to conclude successfully. > > CMake experts might be aware of other ways to address this issue more in line > with the reason the block was removed. > > > Diffs > - > > cmake/modules/FindKDE4Internal.cmake 7d54b9b > > Diff: https://git.reviewboard.kde.org/r/124824/diff/ > > > Testing > --- > > On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . > > The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake > 3.0.1 . > > > Thanks, > > René J.V. Bertin > >
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84069 --- I stumbled upon the same, it's actually a bug in cmake fixed by this commit: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961976060d872faffb - Heiko Becker On Aug. 19, 2015, 5:41 nachm., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124824/ > --- > > (Updated Aug. 19, 2015, 5:41 nachm.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > --- > > The recent removal of the code block from FindKDE4Internal.cmake starting > with the `cmake_minimum_required` statement breaks configuring on OS X: > > ``` > -- The C compiler identification is AppleClang 6.0.0.657 > -- The CXX compiler identification is AppleClang 6.0.0.657 > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - not found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - found > -- Looking for QT_MAC_USE_COCOA > -- Looking for QT_MAC_USE_COCOA - found > -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) > -- Looking for include file pthread.h > -- Looking for include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - found > -- Found Threads: TRUE > CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 > (elseif): > given arguments: > > "VERSION_LESS" "3.1" > > Unknown arguments specified > Call Stack (most recent call first): > /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 > (_pkgconfig_parse_options) > /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) > /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 > (FIND_PACKAGE) > /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) > /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 > (find_package) > /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) > CMakeLists.txt:4 (find_package) > > > -- Configuring incomplete, errors occurred! > ``` > > The attached patch is the minimum reintroduction of the removed code that > allows the cmake procedure to conclude successfully. > > CMake experts might be aware of other ways to address this issue more in line > with the reason the block was removed. > > > Diffs > - > > cmake/modules/FindKDE4Internal.cmake 7d54b9b > > Diff: https://git.reviewboard.kde.org/r/124824/diff/ > > > Testing > --- > > On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . > > The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake > 3.0.1 . > > > Thanks, > > René J.V. Bertin > >
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
Am Mittwoch, 19. August 2015, 21:14:38 schrieb Heiko Becker: > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961 > 976060d872faffb But the short fix for this is indeed to put cmake_minimum_required() into your project. But not into a project you include, but into the main project you are trying to build. Greetings, Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
> On Aug. 19, 2015, 11:14 p.m., Heiko Becker wrote: > > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > > > > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961976060d872faffb Well, IMVHO it's fine to impose upgrading to the latest cmake and/or adding the `cmake_minimum_required` statement in each and every dependency's toplevel CMake file, but not for the legacy KDE/4.14 branch (esp. not the latter option)... - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84069 --- On Aug. 19, 2015, 7:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124824/ > --- > > (Updated Aug. 19, 2015, 7:41 p.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > --- > > The recent removal of the code block from FindKDE4Internal.cmake starting > with the `cmake_minimum_required` statement breaks configuring on OS X: > > ``` > -- The C compiler identification is AppleClang 6.0.0.657 > -- The CXX compiler identification is AppleClang 6.0.0.657 > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - not found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - found > -- Looking for QT_MAC_USE_COCOA > -- Looking for QT_MAC_USE_COCOA - found > -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) > -- Looking for include file pthread.h > -- Looking for include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - found > -- Found Threads: TRUE > CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 > (elseif): > given arguments: > > "VERSION_LESS" "3.1" > > Unknown arguments specified > Call Stack (most recent call first): > /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 > (_pkgconfig_parse_options) > /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) > /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 > (FIND_PACKAGE) > /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) > /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 > (find_package) > /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) > CMakeLists.txt:4 (find_package) > > > -- Configuring incomplete, errors occurred! > ``` > > The attached patch is the minimum reintroduction of the removed code that > allows the cmake procedure to conclude successfully. > > CMake experts might be aware of other ways to address this issue more in line > with the reason the block was removed. > > > Diffs > - > > cmake/modules/FindKDE4Internal.cmake 7d54b9b > > Diff: https://git.reviewboard.kde.org/r/124824/diff/ > > > Testing > --- > > On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . > > The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake > 3.0.1 . > > > Thanks, > > René J.V. Bertin > >
Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement
> On Aug. 19, 2015, 11:14 p.m., Heiko Becker wrote: > > I stumbled upon the same, it's actually a bug in cmake fixed by this commit: > > > > > > http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961976060d872faffb > > René J.V. Bertin wrote: > Well, IMVHO it's fine to impose upgrading to the latest cmake and/or > adding the `cmake_minimum_required` statement in each and every dependency's > toplevel CMake file, but not for the legacy KDE/4.14 branch (esp. not the > latter option)... And to reply to Eike (without subscribing to kde-core-devel): the shortest fix is not touching what always worked. With most project developers now focussing on KF5, changing the toplevel CMake file would fall to users and distro maintainers, who shouldn't have to be bothered by this kind of patching. - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124824/#review84069 --- On Aug. 19, 2015, 7:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124824/ > --- > > (Updated Aug. 19, 2015, 7:41 p.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > --- > > The recent removal of the code block from FindKDE4Internal.cmake starting > with the `cmake_minimum_required` statement breaks configuring on OS X: > > ``` > -- The C compiler identification is AppleClang 6.0.0.657 > -- The CXX compiler identification is AppleClang 6.0.0.657 > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- Check for working C compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- Check for working CXX compiler: > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ > -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- Looking for Q_WS_X11 > -- Looking for Q_WS_X11 - not found > -- Looking for Q_WS_WIN > -- Looking for Q_WS_WIN - not found > -- Looking for Q_WS_QWS > -- Looking for Q_WS_QWS - not found > -- Looking for Q_WS_MAC > -- Looking for Q_WS_MAC - found > -- Looking for QT_MAC_USE_COCOA > -- Looking for QT_MAC_USE_COCOA - found > -- Found Qt-Version 4.8.7 (using /opt/local/libexec/qt4/bin/qmake) > -- Looking for include file pthread.h > -- Looking for include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - found > -- Found Threads: TRUE > CMake Error at /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:112 > (elseif): > given arguments: > > "VERSION_LESS" "3.1" > > Unknown arguments specified > Call Stack (most recent call first): > /opt/local/share/cmake-3.2/Modules/FindPkgConfig.cmake:501 > (_pkgconfig_parse_options) > /opt/local/share/cmake-3.2/Modules/FindOpenSSL.cmake:43 (pkg_check_modules) > /opt/local/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 > (FIND_PACKAGE) > /opt/local/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE) > /opt/local/share/apps/cmake/modules/FindKDE4Internal.cmake:425 > (find_package) > /opt/local/share/cmake-3.2/Modules/FindKDE4.cmake:108 (find_package) > CMakeLists.txt:4 (find_package) > > > -- Configuring incomplete, errors occurred! > ``` > > The attached patch is the minimum reintroduction of the removed code that > allows the cmake procedure to conclude successfully. > > CMake experts might be aware of other ways to address this issue more in line > with the reason the block was removed. > > > Diffs > - > > cmake/modules/FindKDE4Internal.cmake 7d54b9b > > Diff: https://git.reviewboard.kde.org/r/124824/diff/ > > > Testing > --- > > On OS X 10.9.5 with KDELibs 4.14.11 (v4.14.10-20-g150d983) and CMake 3.2.2 . > > The unmodified code from v4.14.10-20-g150d983 is fine on Linux with cmake > 3.0.1 . > > > Thanks, > > René J.V. Bertin > >
