Re: Review Request 125561: Align FindGettext with CMP002 policy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- (Updated Oct. 10, 2015, 1:42 a.m.) Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf. Changes --- Minimal surgery to FindGettext Summary (updated) - Align FindGettext with CMP002 policy Repository: kdelibs Description --- Otherwise some apps fail to build with kdelibs >= 4.14.11: ``` CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET): add_custom_target cannot create target "pofiles" because another target with the same name already exists. The existing target is a custom target created in source directory "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for policy CMP0002 for more details. Call Stack (most recent call first): po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) ``` Diffs (updated) - cmake/modules/FindGettext.cmake 91e88f7 Diff: https://git.reviewboard.kde.org/r/125561/diff/ Testing --- Skanlite now builds. Thanks, Hrvoje Senjan
Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake
> On Oct. 9, 2015, 2:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. > > Jeremy Whiting wrote: > Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see > https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own > translations in the tarball (everything we release from extragear) fails to > build with a newer cmake. With this change in the kdelibs cmake modules it > builds fine by setting a different target for each po folder. > > Albert Astals Cid wrote: > Ok, bad wording, it's probably a bugfix, but doesn't look like a minimal > bugfix, i mean it's rewriting the whole file, is there nothing better than > that we can do? Ah, that I don't know. As I said before, following all this cmake macro stuff is somehow over my head (or I'm not trying hard enough, dunno). Hrvoje, is there a simpler way to do what you're proposing here? - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86580 --- On Oct. 8, 2015, 11:50 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > --- > > (Updated Oct. 8, 2015, 11:50 a.m.) > > > Review request for Build System, kdelibs, Localization and Translation > (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > --- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 > (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > --- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > >
Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake
> On oct. 9, 2015, 8:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. > > Jeremy Whiting wrote: > Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see > https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own > translations in the tarball (everything we release from extragear) fails to > build with a newer cmake. With this change in the kdelibs cmake modules it > builds fine by setting a different target for each po folder. Ok, bad wording, it's probably a bugfix, but doesn't look like a minimal bugfix, i mean it's rewriting the whole file, is there nothing better than that we can do? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86580 --- On oct. 8, 2015, 5:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > --- > > (Updated oct. 8, 2015, 5:50 p.m.) > > > Review request for Build System, kdelibs, Localization and Translation > (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > --- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 > (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > --- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > >
Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake
> On Oct. 9, 2015, 2:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own translations in the tarball (everything we release from extragear) fails to build with a newer cmake. With this change in the kdelibs cmake modules it builds fine by setting a different target for each po folder. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86580 --- On Oct. 8, 2015, 11:50 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > --- > > (Updated Oct. 8, 2015, 11:50 a.m.) > > > Review request for Build System, kdelibs, Localization and Translation > (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > --- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 > (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > --- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > >
Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86580 --- This doesn't look like "a bugfix" to me. - Albert Astals Cid On oct. 8, 2015, 5:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > --- > > (Updated oct. 8, 2015, 5:50 p.m.) > > > Review request for Build System, kdelibs, Localization and Translation > (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > --- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 > (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > --- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > >