Re: Review Request 127138: Konqueror: Fix window title showing as "/" when URL ends with that

[Jonathan Marten]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127138/
---

(Updated Feb. 23, 2016, 11:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps and David Faure.


Changes
---

Submitted with commit f868ba3b34b4f55111c3b6fb1ff0e6bcaa1d2797 by Jonathan 
Marten to branch frameworks.


Repository: kde-baseapps


Description
---

This happens when a local file URL which ends in "/" is navigated to.  For 
example, going to "/home/user" correctly shows "user" as the window title, 
while going to "/home/user/" shows "/" because the fileName() of that URL is 
empty.  This happens in particular when using the "Up" action, as it goes from 
"/home/user/foo" to "/home/user/".

This change ensures that trailing slashes are removed from URLs before using 
fileName() on them.


Diffs
-

  konqueror/src/konqview.cpp 3707c7a 

Diff: https://git.reviewboard.kde.org/r/127138/diff/


Testing
---

Built kde-baseapps with these changes, observed correct display of base name in 
Konqueror window title while navigating.


Thanks,

Jonathan Marten

Re: Review Request 127138: Konqueror: Fix window title showing as "/" when URL ends with that

[Jonathan Marten]

> On Feb. 23, 2016, 7:49 a.m., David Faure wrote:
> > konqueror/src/konqview.cpp, line 692
> > 
> >
> > Your code is correct in that it's equivalent to the old code. However I 
> > wonder if this couldn't be simplified.
> > 
> > If we want to display the filename of this->url(), unless "caption" was 
> > set to something completely different by the part, we could just compare 
> > path() instead of fileName()...
> > 
> > const QUrl captionUrl(QUrl::fromUserInput(caption));
> > if (captionUrl.isValid() && captionUrl.isLocalFile() && 
> > captionUrl.path() == url().path()) {
> > adjustedCaption = 
> > captionUrl.adjusted(QUrl::StripTrailingSlash).fileName();
> > // if empty...
> > }
> > 
> > This looks a bit simpler, I think? If you agree, can you test it, and 
> > push it if it works?

Tested and working, thanks for the suggestion!


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127138/#review92652
---


On Feb. 22, 2016, 3:12 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127138/
> ---
> 
> (Updated Feb. 22, 2016, 3:12 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> This happens when a local file URL which ends in "/" is navigated to.  For 
> example, going to "/home/user" correctly shows "user" as the window title, 
> while going to "/home/user/" shows "/" because the fileName() of that URL is 
> empty.  This happens in particular when using the "Up" action, as it goes 
> from "/home/user/foo" to "/home/user/".
> 
> This change ensures that trailing slashes are removed from URLs before using 
> fileName() on them.
> 
> 
> Diffs
> -
> 
>   konqueror/src/konqview.cpp 3707c7a 
> 
> Diff: https://git.reviewboard.kde.org/r/127138/diff/
> 
> 
> Testing
> ---
> 
> Built kde-baseapps with these changes, observed correct display of base name 
> in Konqueror window title while navigating.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

Spread to more platforms - Randa Meetings 2016 open for registration

[Mario Fux]

Good morning everyone

Please excuse this cross-posting but all the above mailing list fit quite well 
this year's topic of the Randa Meetings:

multi-platform end-user application development. This includes stuff like 
improving KDE Frameworks 5 (KF5) on other platforms like MS Windows, Android 
or Apple’s MacOSX, presenting and discussing how software distribution works 
on other systems than GNU/Linux (Windows installers, app stores and 
application bundles) and learning from the experience projects like Krita, 
digiKam, Rkward, Kdenlive & Co collected. We’d like to bring this information 
to more KDE Applications and work on this during a full week.

So if you're interested and can help please go to:
https://sprints.kde.org/sprint/301
and add yourself.

And spread this information and tell people that could be of great help.

This email though is just an informational email and thus not to start a 
discussion.

Thanks and cu soon
Mario