Re: Reviving KAudioCreator

2017-12-27 Thread Kevin Ottens
Hello,

On Tuesday, 26 December 2017 23:18:00 CET Albert Astals Cid wrote:
> One kind-of-big bug i'd like fixed is that it doesn't realize the encoder
> command line is not there, i was waiting for like 5 minutes wondering why it
> took so much to encode until i realized that i don't actaully have the flac
> command line installed.

Yes, I encountered that one indeed. I'll try to take a look.

Otherwise I ripped and encoded a few CDs successfully over the week-end.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.


Re: Reviving KAudioCreator

2017-12-27 Thread Leslie Zhai
I recommend to use k3b https://github.com/kde/k3b and I am maintaining 
it, please report a bug if failed to rip cd by k3b, thanks!



在 2017年12月22日 19:48, Luigi Toscano 写道:

Luigi Toscano ha scritto:

Kevin Ottens ha scritto:

Hello all,

I happen to be one of those poor souls who still rip CDs from time to time.
I'm using Dolphin for that right now, but I miss the convenience of using
KAudioCreator a while back.

It looks like it's not released at all anymore. After a quick glance at the
repository, it seems to be in a somewhat good shape (at least it builds and
starts, I didn't push further yet).>
Then, I'd like to revive it and have it part of KDE Applications. Anyone with
an objection about that? If none, how do we proceed?

No objections; as pre-review, translations and documentation were already
checked and fixed some time ago.


I see a couple of things which need to be improved a bit so I'll try to work
on those in the meantime.

Adding Leslie in CC (not sure he is subscribed here), as he did the initial
porting.


https://github.com/KDE/kaudiocreator is just able to work.



Uhm, adding the proper address.

Do you want to move it to kdereview now?


--
Regards,
Leslie Zhai - https://reviews.llvm.org/p/xiangzhai/





Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-12-27 Thread Ralf Habacker

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130239/
---

(Updated Dec. 27, 2017, 10:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and Albert Astals Cid.


Changes
---

Submitted with commit 246298e57ed7ff7a3cbabe5fc9f95957cb6dc257 by Ralf Habacker 
to branch KDE/4.14.


Bugs: 384334
http://bugs.kde.org/show_bug.cgi?id=384334


Repository: kdelibs


Description
---

This patch fixes an issue that on the first start of KMyMoney (and on some 
computers on every start for example reported by 
https://forum.kde.org/viewtopic.php?f=69=141673=ba4dcaa26018f16e19d21c58c34ad4e9)
 on running kconf_update the user account control pops up and forces the user 
to allow or deny  this application.

Commit message

   Add Windows manifest to  kconf_update.exe

This explicitly sets the execution level to 'asInvoker', preventing
Windows' UAC heuristics from deciding that because its name mentions
"update", it probably needs to escalate privileges.

FIXED-IN:4.14.36
BUG:384334


Diffs
-

  kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33 


Diff: https://git.reviewboard.kde.org/r/130239/diff/3/


Testing
---

Compiled at 
https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4
 and tested with KMyMoney snapshot for Windows downloadable from 
https://software.opensuse.org/package/mingw32-kmymoney-portable


Thanks,

Ralf Habacker