---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128854/#review103862
---
Migrated to Phabricator: https://phabricator.kde.org/D10297
- Gregor Mi
On Aug. 3, 2017, 1:25 nachm., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128854/
> ---
>
> (Updated Aug. 3, 2017, 1:25 nachm.)
>
>
> Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette,
> Thomas Lübking, and Thomas Pfeiffer.
>
>
> Repository: libksysguard
>
>
> Description
> ---
>
> This adds a new "Tools" button to the ksysguard widget which contains entries
> to related tools:
>
> - Run Command --> starts KRunner to execute a command
> - KSysguard --> starts KSysguard (this is useful because Ctrl+Esc only starts
> the lightweight System Monitor which has less features)
> - Info Center --> starts the Info Center which shows additional system
> information
> - Htop --> starts htop
> - Kill a window (Ctrl+Alt+Esc) --> triggers the KWin kill window function.
> The displayed shortcut is the one set in Global Keyboard Shortcuts.
> Currently, this shortcut is shown in the End Process... button tooltip but
> there it is hard-coded.
>
> This RR replaces this old RR https://git.reviewboard.kde.org/r/122249/
>
>
> Diffs
> -
>
> CMakeLists.txt 84a447990563cf1605c06989b255627e99ef31b3
> processui/CMakeLists.txt 1927839282a6282c824f5bbb5d35ea94075f428e
> processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3
> processui/ksysguardprocesslist.cpp 79e9bb3c4e9d481a03d2e5992ab1c0692a06de28
>
>
> Diff: https://git.reviewboard.kde.org/r/128854/diff/5/
>
>
> Testing
> ---
>
> - test if all tools start correctly
> - check if a changed shortcut for Kill Window is shown in the tools menu (see
> screenshot)
> - check if for example htop is not installed that there is no menu item for it
>
>
> File Attachments
>
>
> screenshot of the new Tools button
>
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
>
>
> Thanks,
>
> Gregor Mi
>
>
