kdesrc-build messes with environment

2019-04-24 Thread Milian Wolff
Hey all,

for some reason, my `kdesrc-build` uses a different environment than my normal 
shells. I have so far not figured out why that is:

$ env | grep "^PATH="
PATH=/home/milian/.bin:/home/milian/projects/compiled/other/bin:/home/
milian/.bin/kf5:/home/milian/projects/compiled/kf5-dbg/bin:/home/milian/
projects/compiled/other/bin:/home/milian/projects/compiled/kf5/bin:/usr/local/
sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/
bin/vendor_perl:/usr/bin/core_perl

$ kdesrc-build --run env | grep "^PATH="
PATH=/bin:/home/milian/.bin:/home/milian/projects/compiled/other/bin:/home/
milian/.bin/kf5:/home/milian/projects/compiled/kf5-dbg/bin:/home/milian/
projects/compiled/other/bin:/home/milian/projects/compiled/kf5/bin:/usr/local/
sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/
bin/vendor_perl:/usr/bin/core_perl

Note how it prepends /bin to PATH, which leads to all kinds of nasty side 
effects for me. I want my PATH to be used as-is, most notably such that some 
of the tools I've built myself get picked up, rather than the versions I have 
available globally in /bin.

Does anyone know where this could come from?

Thanks
-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.


Re: Symmy in kde-review

2019-04-24 Thread Elvis Angelaccio
Hi Adriaan

On 12/04/19 13:12, Adriaan de Groot wrote:
> On Friday, April 12, 2019 10:13:10 AM CEST Jonathan Riddell wrote:
>> On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio  
> wrote:
>>> symmy has been moved to kde-review for the usual review process.
>>>
>>> It's a tiny frontend for the symmetric encryption functionality of GPG. It
>>> doesn't handle signing or public/private keys, as we already have kgpg or
>>> kleopatra for that.
>>>
>>> Symmy can be useful if you have to send some sensitive file to someone, of
>>> if you want to store it on some proprietary cloud service.
> 
> I should have piped up earlier:
> 
> # Compatibility
> 
> I wonder about Messages.sh. It claims to need bash, but I don't actually see 
> any bash-ism in it. $() command substitution is POSIX-compatible.

Fixed, thanks.

> 
> I haven't looked at tooling to produce manpages from docbook, but good on you 
> for including a manpage.
> 
> Compiled without meaningful warnings w/ clang 6 (which is often more picky 
> than gcc).
> 
> # Licensing
> 
> You might want to add SPDX identifiers to files, but that's icing on the 
> cake. 
> Looks like a consistent GPLv2+ codebase, well-documented.
> 
> # Runtime
> 
> Since it's supposed to be a CLI application, you might want to massage the 
> QPA 
> loading a bit, since when I run it (ssh'ed in to my build machine) It does 
> this:

Note that even if it can be used from CLI, it's still a GUI app as it
needs Qt Widgets to show the passphrase dialogs.

> 
> [adridg@beastie ~/src/kde/symmy/build]$ ./src/symmy 
> qt.qpa.xcb: could not connect to display 
> qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though 
> it was found.
> This application failed to start because no Qt platform plugin could be 
> initialized. Reinstalling the application may fix this problem.
> 
> Available platform plugins are: wayland-org.kde.kwin.qpa, bsdfb, minimal, 
> offscreen, vnc, xcb.
> 
> Abort trap (core dumped)
> 
> 
> 
> But overall: well done, welcome to extragear.
> 
> [ade]

Cheers,
Elvis