Re: Ruqola in KDE-review

2019-09-15 Thread laurent Montel
> Can the icons on the top bar have tooltips? I had no idea what would happen
> when pressing the "two people" icon.

Done.




Re: Ruqola in KDE-review

2019-09-15 Thread laurent Montel
Le lundi 16 septembre 2019, 00:14:12 CEST Albert Astals Cid a écrit :
> El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va 
escriure:
> > Hi,
> > I would like to move ruqola to extragear/network.
> > So I asked to sysadmin to move ruqola to kde-review (it was done).
> > 
> > Ben told me that this period will start in 2 weeks.
> > 
> > If you want to review it... :)
> 
> Now onto the using side:
> 
> Starting it for the first time says
> 
> received something unhandled: "{\"server_id\":\"0\"}"
> Connected
> org.kde.ruqola: Unknown service type:  "Accounts_OAuth_Gitlab_identity_path"
> org.kde.rocketchatqtrestapi: Auth settings is empty. It's a bug
> org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
> org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob

Normal it's a bug from yesterday. This one will be fixed today.


> 
> And then the ui says "login failed"
> 
> 
> Connected to what? Is it attempting to login to something even if i have
> never used the app?

Yep on open.rocket.chat server. It's the default server. Perhaps I need to 
disable it.

> Maybe we should not try to do that? it's a bit
> confusing
> 
> Can the icons on the top bar have tooltips? I had no idea what would happen
> when pressing the "two people" icon.

I will add tooltips on theses icons.

> 
> Quite a few of the "default avatars" (i.e. those that don't have their own
> avatar set) look small and wrong if you compare them to what they look on
> the webapp (see your company chat for an example)

Yep known bug. For the moment I don't understand why.

> 
> Configure account is unfinished? https://i.imgur.com/d8wUwNn.png

Yep it's in progress.

> Ah, on the second login looked different and it at least showed my account
> name there on the first line (even though i still was not able to configure
> anything?)
> 
> Searching for "montel" on the webapp on the company server shows me your
> chat (that i don't have open), searching for the same on ruqola doesn't, so
> i don't really have a way to talking to you

Where do you search it ?

> 
> Also some of the fonts look terrible for a chat app, but that may be because
> of Qt Quick itself :/

I know it. For the moment no idea about this bug too

> 
> Compare https://i.imgur.com/d4sKAwn.png (ruqola) with
> https://i.imgur.com/ibZ7Uim.png (kmail)
> 
> Other than that it seems that it is a good start, so i agree it's a good
> idea to make some noise around it and see if we can get some more
> contributors :)
> 
> Cheers,
>   Albert
> 
> > Regards.


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 




Re: Ruqola in KDE-review

2019-09-15 Thread laurent Montel
Le dimanche 15 septembre 2019, 23:54:19 CEST Albert Astals Cid a écrit :
> El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va 
escriure:
> > Hi,
> > I would like to move ruqola to extragear/network.
> > So I asked to sysadmin to move ruqola to kde-review (it was done).
> > 
> > Ben told me that this period will start in 2 weeks.
> > 
> > If you want to review it... :)
> 
> class LIBRUQOLACORE_TESTS_EXPORT Emoji
> has
> Emoji &operator=(const Emoji &other);
> but no
> Emoji(const Emoji &other);
> 
> newer gcc complains about it, also the operator= doesn't copy mCachedHtml is
> that on purpose? If not i'd suggest to simply mark operator= and the copy
> contructor as = default.
> 
> 
> 
> 
> class LIBRUQOLACORE_TESTS_EXPORT User
> also has the same warning, given that the operator= is implemented and not
> the copy constructor. Same suggestion to just use = default on them.
> 
> 
> and a whole lots more of classes seem to have this issue. Can you double
> check them for me?

Fixed thanks


> 
> http://paste.debian.net/1100950/
> 
> Cheers,
>   Albert
> 
> > Regards.


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 




Re: Ruqola in KDE-review

2019-09-15 Thread Albert Astals Cid
El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va 
escriure:
> Hi,
> I would like to move ruqola to extragear/network.
> So I asked to sysadmin to move ruqola to kde-review (it was done).
> 
> Ben told me that this period will start in 2 weeks.
> 
> If you want to review it... :)

Now onto the using side:

Starting it for the first time says

received something unhandled: "{\"server_id\":\"0\"}"
Connected
org.kde.ruqola: Unknown service type:  "Accounts_OAuth_Gitlab_identity_path"
org.kde.rocketchatqtrestapi: Auth settings is empty. It's a bug
org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob

And then the ui says "login failed"


Connected to what? Is it attempting to login to something even if i have never 
used the app? Maybe we should not try to do that? it's a bit confusing

Can the icons on the top bar have tooltips? I had no idea what would happen 
when pressing the "two people" icon.

Quite a few of the "default avatars" (i.e. those that don't have their own 
avatar set) look small and wrong if you compare them to what they look on the 
webapp (see your company chat for an example)

Configure account is unfinished? https://i.imgur.com/d8wUwNn.png

Ah, on the second login looked different and it at least showed my account name 
there on the first line (even though i still was not able to configure 
anything?)

Searching for "montel" on the webapp on the company server shows me your chat 
(that i don't have open), searching for the same on ruqola doesn't, so i don't 
really have a way to talking to you

Also some of the fonts look terrible for a chat app, but that may be because of 
Qt Quick itself :/

Compare https://i.imgur.com/d4sKAwn.png (ruqola) with 
https://i.imgur.com/ibZ7Uim.png (kmail)

Other than that it seems that it is a good start, so i agree it's a good idea 
to make some noise around it and see if we can get some more contributors :)

Cheers,
  Albert


> 
> Regards.
> 
> 






Re: Ruqola in KDE-review

2019-09-15 Thread Albert Astals Cid
El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va 
escriure:
> Hi,
> I would like to move ruqola to extragear/network.
> So I asked to sysadmin to move ruqola to kde-review (it was done).
> 
> Ben told me that this period will start in 2 weeks.
> 
> If you want to review it... :)

class LIBRUQOLACORE_TESTS_EXPORT Emoji
has 
Emoji &operator=(const Emoji &other);
but no
Emoji(const Emoji &other);

newer gcc complains about it, also the operator= doesn't copy mCachedHtml is 
that on purpose? If not i'd suggest to simply mark operator= and the copy 
contructor as = default.




class LIBRUQOLACORE_TESTS_EXPORT User
also has the same warning, given that the operator= is implemented and not the 
copy constructor. Same suggestion to just use = default on them.


and a whole lots more of classes seem to have this issue. Can you double check 
them for me?

http://paste.debian.net/1100950/

Cheers,
  Albert

> 
> Regards.
> 
> 






Re: Taking over maintainership of the kaccounts-* repos

2019-09-15 Thread Martin Klapetek
On Fri, Sep 13, 2019 at 4:21 AM Bhushan Shah  wrote:

> Hello!
>
> At akademy we talked about the KAccounts and realized that kaccounts is
> unmaintained and/or Martin is not active.
>

https://martys.typepad.com/blog/2016/06/new-maintainers-wanted-kde-telepathy-kaccounts-plasma-notifications-and-others.html

You 'realized' after three years? :P


>
> So I propose to take over maintainership of the following repositories.
>
> - kaccounts-integration
> - kaccounts-providers
> - kaccounts-mobile
>
> If you have any concerns/objections with this, let me know.
>

Yes please, go ahead!

Cheers
--
Martin Klapetek


Re: Taking over maintainership of the kaccounts-* repos

2019-09-15 Thread Aleix Pol
On Fri, Sep 13, 2019 at 10:35 AM Bhushan Shah  wrote:
>
> Hello!
>
> At akademy we talked about the KAccounts and realized that kaccounts is
> unmaintained and/or Martin is not active.
>
> So I propose to take over maintainership of the following repositories.
>
> - kaccounts-integration
> - kaccounts-providers
> - kaccounts-mobile
>
> If you have any concerns/objections with this, let me know.
>
> Thanks
>
> --
> Bhushan Shah
> http://blog.bshah.in
> IRC Nick : bshah on Freenode
> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D

:) thanks Bhushan!

Aleix


Re: KDE Frameworks 5.62.0 released

2019-09-15 Thread David Faure
On samedi 14 septembre 2019 15:17:29 CEST Christoph Feck wrote:
> On 09/14/19 13:35, David Faure wrote:
> > 14th September 2019. KDE today announces the release of KDE Frameworks
> > 5.62.0.
> > 
> > http://kde.org/announcements/kde-frameworks-5.62.0.php
> 
> This web page says the release number is 5.1.0.

Good thing the code has less bugs than the generated web pages :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





KF6 Sprint

2019-09-15 Thread Volker Krause
Hi,

as you might have seen in David's summary of the KF6 BoF at Akademy (https://
mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), 
there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we 
had in Randa a few years back, to determine what we actually want to achieve 
with KF6 beyond just porting to Qt6.

If you are interested please subscribe to https://phabricator.kde.org/T11535 
and indicate your interest to participate, as well as times that would work 
for you. I'm not just looking at the current KF5 contributors for this, but 
also those of you heavily using KF5.

If you are willing to help organize the sprint, please indicate so there too, 
help with that would be greatly appreciated (I'm not organizing this, I'm just 
writing this email because Albert asked me too ;-) ).

With Qt 6 planned for Nov 2020 we are probably looking at a 18-24 month time 
frame towards KF6, so it's time to get this going.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.