Re: plasma-systemmonitor in kdereview

2020-10-18 Thread Albert Astals Cid
El dijous, 1 d’octubre de 2020, a les 14:36:05 CEST, Arjen Hiemstra va escriure:
> On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote:
> > On 01.10.20 11:36, Arjen Hiemstra wrote:
> > > Hello,
> > > 
> > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It
> > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> > > 
> > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It
> > > makes use of the ksystemstats daemon and the faces system for system
> > > monitor plasmoids that were both introduced in Plasma 5.19.
> > > 
> > > Our current plan is to do a "preview release" alongside Plasma 5.20, then
> > > have it be an official part of Plasma with 5.21.
> > 
> > Cool stuff.
> > 
> > L10n is currently a bit incomplete.
> > Notably
> > - the pages files lack any localization at all and I'm also not sure how
> > those could be best localized.
> 
> Yeah that is a good point. If we can somehow extract the strings from these 
> files I think we can make it work. But that may need some custom scripting.

I think that shows a bit of a bad design decision. You shouldn't have default 
user visible strings in data files if they are also user editable

If you do, you have several chained problems:
 * You need to extract those strings somehow 
 * You need to feed all the "title" strings coming from .page files through 
i18n() to get the translation before showing it to the user
 * Once you do that, what happens if i create a page and call it "Disk"? i do 
*not* want to get the translation for that, it's something i manually created i 
want to get exactly what i wrote
 * This means that now for each title string in your .page files you need to 
store whether this is a default string and thus should be passed through i18n 
or if it is a user-entered string and should not be passed through i18n

Random suggestion after spending 2 minutes thinking on it, for the default 
pages instead of having
  title=Disk
you have
  default_page_title=overview_page_disk

and then on the C++ side you have a big group of
  if (default_page_title == "overview_page_disk") return i18nc("Label on 
Overview Page", "Disk");

and leave title only for user created pages.

Cheers,
   Albert




Re: plasma-systemmonitor in kdereview

2020-10-18 Thread Albert Astals Cid
El dijous, 1 d’octubre de 2020, a les 11:36:12 CEST, Arjen Hiemstra va escriure:
> Hello,
> 
> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can 
> be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> 
> plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes 
> use of the ksystemstats daemon and the faces system for system monitor 
> plasmoids that were both introduced in Plasma 5.19.
> 
> Our current plan is to do a "preview release" alongside Plasma 5.20, then 
> have 
> it be an official part of Plasma with 5.21.

How serious are these cmake warnings? http://paste.debian.net/1167754/

I'd personally would suggest to remove these default values from KillDialog.qml
property string killButtonText: "Exterminate"
property string killButtonIcon: "killbots"
property string questionText: "Ex-ter-mi-nate"
they are not used anywhere and just cause confusion.

I guess i'm running a too old version of some dependency?
  
"file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde.ksysguard.processtable/contents/ui/FullRepresentation.qml:127:18:
 Type ProcessTableView unavailable"
  
"file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde.ksysguard.processtable/contents/ui/ProcessTableView.qml:97:9:
 Cannot assign to non-existent property \"flatList\""
Would make sense to mark that in the cmakelists you think? or is it just 
supposed to be used with plasma master in sync?

Cheers,
  Albert

> 
> Cheers,
> Arjen
> 
> 
> 






Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-18 Thread David Faure
On mardi 6 octobre 2020 11:59:34 CEST Ben Cooksley wrote:
> Hi all,
> 
> This evening i've completed updates to the Windows CI system, bringing it
> from the previous Qt 5.14 setup it was using up to the more recent Qt 5.15.
> As part of this various other libraries will have also been updated.
> 
> This update was prompted by an unannounced dependency change within Breeze
> Icons. As a reminder to all developers, it is imperative that any change to
> your dependencies on a non-KDE project be announced two weeks or more in
> advance.
> 
> Unfortunately due to regressions within Breeze Icons, it is not possible
> for the Dependency Builds to complete at this time, meaning Windows CI
> functionality will be generally unavailable until this is corrected.
> 
> The failure log can be found at
> https://build.kde.org/job/Administration/job/Dependency%20Build%20Extragear%
> 20stable-kf5-qt5%20WindowsMSVCQt5.15/lastFailedBuild/console

That looks like the usual java timeout

I re-ran the exact same job and it passed.

Can you re-enable normal CI service for Windows?
I noticed e.g. that KIO tests were not run anymore...

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-18 Thread Milian Wolff
Hey all,

since some time now I'm only compiling parts of KF5 selectively into a custom 
prefix. Most notably, I'm only interested in ktexteditor and syntax-
highlighting, and would like to obtain all other frameworks through my 
distribution packages.

Sadly, this doesn't work as easily, as ktexteditor is trying to do this:

```
install(TARGETS kauth_ktexteditor_helper DESTINATION $
{KAUTH_HELPER_INSTALL_DIR} )
kauth_install_helper_files(kauth_ktexteditor_helper 
org.kde.ktexteditor.katetextbuffer root)
kauth_install_actions(org.kde.ktexteditor.katetextbuffer buffer/
org.kde.ktexteditor.katetextbuffer.actions)
```

Because my KAuth is a system-provided installation, and KTextEditor should be 
installed into a user-writable prefix, I get this error on `ninja install`:

```
CMake Error at src/cmake_install.cmake:143 (file):
  file INSTALL cannot copy file
  "/home/milian/projects/kf5/build/frameworks/ktexteditor/src/
org.kde.ktexteditor.katetextbuffer.policy"
  to "/usr/share/polkit-1/actions/org.kde.ktexteditor.katetextbuffer.policy":
  Permission denied.
Call Stack (most recent call first):
  cmake_install.cmake:77 (include)
```

I can workaround this by either commenting out the kauth install bits in 
ktexteditor or by installing kauth seperately too. But both are in my opinion 
not ideal.

I don't think it's currently possible to overwrite the KAuth install directory 
at cmake configure time. I would like to change that, unless there is 
something I'm missing which would prevent this? I am hoping that any folder 
works as long as it's listed in the `XDG_DATA_DIRS` env var - can someone 
confirm this?

Thanks

-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.