Re: Aura Browser in KDE Review
El divendres, 26 d’agost de 2022, a les 12:27:22 (CEST), Aditya Mehra va escriure: > Hi, > > Aura Browser is in KDE Review and would like to release it along with Plasma > Bigscreen > > Aura browser is a web browser specifically designed to work with remote > controls and key navigation for Plasma Bigscreen, it supports a virtual > mouse cursor and multiple tabs it also includes a third party AdBlock from > brave browser based on easy list. > > You can find the repository here: > https://invent.kde.org/plasma-bigscreen/aura-browser > > Request to please review Aura Browser. wcgrep text: | grep \" will show you lots of places that need i18n (or qstr that you use in 2 places) You have a Messages.sh but if you're going to keep using qstr you need to update it to use the Qt extraction command not the ki18n one. All those third-party are a bit sub-optimal, can we depend on packaged versions of them or they don't exist as such? Can you make cmake complain if the virtualkeyboard is not found? i think we have RUNTIME warning categories for that? It's relatively easy to get it crashing on closing the app, open a webpage (i tried wikipedia), close the app gdb trace https://pst.klgrth.io/paste/jobc7 Cheers, Albert > > Regards, > Aditya
Re: Plasma Remote Controllers in KDE Review
El divendres, 26 d’agost de 2022, a les 12:21:40 (CEST), Aditya Mehra va escriure: > Hi, > > Plasma remote controllers is in KDE Review and would like to release it > along with Plasma Bigscreen > > Plasma remote controllers allows translating various input device events > into keyboard and pointer events send from remote control type devices like > CEC and Gamepads to provide key navigation support in applications. It also > allows re mapping of keys to specific events. > > You can find the repository here: > https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers > > Request to please review Plasma remote controllers. There's a few "can be marked override" that i think that you should. You need to call KLocalizedString::setApplicationDomain in the main of the app. Cheers, Albert > > Regards, > Aditya
Re: Plank Player in KDE Review
El divendres, 26 d’agost de 2022, a les 12:29:31 (CEST), Aditya Mehra va escriure: > Hi, > > Plank Player is in KDE Review and would like to release it along with Plasma > Bigscreen > > Plank Player is a local media player specifically designed to work with > remote controls and key navigation for bigscreen. > > You can find the repository here: > https://invent.kde.org/plasma-bigscreen/plank-player > > Request to please review Plank Player. This seems wrong MimeType=application/vnd.debian.binary-package;application/x-rpm; This needs i18n / or qstr ./app/qml/Menu.qml:91:text: "Press 'esc' or the [←] Back button to close" and then you need the appropriate a Messages.sh I'm not sure having the folders sorted case sensitive makes sense, i think we stopped doing that a while ago? Cheers, Albert > > Regards, > Aditya
Re: Plasma Remote Controllers in KDE Review
Hi, Thanks for the review, I have fixed most of the issues mentioned in this list. Please review again. Regards, Aditya From: Harald Sitter Sent: Friday, August 26, 2022 10:43 PM To: Aditya Mehra Cc: kde-core-devel Subject: Re: Plasma Remote Controllers in KDE Review - src dir is missing i18n setup (messages.sh and define in cmakelists) - not reuse covered - metainfo.xml missing (appstream) - doesn't have gitlab ci builds apparently? - doesn't have bugzilla product - clazy is not happy On Fri, Aug 26, 2022 at 12:21 PM Aditya Mehra wrote: > > Hi, > > Plasma remote controllers is in KDE Review and would like to release it along > with Plasma Bigscreen > > Plasma remote controllers allows translating various input device events into > keyboard and pointer events send from remote control type devices like CEC > and Gamepads to provide key navigation support in applications. It also > allows re mapping of keys to specific events. > > You can find the repository here: > https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers > > Request to please review Plasma remote controllers. > > Regards, > Aditya
Re: Plasma Remote Controllers in KDE Review
- src dir is missing i18n setup (messages.sh and define in cmakelists) - not reuse covered - metainfo.xml missing (appstream) - doesn't have gitlab ci builds apparently? - doesn't have bugzilla product - clazy is not happy On Fri, Aug 26, 2022 at 12:21 PM Aditya Mehra wrote: > > Hi, > > Plasma remote controllers is in KDE Review and would like to release it along > with Plasma Bigscreen > > Plasma remote controllers allows translating various input device events into > keyboard and pointer events send from remote control type devices like CEC > and Gamepads to provide key navigation support in applications. It also > allows re mapping of keys to specific events. > > You can find the repository here: > https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers > > Request to please review Plasma remote controllers. > > Regards, > Aditya
Re: Aura Browser in KDE Review
This is missing an Appstream file and the licencing isn't clear, it should get SPDX licences. Jonathan On Fri, 26 Aug 2022 at 11:27, Aditya Mehra wrote: > Hi, > > Aura Browser is in KDE Review and would like to release it along with > Plasma Bigscreen > > Aura browser is a web browser specifically designed to work with remote > controls and key navigation for Plasma Bigscreen, it supports a virtual > mouse cursor and multiple tabs it also includes a third party AdBlock from > brave browser based on easy list. > > You can find the repository here: > https://invent.kde.org/plasma-bigscreen/aura-browser > > Request to please review Aura Browser. > > Regards, > Aditya >
Plank Player in KDE Review
Hi, Plank Player is in KDE Review and would like to release it along with Plasma Bigscreen Plank Player is a local media player specifically designed to work with remote controls and key navigation for bigscreen. You can find the repository here: https://invent.kde.org/plasma-bigscreen/plank-player Request to please review Plank Player. Regards, Aditya
Aura Browser in KDE Review
Hi, Aura Browser is in KDE Review and would like to release it along with Plasma Bigscreen Aura browser is a web browser specifically designed to work with remote controls and key navigation for Plasma Bigscreen, it supports a virtual mouse cursor and multiple tabs it also includes a third party AdBlock from brave browser based on easy list. You can find the repository here: https://invent.kde.org/plasma-bigscreen/aura-browser Request to please review Aura Browser. Regards, Aditya
Plasma Remote Controllers in KDE Review
Hi, Plasma remote controllers is in KDE Review and would like to release it along with Plasma Bigscreen Plasma remote controllers allows translating various input device events into keyboard and pointer events send from remote control type devices like CEC and Gamepads to provide key navigation support in applications. It also allows re mapping of keys to specific events. You can find the repository here: https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers Request to please review Plasma remote controllers. Regards, Aditya
