Re: New santizer warning in KF 5.98 headers

2023-01-10 Thread Michael Reeves
Thanks. I would say your right there this would definitely have caught
someone's attention if didn't work in practice with what kde needs.
Santizers are by design quite pedantic as serves there purpose well.

On Tue, Jan 10, 2023 at 5:34 PM Albert Astals Cid  wrote:

> El dimarts, 10 de gener de 2023, a les 22:49:43 (CET), Michael Reeves va
> escriure:
> > /usr/include/KF5/KConfigWidgets/kstandardaction.h:261:64: runtime error:
> > load of value 4294967295, which is not a valid value for type
> > 'Qt::ConnectionType'
> >
> > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
> > /usr/include/KF5/KConfigWidgets/kstandardaction.h:261:64 in
> >
> > The issue stems for assigning an int to a enum which is internally
> > considered unsigned and possibly smaller than the four byte int. If this
> is
> > doing what we expect than I need a way to shut off the warning.
>
> That code has been there since May last year, so not exactly "new".
>
> Given it doesn't seem to be crashing it would seem it's one of those
> "undefined
> but it works in all the compilers we care about".
>
> Of course patches to make the sanitizer are really welcome :)
>
> Cheers,
>   Albert
>
>
>
>


Re: New santizer warning in KF 5.98 headers

2023-01-10 Thread Albert Astals Cid
El dimarts, 10 de gener de 2023, a les 22:49:43 (CET), Michael Reeves va 
escriure:
> /usr/include/KF5/KConfigWidgets/kstandardaction.h:261:64: runtime error:
> load of value 4294967295, which is not a valid value for type
> 'Qt::ConnectionType'
> 
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
> /usr/include/KF5/KConfigWidgets/kstandardaction.h:261:64 in
> 
> The issue stems for assigning an int to a enum which is internally
> considered unsigned and possibly smaller than the four byte int. If this is
> doing what we expect than I need a way to shut off the warning.

That code has been there since May last year, so not exactly "new".

Given it doesn't seem to be crashing it would seem it's one of those "undefined 
but it works in all the compilers we care about".

Of course patches to make the sanitizer are really welcome :)

Cheers,
  Albert





New santizer warning in KF 5.98 headers

2023-01-10 Thread Michael Reeves
/usr/include/KF5/KConfigWidgets/kstandardaction.h:261:64: runtime error:
load of value 4294967295, which is not a valid value for type
'Qt::ConnectionType'

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
/usr/include/KF5/KConfigWidgets/kstandardaction.h:261:64 in

The issue stems for assigning an int to a enum which is internally
considered unsigned and possibly smaller than the four byte int. If this is
doing what we expect than I need a way to shut off the warning.


Re: GItlab update

2023-01-10 Thread Eugen Mohr

Hi Ben

Since the update “Project information” -> “activity” doesn’t show
“Issues” anymore. The tab “Issues events” doesn’t show issues neither.

Example: https://invent.kde.org/multimedia/kdenlive/activity vs.
https://invent.kde.org/multimedia/kdenlive/-/issues.

Eugen

Am 08.01.2023 um 11:03 schrieb Ben Cooksley:

Hi all,

This evening I updated our Gitlab instance at invent.kde.org
 to the latest version - 15.7.1.
The release notes for this can be found at
https://about.gitlab.com/releases/2022/12/22/gitlab-15-7-released/

Of particular note for folks are the following:
- Gitlab CLI Tool: https://docs.gitlab.com/ee/integration/glab/
- Using a SSH key to sign your commits:
https://docs.gitlab.com/ee/user/project/repository/ssh_signed_commits/
- New Web IDE: https://docs.gitlab.com/ee/user/project/web_ide_beta/
(based on VS Code)

Please note that the new VS Code based Web IDE is currently in beta,
if you experience issues with it you can disable it in your
preferences: https://invent.kde.org/-/profile/preferences

Should there be any issues, please let us know.

Thanks,
Ben