Re: plasma-nano and plasma-phone-components are now in kdereview

[Alexey Min]

Are there plans to finally fix all those nasty QML errors listed at
https://invent.kde.org/kde/plasma-phone-components/issues ?

вс, 10 нояб. 2019 г. в 04:07, Albert Astals Cid :
>
> El divendres, 8 de novembre de 2019, a les 8:09:33 CET, Bhushan Shah va 
> escriure:
> > Hello!
> >
> > plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components
>
> clazy found a crasher
>  const char* country = countrycode.toUtf8().constData();
>
> other minor clazy stuff in http://paste.debian.net/1115558/
>
> And other minor clang-tidy stuff in http://paste.debian.net/1115559/
>
> Cheers,
>   Albert
>
>

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

[Alexey Min]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130239/#review103848
---


Ship it!




Ship It!

- Alexey Min


On Сен. 27, 2017, 9:19 д.п., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130239/
> ---
> 
> (Updated Сен. 27, 2017, 9:19 д.п.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Bugs: 384334
> http://bugs.kde.org/show_bug.cgi?id=384334
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This patch fixes an issue that on the first start of KMyMoney (and on some 
> computers on every start for example reported by 
> https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9)
>  on running kconf_update the user account control pops up and forces the user 
> to allow or deny  this application.
> 
> Commit message
> 
>Add Windows manifest to  kconf_update.exe
> 
> This explicitly sets the execution level to 'asInvoker', preventing
> Windows' UAC heuristics from deciding that because its name mentions
> "update", it probably needs to escalate privileges.
> 
> FIXED-IN:4.14.36
> BUG:384334
> 
> 
> Diffs
> -
> 
>   kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130239/diff/3/
> 
> 
> Testing
> ---
> 
> Compiled at 
> https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4
>  and tested with KMyMoney snapshot for Windows downloadable from 
> https://software.opensuse.org/package/mingw32-kmymoney-portable
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

[Alexey Min]

> On Сен. 26, 2017, 6:02 п.п., Albert Astals Cid wrote:
> > cmake/modules/Win32Macros.cmake
> > Lines 61 (patched)
> > 
> >
> > I don't think it makes sense adding a new public-ish macro in 4.14.lots
> 
> Ralf Habacker wrote:
> See revision 1 of this patch at 
> https://git.reviewboard.kde.org/r/130239/diff/1/
> 
> Albert Astals Cid wrote:
> I'm personally happier with that patch for almost dead 4.14 (it has 2 
> releases left), now you're going to need someone with a win32 build/knowledge 
> to approve since honestly i have no idea what this does.
> 
> Ralf Habacker wrote:
> > for almost dead 4.14 (it has 2 releases left),
> 
> Looking at the number of open KF5 related windows issues I guess kmymoney 
> and umbrello for Windows will depends on KDE4 at least a year. 
> 
> >i have no idea what this does.
> 
> From 
> https://stackoverflow.com/questions/20096706/how-does-windows-decide-whether-to-display-the-uac-prompt
> 
> kconf_update is "hitting a Windows Installer Detection Technology 
> compatibility heuristic. Windows will try to detect when an application is an 
> installer, and probably needs to be elevated."
> 
> BTW: The same issue happens also with KF5

This looks good and harmless actually. As I understood, it adds a .rc (windows 
resource file) with embedded manifest resource, saying that no elevation is 
needed for this .exe file.
We at our work also had problems with this windows heuristic (we had a helper 
program, containing "setup" in its name, so it magically required administrator 
rights with no real need for this).
So if this really works and helps for windows, why not.


- Alexey


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130239/#review103738
---


On Сен. 27, 2017, 9:19 д.п., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130239/
> ---
> 
> (Updated Сен. 27, 2017, 9:19 д.п.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Bugs: 384334
> http://bugs.kde.org/show_bug.cgi?id=384334
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This patch fixes an issue that on the first start of KMyMoney (and on some 
> computers on every start for example reported by 
> https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9)
>  on running kconf_update the user account control pops up and forces the user 
> to allow or deny  this application.
> 
> Commit message
> 
>Add Windows manifest to  kconf_update.exe
> 
> This explicitly sets the execution level to 'asInvoker', preventing
> Windows' UAC heuristics from deciding that because its name mentions
> "update", it probably needs to escalate privileges.
> 
> FIXED-IN:4.14.36
> BUG:384334
> 
> 
> Diffs
> -
> 
>   kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130239/diff/3/
> 
> 
> Testing
> ---
> 
> Compiled at 
> https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4
>  and tested with KMyMoney snapshot for Windows downloadable from 
> https://software.opensuse.org/package/mingw32-kmymoney-portable
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>