Changing the KDE Edu module maintainer
Hi, I have been the assigned KDE Edu module maintainer for the past years but due to family life (aging parents, husband being often away for his work, kids,…) I have not been active in the past 2 years and things will be very busy until at least mid-September so I will not contribute again to KDE until at least this time. I cannot go to the Randa meeting nor Akademy due to already planned events (we’ll celebrate our 30th anniversary on the 10th of August for example!). Aleix Pol will take over as module maintainer as he has been in charge since I stepped down. I’d like to thank him along with all the other amazing people working on KDE educational apps (in particular Andreas Cord-Landwehr). I did not realise I had a formal role as maintainer which is needed for allowing new apps in KDE Edu, otherwise I would have stepped down earlier. Of course I hope to contribute again and I still follow what’s happening through the mailing lists so don’t think you’ll get rid of me for good ;-) Best regards to all and thanks to everyone for what you brought me so far. Anne-Marie aka annma
Re: R: Re: kde review kartesio
Hi, I think Kartesio is not ready to move: - the GUI is not so good - lack of tooltips - I am not happy with some strings and they lack context info - the standard C++ code is not so good either (this rm for example) - lack of testing I suggest you do a release first so we can test translations and you can get some users feedback and have time to move the code to Qt classes. This is my suggestion only, others may disagree Best regards, Anne-Marie
Re: R: Re: kde review kartesio
Hi, Hi, actually I have not prepared any binary package. Anyway, you can install Kartesio downloading the source code from the git repo (https://projects.kde. org/projects/kdereview/kartesio), installing the library libzorbaneural (https: //www.gitorious.org/zorbaneural/zorbaneural/trees/master/binary- packages/libzorbaneural-0.1), and running the build.sh script you find in the Kartesio root folder. Why is this build.sh script needed? Is it because I did not run it that I got my build error? Also, you should have installed the program maxima (just the program, dev libraries are not needed) to have Kartesio fully working. If there are some troubles in building Kartesio, just ask me. I have this error: /home/kde-devel/kartesio/src/calculations.cpp:278:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: some warnings being treated as errors Best regards, Anne-Marie
Re: kde review kartesio
Hi, In general, you're mixing a lot of plain C / stdlib stuff into Qt code. Is there a reason for that? For example, in calculations.cpp:148 you take text from a text field, convert it to a byte array, convert it to a char* and then pass it to a function. Why not just pass the QString? You can iterate over a QString like foreach ( const QChar c, myqstring ) { ... } or also for ( int i = 0; i myqstring.size(); i++ ) { ... } if you like that better, and you can also index it like a char*, as in mystring[i+1] or so. Yes, this is an heritage from the older version of Kartesio, that was based mainly on plain ANSI C++. Those mixing are just an hack to make Kartesio work immediately. If I'll have time, I will translate everything into Qt, but first of all I would like to apply other features. You asked for an inclusion in KDE and we are reviewing Kartesio. There is already a big amount of work to be done from the comments you got. I don't think adding features now is a smart move, review is a phase where your program should reach KDE standards. Using Qt libs wherever possible is the priority and getting all the required fixes will make you busy enough. Best regards, Anne-Marie
Re: R: Re: R: Re: kde review kartesio
Hi, so I don't have to type all those every time I want to build Kartesio again. I'm not sure why you get that error, mainlybecause I don't know which is the instruction that gives that problem since I changed a lot the code in these hours. Try to download the latest git version and build it, so I will know exactly where the problem is. commenting out line 465 in calculations.cpp makes it build (the line after the return). Anne-Marie
Re: kde review kartesio
Hi, I am wondering what is the user base for this application as it seems quite specialized (I did not build it yet though). Can you tell us more about the potential target? Another question that comes to mind is: can't it be a feature of an existing KDE Edu apps? Best regards, Anne-Marie - Mail original - De: LucaTringali tringalinv...@libero.it À: kde-core-devel@kde.org Envoyé: Jeudi 9 Mai 2013 18:06:16 Objet: kde review kartesio Hello, I have been working on Kartesio, a program for calculating best fit curves with experimental points. I think it is ready to be moved in the KDE Edu main repo now, so I'm asking your approval. I followed the guidelines ( http://techbase.kde.org/Policies/Application_Lifecycle ) and Kartesio is actually in KDE review: https://projects.kde.org/projects/kdereview/kartesio For any question, ask me. Luca Tringali
Re: kde review kartesio
Hi, A few primary remarks: - libzorbaneural is needed but my distro does not have anything with neural in it (OpenSuse 12.3) what repo do I need to add in order to get it? The libzorbaneural website should be added to the cmake file so people can find this and packagers can add it to their distros. - I see a screenshot folder and some .pro files that probably are not needed - some doxygen comments for the variables in the .h files would be appreciated, if anyone else wants to fix bugs it'll help a lot. - Kartesio does not build for me, I get /home/kde-devel/kartesio/src/calculations.cpp:278:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: some warnings being treated as errors - I don't see a Messages.sh file to extract translatable strings. - I am not comfortable with the rm call line 181 in calculations.cpp = you can probably use more Qt classes here and in other parts of this file too. That's only a quick review as I couldn't run the app yet. Tomaz, as for the user base maybe we could start a module for advanced scientific tools? Best regards, Anne-Marie - Mail original - De: Tomaz Canabrava tcanabr...@kde.org À: Anne-Marie Mahfouf annemarie.mahf...@free.fr Cc: LucaTringali tringalinv...@libero.it, kde-core-devel@kde.org Envoyé: Vendredi 10 Mai 2013 12:28:54 Objet: Re: kde review kartesio Quite Unlikely ... It's a Solver, to fit curves into points, That's very used in any theorical research, engeniering, math, phisics, etc. 2013/5/10 Anne-Marie Mahfouf annemarie.mahf...@free.fr Hi, I am wondering what is the user base for this application as it seems quite specialized (I did not build it yet though). Can you tell us more about the potential target? Another question that comes to mind is: can't it be a feature of an existing KDE Edu apps? Best regards, Anne-Marie - Mail original - De: LucaTringali tringalinv...@libero.it À: kde-core-devel@kde.org Envoyé: Jeudi 9 Mai 2013 18:06:16 Objet: kde review kartesio Hello, I have been working on Kartesio, a program for calculating best fit curves with experimental points. I think it is ready to be moved in the KDE Edu main repo now, so I'm asking your approval. I followed the guidelines ( http://techbase.kde.org/Policies/Application_Lifecycle ) and Kartesio is actually in KDE review: https://projects.kde.org/projects/kdereview/kartesio For any question, ask me. Luca Tringali
Review Request 110102: Change 2 strings from Display to Screen for better consistency.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110102/ --- Review request for kde-workspace and Dario Freddi. Description --- The Battery applet indicates Screen Brightness and most strings refer to Screen except those 2 strings which referred to Display and that I changed to Screen Diffs - powerdevil/daemon/actions/bundled/powerdevildimdisplayaction.desktop 3050455 powerdevil/daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 79f88ae Diff: http://git.reviewboard.kde.org/r/110102/diff/ Testing --- Testing done, OK Thanks, Anne-Marie Mahfouf
Review Request: Make KRunner Enter work again in 4.10
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108197/ --- Review request for kde-workspace and Aaron J. Seigo. Description --- Aaron reverted some code in the 4.9 branch but not in the 4.10 branch where he seemed to not have the bug. Although we all have the bug and thus this patch reverts the code in the same way he did for 4.9. Should also be fixed in master because Enter not working makes KRunner useless. This addresses bug https://bugs.kde.org/show_bug.cgi?id=309787. http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=309787 Diffs - krunner/interfaces/default/interface.cpp fac1066 Diff: http://git.reviewboard.kde.org/r/108197/diff/ Testing --- Works as expected Thanks, Anne-Marie Mahfouf
Re: ALERT: KDElibs (at least) 4.8.4 is actually 4.8.80+
On 06/09/2012 12:10 PM, Modestas Vainius wrote: Hello, On šeštadienis 09 Birželis 2012 13:01:20 Albert Astals Cid wrote: here at Debian we had a really bad experience with 4.8.4. While 4.8.3 was pretty good, 4.8.4 seemed like a huge step backwards in terms of stability (random crashes there and there). After quick investigation of kdelibs 4.8.4 I found the following: I don't know yet if any other modules from 4.8.4 has been mis-packaged in the same way There's no mispackaging. If you followed the list or read the archives before blaming people of wrong doing you'd know that kdelibs for 4.8.4 and 4.8.80 actually come from the same branch. Thank you for pushing a bunch of untested huge changes in the minor point release. Really appreciated. what are those untested changes please? the Quality Team will be happy to test anything you want to be tested so please state what we need to do. Anne-Marie
Re: kdelibs and Qt version dependency
On 06/06/2012 03:19 AM, Dawit A wrote: It is a simple matter to put a #ifdef around the code that does not compile with Qt 4.7. I wish this issue was raised when the code was up for review for more than a month or the Qt documentation mentioned something about those functions only being available in Qt 4.8. Anyhow, I have attached a patch that should make it compile on Qt 4.7.x. If someone is willing to test it against Qt 4.7 and let me know if it compiles and works fine for them, I can commit it. It will however mean that bug# 275524 will not be fixed for those using Qt 4.7. On Tue, Jun 5, 2012 at 3:16 PM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: On May 19, Dawit Alemayehu commited a change that uses QSslConfiguration::testSslOption that is only available in Qt 4.8 This means that both kdelibs 4.8.4 and kdelibs 4.9 now depend in Qt 4.8 instead Qt 4.7 I want to ask the kdelibs maintainers: a) Do you think it makes sense to change our Qt required version from Qt 4.7 in kdelibs 4.8.3 to Qt 4.8 in kdelibs 4.8.4 ? b) Do you think kdelibs 4.9 should depend in Qt 4.8 or not? Cheers, Albert I tried the patch, you forgot some stuff. I am working on the 4.8.80 kdelibs tarball if that matters. I added #if QT_VERSION = 0x040800 if (sslConfig.testSslOption(QSsl::SslOptionDisableCompression) !shouldSslCompressBeDisabled) { setMetaData(QLatin1String({internal~currenthost}LastUsedSslDisableCompressionFlag), QString::number(true)); } #endif and #if QT_VERSION = 0x040800 kDebug(7027) Trying SSL handshake with protocol: version , SSL compression ON: sslConfig.testSslOption(QSsl::SslOptionDisableCompression); #endif and it built. Anne-Marie
KDE 4.9 feature plan
Hi all, It would be great if you could all take a few minutes to update the feature plan for 4.9 (preferably right now or you'll forget again!) http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan as the Quality Team would need to identify new features, new applets, new apps,.. in order to give them some priority testing! Can you also forward this to any relevant subgroup you know, thanks a lot in advance. Best regards, Anne-Marie
Akademy hotels and hostels - book now
Hi all, Just a reminder: if you're planning to attend Akademy this year, please book you hotel or hostel room asap. Late June and July is high season in Tallinn and you might have trouble finding a hotel room if you want to book last minute. A list of recommended hostels and hotels can be found here: http://akademy.kde.org/accommodation Cheers, Claudia -- Claudia Rauch Business Manager KDE e.V. Linienstr. 141 10115 Berlin Germany
Re: Setting up a Quality Team within KDE
On 04/08/2012 07:11 AM, Percy Camilo Triveño Aucahuasi wrote: Hi Anne, hi all On Fri, Apr 6, 2012 at 12:03 PM, Anne-Marie Mahfouf This is addressed for 4.9 as putting in place a few selected areas of functional testing and hopefully we will assess some automated UI testing tools and start using them in the following releases. I hope we can gather enough beta testers and make this working. Indeed, Nice idea, I think this is the right focus to (auto)test the functionality/features of the app. I've searched some info about this topic and found this: http://ldtp.freedesktop.org/wiki/Home It has full support for KDE/Qt (4.x) apps and the scripts (for autotesting) can be written with Python. My 0.5 cents :) Cheers, Percy Yes this is maybe the best free tool to do the job. DO you or anybody have used it already? Thanks for your input, Anne-Marie On Fri, Apr 6, 2012 at 12:03 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr mailto:annemarie.mahf...@free.fr wrote: On 04/06/2012 02:23 PM, Aleix Pol wrote: On Thu, Apr 5, 2012 at 1:42 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr mailto:annemarie.mahf...@free.fr wrote: Hi, We would like to setup a Quality Testing Team within KDE in order to better test our next KDE SC and make the beta process more efficient. Attached is the first draft of the ideas I brainstormed. Source .odt of this document is available at http://quickgit.kde.org/index.php?p=scratch%2Fannma%2Fquality-testing-doc.git (We can make it a public Google doc if it is more convenient or an etherpad). The document roughly describes 2 areas of action: - reinforcement (labelled Reinforce) of existing structures (mainly targetted to developers and mainly relevant before the beta stage of the release). This could be used as guidelines for new developers. Of course it won't be newbies which will develop Unit Tests or check the code quality. But some guidelines can be useful for libs outside Frameworks. An area of relevant reinforcement that can be currently done is the Review process for new integration. - new infra-structures: this is labelled New in the doc: this is what I would see to happen for the 4.9 release. A new mailing list has been set up in order to discuss all this: please subscribe to it if you would like to be part of this https://mail.kde.org/mailman/listinfo/kde-testing An IRC channel also was created on Freenode: #kde-quality Please join the mailing list and the IRC channel so we can setup a plan to start putting all this in gear! Thanks in advance, Anne-Marie and Myriam Hi! I think this project is a very interesting idea and definitely something we need. Said that, I'd like to propose some small changes on how this should be done. In the document there are some actions to be taken that sound a bit too technical, for example it specifies reinforcing the unit testing. This is something that we should have been doing already and I don't see someone from the Quality Team going to a development team and improving that. Making unit tests is the developer task (and the document mentions it) and we do have solit Unit Tests in kdelibs and Frameworks and kdepimlibs. However there are other libs within KDE where maybe unit tests are not as present as they should (I did not research that though). Also, about unit tests, it's not only writing them, it's also running them. This is not done in a regular basis and needs to be automated in the future and the fails need to be fixed. No newbie will ever touch to any Unit Tests of course. And any action will be discussed with the gurus in this field (/me does not point to David). We have many tools for developers which are not fully used: latest great tool is Jenkins which I was aware of only recently. My label Reinforce is to take full advantage of those existing tools. (It would be cool if at Akademy there are some talks focusing on using these tools.) What I'd like to see is this new team testing KDE and its applications from a user perspective, specifying the different perspectives the KDE end user will face (different OS, different form factors, etc) and reporting problems (not necessarily bugs, as in crashes) and proposing new solutions. This is addressed for 4.9 as putting in place
Re: Setting up a Quality Team within KDE
On 04/06/2012 02:23 PM, Aleix Pol wrote: On Thu, Apr 5, 2012 at 1:42 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr wrote: Hi, We would like to setup a Quality Testing Team within KDE in order to better test our next KDE SC and make the beta process more efficient. Attached is the first draft of the ideas I brainstormed. Source .odt of this document is available at http://quickgit.kde.org/index.php?p=scratch%2Fannma%2Fquality-testing-doc.git (We can make it a public Google doc if it is more convenient or an etherpad). The document roughly describes 2 areas of action: - reinforcement (labelled Reinforce) of existing structures (mainly targetted to developers and mainly relevant before the beta stage of the release). This could be used as guidelines for new developers. Of course it won't be newbies which will develop Unit Tests or check the code quality. But some guidelines can be useful for libs outside Frameworks. An area of relevant reinforcement that can be currently done is the Review process for new integration. - new infra-structures: this is labelled New in the doc: this is what I would see to happen for the 4.9 release. A new mailing list has been set up in order to discuss all this: please subscribe to it if you would like to be part of this https://mail.kde.org/mailman/listinfo/kde-testing An IRC channel also was created on Freenode: #kde-quality Please join the mailing list and the IRC channel so we can setup a plan to start putting all this in gear! Thanks in advance, Anne-Marie and Myriam Hi! I think this project is a very interesting idea and definitely something we need. Said that, I'd like to propose some small changes on how this should be done. In the document there are some actions to be taken that sound a bit too technical, for example it specifies reinforcing the unit testing. This is something that we should have been doing already and I don't see someone from the Quality Team going to a development team and improving that. Making unit tests is the developer task (and the document mentions it) and we do have solit Unit Tests in kdelibs and Frameworks and kdepimlibs. However there are other libs within KDE where maybe unit tests are not as present as they should (I did not research that though). Also, about unit tests, it's not only writing them, it's also running them. This is not done in a regular basis and needs to be automated in the future and the fails need to be fixed. No newbie will ever touch to any Unit Tests of course. And any action will be discussed with the gurus in this field (/me does not point to David). We have many tools for developers which are not fully used: latest great tool is Jenkins which I was aware of only recently. My label Reinforce is to take full advantage of those existing tools. (It would be cool if at Akademy there are some talks focusing on using these tools.) What I'd like to see is this new team testing KDE and its applications from a user perspective, specifying the different perspectives the KDE end user will face (different OS, different form factors, etc) and reporting problems (not necessarily bugs, as in crashes) and proposing new solutions. This is addressed for 4.9 as putting in place a few selected areas of functional testing and hopefully we will assess some automated UI testing tools and start using them in the following releases. I hope we can gather enough beta testers and make this working. I'm really hopeful about such a team, I think it's a good opportunity for KDE to be able to reach contributions for a less common sector of our community and keep working together for a greater KDE experience. Cheers! Aleix Thanks for your input! Anne-Marie
Re: compile error with kde-runtime
Hi, I had to rm CMakeCache.txt in kdelibs build dir for it to be built with the latest SDO. Anne-Marie On 03/07/2012 11:14 AM, Vishesh Handa wrote: On Wed, Mar 7, 2012 at 3:35 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr mailto:annemarie.mahf...@free.fr wrote: On 03/07/2012 09:54 AM, Hugo Pereira Da Costa wrote: My experience: you need to rebuild kdelibs first (with latest sdo installed) to re-generate source code from the ontologies, that is then used in kde-runtime. Yup! (to experts, correct me if I'm wrong) Hugo I updated SDO from git master, I rebuilt and installed kdelibs and I still get the error. There is something else probably to build: I can't see where this Nepomuk::Vocabulary::NFO comes from. In any case, cmake should fail somehow if I miss something. NFO is generated by cmake scripts in kdelibs/nepomuk. If you look in the build directory you'll find the file nfo.h Eg - vlap:~/kde/build/kdelibs/nepomuk $ ack -a depiction nfo.h 643: * http://www.semanticdesktop.org/ontologies/2007/03/22/nfo#depiction 648:NEPOMUK_EXPORT QUrl depiction(); Binary file CMakeFiles/nepomuk.dir/nfo.o matches nfo.cpp 103: nfo_depiction( QUrl::fromEncoded( http://www.semanticdesktop.org/ontologies/2007/03/22/nfo#depiction;, QUrl::StrictMode ) ), 234:QUrl nfo_depiction; 671:QUrl Nepomuk::Vocabulary::NFO::depiction() 673:return s_nfo()-nfo_depiction; Could you check if it has this 'depiction' function? If it doesn't could you check if your SDO has it? vlap:~/kde/src/shared-desktop-ontologies/nfo $ ack -a depiction nfo.trig.in http://nfo.trig.in 944:nfo:depiction 948: rdfs:label depiction ; 958: nrl:inverseProperty nfo:depiction . Anne-Marie Still waiting to hear how to fix the error in compiling kde-runtime. Git updates have not helped. [ 33%] Building CXX object nepomuk/kioslaves/nepomuk/CMakeFiles/kio_nepomuk.dir/__/common/resourcestat.o /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp: In member function ‘QByteArray Nepomuk::ResourcePageGenerator::generatePage() const’: /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp:204:36: error: ‘depiction’ is not a member of ‘Nepomuk::Vocabulary::NFO’ /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp:205:52: error: ‘depiction’ is not a member of ‘Nepomuk::Vocabulary::NFO’ make[2]: *** [nepomuk/kioslaves/nepomuk/CMakeFiles/kio_nepomuk.dir/resourcepagegenerator.o] Error 1 make[2]: *** Waiting for unfinished jobs Please advise. Thanks David On Sun, Mar 4, 2012 at 9:54 AM, Anne-Marie Mahfouf annemarie.mahf...@free.fr mailto:annemarie.mahf...@free.fr wrote: On 03/04/2012 09:41 AM, Vishesh Handa wrote: On Sat, Mar 3, 2012 at 10:23 PM, David Boosalis david.boosa...@gmail.com mailto:david.boosa...@gmail.com wrote: Thank you for the reply. By SDO I assume it is shared-desktop-ontologies. I very rarely build this, but from your email I did a git update on this and there was only one file updated. Perhaps I need to be on a different branch then master. I also updated and built kdelibs from master. I still get the same compile errors with kde-runtime Are you sure you have the correct git repo of SDO? Please check - http://techbase.kde.org/Getting_Started/Build/Requirements#Shared-Desktop-Ontologies I have the same error with SDO master up-to-date. Anne-Marie -David On Fri, Mar 2, 2012 at 11:42 PM, Vishesh Handa m...@vhanda.in mailto:m...@vhanda.in wrote: You need to update SDO, and then update kdelibs. On Sat, Mar 3, 2012 at 6:20 AM, David Boosalis david.boosa...@gmail.com mailto:david.boosa...@gmail.com wrote: Sorry if this is the wrong group to ask this question, please refer me to the right group if you know. The issue is kde-runtime from master. I've been getting the following compile error for about a week now. /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp: In member function ‘QByteArray Nepomuk::ResourcePageGenerator::generatePage() const’: /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp:204:36: error: ‘depiction’ is not a member of ‘Nepomuk::Vocabulary::NFO’ David
Re: compile error with kde-runtime
On 03/04/2012 09:41 AM, Vishesh Handa wrote: On Sat, Mar 3, 2012 at 10:23 PM, David Boosalis david.boosa...@gmail.com mailto:david.boosa...@gmail.com wrote: Thank you for the reply. By SDO I assume it is shared-desktop-ontologies. I very rarely build this, but from your email I did a git update on this and there was only one file updated. Perhaps I need to be on a different branch then master. I also updated and built kdelibs from master. I still get the same compile errors with kde-runtime Are you sure you have the correct git repo of SDO? Please check - http://techbase.kde.org/Getting_Started/Build/Requirements#Shared-Desktop-Ontologies I have the same error with SDO master up-to-date. Anne-Marie -David On Fri, Mar 2, 2012 at 11:42 PM, Vishesh Handa m...@vhanda.in mailto:m...@vhanda.in wrote: You need to update SDO, and then update kdelibs. On Sat, Mar 3, 2012 at 6:20 AM, David Boosalis david.boosa...@gmail.com mailto:david.boosa...@gmail.com wrote: Sorry if this is the wrong group to ask this question, please refer me to the right group if you know. The issue is kde-runtime from master. I've been getting the following compile error for about a week now. /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp: In member function ‘QByteArray Nepomuk::ResourcePageGenerator::generatePage() const’: /home/david/kde/src/KDE/kde-runtime/nepomuk/kioslaves/nepomuk/resourcepagegenerator.cpp:204:36: error: ‘depiction’ is not a member of ‘Nepomuk::Vocabulary::NFO’ David On Fri, Mar 2, 2012 at 9:58 AM, Lamarque Vieira Souza lamar...@kde.org mailto:lamar...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/ Review request for kdelibs. By Lamarque Vieira Souza. Description Currently kdeclarative library does not install the KDeclarativeConfig.cmake and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative. In the current situation any KDE program that want to use it set the kdeclarative name hardcoded into CMakeLists.txt, which is not ideal. This patch fixes that problem. Diffs * experimental/libkdeclarative/CMakeLists.txt (0db647c) * experimental/libkdeclarative/KDeclarativeConfig.cmake.in http://KDeclarativeConfig.cmake.in (PRE-CREATION) * experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in http://KDeclarativeConfigVersion.cmake.in (PRE-CREATION) View Diff http://git.reviewboard.kde.org/r/104140/diff/
Re: Please avoid noisy merge commits in frameworks
On 02/19/2012 04:58 PM, Stephen Kelly wrote: Stephen Kelly wrote: Hi there, I was reviewing the changes in the frameworks branch from yesterday. Something I noticed was that there are a lot of merge commits that don't need to exist. Ugh. Yet more of this just appeared... Recent history in the frameworks branch looks far more complex than it is and is harder to follow. There are too many people unaware that they're doing it maybe... Yeah I notice I did it :( It happened yesterday because we were new people (which was very good) working on frameworks and not all of us are 100% used to git yet. I did git config branch.autosetuprebase always which should always rebase. I guess I should get used to using gitk. Anne-Marie
Re: Top 15 Mailinglists with messages in moderation May 1st
On Sunday 01 May 2011 16:00:57 Tom Albers wrote: Hi, New month, new list. If lists are unused, let me know, I will delete them. If someone wants to help with moderation for any of these list, let me know as well. 19 kde-france-ca Where can I see archives of that list and its purpose? Anne-Marie
Re: Introducing libmediawiki
On Saturday, March 19, 2011 11:47:45 AM Alexandre Mendes wrote: Hello, We worked on a library, libmediawiki, to interface the MediaWiki API with Qt, which is a part of the project silk. Also we have produce two new widgets and a kipi plugin to export images to commons.wikimedia.org. They use our library . We think our work can interest some kde developpers and we want to know if you can introduce it in your release schedule. You can find our work at the same place as project-silk. https://projects.kde.org/projects/playground/base/silk/repository/revisions /master/show/mediawiki Best regards, The IUP ISI Team. Hi, Do you want to include the lib in kdelibs? If so, you need to explain what the lib does and list what projects can use this. Also you need to ensure all files have a proper licence header. What I suggest is: - make a list of projects that could use your lib - precise where you want this to be added to (kdelibs, extragear,..) and what it does - add your lib to kdereview so developers can test it Additional question: will you maintain this code after your university task is finished? Best regards, Anne-Marie PS: probably kdeedu can use it as well as Picture Frame applet, both projects I am involved in. But you need to clarify what your lib exactly can do!
Review Request: In System Settings in French the icon's description is badly cut when there is a single quote
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6106/ --- Review request for kdelibs. Summary --- Patch to address https://bugs.kde.org/show_bug.cgi?id=257988: in French in System Settings the icon's description string is badly cut when there is a single quote. Unit tests added for the whole method (by Fredrikh) and for the specific single quote by me. Should go in 4.6 so please any kde-core devel review! Thanks Diffs - trunk/KDE/kdelibs/kdecore/tests/kstringhandlertest.h 1205827 trunk/KDE/kdelibs/kdecore/tests/kstringhandlertest.cpp 1205827 trunk/KDE/kdelibs/kdecore/text/kstringhandler.cpp 1205827 Diff: http://svn.reviewboard.kde.org/r/6106/diff Testing --- Tested in French, fixes the bug. Thanks, Anne-Marie