Re: New repo in kdereview: plasma-settings
Forwarding message, since had wrong reply to address in previous message - Forwarded message from Bhushan Shah - Date: Mon, 15 Feb 2021 11:44:14 +0530 From: Bhushan Shah To: Harald Sitter Subject: Re: New repo in kdereview: plasma-settings On Mon, Jan 25, 2021 at 03:29:18PM +0100, Harald Sitter wrote: > On 25.01.21 08:05, Bhushan Shah wrote: > > Hello everyone! > > > > I want to move plasma-settings repo to kdereview, it is settings > > application used by the Plasma Mobile, it is based on Kirigami. > > > > https://invent.kde.org/plasma-mobile/plasma-settings > > > > Main difference between plasma-settings and original system settings > > application used in plasma desktop is, this code is much more lean and > > modern, it is my understanding that long term idea is to replace the > > original systemsettings code base with plasma-settings. But for now this > > is mobile specific. > > kpackage is very grumpy during cmake stage > > no appstream data :( > > Not sure if intentional but ModulesModel actually doesn't constrain to > settings KCMS. It'd also display info center kcms as well as (I think) > plugin KCMS (e.g. krunner's) It is not intentional, but thinking about this I think it is fine, we are filtering them out based PLASMA_PLATFORM anyway. > not installing a hicolor icon We are reusing system settings icon from theme anyway, so not sure if I need to install something? > I am pretty sure l10n isn't working. I can't see the translations domain > set anywhere (mind you, kcms likely work; --help might now) src/main.cpp sets the translations domain to plasma-settings, but that said, it is wrong, it should be mobile.plasma-settings, will fix it. > Along a similar note the package/ dir isn't covered by a Messages.sh and > consequently isn't actually i18n'd. I suggest moving package into src/ > and the main Message.sh into src/ as well and let it cover everything > inside. It'd clarify extraction responsibility somewhat. Done that, 796bba52ae04559fe19465455e3446bc20819711 > might be worth making the source reuse compliant Done : a59007f383308503e59498b3036e1483bca26e35 > some qml file lack license information (KCMContainer.qml, info's > main.qml at least - would be easier to check if the source was compliant ;)) https://invent.kde.org/plasma-mobile/plasma-settings/-/merge_requests/79 > > I am very certain that lots of code inside modules/info/ was copied from > kinfocenter's about-distro but lacks any attribution to its original > authors *cough* including your's truly Done: 21715b762e8399555e2c9ad3b02f163d7c30153f > > password module has copies of org.freesktop.Accounts*xml at a glance > they are installed by accountsservice, you could just use the installed > versions instead of holding a copy > > HS > -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D - End forwarded message - -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: New repo in kdereview: plasma-angelfish
On Mon, Jan 25, 2021 at 02:56:39PM +0100, Harald Sitter wrote:
> On 25.01.21 06:55, Bhushan Shah wrote:
> > Hello everyone!
> >
> > Yet another Plasma Mobile repository in kdereview:
> >
> > https://invent.kde.org/plasma-mobile/plasma-angelfish
> >
> > Plasma Angelfish is browser written in Kirigami which uses the
> > QtWebengine for rendering web pages. It is optimized for the mobile
> > usecase.
> >
> > Current feature list is available in README.md of the repository.
>
> Not sure I am liking the InitialPreference in the desktop file.
>
> Encoding in desktop files has been deprecated for like a million years ^^
Fixed in 0d598a916c913a78927985dedc1ef55b033de525
>
> Inconsistent spelling between desktop file "Web Browser" and appstream
> file "Webbrowser". I also think the former is the way one generally
> spells it.
>
> .appdata.xml is a legacy suffix, you might want to use .metainfo.xml
Fixed in 83ddac3ba877e9e4f80e4d8641871e73dc22adfa
> Same as with phonebook, I don't see the translation domain getting set
> anywhere and by extension l10n is likely kaput.
Fixed in b284b48ed48e771e94e0062f7afa567a67fca550
> Inside SettingsNavigationBarPage.qml there's a concatenated multi line
> string, I'm not sure if that'd get extracted correctly for l10n. Best check.
In next thread i18n people confirmed that this is fine.
> Many files don't have license info, see point 15 of the license policy
> [1] :(
>
> You may want to move from the incomplete COPYING file to reuse LICENSES/
> folder.
Fixed in : 8bf8afdd3ad9777acd2762e561c9959a7e09bc66 and
e72270b50dad3db109270c99a9b1e88909f4ffa0
> DesktopFileGenerator manually calls kbuildsycoca :O - This should just
> work and if not get fixed properly. Super alternatively
> KSycoca::self()->ensureCacheValid() is exactly made for this use case.
>
> The flatpak run inside DesktopFileGenerator seems super opinionated, but
> with the only target system being plasma-mobile I guess it doesn't matter?
Those are only used if the angelfish is running as a flatpak app, if
not, it would use standard angelfish-webapp command.
>
> The message("warning:" in src/CMakeLists.txt ought to be
> add_feature_info() really [2]
Fixed in e38e8b1b2ac5c487c587f5af708757b27eae9db0
>
> [1] https://community.kde.org/Policies/Licensing_Policy
> [2] https://cmake.org/cmake/help/v3.8/module/FeatureSummary.html
>
> > Before moving it to extragear I would like to drop plasma- prefix from
> > the repository as this repo have nothing much to do with "Plasma". And
> > it is otherwise already called just "Angelfish" in its desktop files and
> > stuff.
> +1
>
>
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
Re: New repo in kdereview: plasma-phonebook
Hello, On Mon, Jan 25, 2021 at 02:18:51PM +0100, Harald Sitter wrote: > On 25.01.21 06:48, Bhushan Shah wrote: > > Hello everyone! > > > > I am back with more Plasma Mobile related repositories in kdereview. I > > want to move plasma-phonebook in kdereview. plasma-phonebook is kirigami > > based phonebook application, it uses kpeople backends like kpeoplesink, > > kpeoplevcard, kpeople akonadi backend etc to fetch and store contacts on > > your system. > > I am pretty sure l10n isn't working. I can't see the translations domain > set anywhere. https://invent.kde.org/plasma-mobile/plasma-phonebook/commit/98d768493ab7ab1360d454983bb99e339751d91c > On the subject of strings I'd suggest checking them all for HIG > compliance. In main.qml alone all strings are wrong as titles and > buttons are supposed to use Title Capitalization > https://hig.kde.org/style/writing/capitalization.html https://invent.kde.org/plasma-mobile/plasma-phonebook/-/commit/a89acbfc9e4227a7cf0d91f5ecdee8cf105710f8 > > The desktop file seems to be lacking an actual main category (it's in > the lost section in the launcher for me) > > What's the use case for the unregistered x-plasma-phonebook mimetype > (registered for by the desktop file)? Perhaps the more relevant question > is why would it should be unregistered instead of inside our vendor tree > (vnd.kde.phone.book or some such)? https://invent.kde.org/plasma-mobile/plasma-phonebook/-/commit/e7c1e54d71d0c3cdd36950d0f8b326df44aca115 > > Many files don't have license info, see point 15 of the license policy > [1] :( > > Actual qml **source** files have no license info! Licensing is being sorted out as I write this email. I will reach out to Fabian, original author of some of these files for clarification > > DetailListItem.qml isn't used. https://invent.kde.org/plasma-mobile/plasma-phonebook/-/commit/4add44d12f9d43ab4f8eba181f3ad5b681429dc6 > > Are we quite sure that hardcoding colors is the way to go? :O > > Header.qml actually has a crash for me because ColorOverlay is inside a > FastBlur that is both parent and source (qt docs about source: "Note: It > is not supported to let the effect include itself, for instance by > setting source to the effect's parent.") > > Similarly the FastBlur looks to be falling into that trap of > parent===source, albeit not crashing for me. This needs looking into. > > Spelling is inconsistent. The desktop file spells it "Phone Book" the > appstream file spells it "Plasma Phonebook". > > .appdata.xml is a legacy suffix, you might want to use .metainfo.xml > instead. > > On the subject of the appstream file. Missing > KDE :( https://invent.kde.org/plasma-mobile/plasma-phonebook/-/commit/27a94cdda11ecc5b6ed0269917a2643d5f632518 > > # Probably a bit nitpicky > > Failing to store contact changes in AddContactPage lacks actual UI > backing, it merely qwarns. > > Various single argument ctors aren't tagged `explicit`. https://invent.kde.org/plasma-mobile/plasma-phonebook/-/commit/1007e7b2f0c916bdf9f74b2ae63a8d494cd807c9 > > [1] https://community.kde.org/Policies/Licensing_Policy > > > Another thing I want to discuss is, branding, currently it is named as > > Plasma Phonebook which is bit awkward because Plasma is not related to > > app at all and even android port for app exists. Maybe we should name > > this just phonebook? > > Is this about the repo/tarball name or the display string? > > The former already lacks the plasma prefix in the .desktop file, I'd > argue the appstream name should do the same. System Settings is a > precedent for something similar. > > As for tarballs: some distros get grumpy over overly generic source > names, so while I think phonebook is fine it may be less fine for > distros. It probably matters little what the repo/tarball is called though. > > HS > -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
New repo in kdereview: plasma-settings
Hello everyone! I want to move plasma-settings repo to kdereview, it is settings application used by the Plasma Mobile, it is based on Kirigami. https://invent.kde.org/plasma-mobile/plasma-settings Main difference between plasma-settings and original system settings application used in plasma desktop is, this code is much more lean and modern, it is my understanding that long term idea is to replace the original systemsettings code base with plasma-settings. But for now this is mobile specific. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
New repo in kdereview: plasma-angelfish
Hello everyone! Yet another Plasma Mobile repository in kdereview: https://invent.kde.org/plasma-mobile/plasma-angelfish Plasma Angelfish is browser written in Kirigami which uses the QtWebengine for rendering web pages. It is optimized for the mobile usecase. Current feature list is available in README.md of the repository. Before moving it to extragear I would like to drop plasma- prefix from the repository as this repo have nothing much to do with "Plasma". And it is otherwise already called just "Angelfish" in its desktop files and stuff. Cheers. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
New repo in kdereview: plasma-phonebook
Hello everyone! I am back with more Plasma Mobile related repositories in kdereview. I want to move plasma-phonebook in kdereview. plasma-phonebook is kirigami based phonebook application, it uses kpeople backends like kpeoplesink, kpeoplevcard, kpeople akonadi backend etc to fetch and store contacts on your system. Another thing I want to discuss is, branding, currently it is named as Plasma Phonebook which is bit awkward because Plasma is not related to app at all and even android port for app exists. Maybe we should name this just phonebook? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: plasma-mobile/spacebar in kdereview
Hello, I have fixed the i18n issue with the spacebar, and crash fix was committed by the JBB, Since it has been in kdereview for month now, I will proceed to move this to extragear and prepare 0.1 release of it. Thanks! On Thu, Dec 17, 2020 at 06:02:20PM +0530, Bhushan Shah wrote: > Hello everyone! > > Yet another Plasma Mobile app I would like to put in kdereview, spacebar > > spacebar is SMS app, it mainly consists of the two parts, > > - spacebar observer > - spacebar client > > spacebar observer is DBUS activated service which can watch for > incoming/outgoing telepathy messages and adds them in database, spacebar > client is what users interact with to check the incoming messages and > send outgoing messages. > > Similar to plasma-dialer, to test this you need ofono phonesim and > telepathy-ring or telepathy-ofono. > > Cheers! > > -- > Bhushan Shah > http://blog.bshah.in > IRC Nick : bshah on Freenode > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
plasma-mobile/spacebar in kdereview
Hello everyone! Yet another Plasma Mobile app I would like to put in kdereview, spacebar spacebar is SMS app, it mainly consists of the two parts, - spacebar observer - spacebar client spacebar observer is DBUS activated service which can watch for incoming/outgoing telepathy messages and adds them in database, spacebar client is what users interact with to check the incoming messages and send outgoing messages. Similar to plasma-dialer, to test this you need ofono phonesim and telepathy-ring or telepathy-ofono. Cheers! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
plasma-mobile/plasma-dialer in kdereview
Hello everyone! We would like to move plasma-mobile/plasma-dialer in kdereview, note that currently it is in "extragear" but it seems to me that initial import of code back in 2015 was mistake and by mistake it was imported to extragear directly instead of the playground. plasma-dialer is dialer application for Plasma Mobile. It is basically telepathy client with two parts, approver and dialer client. To test this on local system if you want you need ofono-phonesim and telepathy-ofono or telepathy-ring. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Git merge workflow: reverse it?
Hello everyone! At plasma, we are experimenting with new workflow regarding how bugfixes are put on the stable branch [1]. # Previous workflow - Current workflow is that we commit to stable branch and then merge it upwords until master branch - i.e commit to Plasma/5.18 branch, merge 5.18 into 5.19 and then master # Current workflow - Proposed workflow is to instead commit all changes in master, and cherry-pick related changes in the stable branch as needed - We had been using this workflow for about 1 month now and I'd say it is working nicely for us. # Why? We occasionally hit several issues with previous workflow, - Merge conflicts when merging changes upwords - Changes which are valid only for stable branch needs to be reverted in master branches. So you end-up with, stable-fix, revert of stable fix and then different fix and overall weird history. - Accidential merges from the master branch to stable branch which needs to be force-resetted. - It's worth noting that Qt also recently changed to merge to dev, cherry-pick backwards. - This also allows for workflows where we want to commit some bugfix in the master branch for few days/weeks and if it works fine in general testing then, cherry-pick it in stable branches. Proposal is to probably adapt this policy kde-wise if people feel that advantages are worth it. Thanks [1] https://mail.kde.org/pipermail/plasma-devel/2020-June/117887.html -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Gitlab Turn-off Issues
On Mon, Jun 29, 2020 at 12:59:37PM +0200, Kevin Kofler wrote: > The thing is, GitLab is also not particularly open to external > contributions, in particular, they are not going to add features to the > Community Edition that they deliberately omitted, and if you submit a new > feature, they can also decide to restrict it to enterprise customers. May I please suggest to make public statements which have the facts backing to it? Because that statement is not correct and have zero backing to it. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Namespaces for a few repositories on invent (was Re: Migration to Gitlab -- Update)
On Sun, May 10, 2020 at 02:54:35PM +0200, Luigi Toscano wrote: > I went through the list of the new structure, and I can only imagine the work > needed to reshuffle > Am I still on time to propose some fine tuning? Sure, feel free to make suggestions on final place of items on structure > == Proposed moves: > kio-upnp-ms: applications -> network > mark: applications -> education > kdecoration-viewer: applications -> sdk > kolorfill: applications -> games > klook: applications -> graphics > peruse: applications -> graphics done! > == A bit more open questions about: > libkdegameai: libraries -> games (like libkdegames) done! > macports-kde: sdk -> packaging (not 100% sure) this kinda looks unmaintained to me, last commit is in 2014/15, and otherwise seems untouched, should unmaintained be better place for this? > kup: system -> utilities (like kbackup!) Good that we have backup for backup applications , anyway would it make sense to move this otherway around? (kbackup -> system?) I kind of consider backup "system"/"core" stuff... > mangonel seems a bit of place too in system (which has mostly lower-level > configuration stuff), maybe utilities? done! > > == There are a few second-level namespaces, are we going to keep them? I can > see: Thanks for noticing the second-level namespaces, I completely overlooked it seems > * graphics/digikam/ > - it only contains digikam-doc, which should maybe just go under graphics/ > * graphics/libs > - a few libraries which be moved under graphics/ directly (or libraries, but > they are graphics-related) > * network/telepathy > - only telepathy-logger-qt, it could go under network/ directly I've flattened these ones. > * others/kde-edu-courses/ > - why not directly under education ? I guess it can go into education, but looking at content I am more inclined to think that this belongs into unmaintained, aren't those applications instead using the GHNS? I am not even sure where this content is hosted if at all (seems to have .php files in there) > Also unmaintained/ contains two of them (necessitas, strigi), but it doesn't > matter much I guess. I've flattened necessitas and strigi. > Ciao! > -- > Luigi -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Migration to Gitlab -- Update
Hello, On Sun, May 10, 2020 at 01:20:23PM +0200, Johan Ouwerkerk wrote: > On Sun, May 10, 2020 at 9:49 AM Ben Cooksley wrote: > > > > Following lengthy discussion in the original thread, it was agreed > > that the original sysadmin proposal of various categories would be > > implemented, with repositories organised according to that structure. > > > > You can find this documented at > > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent > > > > -- Conclusion -- > > > > Should anyone have any questions regarding the above, please let us know! > > > > Just to confirm, by documented you mean that the layout of the various > `metadata.yaml` files indicates what the layout of the repositories > will become? Becuase looking at Keysmith for example, it seems that > the metadata repopath has not been updated yet: > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent/utilities/keysmith/metadata.yaml?h=bshah/invent Yes, that is correct, currently directory structure is what will be final structure, repopath and other bits will migrated all at once when actual move happens -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Information regarding upcoming Gitlab Migration: clarifications
Good afternoon, [Please keep sysad...@kde.org list or bs...@kde.org in the CC for replies] I want to clarify some bits for which we have gotten a questions about, - Non unique naming: There's some teams which prefer if we dropped the namespace- part from their name which we have added. While currently this does not result in the naming conflict right away, we realize this will cause it at one point, for example, maui-dialer -> maui/dialer plasma-dialer -> plasma-mobile/dialer To minimize the impact of the Gitlab move we won't be doing such renames which introduce non-unique names right away. But we would prefer if the existing tooling or infrastructure is ready for this kind of cases at later point. Only way to enforce non-unique naming is one big KDE/ subgroup which we want to avoid. Current naming in the repo-metadata branch[1] I've pointed does not reflect those renames, as we are not planning to do those renames right away during gitlab move, but at a later stage. - Existing configurations: we want to reduce impact on existing release schedule, and existing developer workflow, therefore we will continue to privide the existing anongit.kde.org and git.kde.org (although this will be read-only) with current flat structuring for 3 weeks after actual migration, which will keep the existing scripts/clones working enough to give developers time to change to the new structure. We will also try to provide a script which allows you to migrate your existing clones to new repo paths and as mentioned by Ben in other message, potentially a git-kde script which would allow you to clone individual repository without knowing it's namespace (provided that there is no conflict of it's name). like "git kde karchive" - Translations: we will co-ordinate with the translations team to let them adapt their tooling to updated structure as this requires changes on their side how translations are stored in svn repository Thanks! [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Information regarding upcoming Gitlab Migration
Hi Adriaan, On Tue, Apr 28, 2020 at 01:08:33PM +0200, Adriaan de Groot wrote: > A tool-like actor that I don't think has been mentioned so far is "existing > checkouts". I have a src/kde with all the bits I've looked at "recently". > There may even be some SVN checkouts there -- I'm willing to forget about > those. Surprising and annoying me every time I update those sometime in the > future is not good, but it's only going to annoy me once (per repo, so at > most > 143 times for my clones). We have a plan to provide a script which can change remotes in existing clones. (It would take a top-level directory path for all your clones). > Perhaps it's the "old school", but kdesrc-build doesn't do anything for me. > I'm intermittently interested in the source of some random part of KDE -- > generally because it's mentioned on IRC -- and then I need that source where > I > can look at it. Whether it's 'git clone' or 'kdesrc-build --just-the-source- > please' doesn't matter much. > > If there's any compiling to be done, the less magic there is between me and > the compile, the better. > > So, yeah: `git clone kde:x` all the way, but I'm also not really invested in > the structure of the label x, or the precise configuration of kde:. > > > > Now, if a simple(ish) script can be created to make > > something akin to the kde: rewriting work, even if what it really does is to > > search gitlab and create a clone with the appropriate command, i could deal > > with that, but having the ability to simply ask for the project name is > > more than a little useful. > > I think we shouldn't underestimate how names are a social construct, though: > the current flat structure comes after a structured SVN naming epoch. But I'd > totes +1 a search-and-redirector, especially if it means I can write `git > clone kde:peruse` and the resulting .git/config has followed the redirects > and > whatnot and ended up with `url: kdeforreal:audio/peruse` One thing to remember is, you can't really have a dynamic insteadOf URL setup. Besides, even if we had a everything under KDE namespace I'd find a setup for this weird enough. Let's assume that everything is under invent.kde.org/kde (and invent.kde.org/sysadmin and invent.kde.org/websites as it is right now). Now you add a following snippet in gitconfig, [url "https://invent.kde.org/KDE/;] insteadOf = kde: [url "g...@invent.kde.org:KDE/"] pushInsteadOf = kde: Which is slightly modified version of the existing kde: URL helper shown here, https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes Now this is perfectly fine for the something which is kde/ so you can do git clone kde:krita and it would happily replace 'kde:' part with 'https://invent.kde.org/KDE/' and would clone 'https://invent.kde.org/KDE/krita' But, now things get interesting when you want to clone the docs-krita-org which is in the websites/ namespace. We will have to keep this things in separate namespace for policy reasons (and same goes for sysadmin stuff). How would you clone docs-krita-org? git clone kde:../websites/krita-org ? add a separate prefix for websites and sysadmin? Let's assume that you added snippet for sysadmin and websites, it's just 8 more lines after all, [url "https://invent.kde.org/websites/;] insteadOf = websites: [url "g...@invent.kde.org:websites/"] pushInsteadOf = websites: [url "https://invent.kde.org/sysadmin/;] insteadOf = sysadmin: [url "g...@invent.kde.org:sysadmin/"] pushInsteadOf = sysadmin: Does this solve all use-cases? I believe no, it still does not support the personal repositories of users. So you also need to add 4 more lines for your own user, and 4 for each user whose repository you want to clone. What our workflow with the kde: prefix so far had been really useful I agree, and I will miss it, but with departure of gitolite which allowed repositories at top-level, we can't easily support this, and we have to accept it. Perhaps solution suggested by Ben in his email could be useful instead and in addition generic invent: snippet which does not include any namespace. [url "https://invent.kde.org/;] insteadOf = invent: [url "g...@invent.kde.org:"] pushInsteadOf = invent: > (That said, bigflatlistofrepositories.kde.org .. or maybe call it > cgit.kde.org > .. could be a particular view onto gitlab which does flattening and search, > but only if there's people around to create it and maintain it) Just to clarify, sysadmins have no plan to support or maintain the cgit instance once we migrate to Gitlab. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Information regarding upcoming Gitlab Migration
Hi Olivier, On Mon, Apr 27, 2020 at 10:49:46PM +0200, Olivier Churlaud wrote: > >Because in order to search for something, you need to know it exists. > > > >If you are just casually browsing, then the search can't help you. > > I don't think people casually browse our repos. What use case is more likely > to happen and do we want to support? We don't really want to discard use-cases just because it does not suit our workflow. That is not how we are going to gain new contributors, we should value each contribution, be it drive-by contribution, or focused contribution towards one single project. > Use case 1 : Jerry learns about KDE and go in their forge in the Multimedia > section. After carefully reading the code of two applications and three libs > he starts contributing to Elisa. > > Use case 2 : While using her Ubuntu installation of Elisa / while reading on > reddit about Elisa, Jerry decides to try to contribute to this project/fix > this bug that itches her and searches for it in KDE's forge. Let me add a some more usecases, some of which I've been dealing with in project I maintain. Use case 3 : Tom comes in Plasma Mobile channel and asks for Plasma Mobile applications source code Use case 4 : Tom is a student in Germany and is interested in contributing to wikitolearn, and he asks where can I find code of the wikitolearn? Suggestion offered by sysadmin team does not cater to one single use-case, but offers a way to provide a solution to all 4 usecases. For Plasma Mobile team or Wikitolearn team it would be much easier to refer contributors to the https://invent.kde.org/plasma-mobile or https://invent.kde.org/wikitolearn then tell them to go to https://invent.kde.org/KDE and search for the tag wikitolearn or Plasma Mobile. > On the other hand, I think the discussion about spotting open merge requests > (in a derived thread from this one) should be answered, being by relevant > tags, subgroups or whatever. (super personal note) Ironically, Usecase 1 is how I started contributing to KDE 7 years back. While I was inspired by battery monitor re-design in 4.11 release, I wanted to work on "something" so I did literally browse through various repositories to find something where my technical capabilities were enough to work on [1]. Back then it was projects.kde.org (chiliproject installation). [1] https://blog.bshah.in/2013/09/01/hello-planet/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Information regarding upcoming Gitlab Migration
Hi Nate, On Mon, Apr 27, 2020 at 07:45:23AM -0600, Nate Graham wrote: > Trying to categorize everything into a single group cannot succeed because > many projects could logically belong to multiple groups (e.g > plasma-framework is a framework that's a part of Plasma; Discover is an app > that's a part of Plasma; kdenetwork-filesharing and kio-extras are libraries > that are distributed via the apps release service). I foresee endless > pointless arguments about the best group for something to live in. I've agreed in previous threads that sometime our grouping is not perfect, but this is something we can improve instead of throwing idea of grouping out altogether. > Let's step back: do we have to put every repo inside a group in the first > place? Is it solely so you can look at a nice list of all open merge > requests for PIM/Frameworks/etc? If so, perhaps this workflow could be > approximated with tags instead or group assignments instead No goal is not just that you get nice list of all open merge requests or issues. Main goal is we want to offer user or potential contributors a list of closely related projects instead of list of all 1100+ projects we have. That would mean, If user wants to see all frameworks, or graphics applications, or multimedia applications, they can. The workflow, with labels you mention is trying to achieve a totally different goal then what we are trying to solve here. Labels/Tags are for sorting issues, and/or merge requests. They can't be reliable solution for the sorting of the multiple repositories. On technical side, Gitlab does not offer labels for projects, but setting called topic. You can see that in screenshot[1] linked. Besides, from home page there's no way to filter something for e.g "Graphics". nore project listing shows the tags alongside of the project names, also making use of this tags means that if user clicks this tags, what they are offered is *all* the repositories including forks of the repositories, which means when you search for graphics [2], you get many duplicative results and this is really not something discoverable. > We create many very granular groups for the purposes of organizing teams and > and performing code review (e.g. Plasma, KWin, Frameworks, PIM, Krita, > Dolphin, Okular, VDG, etc.) and then every new merge request could receive a > tag or assignee corresponding to its relevant code review groups (e.g. merge > requests for kio and kio-extras could get get tagged with both "Frameworks", > and "Dolphin"; plasma-frameworks MRs could get tagged with both "Plasma" and > "Frameworks", and so on). As explained above, while grouping repositories is trying to solve the merge requests/issue organization, it is not sole purpose of the suggested grouping, discoverability and reachability is the main issue we are trying to solve here. [1] https://i.imgur.com/h1L1A5H.png [2] https://i.imgur.com/ajOszEL.png -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Information regarding upcoming Gitlab Migration
Hi Ingo, On Mon, Apr 27, 2020 at 03:46:13PM +0200, Ingo Klöcker wrote: > > > I'm sorry, but I don't think that this is solved by your proposal for the > > > KDE PIM projects because not everything related to KDE PIM (e.g. relevant > > > frameworks like kcontacts, kholidays, kpeople and soon kdav) will be in > > > the same group. The same is true for any project which uses some > > > frameworks, e.g. graphics and the imageformats framework or whatever > > > group kate and kwrite are going to end up in and the ktexteditor > > > framework. > > > > This is something which can be easily solved by Gitlab, Gitlab offers a > > solution where project can be shared with another group. > > > > So e.g. sharing kcontacts with kdepim should be possible, then all merge > > requests/issues from kcontacts would show up under pim as well. > > Great. So we could put all repos into an "all" group (e.g. rename kde to all) > and then have every subcommunity decide for themselves which repos they want > to see in their group. No, sadly this does not work, I just tested this, I have two different groups here - https://invent.kde.org/sysadmin/test/test1 - https://invent.kde.org/sysadmin/test/test2 test1 have a repo called foo under it, which is shared with the test2 group. When someone visits test2, they are not offered the list of the shared repositories but they are instead offered the empty page. One have to click on Shared repositories tab to actually see the list. https://invent.kde.org/groups/sysadmin/test/test2/-/shared This defeats the purpose of the creating subgroups (offering easy reachability). -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Information regarding upcoming Gitlab Migration
In part I am mostly re-iterating what Ben already mentioned in different messages. On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > Does this mean that to clone it we'll have to go "git clone > kde:games/knetwalk" or something along the lines? Yes [Rest of message is with sysadmin hat off and as a developer] > If that's the case I'd much prefer if we didn't do this, at the moment > it's already uncomfortable for me to remember the URL for some of the > repos (e.g. is it sysadmin/ or not?), this will only increase the > problem and I personally don't see the advantage. I do agree that it maybe small inconvience, but let's be honest, most of us have been using kdesrc-build or some kind of automated tooling for building everything, apart from very rare case we never have to manually clone any of KDE repository, at least it is true for me personally. I am not sure about others. [Very non-scientific test, I did "history | grep 'git clone kde:'" on my machine and only instances were 4, websites/conf-kde-in, kde-build-metadata, sysadmin/irc-notifications, sysadmin/binary-factory-tooling, rest was automatically downloaded by the kdesrc-build] Anyway, getting back on topic, while this option gives some initial setbacks in our own personal workflow, let's look at bigger picture. Let's say I am the new developer who wants to contribute to frameworks. One of reason we are switching to gitlab is better onboarding, current state is that we have cgit.kde.org as a repository browser. By default I open it, I get the sorting by name, first repository is abakus. Commits as old as 14 years(!), after that some more mix of unmaintained repositories and scrolling almost 1.5 page, I get greeted with baloo, first framework in whole list. Let's just assume that name based sorting is bad idea, and we sort by activity instead. Here I get much better results, first framework is solid. But at same time if I was looking for SDK, kdevelop would appear at 3rd scroll-page. Here cgit is able to show many items in single scroll page, you can be assured that on gitlab it would not show kdevelop in first 6-7 pages. You might wonder why search does not help here? So problem with search is you need to know what you are looking for[*], but drive-by contributors, or users who are simply browsing our repositories won't know what they are looking for, they are simply trying to find a thing that interests them. Giving them categories/groups allows them to focus on topic they like and they can contribute to. > e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is > krita graphics or its own thing? I agree that categories are something which we can improve upon, but this is something which we can improve upon, rejecting idea of categories just because 7-10 repos are at wrong place is ultimately not going to do anything good. > I really prefer when I don't have to guess this kind of things when > fetching a repository. [*] Ironically, in your case search would be helpful as you know you are looking for knetwalk so you can just add it and search it -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Information regarding upcoming Gitlab Migration
[Please keep sysad...@kde.org list or bs...@kde.org in the CC for replies] Hello Community members, In view of upcoming Gitlab migration, we sysadmin team wants to share the recommended structuring for the repositories on Gitlab. We had multiple options, - Flat structure: In this option we would have everything under one single namespace/group: https://invent.kde.org/kde/knetwalk - Subgroups under top-level group: In this option we would have a groups under KDE namespace: https://invent.kde.org/kde/games/knetwalk - Groups at top level: In this option we would establish a series of groups at the top level, e.g. https://invent.kde.org/games/knetwalk We have discussed this with small but representative group of contributors or maintainers, and based on their suggestions, we recommend that we go with option 3. Having sub-groups at top level will allow us to, - Provides good visibility on all reviews, tasks and other items within the groups/modules we define - Provides improvements to discoverability of projects - Makes it possible for groups of projects to establish a group level task board should it fit their needs (for tracking a release for instance) - Makes the most semantic sense, as the ‘KDE’ top level group suggested in option 2 is duplicative considering the Gitlab instance is under kde.org. - The discoverability of projects is maximised, as there is no need to open the top level ‘KDE’ group before going into the subgroup. I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. If we don't have any objections we would like to implement this next week and move projects to https://invent.kde.org. Thanks! Bhushan for sysadmin team [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Moving several repositories in kdesupport to unmaintained
Any objections to moving following out of kdesupport to unmaintained? - automoc - emerge - emerge-history - libqzeitgeist - soprano - strigi All of this is kde4 based our outdated Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Move kimagemapeditor to kdegraphics
In effort to tidy up the various categories, I want to propose moving the kimagemapeditor to kdegraphics, from kdewebdev. (Reasoning behind this is kdewebdev is cateogory with single repo, everything else is moved elsewhere, so would be nice to tidy this up) Do anyone have any objections to this? -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Move some out-of-date bindings to unmaintained
There's some out-of-date bindings in the kdebindings, - kimono - qyoto - qtruby - korundum - perlqt - perlkde - smokeqt - smokegen - smokekde - pykde4 Most of this are still based on Qt4, and does not have commits in say last 4 years, there's also pykde5 but I don't know if is maintained? Anyway, any objections to me moving following to unmaintained? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Keysmith in kdereview
Hi everyone! On Sun, Jan 12, 2020 at 02:43:16PM +0100, Johan Ouwerkerk wrote: > Keysmith has been in KDE review for over three weeks, so unless there > is urgent new feedback that leaves the question: what is next? > > Thanks again for all your help and feedback making Keysmith much better! Since there has been no other objections, I will move the keysmith into extragear today. Cheers! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Keysmith in kdereview
Hello everyone! Keysmith (https://invent.kde.org/kde/keysmith) has been moved to kdereview. Keysmith is a Two-factor code generator for Plasma Mobile and Desktop and is using oath-toolkit for this purpose. User interface is written in the kirigami. Thanks! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
plasma-nano and plasma-phone-components are now in kdereview
Hello! plasma-nano: https://invent.kde.org/kde/plasma-nano plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components Two repos have been moved to kdereview, with final intended destinition being kde/workspace. plasma-nano is a minimal shell package which other shell package can extend, while plasma-phone-components is a shell package, look and feel and several other components which makes Plasma Mobile. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Taking over maintainership of the kaccounts-* repos
Hello! At akademy we talked about the KAccounts and realized that kaccounts is unmaintained and/or Martin is not active. So I propose to take over maintainership of the following repositories. - kaccounts-integration - kaccounts-providers - kaccounts-mobile If you have any concerns/objections with this, let me know. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Downtime announcement: www.kde.org
[sending again from right address since my gmail address is not subscribed to somee lists] Hello, On Mon, Nov 05, 2018 at 11:02:43PM +1300, Ben Cooksley wrote: > > In order to allow for hardware maintenance, one of our physical > > hardware hosts will need to be shutdown for a few hours on Monday. > > This downtime will commence around 9:30am UTC and may take several > > hours. The maintenance is now completed, and as far as we are aware, all services are now back up. If you have trouble accessing any of services, please let us know over email or sysadmin ticket. Thanks! > > > > During this time a number of sites will be inaccessible, including: > > - www.kde.org > > - autoconfig.kde.org > > - docs.kde.org > > - ev.kde.org > > - freebsd.kde.org > > - hig.kde.org > > - kdesrc-build.kde.org > > - neon.kde.org > > - releases.neon.kde.org > > - networkcheck.kde.org > > - planet.kde.org > > > > Other websites within KDE.org that are dependent on resources hosted > > on those sites may also experience delayed loading times in browsers > > during this window. > > > > As some of these sites are relied upon by applications to function > > properly, those applications may experience degraded functionality > > during this time. > > > > Affected applications include: > > - Discover > > - Kaffeine > > - Kopete > > - Plasma Network Manager (when behind a captive portal) > > - Any application using GHNS > > > > In addition, any other site which is hosted by the server known as > > "olios.kde.org" will also be unavailable during this time. > > > > Apologies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Downtime announcement: www.kde.org
Hello everyone, On Mon, Nov 05, 2018 at 11:02:43PM +1300, Ben Cooksley wrote: > > In order to allow for hardware maintenance, one of our physical > > hardware hosts will need to be shutdown for a few hours on Monday. > > This downtime will commence around 9:30am UTC and may take several > > hours. The maintenance is now completed, and as far as we are aware, all services are now back up. If you have trouble accessing any of services, please let us know over email or sysadmin ticket. Thanks! > > > > During this time a number of sites will be inaccessible, including: > > - www.kde.org > > - autoconfig.kde.org > > - docs.kde.org > > - ev.kde.org > > - freebsd.kde.org > > - hig.kde.org > > - kdesrc-build.kde.org > > - neon.kde.org > > - releases.neon.kde.org > > - networkcheck.kde.org > > - planet.kde.org > > > > Other websites within KDE.org that are dependent on resources hosted > > on those sites may also experience delayed loading times in browsers > > during this window. > > > > As some of these sites are relied upon by applications to function > > properly, those applications may experience degraded functionality > > during this time. > > > > Affected applications include: > > - Discover > > - Kaffeine > > - Kopete > > - Plasma Network Manager (when behind a captive portal) > > - Any application using GHNS > > > > In addition, any other site which is hosted by the server known as > > "olios.kde.org" will also be unavailable during this time. > > > > Apologies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
PSA: Phabricator staging repositories
Hello developers, So in last few days I and Ben has been working on setting up the staging repositories for phabricator. More information on this feature is documented as part of Harbormaster documentation [1] change handoff section. To explain further, this will allow the people to push commits for review to a dedicated staging area, which opens up the new possibilities like, - Landing the changes directly from Web UI - Handing over the changes to CI systems like build.kde.org or build.neon.kde.org or binary-factory.kde.org which in turn can run the build against proposed changes and send status back to review saying "Hey! That review doesn't build" or "All Green!" Currently required changes for those two usecases is not implemented yet. But, enabling staging repository is the first step in that direction. Currently we have all pieces to enable the staging area in the repositories ready, but it is not enabled. As we think we should notify community about upcoming changes. We will be enabling this feature in upcoming week. # So how does staging repository works? When you create a diff using arcanist, what it does is, push the commit for which changes were created to tag like phabricator/diff/12345, where 12345 represents the diff ID to different git mirror of mainline git repositories on git.kde.org. The URL where this tags will be pushed is, "stag...@git.kde.org:reponame.git" One imporant thing to note is, stag...@git.kde.org won't accept the normal pushes, and for most of the developers this URL is implementation detail. You should not push direct changes to this repositories. Also, to allow non-developers to push to the staging area, we have enabled the option to upload ssh keys for the normal users. The keys added there will be synced to stag...@git.kde.org automatically allowing the non-developers to push to staging area. So in general here is what you should do, # For users who want to submit the changes to phabricator Please make sure you have your keys uploaded to identity.kde.org, you can do it by clicking on "Manage SSH Keys" option in right sidebar after logging in. # For both users and developers Make sure your ~/.ssh/config have entry for stag...@git.kde.org. Below is example from my ssh config. Host git.kde.org HostName git.kde.org User staging IdentityFile ~/.ssh/id_rsa_kde # For maintainers of projects For some reason you don't want your project to use the staging repositories on phabricator, or have any questions, please get in touch with us. PS: We are interested in getting some beta testing for this feature before we enable this changes to all repositories, if you maintain a project and if you are interested in testing this out, please mention us. PPS: I have just sent this e-mail to few lists I am subscribed to (kde-devel, kde-core-devel, kde-frameworks-devel, plasma-devel and sysadmin list) but if you think I have missed sending this to some list, feel free to forward it and please make sure to include sysad...@kde.org or me in reply. Thanks [1] https://secure.phabricator.com/book/phabricator/article/harbormaster/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: CI Requirements - Lessons Not Learnt?
On Thu, Jan 12, 2017 at 7:44 PM, Kevin Kofler <kevin.kof...@chello.at> wrote: > I don't see how it would be any more work to maintain #if FEATURE as > compared to #if 0. We've had cases of eventually no-one compiling that code, and if somebody compiles that codepath it results in complete failure or crazy bugs to debug. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
Re: apidocs page seems broken
On Mon, Feb 8, 2016 at 3:15 PM, Ben Cooksley <bcooks...@kde.org> wrote: > IOError: [Errno 2] No such file or directory: > '/home/api/dependency-information/kf5-qt5/frameworks/kdeclarative/inst/KDeclarative.yaml' > > Someone fix KDeclarative please (something in the CMake magic > generates that file), and kapidox needs hardening against improper > setup of Frameworks. > This should also have been caught in the review process! > > This is far from the first time that improper metadata has broken the > API Documentation generation requiring sysadmin to look into this. This files are generated by build jobs on build.kde.org however recently Jenkins had problem and some disks were read only or something... so this failed https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/78/console 10:05:36 Dependencies for libkdeclarative found: it will be built 10:05:36 Dependencies for KQuickControls found: it will be built 10:05:36 Dependencies for KCoreAddons QML bindings found; it will be built 10:06:15 Traceback (most recent call last): 10:06:15 File "/home/jenkins/scripts/kapidox/src/depdiagram-prepare", line 144, in 10:06:15 sys.exit(main()) 10:06:15 File "/home/jenkins/scripts/kapidox/src/depdiagram-prepare", line 129, in main 10:06:15 if prepare_one(fw_dir, dot_dir): 10:06:15 File "/home/jenkins/scripts/kapidox/src/depdiagram-prepare", line 84, in prepare_one 10:06:15 if not generate_dot(fw_dir, fw_name, output_dir): 10:06:16 File "/home/jenkins/scripts/kapidox/src/depdiagram-prepare", line 67, in generate_dot 10:06:16 shutil.rmtree(build_dir) ... 10:06:16 OSError: [Errno 30] Read-only file system: '/tmp/depdiagram-prepare-build-Jeyvqc/src/qmlcontrols/draganddrop/CMakeFiles/draganddropplugin_automoc.dir/build.make' Resulting in all this chaos.. I've triggered rebuild of kdeclarative and hopefully that will fix this. Cheers! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: apidocs page seems broken
On Mon, Feb 8, 2016 at 7:44 PM, Bhushan Shah <bhus...@gmail.com> wrote: > Resulting in all this chaos.. I've triggered rebuild of kdeclarative > and hopefully that will fix this. And wooho! seems latest run fixed this.. :-) -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: kde-build-metadata for beta branches
Hello, On Sat, Nov 21, 2015 at 4:24 PM, Jonathan Riddell <j...@jriddell.org> wrote: > Can I change kde-build-metadata to Plasma/5.5 while the branch is in > stable or will that mess up other uses of kde-build-metadata? AFAIK, yes you can change kde-build-metadata. Given its branched and Plasma/5.5 is new stable. Thanks -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: plasma-mediacenter in kdereview from extragear
Hello! On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah bhus...@gmail.com wrote: We want to move plasma-mediacenter to kde/workspace for releasing it with Plasma 5.x release cycle, Plasma media center is living room solution of plasma workspaces, it is integrated as shell package for PMC. Given the two week has been passed in kdereview and as there are no objections I will file the sysadmin request to move the repository to kde/workspace Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Review Request 121831: libksysguard: process.h: encapsulate private fields
On Feb. 21, 2015, 8:16 a.m., Hrvoje Senjan wrote: can you check what needs to be adjusted in plasma-workspace? it fails to build with your change: [ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: error: 'proc-KSysGuard::Process::command' does not have class type [ 451s] QString cmdline = proc ? proc-command.simplified() : QString(); // proc-command has a trailing space??? [ 451s]^ [ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:501:103: error: no matching function for call to 'KService::KService(unresolved overloaded function type, QString, QString)' [ 451s] services QExplicitlySharedDataPointerKService(new KService(proc-name, cmdline, QString())); [ 451s] ^ [ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:501:103: note: candidates are: [ 451s] In file included from /usr/include/KF5/KService/KService:1:0, [ 451s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:32: [ 451s] /usr/include/KF5/KService/kservice.h:580:5: note: KService::KService(QDataStream, int) [ 451s] KService(QDataStream str, int offset); [ 451s] ^ [ 451s] /usr/include/KF5/KService/kservice.h:580:5: note: candidate expects 2 arguments, 3 provided [ 451s] In file included from /usr/include/KF5/KService/KService:1:0, [ 451s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:32: [ 451s] /usr/include/KF5/KService/kservice.h:82:14: note: KService::KService(const KDesktopFile*, const QString) [ 451s] explicit KService(const KDesktopFile *config, const QString entryPath = QString()); [ 451s] ^ [ 451s] /usr/include/KF5/KService/kservice.h:82:14: note: candidate expects 2 arguments, 3 provided [ 451s] /usr/include/KF5/KService/kservice.h:75:14: note: KService::KService(const QString) [ 451s] explicit KService(const QString fullpath); [ 451s] ^ [ 451s] /usr/include/KF5/KService/kservice.h:75:14: note: candidate expects 1 argument, 3 provided [ 451s] /usr/include/KF5/KService/kservice.h:68:5: note: KService::KService(const QString, const QString, const QString) [ 451s] KService(const QString name, const QString exec, const QString icon); [ 451s] ^ [ 451s] /usr/include/KF5/KService/kservice.h:68:5: note: no known conversion for argument 1 from 'unresolved overloaded function type' to 'const QString' [ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp: In function 'QUrl TaskManager::getServiceLauncherUrl(int, const QString, const QStringList)': [ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:516:43: error: 'proc-KSysGuard::Process::command' does not have class type [ 451s] QString cmdline = proc ? proc-command.simplified() : QString(); // proc-command has a trailing space??? [ 451s]^ Gregor Mi wrote: Probably `proc-command` must be replace with `proc-command()`. I'll check that. Gregor Mi wrote: How can I find out if which branch was compiled? I assume it is the master branch. How can I find out if which branch was compiled? I assume it is the master branch. Yes its master branch - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review76358 --- On Feb. 21, 2015, 3:16 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Feb. 21, 2015, 3:16 a.m.) Review request for KDE Base Apps, Dominik Haumann, Eike Hein, and John Tapsell. Repository: libksysguard Description --- This is a follow-up to https://git.reviewboard.kde.org/r/121717/: In process.h there are several public fields which easily trigger BIC changes. This RR introduces a d-ptr. (In a separate commit I would add the .reviewboardrc file) Diffs - processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9 processui/scripting.cpp 76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0 processcore/processes_solaris_p.cpp f054df4b1e762e9cbec1ff8dea78f467b878bee0 processui/ProcessFilter.cpp ec520593fb67c777d56817f2493d40dc5ade0347
Re: plasma-mediacenter in kdereview from extragear
On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah bhus...@gmail.com wrote: Looking forward to review from community Just for record : This mail is sent to both plasma-devel and kde-core-devel, reply to kde-core-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Build dependency issues with kdesrc-build
On Sat, Jan 31, 2015 at 11:50 PM, Mathieu Tarral mathieu.tar...@gmail.com wrote: I noticed an issue with the plasmate component, which is build when you include kf5-workspace-build-include. It has a build dependency on KDevPlatform, but this component is only selected in kf5-applications-build-include. So should we move plasmate into Applications ? Or move KDevPlatform into Workspace ? Please see http://mail.kde.org/pipermail/plasma-devel/2015-January/038642.html -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: kio-extras
On Thu, Jan 22, 2015 at 4:12 PM, Jonathan Riddell j...@jriddell.org wrote: kio-extras is currently released part of Plasma 5. It's need said that it would be better to be part of applications because they're plugins used by applications and typically not by the desktop. With Plasma 5.2 about to go out shall I ask for kio-extras to be moved and if so into which module? Also related, http://mail.kde.org/pipermail/kde-frameworks-devel/2015-January/021686.html -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Review Request 116600: depend upon CMake 2.8.12
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116600/ --- Review request for kde-workspace and Martin Gräßlin. Repository: kde-workspace Description --- FindXCB requires cmake 2.8.12 and kde-workspace asks for 2.8.6 so this warning/error(?) is printed CMake Warning (dev) at /opt/kf5/share/ECM/find-modules/FindXCB.cmake:64 (message): Your project should require at least CMake 2.8.12 to use FindXCB.cmake Diffs - CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116600/diff/ Testing --- works, warning is gone Thanks, Bhushan Shah
Re: Review Request 116600: depend upon CMake 2.8.12
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116600/ --- (Updated March 4, 2014, 4:29 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Martin Gräßlin. Repository: kde-workspace Description --- FindXCB requires cmake 2.8.12 and kde-workspace asks for 2.8.6 so this warning/error(?) is printed CMake Warning (dev) at /opt/kf5/share/ECM/find-modules/FindXCB.cmake:64 (message): Your project should require at least CMake 2.8.12 to use FindXCB.cmake Diffs - CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116600/diff/ Testing --- works, warning is gone Thanks, Bhushan Shah
Re: Using kqmlgraphplugin in Plasma Next
Hello, On Fri, Jan 31, 2014 at 7:26 PM, Mark Gaiser mark...@gmail.com wrote: Porting the graph-plugin to Qt5 is likely going to take you a few days depending on how much you work on it. I already have working port of kqmlgraphplugin, (Surprise? :D) Well yes some things are not working but yes, Porting is not much effort. But after that my real problem is how Plasma applets will use it? I prepared my graph plugin with these needs in my mind. But graph plugin from sebas have somewhat different API. So will need work to match Plasma needs. And I told you earlier I don't want to work on scenegraph based solution. If someone wants to he/she is free to do and I will remove my claim from this task. It is using QAbstractTabelModel, so applets will need to create datamodel which can feed data to graph plugin. Or something different way(?). And I don't think some pure QML only applet want to pull in extra C++ based models to plot charts. So I am totally confused and diverged, I can not decide what to do? Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Using kqmlgraphplugin in Plasma Next
On Fri, Jan 31, 2014 at 7:51 PM, Bhushan Shah bhus...@gmail.com wrote: I already have working port of kqmlgraphplugin, (Surprise? :D) by working I mean I can compile it.. Not actually working.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Splitting kde-workspace and kde-runtime proposal
Hello! On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas afies...@kde.org wrote: In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with. We are going to create 2 new repos called plasma-desktop and plasma-workspace, we decided to use plasma as a prefix so in the future we can have more workspaces and desktops without being in the awkward situation of having one wrongly labeled as KDE while others are not (thinking on for example having Razorqt/lxde as part of KDE in the future). Current kde-workspace and kde- runtime will be kept for history reasons. I want to suggest something different, 1) Create two different groups named plasma-workspace and plasma-desktop like frameworks 2) Split out every component into individual repos 3) Assign repos to the related group. Advantages: 1) Easy to assign maintainer to individual component. 2) If we split only some repos, we can not mark it as part of workspace but this way we can do it. 3) More, may be? That's my humble suggestion. :) Again, this is a proposal so please! send any feedback you might have. Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Splitting kde-workspace and kde-runtime proposal
Hello! On Tue, Jan 21, 2014 at 3:35 PM, Antonis Tsiapaliokas kok...@gmail.com wrote: I think that splitting each individual component to its own repo might be a bit confusing. Because if we don't have two groups (plasma-desktop and plasma- workspace), then we will not be able to provide something as a standard solution. So each person will consider Plasma Desktop as something entirely different. Yes having group is essential, otherwise it will create confusion.. repo like kde:kf5umbrella will be also needed. Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/#review42284 --- IMHO ship it! but I will wait for others to give you Ship It! - Bhushan Shah On Oct. 24, 2013, 8:02 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/ --- (Updated Oct. 24, 2013, 8:02 p.m.) Review request for kde-workspace and Plasma. Repository: kde-workspace Description --- Removes the white-black gradient spreading through the upper-half of the screen. IMHO it looks more elegant when it's just plain black. Diffs - ksplash/ksplashqml/themes/Minimalistic/main.qml e4fb8b8 Diff: http://git.reviewboard.kde.org/r/113419/diff/ Testing --- File Attachments Before http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png After http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png Thanks, Martin Klapetek
Re: Review Request 113056: Port ksgrd library to KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113056/ --- (Updated Oct. 3, 2013, 11 a.m.) Review request for kde-workspace and Sebastian Kügler. Repository: kde-workspace Description --- Port ksgrd library to KF5, I already pushed kDebug qDebug changes with commit 03681a90 Diffs (updated) - libs/ksysguard/CMakeLists.txt b00d9ff libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 libs/ksysguard/ksgrd/SensorManager.cpp f1657ee libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 Diff: http://git.reviewboard.kde.org/r/113056/diff/ Testing --- No tests, we can test this by porting systemmonitor dataengine later. Tested, works as expected. https://git.reviewboard.kde.org/r/113072/ Thanks, Bhushan Shah
Re: Review Request 113056: Port ksgrd library to KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113056/ --- (Updated Oct. 3, 2013, 5:50 a.m.) Review request for kde-workspace and Sebastian Kügler. Repository: kde-workspace Description --- Port ksgrd library to KF5, I already pushed kDebug qDebug changes with commit 03681a90 Diffs - libs/ksysguard/CMakeLists.txt b00d9ff libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 libs/ksysguard/ksgrd/SensorManager.cpp f1657ee libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 Diff: http://git.reviewboard.kde.org/r/113056/diff/ Testing (updated) --- No tests, we can test this by porting systemmonitor dataengine later. Tested, works as expected. https://git.reviewboard.kde.org/r/113072/ Thanks, Bhushan Shah
Re: Review Request 112641: port about kio slave
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112641/ --- (Updated Sept. 10, 2013, 4:13 p.m.) Review request for KDE Runtime. Changes --- KDE_EXPORT to Q_DECL_EXPORT Description --- Port about kio slave Diffs (updated) - kioslave/CMakeLists.txt ff66ab6 kioslave/about/CMakeLists.txt 4f8d91f kioslave/about/kio_about.h 620d6aa kioslave/about/kio_about.cpp d7396d8 Diff: http://git.reviewboard.kde.org/r/112641/diff/ Testing --- Thanks, Bhushan Shah
Review Request 112641: port about kio slave
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112641/ --- Review request for KDE Runtime. Description --- Port about kio slave Diffs - kioslave/CMakeLists.txt ff66ab6 kioslave/about/CMakeLists.txt 4f8d91f kioslave/about/kio_about.h 620d6aa kioslave/about/kio_about.cpp d7396d8 Diff: http://git.reviewboard.kde.org/r/112641/diff/ Testing --- Thanks, Bhushan Shah
Re: Review Request 112200: Remove unused CMake qimageblitz includes and links
On Aug. 30, 2013, 1:58 p.m., David Faure wrote: Confirmed with http://lxr.kde.org/ident?i=Blitz can we ship it on frameworks-scratch? - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112200/#review38935 --- On Sept. 1, 2013, 2:25 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112200/ --- (Updated Sept. 1, 2013, 2:25 p.m.) Review request for kde-workspace. Description --- No source files in kcontrol/ reference qimageblitz, so there doesn't seem any need to include it and link against it. Diffs - kcontrol/desktoptheme/CMakeLists.txt cc8fd992449c198a1621c2ffdba05487385a4fac kcontrol/style/CMakeLists.txt 6e93bedb1b4c50359210a1f1d75c0f5aae60bc91 Diff: http://git.reviewboard.kde.org/r/112200/diff/ Testing --- Thanks, Michael Palimaka
Review Request 112326: enable keystate dataengine on KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112326/ --- Review request for kde-workspace. Description --- Enable keystate DataEngine on KF5. Diffs - plasma/generic/dataengines/CMakeLists.txt 8b0d21b plasma/generic/dataengines/keystate/CMakeLists.txt 3f92173 plasma/generic/dataengines/keystate/keystate.cpp 99bdd76 Diff: http://git.reviewboard.kde.org/r/112326/diff/ Testing --- Compiles - check Links - check Installs - check Works - check However somehow its not showing keyboard keys, looks like problem in kdelibs KModifierKeyInfo. Thanks, Bhushan Shah
Re: Review Request 112260: Enable Dict DataEngine on KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- (Updated Aug. 26, 2013, 11:09 a.m.) Review request for kde-workspace. Description --- Enable dict DataEngine on KF5. Diffs (updated) - plasma/generic/dataengines/CMakeLists.txt a20ddae plasma/generic/dataengines/dict/CMakeLists.txt 2cab7c2 plasma/generic/dataengines/dict/dictengine.h 24dc265 plasma/generic/dataengines/dict/dictengine.cpp 127b0e0 Diff: http://git.reviewboard.kde.org/r/112260/diff/ Testing --- Compiles - check Installs - check Engine Explorer - check Functions - check Thanks, Bhushan Shah
Re: Review Request 112260: Enable Dict DataEngine on KF5
On Aug. 26, 2013, 11:29 a.m., David Edmundson wrote: plasma/generic/dataengines/dict/CMakeLists.txt, line 11 http://git.reviewboard.kde.org/r/112260/diff/2/?file=184749#file184749line11 We try to avoid extra whitespace in files. You have a blank space after plasma_engine_dict. It seems pedantic, but if we don't follow this when the next person saves the document it will show they edited the file and it messes the changelogs. For future reference in kate open Settings-Configure-Open/Save and under automatic cleanups select Remove trailing spaces on modified lines. I use vim more and kate in very rare case. I have that option already enabled in Kate but missing in vim. - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38609 --- On Aug. 26, 2013, 12:55 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- (Updated Aug. 26, 2013, 12:55 p.m.) Review request for kde-workspace. Description --- Enable dict DataEngine on KF5. Diffs - plasma/generic/dataengines/CMakeLists.txt a20ddae plasma/generic/dataengines/dict/CMakeLists.txt 2cab7c2 plasma/generic/dataengines/dict/dictengine.h 24dc265 plasma/generic/dataengines/dict/dictengine.cpp 127b0e0 Diff: http://git.reviewboard.kde.org/r/112260/diff/ Testing --- Compiles - check Installs - check Engine Explorer - check Functions - check Thanks, Bhushan Shah
Review Request 112241: Fix Show Launcher when not running option in taskbar widget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- Review request for kde-workspace, Plasma and Eike Hein. Description --- Fix the crash in plasma-desktop caused by newer QML taskbar widget. Simple steps to reproduce this crash. 1) Pin any task/application to taskbar using show launcher when not running option. 2) Close application. 3) Desktop crashes. Reason : 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, - pointer to task is not null - taskItem itself is not null - scene is not null 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed. Patch : This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item. Diffs - plasma/desktop/applets/tasks/tasks.cpp c4aef4b Diff: http://git.reviewboard.kde.org/r/112241/diff/ Testing --- Testing compilation - check installation - check plasmoidviewer - check in panel - check independently - check Thanks, Bhushan Shah
Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint. Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause. Are you sure that this happens on 32 bit only? - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 --- On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- (Updated Aug. 24, 2013, 2 p.m.) Review request for kde-workspace, Plasma and Eike Hein. Description --- Fix the crash in plasma-desktop caused by newer QML taskbar widget. Simple steps to reproduce this crash. 1) Pin any task/application to taskbar using show launcher when not running option. 2) Close application. 3) Desktop crashes. Reason : 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, - pointer to task is not null - taskItem itself is not null - scene is not null 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed. Patch : This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item. Diffs - plasma/desktop/applets/tasks/tasks.cpp c4aef4b Diff: http://git.reviewboard.kde.org/r/112241/diff/ Testing --- Testing compilation - check installation - check plasmoidviewer - check in panel - check independently - check Thanks, Bhushan Shah
Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint. Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause. Bhushan Shah wrote: Are you sure that this happens on 32 bit only? Eike Hein wrote: No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR. I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :). Thomas Lübking wrote: What bug and is WId involved? https://bugs.kde.org/show_bug.cgi?id=322283 - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 --- On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- (Updated Aug. 24, 2013, 2 p.m.) Review request for kde-workspace, Plasma and Eike Hein. Description --- Fix the crash in plasma-desktop caused by newer QML taskbar widget. Simple steps to reproduce this crash. 1) Pin any task/application to taskbar using show launcher when not running option. 2) Close application. 3) Desktop crashes. Reason : 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, - pointer to task is not null - taskItem itself is not null - scene is not null 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed. Patch : This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item. Diffs - plasma/desktop/applets/tasks/tasks.cpp c4aef4b Diff: http://git.reviewboard.kde.org/r/112241/diff/ Testing --- Testing compilation - check installation - check plasmoidviewer - check in panel - check independently - check Thanks, Bhushan Shah
Review Request 112223: Enable FileBrowser DataEngine
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112223/ --- Review request for kde-workspace and Plasma. Description --- Enable FileBrowser DataEngine on top of KF5 Diffs - plasma/generic/dataengines/CMakeLists.txt 579e929 plasma/generic/dataengines/filebrowser/CMakeLists.txt 528414f plasma/generic/dataengines/filebrowser/filebrowserengine.h 49819a9 plasma/generic/dataengines/filebrowser/filebrowserengine.cpp 2387bee Diff: http://git.reviewboard.kde.org/r/112223/diff/ Testing --- Compiles = check Plasma Engine explorer = Check Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 12:37 p.m.) Review request for kde-workspace and Marco Martin. Changes --- Fix issues. Description --- Activity bar applet ported in QML. Diffs (updated) - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:16 p.m.) Review request for kde-workspace and Marco Martin. Description --- Activity bar applet ported in QML. Diffs (updated) - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 44 http://git.reviewboard.kde.org/r/111992/diff/5/?file=178116#file178116line44 Here there is an old issue of TabBar that should be addressed one day or another.. it doesn't support vertical formfactors, in a vertical panel will just break. For now, even if will look rather terrible in that case the tabbar should probably just be rotated 90° Anything to do in this applet? Or just Drop this issue? - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37558 --- On Aug. 12, 2013, 3:14 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 12, 2013, 3:14 a.m.) Review request for kde-workspace and Marco Martin. Description --- Activity bar applet ported in QML. Diffs - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 12, 2013, 10:30 a.m.) Review request for kde-workspace and Marco Martin. Changes --- Updated review request. Description --- Activity bar applet ported in QML. Diffs (updated) - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 4:11 a.m.) Review request for kde-workspace and Marco Martin. Changes --- 1) Set minimum height and width to implicit width/height. 2) Rotated tabBar when formFactor is vertical, but it looks *very* wired. Added a bug in qml-components component for this (Bug #323443). I think all issues are resolved!(?) Description --- Activity bar applet ported in QML. Diffs (updated) - plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote:
plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41
http://git.reviewboard.kde.org/r/111992/diff/4/?file=178058#file178058line41
If you want to optimise, you can make TabBar the root item.
i.e instead of
Item {
TabBar {
}
}
we can just have
TabBar {
}
this automatically fixes the implicitWidth/Height change suggested
above.
Item is root because of PlasmaCore.DataSource and setup function.
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37549
---
On Aug. 11, 2013, 11:39 a.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/
---
(Updated Aug. 11, 2013, 11:39 a.m.)
Review request for kde-workspace and Marco Martin.
Description
---
Activity bar applet ported in QML.
Diffs
-
plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb
plasma/generic/applets/activitybar/Messages.sh e73df21
plasma/generic/applets/activitybar/activitybar.h b95cb0c
plasma/generic/applets/activitybar/activitybar.cpp e66bf04
plasma/generic/applets/activitybar/package/contents/ui/main.qml
PRE-CREATION
plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION
plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop
b7155de
Diff: http://git.reviewboard.kde.org/r/111992/diff/
Testing
---
Works, Tested in plasmoidviewer and desktop
Thanks,
Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
On Aug. 10, 2013, 5:04 p.m., David Edmundson wrote: Good start. You shouldn't delete the Messages.sh file. Copy from something that already uses QML, such as the battery applet. There's also a change from the current behaviour. The current one only shows where state = Running, it appears yours shows everything. Is this intentional? Yes! I am showing all activities because if someone wants to switch to activity which is not running then he/she have to do it from activity manager. That don't make sense to me.. - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37476 --- On Aug. 10, 2013, 4:39 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 10, 2013, 4:39 p.m.) Review request for kde-workspace and Marco Martin. Description --- Activity bar applet ported in QML. Diffs - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 10, 2013, 5:28 p.m.) Review request for kde-workspace and Marco Martin. Changes --- Fix some issues. Description --- Activity bar applet ported in QML. Diffs (updated) - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111992: Activity bar in QML.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 11, 2013, 2:48 a.m.) Review request for kde-workspace and Marco Martin. Changes --- Fix messages Description --- Activity bar applet ported in QML. Diffs (updated) - plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb plasma/generic/applets/activitybar/Messages.sh e73df21 plasma/generic/applets/activitybar/activitybar.h b95cb0c plasma/generic/applets/activitybar/activitybar.cpp e66bf04 plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah
Re: Review Request 111648: Fix for GroupExpander that overlaps application icon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111648/ --- (Updated Aug. 8, 2013, 1:06 p.m.) Status -- This change has been discarded. Review request for kde-workspace and Eike Hein. Description --- In current task manager Arrow for the GroupExpander overlaps the application icon, Fix for it. Diffs - plasma/desktop/applets/tasks/package/contents/ui/GroupExpanderOverlay.qml 7aa0d00 Diff: http://git.reviewboard.kde.org/r/111648/diff/ Testing --- Works for me File Attachments Before patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/23/snapshot11.png After patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/23/snapshot12.png Thanks, Bhushan Shah
Review Request 111648: Fix for GroupExpander that overlaps application icon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111648/ --- Review request for kde-workspace and Eike Hein. Description --- In current task manager Arrow for the GroupExpander overlaps the application icon, Fix for it. Diffs - plasma/desktop/applets/tasks/package/contents/ui/GroupExpanderOverlay.qml 7aa0d00 Diff: http://git.reviewboard.kde.org/r/111648/diff/ Testing --- Thanks, Bhushan Shah
Re: Review Request 111648: Fix for GroupExpander that overlaps application icon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111648/ --- (Updated July 23, 2013, 5:37 a.m.) Review request for kde-workspace and Eike Hein. Description --- In current task manager Arrow for the GroupExpander overlaps the application icon, Fix for it. Diffs - plasma/desktop/applets/tasks/package/contents/ui/GroupExpanderOverlay.qml 7aa0d00 Diff: http://git.reviewboard.kde.org/r/111648/diff/ Testing (updated) --- Works for me Thanks, Bhushan Shah
