Review Request 112234: Save krunner dialog size when manually resized
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- Review request for kde-workspace. Description --- This size was previously only saved on destruction, which not once has worked, whether I shut down the computer or log out normally. Now it will save (after 1 sec) after manually resizing the dialog. Diffs - krunner/interfaces/default/interface.h a0367a55043aa18229200ca191e2fab1ecb4a32f krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 Diff: http://git.reviewboard.kde.org/r/112234/diff/ Testing --- Thanks, Harald Hvaal
Review Request 112235: Move focus to search field upon typing from result list
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- Review request for kde-workspace. Description --- Upon typing after having the focus moved down to the results, the focus will be moved back to the search input immediately. Diffs - krunner/interfaces/default/resultitem.cpp 31fe94c96195fdaeaf548207f99b294f7d768203 krunner/interfaces/default/resultscene.cpp 514c2c82d0fe3c3aa04200b5e254a6489bffd89d Diff: http://git.reviewboard.kde.org/r/112235/diff/ Testing --- Thanks, Harald Hvaal
Review Request 112236: krunner: Add the full name of completion matches to history
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/ --- Review request for kde-workspace and Plasma. Description --- Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list. This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them. Exact matches are added as-is. example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added. Diffs - krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 Diff: http://git.reviewboard.kde.org/r/112236/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112236: krunner: Add the full name of completion matches to history
> On Aug. 24, 2013, 10:08 a.m., Thomas Lübking wrote: > > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 > > <http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274> > > > > ... ;-) yeah, not sure what happened with post-review here, but it's definitely not part of the actual commit :) - Harald --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/#review38466 --- On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112236/ > --- > > (Updated Aug. 24, 2013, 9:52 a.m.) > > > Review request for kde-workspace and Plasma. > > > Description > --- > > Previously you would not record the actual item you chose after choosing an > auto-completion, so if you typed say "lal" and you chose a completion way > down the list, the history item would not reflect that choice, only what you > typed to get to the completion list. > > This commit will fill the history combo box with the actual hit you executed, > instead of half-complete strings that don't make sense until you actually > select them. > Exact matches are added as-is. > > example: type ass, and you get Qt Assistant. Instead of adding "ass" to the > history, "Qt Assistant" will be added. > > > Diffs > - > > krunner/interfaces/default/interface.cpp > 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml > 8832d1d03e47a4e6382877d18ee664ecd4d12343 > > Diff: http://git.reviewboard.kde.org/r/112236/diff/ > > > Testing > --- > > > Thanks, > > Harald Hvaal > >
Re: Review Request 112235: Move focus to search field upon typing from result list
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Aug. 24, 2013, 2:42 p.m.) Review request for kde-workspace. Changes --- Although I can't say I'm impressed by how the resultlist handles the pgup/down keys, with this change they are no longer forwarded to the search input. About up/down, that just works because it is handled in the switch just above in the same function, and never gets forwarded. Description --- Upon typing after having the focus moved down to the results, the focus will be moved back to the search input immediately. Diffs (updated) - krunner/interfaces/default/resultitem.cpp 31fe94c96195fdaeaf548207f99b294f7d768203 krunner/interfaces/default/resultscene.cpp 514c2c82d0fe3c3aa04200b5e254a6489bffd89d Diff: http://git.reviewboard.kde.org/r/112235/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112234: Save krunner dialog size when manually resized
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Aug. 24, 2013, 2:48 p.m.) Review request for kde-workspace. Description --- This size was previously only saved on destruction, which not once has worked, whether I shut down the computer or log out normally. Now it will save (after 1 sec) after manually resizing the dialog. Diffs (updated) - krunner/interfaces/default/interface.h a0367a55043aa18229200ca191e2fab1ecb4a32f krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 Diff: http://git.reviewboard.kde.org/r/112234/diff/ Testing --- Thanks, Harald Hvaal
Review Request 112258: ksysguard process list: better keyboard navigation
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- Review request for kde-workspace. Description --- ksysguard has good keyboard handling, but it can be better. For example, it has annoyed me that I cannot use the del/shift-del shortcuts or get the context menu unless I explicitly tab my way down to the treeview (even though pressing up/down with the text field focused gives the false impression that the rows have focus). This diff makes this keyboard navigation more efficient. While the comments in the code should describe the behavior well enough, here they are listed: * Search field ** Pressing enter moves to first item in treeview and opens context menu ** Pressing down/pgdown will move actual focus to the treeview ** Focusing the text field clears the treeview selection. This emphasises that only one visual element is focused at a time, as well as that you can not interact with the items in the view until they have been selected. * Treeview ** Pressing up when on the first entry will move focus to the text field ** If you start typing, the focus will immediately be moved to the text field ** When focus is received, select first row in the treeview Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff4e93041e4b1911e2643bfda6888d171bd Diff: http://git.reviewboard.kde.org/r/112258/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112234: Save krunner dialog size when manually resized
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Aug. 25, 2013, 6:46 p.m.) Review request for kde-workspace. Changes --- Fix a case where the current size was stored as the default size when the dialog was collapsed Description --- This size was previously only saved on destruction, which not once has worked, whether I shut down the computer or log out normally. Now it will save (after 1 sec) after manually resizing the dialog. Diffs (updated) - krunner/interfaces/default/interface.h a0367a55043aa18229200ca191e2fab1ecb4a32f krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 Diff: http://git.reviewboard.kde.org/r/112234/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112236: krunner: Add the full name of completion matches to history
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/ --- (Updated Aug. 31, 2013, 11:34 a.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Description --- Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list. This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them. Exact matches are added as-is. example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added. Diffs - krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 Diff: http://git.reviewboard.kde.org/r/112236/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112258: ksysguard process list: better keyboard navigation
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- (Updated Sept. 1, 2013, 8:24 a.m.) Review request for kde-workspace. Changes --- *bump* Description (updated) --- ksysguard has good keyboard handling, but it can be better. For example, it has annoyed me that I cannot use the del/shift-del shortcuts or get the context menu unless I explicitly tab my way down to the treeview (even though pressing up/down with the text field focused gives the false impression that the rows have focus). This diff makes this keyboard navigation more efficient. While the comments in the code should describe the behavior well enough, here they are listed: * Search field ** Pressing enter moves to first item in treeview and opens context menu ** Pressing down/pgdown will move actual focus to the treeview ** Focusing the text field clears the treeview selection. This emphasises that only one visual element is focused at a time, as well as that you can not interact with the items in the view until they have been selected. * Treeview ** Pressing up when on the first entry will move focus to the text field ** If you start typing, the focus will immediately be moved to the text field ** When focus is received, select first row in the treeview Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff4e93041e4b1911e2643bfda6888d171bd Diff: http://git.reviewboard.kde.org/r/112258/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112234: Save krunner dialog size when manually resized
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Sept. 1, 2013, 8:25 a.m.) Review request for kde-workspace. Changes --- *bump* Description (updated) --- This size was previously only saved on destruction, which not once has worked, whether I shut down the computer or log out normally. Now it will save (after 1 sec) after manually resizing the dialog. Diffs - krunner/interfaces/default/interface.h a0367a55043aa18229200ca191e2fab1ecb4a32f krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 Diff: http://git.reviewboard.kde.org/r/112234/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112258: ksysguard process list: better keyboard navigation
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- (Updated Oct. 2, 2013, 6:30 a.m.) Review request for kde-workspace. Repository: kde-workspace Description (updated) --- ksysguard has good keyboard handling, but it can be better. For example, it has annoyed me that I cannot use the del/shift-del shortcuts or get the context menu unless I explicitly tab my way down to the treeview (even though pressing up/down with the text field focused gives the false impression that the rows have focus). This diff makes this keyboard navigation more efficient. While the comments in the code should describe the behavior well enough, here they are listed: * Search field ** Pressing enter moves to first item in treeview and opens context menu ** Pressing down/pgdown will move actual focus to the treeview ** Focusing the text field clears the treeview selection. This emphasises that only one visual element is focused at a time, as well as that you can not interact with the items in the view until they have been selected. * Treeview ** Pressing up when on the first entry will move focus to the text field ** If you start typing, the focus will immediately be moved to the text field ** When focus is received, select first row in the treeview After bumping this twice already without responses, I'm thinking about pushing it as it is unlikely to cause much (if any) trouble. Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff4e93041e4b1911e2643bfda6888d171bd Diff: http://git.reviewboard.kde.org/r/112258/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112234: Save krunner dialog size when manually resized
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Oct. 18, 2013, 7:28 a.m.) Review request for kde-workspace. Changes --- bump Repository: kde-workspace Description --- This size was previously only saved on destruction, which not once has worked, whether I shut down the computer or log out normally. Now it will save (after 1 sec) after manually resizing the dialog. Diffs - krunner/interfaces/default/interface.h a0367a55043aa18229200ca191e2fab1ecb4a32f krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 Diff: http://git.reviewboard.kde.org/r/112234/diff/ Testing (updated) --- Thanks, Harald Hvaal
Re: Review Request 112235: Move focus to search field upon typing from result list
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Oct. 18, 2013, 7:29 a.m.) Review request for kde-workspace. Changes --- bump Repository: kde-workspace Description --- Upon typing after having the focus moved down to the results, the focus will be moved back to the search input immediately. Diffs - krunner/interfaces/default/resultitem.cpp 31fe94c96195fdaeaf548207f99b294f7d768203 krunner/interfaces/default/resultscene.cpp 514c2c82d0fe3c3aa04200b5e254a6489bffd89d Diff: http://git.reviewboard.kde.org/r/112235/diff/ Testing (updated) --- Thanks, Harald Hvaal
Re: Review Request 112258: ksysguard process list: better keyboard navigation
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- (Updated Oct. 18, 2013, 7:29 a.m.) Review request for kde-workspace. Changes --- bump Repository: kde-workspace Description --- ksysguard has good keyboard handling, but it can be better. For example, it has annoyed me that I cannot use the del/shift-del shortcuts or get the context menu unless I explicitly tab my way down to the treeview (even though pressing up/down with the text field focused gives the false impression that the rows have focus). This diff makes this keyboard navigation more efficient. While the comments in the code should describe the behavior well enough, here they are listed: * Search field ** Pressing enter moves to first item in treeview and opens context menu ** Pressing down/pgdown will move actual focus to the treeview ** Focusing the text field clears the treeview selection. This emphasises that only one visual element is focused at a time, as well as that you can not interact with the items in the view until they have been selected. * Treeview ** Pressing up when on the first entry will move focus to the text field ** If you start typing, the focus will immediately be moved to the text field ** When focus is received, select first row in the treeview After bumping this twice already without responses, I'm thinking about pushing it as it is unlikely to cause much (if any) trouble. Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff4e93041e4b1911e2643bfda6888d171bd Diff: http://git.reviewboard.kde.org/r/112258/diff/ Testing (updated) --- Thanks, Harald Hvaal
Re: Review Request 112258: ksysguard process list: better keyboard navigation
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- (Updated Oct. 18, 2013, 7:41 a.m.) Review request for kde-workspace and John Tapsell. Repository: kde-workspace Description --- ksysguard has good keyboard handling, but it can be better. For example, it has annoyed me that I cannot use the del/shift-del shortcuts or get the context menu unless I explicitly tab my way down to the treeview (even though pressing up/down with the text field focused gives the false impression that the rows have focus). This diff makes this keyboard navigation more efficient. While the comments in the code should describe the behavior well enough, here they are listed: * Search field ** Pressing enter moves to first item in treeview and opens context menu ** Pressing down/pgdown will move actual focus to the treeview ** Focusing the text field clears the treeview selection. This emphasises that only one visual element is focused at a time, as well as that you can not interact with the items in the view until they have been selected. * Treeview ** Pressing up when on the first entry will move focus to the text field ** If you start typing, the focus will immediately be moved to the text field ** When focus is received, select first row in the treeview After bumping this twice already without responses, I'm thinking about pushing it as it is unlikely to cause much (if any) trouble. Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff4e93041e4b1911e2643bfda6888d171bd Diff: http://git.reviewboard.kde.org/r/112258/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112235: Move focus to search field upon typing from result list
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Nov. 6, 2013, 7:05 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace. Repository: kde-workspace Description --- Upon typing after having the focus moved down to the results, the focus will be moved back to the search input immediately. Diffs - krunner/interfaces/default/resultitem.cpp 31fe94c96195fdaeaf548207f99b294f7d768203 krunner/interfaces/default/resultscene.cpp 514c2c82d0fe3c3aa04200b5e254a6489bffd89d Diff: http://git.reviewboard.kde.org/r/112235/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112258: ksysguard process list: better keyboard navigation
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- (Updated Nov. 6, 2013, 7:07 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and John Tapsell. Repository: kde-workspace Description --- ksysguard has good keyboard handling, but it can be better. For example, it has annoyed me that I cannot use the del/shift-del shortcuts or get the context menu unless I explicitly tab my way down to the treeview (even though pressing up/down with the text field focused gives the false impression that the rows have focus). This diff makes this keyboard navigation more efficient. While the comments in the code should describe the behavior well enough, here they are listed: * Search field ** Pressing enter moves to first item in treeview and opens context menu ** Pressing down/pgdown will move actual focus to the treeview ** Focusing the text field clears the treeview selection. This emphasises that only one visual element is focused at a time, as well as that you can not interact with the items in the view until they have been selected. * Treeview ** Pressing up when on the first entry will move focus to the text field ** If you start typing, the focus will immediately be moved to the text field ** When focus is received, select first row in the treeview After bumping this twice already without responses, I'm thinking about pushing it as it is unlikely to cause much (if any) trouble. Diffs - libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff4e93041e4b1911e2643bfda6888d171bd Diff: http://git.reviewboard.kde.org/r/112258/diff/ Testing --- Thanks, Harald Hvaal
Re: Review Request 112234: Save krunner dialog size when manually resized
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Nov. 6, 2013, 7:07 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace. Repository: kde-workspace Description --- This size was previously only saved on destruction, which not once has worked, whether I shut down the computer or log out normally. Now it will save (after 1 sec) after manually resizing the dialog. Diffs - krunner/interfaces/default/interface.h a0367a55043aa18229200ca191e2fab1ecb4a32f krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 Diff: http://git.reviewboard.kde.org/r/112234/diff/ Testing --- Thanks, Harald Hvaal
