Re: synching kactivities in kdelibs/4.7
On Wed, Sep 21, 2011 at 9:03 AM, Ivan Čukić ivan.cu...@kde.org wrote: kdelibs/4.7 shouldn't be used with a separate libkactivities. This is for 4.8 and further. I believe we are supposed to build the rest of KDE (git) against the 4.7 branch of kdelibs now, since master is stale and frozen? Has that changed again? It seems so... I thought there will be libs 4.8 with just bugfixes and stuff. distros packaging KDE from git should also package kactivities (in which case kdelibs need fixing to not install the lib), or if we should ignore the separate repo and continue to use the one from kdelibs (in which case kdelibs needs fixing to provide the cmake stuff)? I'd go for disabling the libkactivities in kdelibs, like it was proposed before. +1
Re: KSambaShare destructor proposed patch
On Sat, Mar 19, 2011 at 8:51 AM, Fabrice Ménard menard.fabr...@orange.fr wrote: Le vendredi 18 mars 2011 20:55:52 David Faure a écrit : Looks good, please commit -- if you don't have a kde svn/git account yet, please get one, your patches are good ;) Thanks I don't have an account yet. I will commit to you then :-) Thanks for your patch, Rodrigo Belem.
Re: About remove nfs filesharing support
Hi all, I update the patch some days ago, but I forgot to post it here. Could you take a look on it? :-) http://reviewboard.kde.org/r/6308/ Thanks, Rodrigo Belem. On 1/8/11, Rodrigo Belém rclbe...@gmail.com wrote: I just sent the *initial* patch to http://reviewboard.kde.org/r/6308/. It lacks username permission handling, disabling widgets when samba share checkbox in unmarked, ui polishing and more :-) The patch already removes the nfs support from the plugin. 2011/1/8 Rodrigo Belém rclbe...@gmail.com: On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen o...@kde.org wrote: On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote: On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer kevin.kram...@gmx.at wrote: One code level nitpick: use of magic UID number 1000. In case this is some kind of standard there is certainly a header specifying a constant/macro for it. If not this looks kind of operating system or maybe even vendor specific. This number needs to be discovered, but I hardcoded it just to get it working :-) kcm_kdm and genkdmconf have code which (probably - i didn't look at your patch) serves the same purpose. it should be probably centralized somehow. Thanks Oswald, I had no idea where to look for it. I think that it should be centralized in KUser. What do you think?
Re: About remove nfs filesharing support
On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen o...@kde.org wrote: On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote: On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer kevin.kram...@gmx.at wrote: One code level nitpick: use of magic UID number 1000. In case this is some kind of standard there is certainly a header specifying a constant/macro for it. If not this looks kind of operating system or maybe even vendor specific. This number needs to be discovered, but I hardcoded it just to get it working :-) kcm_kdm and genkdmconf have code which (probably - i didn't look at your patch) serves the same purpose. it should be probably centralized somehow. Thanks Oswald, I had no idea where to look for it. I think that it should be centralized in KUser. What do you think?
