About remove nfs filesharing support
Hello everybody, I've been working on kubuntu team to update the samba file sharing code and code is already in trunk :-) I have another patch that updates the kdenetwork/filesharing, but it removes all the nfs code, which needs root privileges. Are you ok with this change or do you want keep the nfs support? Thanks, Rodrigo Belem.
Re: About remove nfs filesharing support
On 12/28/2010 03:06 PM, Rodrigo Belém wrote: Hello everybody, I've been working on kubuntu team to update the samba file sharing code and code is already in trunk :-) I have another patch that updates the kdenetwork/filesharing, but it removes all the nfs code, which needs root privileges. Are you ok with this change or do you want keep the nfs support? Well, we should not remove any feature imho, but maybe we can improve it. If the code needs root maybe we can port the current code to KAuth so we have a modern way of doing it.
Re: About remove nfs filesharing support
On Tuesday, 2010-12-28, Alex Fiestas wrote: > On 12/28/2010 03:06 PM, Rodrigo Belém wrote: > > Hello everybody, > > > > I've been working on kubuntu team to update the samba file sharing > > code and code is already in trunk :-) I have another patch that > > updates the kdenetwork/filesharing, but it removes all the nfs code, > > which needs root privileges. Are you ok with this change or do you > > want keep the nfs support? > > Well, we should not remove any feature imho, but maybe we can improve it. > > If the code needs root maybe we can port the current code to KAuth so we > have a modern way of doing it. In any case discussing a patch without the actual patch at hand is totally pointless. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part.
Re: About remove nfs filesharing support
On Tue, Dec 28, 2010 at 10:12 AM, Alex Fiestas wrote: > On 12/28/2010 03:06 PM, Rodrigo Belém wrote: >> >> Hello everybody, >> >> I've been working on kubuntu team to update the samba file sharing >> code and code is already in trunk :-) I have another patch that >> updates the kdenetwork/filesharing, but it removes all the nfs code, >> which needs root privileges. Are you ok with this change or do you >> want keep the nfs support? > > Well, we should not remove any feature imho, but maybe we can improve it. > > If the code needs root maybe we can port the current code to KAuth so we > have a modern way of doing it. > I think remove features is not very good too, but worth keep nfs support and update it? Users really uses this feature?
Re: About remove nfs filesharing support
On Tuesday 28 December 2010 12:56:01 Rodrigo Belém wrote: > On Tue, Dec 28, 2010 at 10:12 AM, Alex Fiestas wrote: > > On 12/28/2010 03:06 PM, Rodrigo Belém wrote: > >> Hello everybody, > >> > >> I've been working on kubuntu team to update the samba file sharing > >> code and code is already in trunk :-) I have another patch that > >> updates the kdenetwork/filesharing, but it removes all the nfs code, > >> which needs root privileges. Are you ok with this change or do you > >> want keep the nfs support? > > > > Well, we should not remove any feature imho, but maybe we can improve it. > > > > If the code needs root maybe we can port the current code to KAuth so we > > have a modern way of doing it. > > I think remove features is not very good too, but worth keep nfs > support and update it? Users really uses this feature? Does that mean making KDE completely oblivious to NFS at all?
Re: About remove nfs filesharing support
On Tue, Dec 28, 2010 at 03:12:24PM +0100, Alex Fiestas wrote: > Well, we should not remove any feature imho, but maybe we can improve it. There's lots of reasons to remove features. If the code is too buggy or too hard to maintain or not used by anyone and cluttering a UI. I don't know which of the above would apply to the NFS feature but it would well be all of them. Jonathan
Re: About remove nfs filesharing support
On Tue, Dec 28, 2010 at 01:18:10PM -0200, Raphael Kubo da Costa wrote: > Does that mean making KDE completely oblivious to NFS at all? No, NFS is almost always system mounted. I've never come across anyone actually using it for user mounts. Far better to work on support for protocols that are designed for the job and standardied like SMB (designed for the job, Rodrigo already implemented), and Webdav (standardised, could be intergrated with OwnCloud). Jonathan
Re: About remove nfs filesharing support
On Tuesday, 2010-12-28, Raphael Kubo da Costa wrote: > On Tuesday 28 December 2010 12:56:01 Rodrigo Belém wrote: > > On Tue, Dec 28, 2010 at 10:12 AM, Alex Fiestas wrote: > > > On 12/28/2010 03:06 PM, Rodrigo Belém wrote: > > >> Hello everybody, > > >> > > >> I've been working on kubuntu team to update the samba file sharing > > >> code and code is already in trunk :-) I have another patch that > > >> updates the kdenetwork/filesharing, but it removes all the nfs code, > > >> which needs root privileges. Are you ok with this change or do you > > >> want keep the nfs support? > > > > > > Well, we should not remove any feature imho, but maybe we can improve > > > it. > > > > > > If the code needs root maybe we can port the current code to KAuth so > > > we have a modern way of doing it. > > > > I think remove features is not very good too, but worth keep nfs > > support and update it? Users really uses this feature? > > Does that mean making KDE completely oblivious to NFS at all? I think the main idea of this thread is to agree to a change without knowing what it exactly changes. Unfortunately we don't have any of the following things at our disposal: - web based system for reviewing patches (you know like a reviewboard) - messaging system with attachment capabilities (you know like email) - remote file access based ion some universal addressing scheme (you know like HTTP) Since, as we already have established, have neither at our disposal I suggest we jsut go ahead and blindly argue about scope, necessity and any other details people can come up with. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part.
Re: About remove nfs filesharing support
On Tuesday, 2010-12-28, Rodrigo Belém wrote: > On Tue, Dec 28, 2010 at 10:19 AM, Kevin Krammer wrote: > > On Tuesday, 2010-12-28, Alex Fiestas wrote: > >> On 12/28/2010 03:06 PM, Rodrigo Belém wrote: > >> > Hello everybody, > >> > > >> > I've been working on kubuntu team to update the samba file sharing > >> > code and code is already in trunk :-) I have another patch that > >> > updates the kdenetwork/filesharing, but it removes all the nfs code, > >> > which needs root privileges. Are you ok with this change or do you > >> > want keep the nfs support? > >> > >> Well, we should not remove any feature imho, but maybe we can improve > >> it. > >> > >> If the code needs root maybe we can port the current code to KAuth so we > >> have a modern way of doing it. > > > > In any case discussing a patch without the actual patch at hand is > > totally pointless. > > Here is the patch :-) Thanks! :) If I understand it correctly it replaces some of the Samba related handling from the UI with some sort of sambashare handling code somewhere else. Additionally it removes all NFS related code. How about moving all Samba UI to a new module and renaming the old one so it explicitly is for NFS. this could then be put into a CMake build option section in case it doesn't build or work correctly. From your original I take that Samba shares can be done without elevated priviledges? Or is this somehow covered by this samba share code referenced in this UI parts? One code level nitpick: use of magic UID number 1000. In case this is some kind of standard there is certainly a header specifying a constant/macro for it. If not this looks kind of operating system or maybe even vendor specific. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part.
Re: About remove nfs filesharing support
On 12/28/2010 04:26 PM, Jonathan Riddell wrote: On Tue, Dec 28, 2010 at 03:12:24PM +0100, Alex Fiestas wrote: Well, we should not remove any feature imho, but maybe we can improve it. There's lots of reasons to remove features. If the code is too buggy Then, let's fix it. or too hard to maintain Then, let's refactor (or at least study what options do we have) it. or not used by anyone Hard to know :/ and cluttering a UI. Well, we need a better design. I don't know nothing about the subjet right now but "Share files" is in my TODO list for 4.6, so I'd like to take a look before remove anything.
Re: About remove nfs filesharing support
On Tuesday 28 December 2010, Jonathan Riddell wrote: > On Tue, Dec 28, 2010 at 01:18:10PM -0200, Raphael Kubo da Costa wrote: > > Does that mean making KDE completely oblivious to NFS at all? > > No, NFS is almost always system mounted. I've never come across > anyone actually using it for user mounts. Far better to work on > support for protocols that are designed for the job and standardied > like SMB (designed for the job, Rodrigo already implemented), and > Webdav (standardised, could be intergrated with OwnCloud). > I use it like that. NFS integrates much better than SMB with unix filesystems, and auto-mounting is not always possible with a laptop that can be moved between different local networks. `Allan
Re: About remove nfs filesharing support
Just for the record: I'm totally in favor of removing NFS support. In its current form it's a security risk. root rights? No way! IIRC NFS is also no encrypted, making it easy to intercept file transmissions. Unless no one of those people who wish the feature to stay actually fix its problems, it's better to remove it. They or someone else may re-add the feature in a secure way later. Marus On Tuesday 28 December 2010 15:06:13 Rodrigo Belém wrote: > Hello everybody, > > I've been working on kubuntu team to update the samba file sharing > code and code is already in trunk :-) I have another patch that > updates the kdenetwork/filesharing, but it removes all the nfs code, > which needs root privileges. Are you ok with this change or do you > want keep the nfs support? > > > Thanks, > > > > Rodrigo Belem.
Re: About remove nfs filesharing support
On Tuesday, December 28, 2010 07:45:09 pm Markus Slopianka wrote: > Just for the record: I'm totally in favor of removing NFS support. > In its current form it's a security risk. root rights? No way! > IIRC NFS is also no encrypted, making it easy to intercept file > transmissions. NFS can be encrypted with kerberos. Without kerberos, nfs is super easy to configure. Samba is (often) a huge headache to configure compared to nfs, but is a bit more secure. Basically, quick, easy, and secure file sharing on Linux is broken. An alternative is needed, but I'm against removing NFS features. > > Unless no one of those people who wish the feature to stay actually fix its > problems, it's better to remove it. They or someone else may re-add the > feature in a secure way later. > > Marus > > On Tuesday 28 December 2010 15:06:13 Rodrigo Belém wrote: > > Hello everybody, > > > > I've been working on kubuntu team to update the samba file sharing > > code and code is already in trunk :-) I have another patch that > > updates the kdenetwork/filesharing, but it removes all the nfs code, > > which needs root privileges. Are you ok with this change or do you > > want keep the nfs support? > > > > > > Thanks, > > > > > > > > Rodrigo Belem.
Re: About remove nfs filesharing support
On Wednesday 29 December 2010 01:55:26 Trever Fischer wrote: > Basically, quick, easy, and secure file sharing on Linux is broken. An > alternative is needed WebDAV, SFTP,...
Re: About remove nfs filesharing support
On Tue, Dec 28, 2010 at 8:55 PM, Trever Fischer wrote: > On Tuesday, December 28, 2010 07:45:09 pm Markus Slopianka wrote: >> Just for the record: I'm totally in favor of removing NFS support. >> In its current form it's a security risk. root rights? No way! >> IIRC NFS is also no encrypted, making it easy to intercept file >> transmissions. > NFS can be encrypted with kerberos. Without kerberos, nfs is super easy to > configure. > Samba is (often) a huge headache to configure compared to nfs, but is > a bit more secure. > Samba comes pre-configured in most distributions and the "net usershare" cmd line tool makes filesharing really easy. > Basically, quick, easy, and secure file sharing on Linux is broken. An > alternative is needed, but I'm against removing NFS features. I'm in favor of remove nfs for now, add webdav support and add a secure nfs filesharing.
Re: About remove nfs filesharing support
On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer wrote: > > Thanks! :) > > If I understand it correctly it replaces some of the Samba related handling > from the UI with some sort of sambashare handling code somewhere else. Yup, all the main code are in ksambashare* > Additionally it removes all NFS related code. > > How about moving all Samba UI to a new module and renaming the old one so it > explicitly is for NFS. this could then be put into a CMake build option > section in case it doesn't build or work correctly. > Great idea :-) I will do that, but I need some help with the ui. Do we have designers/"usability experts" around? :-) > From your original I take that Samba shares can be done without elevated > priviledges? Or is this somehow covered by this samba share code referenced in > this UI parts? > You can share files without root privileges and all the main code lives in kio/kio/ksambashare* > One code level nitpick: use of magic UID number 1000. In case this is some > kind of standard there is certainly a header specifying a constant/macro for > it. If not this looks kind of operating system or maybe even vendor specific. > This number needs to be discovered, but I hardcoded it just to get it working :-)
Re: About remove nfs filesharing support
On Wednesday 29 December 2010 03:29:14 Rodrigo Belém wrote: > Great idea :-) I will do that, but I need some help with the ui. Do we > have designers/"usability experts" around? :-) I'm certainly no expert or a designer but I like usability. Maybe I can help. I can't compile anything, though. My HDD is almost full all the time. I simply have no space available for KDE development files. Either try just posting screenshots of the current state and which features still need to be added or (even better) submit modified packages to OBS for me to install. Markus
Re: About remove nfs filesharing support
On 12/29/2010 03:13 AM, Rodrigo Belém wrote: Samba comes pre-configured in most distributions and the "net usershare" cmd line tool makes filesharing really easy. Basically, quick, easy, and secure file sharing on Linux is broken. An alternative is needed, but I'm against removing NFS features. I'm in favor of remove nfs for now, add webdav support and add a secure nfs filesharing. I'm not sure what is the current state of "Sharing" as i said, but we need a plugin system here imho, for instance I'm writing Bluetooth Sharing and would be nice to have it integrated with the others (Samba, nfs, webdav, http...)
Re: About remove nfs filesharing support
On Wednesday 29 December 2010, Markus Slopianka wrote: > Just for the record: I'm totally in favor of removing NFS support. > In its current form it's a security risk. root rights? No way! That is your choice > IIRC NFS is also no encrypted, making it easy to intercept file > transmissions. > Neither is SMB or HTTP by default. NFS support optional encryption just as well as any other local network protocol. `Allan
Re: About remove nfs filesharing support
On Wednesday 29 December 2010, Rodrigo Belém wrote: > > Basically, quick, easy, and secure file sharing on Linux is broken. An > > alternative is needed, but I'm against removing NFS features. > > I'm in favor of remove nfs for now, add webdav support and add a > secure nfs filesharing. That is very sensible, but that is a distribution and sys-admin choice. We add absolutely no additional security by not providing _client_ access. The security choice is made when exporting filesystems, and KDE is not a NFS server, and closing your eyes does not remove the unsecure shares ;) `Allan
Re: About remove nfs filesharing support
As for a quick lookup, it seems KDE has no (kauth driven or not) GUI to configure nfs, therefore: -> Could the nfs filesharing stuff (i assume it only read/writes to /etc/fstab & /etc/exports, possibly to /etc/hosts.allow) be (easily) converted into a "configure nfs" GUI? - tbh: i'd not let some GUI write to /etc/hosts.allowed on my box ever, but i guess a majority of "joe users" would proably appreciate such solution to avoid the "geez... rtfm" ... "d'ohhh, 'man nfs'" loops - i went through back then ;-) Cheers, Thomas Am Tuesday 28 December 2010 schrieb Rodrigo Belém: > Hello everybody, > > I've been working on kubuntu team to update the samba file sharing > code and code is already in trunk :-) I have another patch that > updates the kdenetwork/filesharing, but it removes all the nfs code, > which needs root privileges. Are you ok with this change or do you > want keep the nfs support? > > > Thanks, > > > > Rodrigo Belem.
Re: About remove nfs filesharing support
On Wednesday 29 December 2010, Allan Sandfeld Jensen wrote: > On Wednesday 29 December 2010, Rodrigo Belém wrote: > > > Basically, quick, easy, and secure file sharing on Linux is broken. An > > > alternative is needed, but I'm against removing NFS features. > > > > I'm in favor of remove nfs for now, add webdav support and add a > > secure nfs filesharing. > > That is very sensible, but that is a distribution and sys-admin choice. We > add absolutely no additional security by not providing _client_ access. > The security choice is made when exporting filesystems, and KDE is not a > NFS server, and closing your eyes does not remove the unsecure shares ;) > I retract this. I was obviously thinking of something else. I have no problem with updating kdenetwork/filesharing and removing NFS from it. `Allan
Re: About remove nfs filesharing support
On Tuesday 28 December 2010, Allan Sandfeld Jensen wrote: > On Tuesday 28 December 2010, Jonathan Riddell wrote: > > On Tue, Dec 28, 2010 at 01:18:10PM -0200, Raphael Kubo da Costa wrote: > > > Does that mean making KDE completely oblivious to NFS at all? > > > > No, NFS is almost always system mounted. I've never come across > > anyone actually using it for user mounts. Far better to work on > > support for protocols that are designed for the job and standardied > > like SMB (designed for the job, Rodrigo already implemented), and > > Webdav (standardised, could be intergrated with OwnCloud). > > I use it like that. NFS integrates much better than SMB with unix > filesystems, and auto-mounting is not always possible with a laptop that > can be moved between different local networks. Note that the nfs://host ioslave will still be working (*), in addition to system mounts. The only thing discussed here is the suid script (and related GUI) that allows users to make nfs shares. (*) so even if "almost always system mounted" is not so true, we still have a client solution that doesn't require mounting. Which I like very much because it doesn't make your machine hang when the server is shut down and you forgot to umount the share... (But then again, sftp:// is easier to setup and more secure). Anyway, I don't know if user-controlled sharing should be kept or removed. It would be interesting to have Mandriva's feedback, since the feature was coded by Mandriva developers, years ago. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
Re: About remove nfs filesharing support
On Friday 31 December 2010, David Faure wrote: > On Tuesday 28 December 2010, Allan Sandfeld Jensen wrote: > > On Tuesday 28 December 2010, Jonathan Riddell wrote: > > > On Tue, Dec 28, 2010 at 01:18:10PM -0200, Raphael Kubo da Costa wrote: > > > > Does that mean making KDE completely oblivious to NFS at all? > > > > > > No, NFS is almost always system mounted. I've never come across > > > anyone actually using it for user mounts. Far better to work on > > > support for protocols that are designed for the job and standardied > > > like SMB (designed for the job, Rodrigo already implemented), and > > > Webdav (standardised, could be intergrated with OwnCloud). > > > > I use it like that. NFS integrates much better than SMB with unix > > filesystems, and auto-mounting is not always possible with a laptop that > > can be moved between different local networks. > > Note that the nfs://host ioslave will still be working (*), in addition to > system mounts. The only thing discussed here is the suid script (and > related GUI) that allows users to make nfs shares. > > (*) so even if "almost always system mounted" is not so true, we still have > a client solution that doesn't require mounting. Which I like very much > because it doesn't make your machine hang when the server is shut down and > you forgot to umount the share... (But then again, sftp:// is easier to > setup and more secure). > > Anyway, I don't know if user-controlled sharing should be kept or removed. > It would be interesting to have Mandriva's feedback, since the feature was > coded by Mandriva developers, years ago. One of the things that confused me, is that I have never seen this feature exposed. If it has no configuration interface, how is it even used? If it is just dead code, please kill it. We have way too much semi-dead code lying around in the lesser KDE modules. `Allan
Re: About remove nfs filesharing support
On 31 Dec 2010, at 4:26 AM, David Faure wrote: On Tuesday 28 December 2010, Allan Sandfeld Jensen wrote: >> On Tuesday 28 December 2010, Jonathan Riddell wrote: >>> On Tue, Dec 28, 2010 at 01:18:10PM -0200, Raphael Kubo da Costa wrote: Does that mean making KDE completely oblivious to NFS at all? >>> >>> No, NFS is almost always system mounted. I've never come across >>> anyone actually using it for user mounts. Far better to work on >>> support for protocols that are designed for the job and standardied >>> like SMB (designed for the job, Rodrigo already implemented), and >>> Webdav (standardised, could be intergrated with OwnCloud). >> >> I use it like that. NFS integrates much better than SMB with unix >> filesystems, and auto-mounting is not always possible with a laptop that >> can be moved between different local networks. > > Note that the nfs://host ioslave will still be working (*), in addition to > system mounts. The only thing discussed here is the suid script (and related > GUI) that allows users to make nfs shares. > > (*) so even if "almost always system mounted" is not so true, we still have a > client solution that doesn't require mounting. Which I like very much because > it doesn't make your machine hang when the server is shut down and you forgot > to umount the share... (But then again, sftp:// is easier to setup and more > secure). > > Anyway, I don't know if user-controlled sharing should be kept or removed. > It would be interesting to have Mandriva's feedback, since the feature was > coded by Mandriva developers, years ago. > Actually, David, you were the one that did the work of helping shepherding that in (I remember as I was the one that got the original author and you talking to get it into KDE back around the 3.2(I think...) series) To be frank, I'd be loath to remove both the ability to create exports or connect to NFS from KDE, as it is a feature that is trivially easy to do on Mac, and Windows (with SFU installed). Please don't remove another system level thing as has been done before. Best option here is to create a KAuth shim app to do the work for this. > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org). >
Re: About remove nfs filesharing support
On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote: > On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer wrote: > > One code level nitpick: use of magic UID number 1000. In case this is some > > kind of standard there is certainly a header specifying a constant/macro for > > it. If not this looks kind of operating system or maybe even vendor > > specific. > > > > This number needs to be discovered, but I hardcoded it just to get it > working :-) > kcm_kdm and genkdmconf have code which (probably - i didn't look at your patch) serves the same purpose. it should be probably centralized somehow.
Re: About remove nfs filesharing support
On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen wrote: > On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote: >> On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer wrote: >> > One code level nitpick: use of magic UID number 1000. In case this is some >> > kind of standard there is certainly a header specifying a constant/macro >> > for >> > it. If not this looks kind of operating system or maybe even vendor >> > specific. >> > >> >> This number needs to be discovered, but I hardcoded it just to get it >> working :-) >> > kcm_kdm and genkdmconf have code which (probably - i didn't look at your > patch) serves the same purpose. it should be probably centralized > somehow. > Thanks Oswald, I had no idea where to look for it. I think that it should be centralized in KUser. What do you think?
Re: About remove nfs filesharing support
I just sent the *initial* patch to http://reviewboard.kde.org/r/6308/. It lacks username permission handling, disabling widgets when samba share checkbox in unmarked, ui polishing and more :-) The patch already removes the nfs support from the plugin. 2011/1/8 Rodrigo Belém : > On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen wrote: >> On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote: >>> On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer >>> wrote: >>> > One code level nitpick: use of magic UID number 1000. In case this is some >>> > kind of standard there is certainly a header specifying a constant/macro >>> > for >>> > it. If not this looks kind of operating system or maybe even vendor >>> > specific. >>> > >>> >>> This number needs to be discovered, but I hardcoded it just to get it >>> working :-) >>> >> kcm_kdm and genkdmconf have code which (probably - i didn't look at your >> patch) serves the same purpose. it should be probably centralized >> somehow. >> > > Thanks Oswald, I had no idea where to look for it. I think that it > should be centralized in KUser. What do you think? >
Re: About remove nfs filesharing support
On Sat, Jan 08, 2011 at 03:54:19PM -0400, Rodrigo Belém wrote: > On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen wrote: > > kcm_kdm and genkdmconf have code which (probably - i didn't look at your > > patch) serves the same purpose. it should be probably centralized > > somehow. > > > Thanks Oswald, I had no idea where to look for it. I think that it > should be centralized in KUser. What do you think? > too specialized. it should probably go to libkworkspace or some such. note that the code is quite a hack which assumes fixed values. the correct solution would be actually parsing /etc/login.defs (and whatever other config files exist, depending on the distribution/os).
Re: About remove nfs filesharing support
Hi all, I update the patch some days ago, but I forgot to post it here. Could you take a look on it? :-) http://reviewboard.kde.org/r/6308/ Thanks, Rodrigo Belem. On 1/8/11, Rodrigo Belém wrote: > I just sent the *initial* patch to http://reviewboard.kde.org/r/6308/. > It lacks username permission handling, disabling widgets when samba > share checkbox in unmarked, ui polishing and more :-) The patch > already removes the nfs support from the plugin. > > 2011/1/8 Rodrigo Belém : >> On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen wrote: >>> On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote: On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer wrote: > One code level nitpick: use of magic UID number 1000. In case this is > some > kind of standard there is certainly a header specifying a > constant/macro for > it. If not this looks kind of operating system or maybe even vendor > specific. > This number needs to be discovered, but I hardcoded it just to get it working :-) >>> kcm_kdm and genkdmconf have code which (probably - i didn't look at your >>> patch) serves the same purpose. it should be probably centralized >>> somehow. >>> >> >> Thanks Oswald, I had no idea where to look for it. I think that it >> should be centralized in KUser. What do you think? >> >
