Re: KDE Goal Project specific issue: Automate and systematize internal processes

[Nate Graham]

[Apologies for the delayed reply; your email was erroneously sorted into 
my spam folder and I missed it until now.]


All of these proposals are just proposals. Nothing mandatory, required, 
or burdened with rules. Just something that overall, would probably 
improve thing such that I would hope that projects would want to opt in.


You can insert tags into the code to make clang-format ignore parts of 
it, which could be uses in the example you've mentioned.


Nate


On 9/10/22 13:34, Michael Reeves wrote:

I  just  read this in the Automate and systematize internal processes Goal

Move clang-format from a git hookscript to pre-commit CI so that merge 
requests will show a CI failure when badly-formatted changes exist, and 
people can see this in a nice UI and fix them


https://phabricator.kde.org/T15627 

For kdiff3 this likely to create un-needed noise due the code base not 
perfectly aligning to the .clang-format format file provided. This comes 
both from headers whose format is untouched a aumber of spaceing quirks 
that I cann't teach clang-format to either ignore or due itself. Is the 
above proposal to  be opt-in like the current system or automatic for 
all projects?

KDE Goal Project specific issue: Automate and systematize internal processes

[Michael Reeves]

I  just  read this in the Automate and systematize internal processes Goal

Move clang-format from a git hookscript to pre-commit CI so that merge
requests will show a CI failure when badly-formatted changes exist, and
people can see this in a nice UI and fix them

https://phabricator.kde.org/T15627

For kdiff3 this likely to create un-needed noise due the code base not
perfectly aligning to the .clang-format format file provided. This comes
both from headers whose format is untouched a aumber of spaceing quirks
that I cann't teach clang-format to either ignore or due itself. Is the
above proposal to  be opt-in like the current system or automatic for all
projects?