Re: KDE Review: Arianna

2023-03-03 Thread Carl Schwan
Le dimanche 26 février 2023 à 4:53 AM, Kevin Kofler  a 
écrit :

> Carl Schwan wrote:
>
> > I want to move Arianna to KDE review. Arianna is an ebook reader
> > currently only supporting epubs. This is based on top of epub.js
> > and QtWebEngine for the actualy rendering of ebooks as doing that
> > from scratch in Qt would be too much work.
>
>
> Okular has an EPub backend using libepub and QTextDocument. How does
> Arianna compare to that? I would expect native code to be more efficient
> than JavaScript especially on mobile devices, which are apparently
> Arianna's main target. But I do not know whether there are, e.g., EPub
> documents that Arianna can render and Okular cannot, so that is why I am
> asking how they compare.

Okular QTextDocument is quite inefficient see for example this long standing
bug: https://bugs.kde.org/show_bug.cgi?id=359932 Aside from being quite
inefficient, QTextDocument has only some basic HTML support and to have a
good support of Epubs you basically need a much better HTML/CSS support
which only a web engine can provide.

If someone wants to try to optimize the native code of Okular, they should
probably replace the old C and unmaintained based libepub library 
and replace it with [1] and [2] which should provide a better starting point.
(and nope, I'm not gonna do it, I'm already too busy with other things).

Carl

[1]: https://invent.kde.org/graphics/arianna/-/blob/master/src/epubcontainer.cpp
[2]: https://github.com/sandsmark/epubreader/blob/master/epubdocument.cpp


Re: KDE Review: Arianna

2023-02-27 Thread Jonathan Riddell
The epub.js is not in preferred modifiable form.  It's cleartext but it's
not the source as anyone would want to edit it.  The comment at the end
says it comes from a mapping called sourceMappingURL=epub.js.map so the
full source of this should be included.

Jonathan


On Sat, 25 Feb 2023 at 13:59, Carl Schwan  wrote:
>
> Hi folks,
>
> I want to move Arianna to KDE review. Arianna is an ebook reader
> currently only supporting epubs. This is based on top of epub.js
> and QtWebEngine for the actualy rendering of ebooks as doing that
> from scratch in Qt would be too much work.
>
> The repo can be found here: https://invent.kde.org/graphics/arianna/
>
> I create a gitlab issue to track the progress of this:
> https://invent.kde.org/graphics/arianna/-/issues/1 Please free to add
> your comments as recently suggested in this mailing list.
>
> Cheers,
> Carl


Re: KDE Review: Arianna

2023-02-27 Thread Kevin Kofler
Carl Schwan wrote:
> I want to move Arianna to KDE review. Arianna is an ebook reader
> currently only supporting epubs. This is based on top of epub.js
> and QtWebEngine for the actualy rendering of ebooks as doing that
> from scratch in Qt would be too much work.

Okular has an EPub backend using libepub and QTextDocument. How does Arianna 
compare to that? I would expect native code to be more efficient than 
JavaScript *especially* on mobile devices, which are apparently Arianna's 
main target. But I do not know whether there are, e.g., EPub documents that 
Arianna can render and Okular cannot, so that is why I am asking how they 
compare.

Kevin Kofler



Re: KDE Review: Arianna

2023-02-26 Thread Albert Astals Cid
El diumenge, 26 de febrer de 2023, a les 4:53:05 (CET), Kevin Kofler va 
escriure:
> Carl Schwan wrote:
> > I want to move Arianna to KDE review. Arianna is an ebook reader
> > currently only supporting epubs. This is based on top of epub.js
> > and QtWebEngine for the actualy rendering of ebooks as doing that
> > from scratch in Qt would be too much work.
> 
> Okular has an EPub backend using libepub and QTextDocument. How does
> Arianna compare to that?

Okular is probably much worse, QTextDocument is not good for showing HTML-like 
content.

Cheers,
  Albert

> I would expect native code to be more efficient
> than JavaScript *especially* on mobile devices, which are apparently
> Arianna's main target. But I do not know whether there are, e.g., EPub
> documents that Arianna can render and Okular cannot, so that is why I am
> asking how they compare.
> 
> Kevin Kofler






Re: KDE Review: Arianna

2023-02-25 Thread Kevin Kofler
Carl Schwan wrote:
> I want to move Arianna to KDE review. Arianna is an ebook reader
> currently only supporting epubs. This is based on top of epub.js
> and QtWebEngine for the actualy rendering of ebooks as doing that
> from scratch in Qt would be too much work.

Okular has an EPub backend using libepub and QTextDocument. How does 
Arianna compare to that? I would expect native code to be more efficient 
than JavaScript *especially* on mobile devices, which are apparently 
Arianna's main target. But I do not know whether there are, e.g., EPub 
documents that Arianna can render and Okular cannot, so that is why I am 
asking how they compare.

Kevin Kofler


Re: KDE Review: Arianna

2023-02-25 Thread Nicolas Fella

Am 25.02.23 um 14:59 schrieb Carl Schwan:

Hi folks,

I want to move Arianna to KDE review. Arianna is an ebook reader
currently only supporting epubs. This is based on top of epub.js
and QtWebEngine for the actualy rendering of ebooks as doing that
from scratch in Qt would be too much work.

The repo can be found here: https://invent.kde.org/graphics/arianna/

I create a gitlab issue to track the progress of this:
https://invent.kde.org/graphics/arianna/-/issues/1 Please free to add
your comments as recently suggested in this mailing list.


I've added some comments/suggestions to the issue.

Overall looks quite good to me.

Cheers

Nico



KDE Review: Arianna

2023-02-25 Thread Carl Schwan
Hi folks,

I want to move Arianna to KDE review. Arianna is an ebook reader
currently only supporting epubs. This is based on top of epub.js
and QtWebEngine for the actualy rendering of ebooks as doing that
from scratch in Qt would be too much work.

The repo can be found here: https://invent.kde.org/graphics/arianna/

I create a gitlab issue to track the progress of this:
https://invent.kde.org/graphics/arianna/-/issues/1 Please free to add
your comments as recently suggested in this mailing list.

Cheers,
Carl