Re: KDiff Bug 436958
Or maybe not. I'll have another look at this now that emergency fix is addressed. Calling SourceData::readAndPreprocess on a SourceData object flagged as a directory shouldn't be happening. On Thu, May 13, 2021, 3:59 PM Michael Reeves wrote: > I was looking at the wrong file then. That very likely is related to bug > 436958. > > On Thu, May 13, 2021, 3:35 PM Ingo Klöcker wrote: > >> On Donnerstag, 13. Mai 2021 07:53:05 CEST Michael Reeves wrote: >> > That's a crash in the implicit default constructor of QTemporaryFile. >> >> I don't think so. >> >> > > #10 0x55590227c7bb in SourceData::readAndPreprocess >> > > (this=0x555903298590, pEncoding=0x555903144ab0, >> > > bAutoDetectUnicode=true) at >> > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 >> points to the line >> Q_ASSERT(!m_fileAccess.isDir()); >> in SourceData.cpp. >> >> https://invent.kde.org/sdk/kdiff3/-/blob/master/src/SourceData.cpp#L351 >> >> Regards, >> Ingo >> >> > On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: >> > > On Thu, May 13, 2021 at 1:00 AM Michael Reeves >> > > wrote: >> > > > Could someone other than myself please have a look at this. >> > > > >> > > > https://bugs.kde.org/show_bug.cgi?id=436958 >> > > > >> > > > None of these issues affect my system. I strongly suspect a distro >> > > > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The >> > > > offending commit makes no sense as a true root cause. I would like >> an >> > > > answer as to what is going on. >> > > >> > > Hi, >> > > I just tried opening it and I get this crash: >> > > >> > > #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 >> > > #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 >> > > #7 0x7f088d4dfc51 in qt_message_fatal (message=> > > pointer>..., context=...) at >> > > >> /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:191 >> > > 4 >> > > #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, >> > > msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at >> > > >> /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 >> > > #9 0x7f088d4df04a in qt_assert (assertion=, >> > > file=, line=) at >> > > >> /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 >> > > #10 0x55590227c7bb in SourceData::readAndPreprocess >> > > (this=0x555903298590, pEncoding=0x555903144ab0, >> > > bAutoDetectUnicode=true) at >> > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 >> > > #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, >> > > pTotalDiffStatus=0x55590334ae70, inFlags=...) at >> > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 >> > > #12 0x5559021afecb in KDiff3App::slotFileOpen >> > > (this=0x555903379bf0) at >> > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 >> > > #13 0x55590215b154 in KDiff3App::completeInit >> > > (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at >> > > /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 >> > > #14 0x55590214c2db in KDiff3Shell::KDiff3Shell >> > > (this=0x5559031d7400, bCompleteInit=true) at >> > > /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 >> > > #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at >> > > /home/apol/devel/frameworks/kdiff3/src/main.cpp:188 >> >>
Re: KDiff Bug 436958
I was looking at the wrong file then. That very likely is related to bug 436958. On Thu, May 13, 2021, 3:35 PM Ingo Klöcker wrote: > On Donnerstag, 13. Mai 2021 07:53:05 CEST Michael Reeves wrote: > > That's a crash in the implicit default constructor of QTemporaryFile. > > I don't think so. > > > > #10 0x55590227c7bb in SourceData::readAndPreprocess > > > (this=0x555903298590, pEncoding=0x555903144ab0, > > > bAutoDetectUnicode=true) at > > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > points to the line > Q_ASSERT(!m_fileAccess.isDir()); > in SourceData.cpp. > > https://invent.kde.org/sdk/kdiff3/-/blob/master/src/SourceData.cpp#L351 > > Regards, > Ingo > > > On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > > > On Thu, May 13, 2021 at 1:00 AM Michael Reeves > > > wrote: > > > > Could someone other than myself please have a look at this. > > > > > > > > https://bugs.kde.org/show_bug.cgi?id=436958 > > > > > > > > None of these issues affect my system. I strongly suspect a distro > > > > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The > > > > offending commit makes no sense as a true root cause. I would like an > > > > answer as to what is going on. > > > > > > Hi, > > > I just tried opening it and I get this crash: > > > > > > #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 > > > #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 > > > #7 0x7f088d4dfc51 in qt_message_fatal (message= > > pointer>..., context=...) at > > > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:191 > > > 4 > > > #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, > > > msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at > > > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 > > > #9 0x7f088d4df04a in qt_assert (assertion=, > > > file=, line=) at > > > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 > > > #10 0x55590227c7bb in SourceData::readAndPreprocess > > > (this=0x555903298590, pEncoding=0x555903144ab0, > > > bAutoDetectUnicode=true) at > > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > > > #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, > > > pTotalDiffStatus=0x55590334ae70, inFlags=...) at > > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 > > > #12 0x5559021afecb in KDiff3App::slotFileOpen > > > (this=0x555903379bf0) at > > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 > > > #13 0x55590215b154 in KDiff3App::completeInit > > > (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at > > > /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 > > > #14 0x55590214c2db in KDiff3Shell::KDiff3Shell > > > (this=0x5559031d7400, bCompleteInit=true) at > > > /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 > > > #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at > > > /home/apol/devel/frameworks/kdiff3/src/main.cpp:188 > >
Re: KDiff Bug 436958
Yeah the code your getting is out of sync with git. That crash is in a qt function that is not directly called by kdiff3. The is visible sign of how its getting called at that line number. In any event I'm about to push a fix for the originating issue. Try building with CMAKE_BUILD_TYPE=Debug. If that fixes the problem then the patch will resolve your case as well. On Thu, May 13, 2021, 3:35 PM Ingo Klöcker wrote: > On Donnerstag, 13. Mai 2021 07:53:05 CEST Michael Reeves wrote: > > That's a crash in the implicit default constructor of QTemporaryFile. > > I don't think so. > > > > #10 0x55590227c7bb in SourceData::readAndPreprocess > > > (this=0x555903298590, pEncoding=0x555903144ab0, > > > bAutoDetectUnicode=true) at > > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > points to the line > Q_ASSERT(!m_fileAccess.isDir()); > in SourceData.cpp. > > https://invent.kde.org/sdk/kdiff3/-/blob/master/src/SourceData.cpp#L351 > > Regards, > Ingo > > > On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > > > On Thu, May 13, 2021 at 1:00 AM Michael Reeves > > > wrote: > > > > Could someone other than myself please have a look at this. > > > > > > > > https://bugs.kde.org/show_bug.cgi?id=436958 > > > > > > > > None of these issues affect my system. I strongly suspect a distro > > > > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The > > > > offending commit makes no sense as a true root cause. I would like an > > > > answer as to what is going on. > > > > > > Hi, > > > I just tried opening it and I get this crash: > > > > > > #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 > > > #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 > > > #7 0x7f088d4dfc51 in qt_message_fatal (message= > > pointer>..., context=...) at > > > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:191 > > > 4 > > > #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, > > > msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at > > > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 > > > #9 0x7f088d4df04a in qt_assert (assertion=, > > > file=, line=) at > > > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 > > > #10 0x55590227c7bb in SourceData::readAndPreprocess > > > (this=0x555903298590, pEncoding=0x555903144ab0, > > > bAutoDetectUnicode=true) at > > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > > > #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, > > > pTotalDiffStatus=0x55590334ae70, inFlags=...) at > > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 > > > #12 0x5559021afecb in KDiff3App::slotFileOpen > > > (this=0x555903379bf0) at > > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 > > > #13 0x55590215b154 in KDiff3App::completeInit > > > (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at > > > /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 > > > #14 0x55590214c2db in KDiff3Shell::KDiff3Shell > > > (this=0x5559031d7400, bCompleteInit=true) at > > > /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 > > > #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at > > > /home/apol/devel/frameworks/kdiff3/src/main.cpp:188 > >
Re: KDiff Bug 436958
On Donnerstag, 13. Mai 2021 07:53:05 CEST Michael Reeves wrote: > That's a crash in the implicit default constructor of QTemporaryFile. I don't think so. > > #10 0x55590227c7bb in SourceData::readAndPreprocess > > (this=0x555903298590, pEncoding=0x555903144ab0, > > bAutoDetectUnicode=true) at > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 points to the line Q_ASSERT(!m_fileAccess.isDir()); in SourceData.cpp. https://invent.kde.org/sdk/kdiff3/-/blob/master/src/SourceData.cpp#L351 Regards, Ingo > On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > > On Thu, May 13, 2021 at 1:00 AM Michael Reeves > > wrote: > > > Could someone other than myself please have a look at this. > > > > > > https://bugs.kde.org/show_bug.cgi?id=436958 > > > > > > None of these issues affect my system. I strongly suspect a distro > > > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The > > > offending commit makes no sense as a true root cause. I would like an > > > answer as to what is going on. > > > > Hi, > > I just tried opening it and I get this crash: > > > > #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 > > #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 > > #7 0x7f088d4dfc51 in qt_message_fatal (message= > pointer>..., context=...) at > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:191 > > 4 > > #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, > > msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 > > #9 0x7f088d4df04a in qt_assert (assertion=, > > file=, line=) at > > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 > > #10 0x55590227c7bb in SourceData::readAndPreprocess > > (this=0x555903298590, pEncoding=0x555903144ab0, > > bAutoDetectUnicode=true) at > > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > > #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, > > pTotalDiffStatus=0x55590334ae70, inFlags=...) at > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 > > #12 0x5559021afecb in KDiff3App::slotFileOpen > > (this=0x555903379bf0) at > > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 > > #13 0x55590215b154 in KDiff3App::completeInit > > (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at > > /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 > > #14 0x55590214c2db in KDiff3Shell::KDiff3Shell > > (this=0x5559031d7400, bCompleteInit=true) at > > /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 > > #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at > > /home/apol/devel/frameworks/kdiff3/src/main.cpp:188 signature.asc Description: This is a digitally signed message part.
Re: KDiff Bug 436958
That's a crash in the implicit default constructor of QTemporaryFile. And that would be a Qt bug if its reproducible. You sure you have the current 1.9 branch and built from that? On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > On Thu, May 13, 2021 at 1:00 AM Michael Reeves > wrote: > > > > Could someone other than myself please have a look at this. > > > > https://bugs.kde.org/show_bug.cgi?id=436958 > > > > None of these issues affect my system. I strongly suspect a distro > > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The > > offending commit makes no sense as a true root cause. I would like an > > answer as to what is going on. > > Hi, > I just tried opening it and I get this crash: > > #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 > #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 > #7 0x7f088d4dfc51 in qt_message_fatal (message= pointer>..., context=...) at > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1914 > #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, > msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 > #9 0x7f088d4df04a in qt_assert (assertion=, > file=, line=) at > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 > #10 0x55590227c7bb in SourceData::readAndPreprocess > (this=0x555903298590, pEncoding=0x555903144ab0, > bAutoDetectUnicode=true) at > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, > pTotalDiffStatus=0x55590334ae70, inFlags=...) at > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 > #12 0x5559021afecb in KDiff3App::slotFileOpen > (this=0x555903379bf0) at > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 > #13 0x55590215b154 in KDiff3App::completeInit > (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at > /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 > #14 0x55590214c2db in KDiff3Shell::KDiff3Shell > (this=0x5559031d7400, bCompleteInit=true) at > /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 > #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at > /home/apol/devel/frameworks/kdiff3/src/main.cpp:188 >
Re: KDiff Bug 436958
Thanks do we have the text of the assert? On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > On Thu, May 13, 2021 at 1:00 AM Michael Reeves > wrote: > > > > Could someone other than myself please have a look at this. > > > > https://bugs.kde.org/show_bug.cgi?id=436958 > > > > None of these issues affect my system. I strongly suspect a distro > > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The > > offending commit makes no sense as a true root cause. I would like an > > answer as to what is going on. > > Hi, > I just tried opening it and I get this crash: > > #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 > #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 > #7 0x7f088d4dfc51 in qt_message_fatal (message= pointer>..., context=...) at > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1914 > #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, > msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 > #9 0x7f088d4df04a in qt_assert (assertion=, > file=, line=) at > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 > #10 0x55590227c7bb in SourceData::readAndPreprocess > (this=0x555903298590, pEncoding=0x555903144ab0, > bAutoDetectUnicode=true) at > /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 > #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, > pTotalDiffStatus=0x55590334ae70, inFlags=...) at > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 > #12 0x5559021afecb in KDiff3App::slotFileOpen > (this=0x555903379bf0) at > /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 > #13 0x55590215b154 in KDiff3App::completeInit > (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at > /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 > #14 0x55590214c2db in KDiff3Shell::KDiff3Shell > (this=0x5559031d7400, bCompleteInit=true) at > /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 > #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at > /home/apol/devel/frameworks/kdiff3/src/main.cpp:188 >
Re: KDiff Bug 436958
On Thu, May 13, 2021 at 1:00 AM Michael Reeves wrote: > > Could someone other than myself please have a look at this. > > https://bugs.kde.org/show_bug.cgi?id=436958 > > None of these issues affect my system. I strongly suspect a distro > specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The > offending commit makes no sense as a true root cause. I would like an > answer as to what is going on. Hi, I just tried opening it and I get this crash: #5 0x7f088cf54ef5 in raise () from /usr/lib/libc.so.6 #6 0x7f088cf3e862 in abort () from /usr/lib/libc.so.6 #7 0x7f088d4dfc51 in qt_message_fatal (message=..., context=...) at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1914 #8 QMessageLogger::fatal (this=this@entry=0x7ffef2f4b378, msg=msg@entry=0x7f088d7ddea0 "ASSERT: \"%s\" in file %s, line %d") at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893 #9 0x7f088d4df04a in qt_assert (assertion=, file=, line=) at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3358 #10 0x55590227c7bb in SourceData::readAndPreprocess (this=0x555903298590, pEncoding=0x555903144ab0, bAutoDetectUnicode=true) at /home/apol/devel/frameworks/kdiff3/src/SourceData.cpp:351 #11 0x5559021a6d5d in KDiff3App::mainInit (this=0x555903379bf0, pTotalDiffStatus=0x55590334ae70, inFlags=...) at /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:144 #12 0x5559021afecb in KDiff3App::slotFileOpen (this=0x555903379bf0) at /home/apol/devel/frameworks/kdiff3/src/pdiff.cpp:938 #13 0x55590215b154 in KDiff3App::completeInit (this=0x555903379bf0, fn1=..., fn2=..., fn3=...) at /home/apol/devel/frameworks/kdiff3/src/kdiff3.cpp:519 #14 0x55590214c2db in KDiff3Shell::KDiff3Shell (this=0x5559031d7400, bCompleteInit=true) at /home/apol/devel/frameworks/kdiff3/src/kdiff3_shell.cpp:60 #15 0x555902148223 in main (argc=1, argv=0x7ffef2f4d108) at /home/apol/devel/frameworks/kdiff3/src/main.cpp:188
KDiff Bug 436958
Could someone other than myself please have a look at this. https://bugs.kde.org/show_bug.cgi?id=436958 None of these issues affect my system. I strongly suspect a distro specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The offending commit makes no sense as a true root cause. I would like an answer as to what is going on.
