Kirigami Addons in KDEReview
Hello folks, I would like to put request a KDE review on the Kirigami Addons project. This repository contains for the moment 2 plugins: * A TreeView for QML: this is maintained by Marco and provides a QML tree view using KItemModels::KDescendantsProxyModel. A copy of this is already in use in the Plasma System Monitor. * A DateTime collections of elements: this is maintained by both me and David Edmundson and provides a date picker, a month view for calendars and a time picker. More plugins might be added in the future to allow to share basic visual components between kirigami applications without putting too much random stuff in Kirigami or adding dependencies to Kirigami. You can find a link to the repo here: https://invent.kde.org/libraries/kirigami-addons/ Regards Carl Schwan https://carlschwan.eu
Re: Kirigami Addons in KDEReview
El divendres, 30 d’abril de 2021, a les 15:51:46 (CEST), Carl Schwan va escriure: > Hello folks, > > I would like to put request a KDE review on the Kirigami Addons > project. This repository contains for the moment 2 plugins: > > * A TreeView for QML: this is maintained by Marco and provides > a QML tree view using KItemModels::KDescendantsProxyModel. A copy > of this is already in use in the Plasma System Monitor. > > * A DateTime collections of elements: this is maintained by both > me and David Edmundson and provides a date picker, a month view > for calendars and a time picker. > > More plugins might be added in the future to allow to share basic > visual components between kirigami applications without putting > too much random stuff in Kirigami or adding dependencies to > Kirigami. It doesn't have a Messages.sh I'm a bit confused about the text: in TimeLabel.qml is it always 2019? :D I think the i18n() should probably be i18nd and specify a domain once you have a Messages.sh This probably needs translation? text: checked ? "PM" : "AM" There's a few warnings that look relatively easy to fix https://ghostbin.com/paste/jNhLT Missing from dateandtime/qmldir DesktopDateInput.qml MobileDateInput.qml Missing from treeview/qmldir InternalTreeTableView.qml TreeViewDecoration.qml InternalTreeListView.qml Cheers, Albert > > You can find a link to the repo here: > https://invent.kde.org/libraries/kirigami-addons/ > > Regards > Carl Schwan > https://carlschwan.eu > > >
Re: Kirigami Addons in KDEReview
On 4/30/21 7:51 AM, Carl Schwan wrote: Hello folks, I would like to put request a KDE review on the Kirigami Addons project. This repository contains for the moment 2 plugins: * A TreeView for QML: this is maintained by Marco and provides a QML tree view using KItemModels::KDescendantsProxyModel. A copy of this is already in use in the Plasma System Monitor. * A DateTime collections of elements: this is maintained by both me and David Edmundson and provides a date picker, a month view for calendars and a time picker. More plugins might be added in the future to allow to share basic visual components between kirigami applications without putting too much random stuff in Kirigami or adding dependencies to Kirigami. You can find a link to the repo here: https://invent.kde.org/libraries/kirigami-addons/ Regards Carl Schwan https://carlschwan.eu I would like to see https://invent.kde.org/libraries/kirigami-addons/-/issues/2 fixed first as the date picker is sort of almost unusable right now. Nate
Re: Kirigami Addons in KDEReview
On Friday, 30 April 2021 23:39:17 CEST Nate Graham wrote: > I would like to see > https://invent.kde.org/libraries/kirigami-addons/-/issues/2 fixed first > as the date picker is sort of almost unusable right now. A good date picker would be most enthusiastically received by the myGNUHealth project, I think. [ade] signature.asc Description: This is a digitally signed message part.
Re: Kirigami Addons in KDEReview
Hey, any news for kirigami-addons getting out of review? I strongly vote for getting it out of review or at least release a new 0.3. So far I can tell master has a lot improved Date picker, that at least for my usage ( laptop with mouse) I could now use ktrip to select a date and time *yeah*. It is a bit of a pitty, that there is software based on kirigami-addons release ( ktrip and initarary). That currently has no useful time/date picker, when you don't build from master branch. I tested that on my librem 5 with postmasker OS, as they ship kirigami-addons v0.2 and I wanted to use ktrip and had no possibility to change the time... > I would like to see > https://invent.kde.org/libraries/kirigami-addons/-/issues/2 fixed first > as the date picker is sort of almost unusable right now. I can understand, that releasing a not really useful timepicker is not nice - but than at least to regular unstable releases. And there is a lot of improvments since 0.2. Some highlights: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/27 regards, hefee -- Mein öffentlicher Schlüssel / My public key: E68031D299A6527C Fingerabdruck / Fingerprint: D256 4951 1272 8840 BB5E 99F2 E680 31D2 99A6 527C runterladen/download: https://keys.openpgp.org/vks/v1/by-fingerprint/ D256495112728840BB5E99F2E68031D299A6527C signature.asc Description: This is a digitally signed message part.
Re : Re: Kirigami Addons in KDEReview
Le samedi 28 mai 2022 à 4:56 PM, Sandro Knauß a écrit : > Hey, Hi, Sorry about dropping the ball on this KDE review request. I was more interested at that time mostly the treeview luging and not so much about the time and date module and my interest in fixing the issues there was not great. Like you said the time picker improved a bit since the issue was brought up, so let's move this project back to KDE Review and wait 2 weeks. It would help us in Kalendar, since we are currently vendoring the tree view plugin and have a duplication of the date picker. Additionally to the two MRs pointed out, there were also a few more improvements: - The TreeView is not working with RTL layouts and has better keyboard navigation - The project is now fully 'reuse' compliant Cheers, Carl > any news for kirigami-addons getting out of review? I strongly vote for > getting it out of review or at least release a new 0.3. > > So far I can tell master has a lot improved Date picker, that at least for my > usage ( laptop with mouse) I could now use ktrip to select a date and time > yeah. > > It is a bit of a pitty, that there is software based on kirigami-addons > release ( ktrip and initarary). That currently has no useful time/date picker, > when you don't build from master branch. I tested that on my librem 5 with > postmasker OS, as they ship kirigami-addons v0.2 and I wanted to use ktrip and > had no possibility to change the time... > > > I would like to see > > https://invent.kde.org/libraries/kirigami-addons/-/issues/2 fixed first > > as the date picker is sort of almost unusable right now. > > > I can understand, that releasing a not really useful timepicker is not nice - > but than at least to regular unstable releases. And there is a lot of > improvments since 0.2. Some highlights: > > https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 > https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/27 > > regards, > > hefee > > -- > Mein öffentlicher Schlüssel / My public key: E68031D299A6527C > Fingerabdruck / Fingerprint: > D256 4951 1272 8840 BB5E 99F2 E680 31D2 99A6 527C > runterladen/download: > https://keys.openpgp.org/vks/v1/by-fingerprint/ > D256495112728840BB5E99F2E68031D299A6527C
