Re: New repo in kdereview: kclock
I'm happy with KClock now, FWIW. I'm going to start sending merge requests for some of the little tiny UI things I notice that I don't think are worth prolonging KDEReview over. Nate On 2/2/23 21:11, Devin wrote: Hi everyone, Is there any feedback left for KClock? If not, I will consider it to have passed kdereview. Thanks, Devin On Fri, Dec 30, 2022 at 2:27 AM Justin wrote: Thanks for the quick reply Albert. I'm not a developer but I've gone over much of the comments from previous: Tested on 22.11 > New Timer doesn't work? Ah it's because it needs kclockd running for that, would it be very hard to give a warning if it isn't running? Seems kclockd is now running automatically. If it is not automatically running that would (in my opinion) be a packaging issue on the distro side. > Is that kirigamiaddons thing released? Seems to be the reason i can't add new Alarms Kirigami Addons has now passed KDE review and has stable releases > Not an expert in UI but for stopwatch having Start/Pause on the top left feels a bit unnatural, maybe would make sense swapping reset and Start? Ask the VDG i guess. In the version I'm running it's centered nicely and I think works well. If you can check this against latest git master to confirm the UI is still the same. > Also in stopwatch for me it'd make a lot of sense if pressing the time starts/pauses, what do you think? This is functioning now. > Silence Alarm After shows an horizontal scrollbar that doesn't to be very useful https://i.imgur.com/7O8DBJc.png This is now called Ring Duration and has no horizontal scroll bar even at the minimum window width. > It's even worse in Alarm Snooze Length where it goes over existing text Same as above, now fixed. > You're missing Messages.sh in kclockd I see this now in the kclockd folder > Please check i18n in your qml files, these seem like need i18n > ... Lots of this i18n stuff appears to have been moved and will need a new review Justin On 30/12/22 20:44, Albert Astals Cid wrote: El divendres, 30 de desembre de 2022, a les 8:46:56 (CET), Justin va escriure: Hey Team, This was last posted about on October 18 2021. I looked at the three items that were needed for kirigami-addons: * Missing is REUSE compliance: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13 * Hanyoung is working on a better time picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17 * And Clau is working on a better date picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 They have all now been merged. Can we resume the review on kirigami-addons so we can continue on kclock? Thanks everyone and have a enjoyable and safe holiday! I gave a long list of comments back in the day that were never answered, do that first and maybe i give it another look. Cheers, Albert Justin
Re: New repo in kdereview: kclock
Hi everyone, Is there any feedback left for KClock? If not, I will consider it to have passed kdereview. Thanks, Devin On Fri, Dec 30, 2022 at 2:27 AM Justin wrote: > > Thanks for the quick reply Albert. I'm not a developer but I've gone > over much of the comments from previous: > > Tested on 22.11 > > > New Timer doesn't work? Ah it's because it needs kclockd running for > that, would it be very hard to give a warning if it isn't running? > > Seems kclockd is now running automatically. If it is not automatically > running that would (in my opinion) be a packaging issue on the distro side. > > > Is that kirigamiaddons thing released? Seems to be the reason i can't > add new Alarms > > Kirigami Addons has now passed KDE review and has stable releases > > > Not an expert in UI but for stopwatch having Start/Pause on the top > left feels a bit unnatural, maybe would make sense swapping reset and > Start? Ask the VDG i guess. > > In the version I'm running it's centered nicely and I think works well. > If you can check this against latest git master to confirm the UI is > still the same. > > > Also in stopwatch for me it'd make a lot of sense if pressing the > time starts/pauses, what do you think? > > This is functioning now. > > > Silence Alarm After shows an horizontal scrollbar that doesn't to be > very useful https://i.imgur.com/7O8DBJc.png > > This is now called Ring Duration and has no horizontal scroll bar even > at the minimum window width. > > > It's even worse in Alarm Snooze Length where it goes over existing text > > Same as above, now fixed. > > > You're missing Messages.sh in kclockd > > I see this now in the kclockd folder > > > Please check i18n in your qml files, these seem like need i18n > > ... > > Lots of this i18n stuff appears to have been moved and will need a new > review > > > Justin > > On 30/12/22 20:44, Albert Astals Cid wrote: > > El divendres, 30 de desembre de 2022, a les 8:46:56 (CET), Justin va > > escriure: > >> Hey Team, > >> > >> This was last posted about on October 18 2021. I looked at the three > >> items that were needed for kirigami-addons: > >> > >> * Missing is REUSE compliance: > >> https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13 > >> * Hanyoung is working on a better time picker: > >> https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17 > >> * And Clau is working on a better date picker: > >> https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 > >> > >> They have all now been merged. Can we resume the review on > >> kirigami-addons so we can continue on kclock? > >> > >> Thanks everyone and have a enjoyable and safe holiday! > > I gave a long list of comments back in the day that were never answered, do > > that first and maybe i give it another look. > > > > Cheers, > >Albert > > > >> Justin > > > > > >
Re: New repo in kdereview: kclock
Thanks for the quick reply Albert. I'm not a developer but I've gone over much of the comments from previous: Tested on 22.11 > New Timer doesn't work? Ah it's because it needs kclockd running for that, would it be very hard to give a warning if it isn't running? Seems kclockd is now running automatically. If it is not automatically running that would (in my opinion) be a packaging issue on the distro side. > Is that kirigamiaddons thing released? Seems to be the reason i can't add new Alarms Kirigami Addons has now passed KDE review and has stable releases > Not an expert in UI but for stopwatch having Start/Pause on the top left feels a bit unnatural, maybe would make sense swapping reset and Start? Ask the VDG i guess. In the version I'm running it's centered nicely and I think works well. If you can check this against latest git master to confirm the UI is still the same. > Also in stopwatch for me it'd make a lot of sense if pressing the time starts/pauses, what do you think? This is functioning now. > Silence Alarm After shows an horizontal scrollbar that doesn't to be very useful https://i.imgur.com/7O8DBJc.png This is now called Ring Duration and has no horizontal scroll bar even at the minimum window width. > It's even worse in Alarm Snooze Length where it goes over existing text Same as above, now fixed. > You're missing Messages.sh in kclockd I see this now in the kclockd folder > Please check i18n in your qml files, these seem like need i18n > ... Lots of this i18n stuff appears to have been moved and will need a new review Justin On 30/12/22 20:44, Albert Astals Cid wrote: El divendres, 30 de desembre de 2022, a les 8:46:56 (CET), Justin va escriure: Hey Team, This was last posted about on October 18 2021. I looked at the three items that were needed for kirigami-addons: * Missing is REUSE compliance: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13 * Hanyoung is working on a better time picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17 * And Clau is working on a better date picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 They have all now been merged. Can we resume the review on kirigami-addons so we can continue on kclock? Thanks everyone and have a enjoyable and safe holiday! I gave a long list of comments back in the day that were never answered, do that first and maybe i give it another look. Cheers, Albert Justin
Re: New repo in kdereview: kclock
El divendres, 30 de desembre de 2022, a les 8:46:56 (CET), Justin va escriure: > Hey Team, > > This was last posted about on October 18 2021. I looked at the three > items that were needed for kirigami-addons: > > * Missing is REUSE compliance: > https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13 > * Hanyoung is working on a better time picker: > https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17 > * And Clau is working on a better date picker: > https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 > > They have all now been merged. Can we resume the review on > kirigami-addons so we can continue on kclock? > > Thanks everyone and have a enjoyable and safe holiday! I gave a long list of comments back in the day that were never answered, do that first and maybe i give it another look. Cheers, Albert > > Justin
Re: New repo in kdereview: kclock
Hey Team, This was last posted about on October 18 2021. I looked at the three items that were needed for kirigami-addons: * Missing is REUSE compliance: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13 * Hanyoung is working on a better time picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17 * And Clau is working on a better date picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 They have all now been merged. Can we resume the review on kirigami-addons so we can continue on kclock? Thanks everyone and have a enjoyable and safe holiday! Justin
Re: New repo in kdereview: kclock
Le lundi 18 octobre 2021 à 2:29 PM, Jonathan Riddell a écrit : > I still don't see any attempt to get kirigami-addons through kdereview and > make a stable release (making a tag in invent isn't the same as making a > stable release). Does anyone feel able to take enough ownership of it to do > that? Else kclock and others will be forever stuck. It's also a problem for KDE Itineray, Plasma System Monitor and Kalendar since the three projects vendors some parts of kirigami addons. There was an attempt by me some time ago to move it through kdereview. This has been a bit stalled due to some lack of time and motivation from my side, sorry :/ Fortunately with Kalendar also depending on Kirigami Addons too, there was a bit of work that was done recently. * Missing is REUSE compliance: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13 I pinged David Ed in the issues and in #plasma last week but will try again tonight :) * Hanyoung is working on a better time picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17 Currently blocked by AM/PM vs 24hours format * And Clau is working on a better date picker: https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20 (upstreaming the modification from Kalendar) Help is welcome for doing reviews :) Cheers, Carl > > Jonathan > > On Fri, 5 Mar 2021 at 02:04, hanyoung wrote: > > > Hello everyone! > > > > I want to move kclock to kdereview. > > > > https://invent.kde.org/plasma-mobile/kclock > > > > KClock is the alarm/clock app for Plasma Mobile. It consists of two parts, > > daemon and the client. The daemon communicates with powerdevil to register > > alarms, and provide DBus interface to interact with the client. > > > > Besides the daemon and the client, some plasmoids also included in the > > repo, although only one is enabled so far. > > > > Regards, > > > > Han
Re: New repo in kdereview: kclock
I still don't see any attempt to get kirigami-addons through kdereview and make a stable release (making a tag in invent isn't the same as making a stable release). Does anyone feel able to take enough ownership of it to do that? Else kclock and others will be forever stuck. Jonathan On Fri, 5 Mar 2021 at 02:04, hanyoung wrote: > Hello everyone! > I want to move kclock to kdereview. > > https://invent.kde.org/plasma-mobile/kclock > > KClock is the alarm/clock app for Plasma Mobile. It consists of two parts, > daemon and the client. The daemon communicates with powerdevil to register > alarms, and provide DBus interface to interact with the client. > > Besides the daemon and the client, some plasmoids also included in the > repo, although only one is enabled so far. > > Regards, > Han >
Re: New repo in kdereview: kclock
On Donnerstag, 3. Juni 2021 16:23:51 CEST Jonathan Riddell wrote: > On Thu, 13 May 2021 at 09:57, hanyoung wrote: > > Kirigami Add-ons (a runtime dependency of kclock) now have a proper > > release. https://invent.kde.org/libraries/kirigami-addons > > Although KClock now has a release published under stable ( > https://download.kde.org/stable/plasma-mobile/21.05/) there is no stable > release of kirigami-addons and no kdereview submission. That should be > fixed first. Well, there was https://mail.kde.org/pipermail/kde-core-devel/2021-April/091283.html Not sure whether all of Albert's and Nate's comments were addressed. Regards, Ingo signature.asc Description: This is a digitally signed message part.
Re: New repo in kdereview: kclock
Although KClock now has a release published under stable ( https://download.kde.org/stable/plasma-mobile/21.05/) there is no stable release of kirigami-addons and no kdereview submission. That should be fixed first. Jonathan On Thu, 13 May 2021 at 09:57, hanyoung wrote: > Kirigami Add-ons (a runtime dependency of kclock) now have a proper > release. https://invent.kde.org/libraries/kirigami-addons > > regards, > Han >
Re: New repo in kdereview: kclock
Kirigami Add-ons (a runtime dependency of kclock) now have a proper release. https://invent.kde.org/libraries/kirigami-addons regards, Han
Re: New repo in kdereview: kclock
El divendres, 5 de març de 2021, a les 3:04:24 CET, hanyoung va escriure: > Hello everyone! > I want to move kclock to kdereview. > > https://invent.kde.org/plasma-mobile/kclock > > KClock is the alarm/clock app for Plasma Mobile. It consists of two parts, > daemon and the client. The daemon communicates with powerdevil to register > alarms, and provide DBus interface to interact with the client. > > Besides the daemon and the client, some plasmoids also included in the repo, > although only one is enabled so far. New Timer doesn't work? Ah it's because it needs kclockd running for that, would it be very hard to give a warning if it isn't running? Is that kirigamiaddons thing released? Seems to be the reason i can't add new Alarms Not an expert in UI but for stopwatch having Start/Pause on the top left feels a bit unnatural, maybe would make sense swapping reset and Start? Ask the VDG i guess. Also in stopwatch for me it'd make a lot of sense if pressing the time starts/pauses, what do you think? Silence Alarm After shows an horizontal scrollbar that doesn't to be very useful https://i.imgur.com/7O8DBJc.png It's even worse in Alarm Snooze Length where it goes over existing text https://i.imgur.com/KwWZzNz.png You're missing Messages.sh in kclockd Please check i18n in your qml files, these seem like need i18n ./src/kclock/qml/BottomToolbar.qml:55:name: "Time" ./src/kclock/qml/BottomToolbar.qml:59:name: "Timer" ./src/kclock/qml/BottomToolbar.qml:63:name: "Stopwatch" ./src/kclock/qml/BottomToolbar.qml:67:name: "Alarm" ./src/kclock/qml/BottomToolbar.qml:71:name: "Settings" There you are trying to translate later doing i18n(model.name), and it very incidentally works because those texts are extracted in other files, but if you didn't have the i18n() for those texts in Sidebar.qml it wouldn't since nothing would know that those strings need to be extracted and translators have to translate them, seems a bit fragile ./src/kclock/qml/SettingsPage.qml:187:name: "30 seconds" ./src/kclock/qml/SettingsPage.qml:191:name: "1 minute" ./src/kclock/qml/SettingsPage.qml:195:name: "5 minutes" ./src/kclock/qml/SettingsPage.qml:199:name: "10 minutes" ./src/kclock/qml/SettingsPage.qml:203:name: "15 minutes" ./src/kclock/qml/SettingsPage.qml:207:name: "Never" ./src/kclock/qml/SettingsPage.qml:242:name: "1 minute" ./src/kclock/qml/SettingsPage.qml:246:name: "2 minutes" ./src/kclock/qml/SettingsPage.qml:250:name: "3 minutes" ./src/kclock/qml/SettingsPage.qml:254:name: "4 minutes" ./src/kclock/qml/SettingsPage.qml:258:name: "5 minutes" ./src/kclock/qml/SettingsPage.qml:262:name: "10 minutes" ./src/kclock/qml/SettingsPage.qml:266:name: "30 minutes" ./src/kclock/qml/SettingsPage.qml:270:name: "1 hour" /src/kclock/qml/AlarmListPage.qml:148:if (dayOfWeek & monday) str += "Mon., "; ./src/kclock/qml/AlarmListPage.qml:149:if (dayOfWeek & tuesday) str += "Tue., "; ./src/kclock/qml/AlarmListPage.qml:150:if (dayOfWeek & wednesday) str += "Wed., "; ./src/kclock/qml/AlarmListPage.qml:151:if (dayOfWeek & thursday) str += "Thu., "; ./src/kclock/qml/AlarmListPage.qml:152:if (dayOfWeek & friday) str += "Fri., "; ./src/kclock/qml/AlarmListPage.qml:153:if (dayOfWeek & saturday) str += "Sat., "; ./src/kclock/qml/AlarmListPage.qml:154:if (dayOfWeek & sunday) str += "Sun., "; ./src/kclock/qml/AboutPage.qml:55:"text" : "long, boring, license text", Cheers, Albert > > Regards, > Han >
