Re: Review Request: Added include files for two widgets
On Monday 23 May 2011, Christoph Feck wrote: On May 23, 2011, 9:33 a.m., Christoph Feck wrote: It is not called RantingWidget, please correct it. Otherwise, good catch. Hm, why didn't I get John's mail ... Because all Review Requests going to kde-core-devel (or any other KDE mailing list) have to be approved manually by the moderators and this might take a few hours... Regards, Ingo signature.asc Description: This is a digitally signed message part.
Re: Review Request: Added include files for two widgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101421/#review3458 --- This review has been submitted with commit 5695a04308d33c505301517b5dae4c8c8e0f7168 by Jon Ander Peñalba. - Commit On May 22, 2011, 11:22 p.m., Jon Ander Peñalba wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101421/ --- (Updated May 22, 2011, 11:22 p.m.) Review request for kdelibs. Summary --- KRantingWidget and KShortcutWidget didn't have an include file with the same name as the class, this patch simply adds this files. Diffs - includes/CMakeLists.txt 0a80219 includes/KRantingWidget PRE-CREATION includes/KShortcutWidget PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101421/diff Testing --- Thanks, Jon Ander
Re: Review Request: Added include files for two widgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101421/#review3459 --- It is not called RantingWidget, please correct it. Otherwise, good catch. - Christoph On May 22, 2011, 11:22 p.m., Jon Ander Peñalba wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101421/ --- (Updated May 22, 2011, 11:22 p.m.) Review request for kdelibs. Summary --- KRantingWidget and KShortcutWidget didn't have an include file with the same name as the class, this patch simply adds this files. Diffs - includes/CMakeLists.txt 0a80219 includes/KRantingWidget PRE-CREATION includes/KShortcutWidget PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101421/diff Testing --- Thanks, Jon Ander
