Re: Review Request: Fix wrong whatsThis strings in proxy kcm
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103131/#review8208 --- This review has been submitted with commit 6bf36ac0d2a0e77e334536563ee061d9a90d4b02 by Burkhard Lück to branch master. - Commit Hook On Nov. 14, 2011, 10:24 a.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103131/ --- (Updated Nov. 14, 2011, 10:24 a.m.) Review request for KDE Base Apps and Dawit Alemayehu. Description --- Corrected whatsThis for HTTPS and SOCKS and common port for socks. Could not find any default/common ports for FTP proxy server, therefore removed that. Diffs - konqueror/settings/kio/kproxydlg.ui 2170e7d Diff: http://git.reviewboard.kde.org/r/103131/diff/diff Testing --- Thanks, Burkhard Lück
Re: Review Request: Fix wrong whatsThis strings in proxy kcm
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103131/#review8197 --- Ship it! There is no longer any default value set for any of them. Please remove anything that talks about default values from all and commit that. Thanks. - Dawit Alemayehu On Nov. 14, 2011, 10:24 a.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103131/ --- (Updated Nov. 14, 2011, 10:24 a.m.) Review request for KDE Base Apps and Dawit Alemayehu. Description --- Corrected whatsThis for HTTPS and SOCKS and common port for socks. Could not find any default/common ports for FTP proxy server, therefore removed that. Diffs - konqueror/settings/kio/kproxydlg.ui 2170e7d Diff: http://git.reviewboard.kde.org/r/103131/diff/diff Testing --- Thanks, Burkhard Lück
