Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review5350 --- This review has been submitted with commit 6fe43f5c89e9d9cbb7dabc0b33b42b7c5c1e by Burkhard Lück to branch master. - Commit On July 12, 2011, 5:59 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101921/ > --- > > (Updated July 12, 2011, 5:59 a.m.) > > > Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. > > > Summary > --- > > Preferred form for authors in kde docbooks is &author.name; > &author.name.mail; , where the entifies are defined in > kdelibs/kdoctools/customization/entities/contributor.entities. > > But using this form does not generated the email in the html output, it is > missing see bug 248576, apparently since several years (around 2004). > > > This addresses bug 248576. > http://bugs.kde.org/show_bug.cgi?id=248576 > > > Diffs > - > > kdoctools/customization/kde-ttlpg-online.xsl 523648b > kdoctools/customization/kde-ttlpg.xsl 78d4792 > > Diff: http://git.reviewboard.kde.org/r/101921/diff > > > Testing > --- > > Building kdelibs with the patch generates the email address in the html file, > tested with kdelibs/doc/sonnet/index.docbook > > > Thanks, > > Burkhard > >
Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review5349 --- This review has been submitted with commit 2534d85a86546fa210d32888f49defb95675a14e by Burkhard Lück to branch KDE/4.7. - Commit On July 12, 2011, 5:59 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101921/ > --- > > (Updated July 12, 2011, 5:59 a.m.) > > > Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. > > > Summary > --- > > Preferred form for authors in kde docbooks is &author.name; > &author.name.mail; , where the entifies are defined in > kdelibs/kdoctools/customization/entities/contributor.entities. > > But using this form does not generated the email in the html output, it is > missing see bug 248576, apparently since several years (around 2004). > > > This addresses bug 248576. > http://bugs.kde.org/show_bug.cgi?id=248576 > > > Diffs > - > > kdoctools/customization/kde-ttlpg-online.xsl 523648b > kdoctools/customization/kde-ttlpg.xsl 78d4792 > > Diff: http://git.reviewboard.kde.org/r/101921/diff > > > Testing > --- > > Building kdelibs with the patch generates the email address in the html file, > tested with kdelibs/doc/sonnet/index.docbook > > > Thanks, > > Burkhard > >
Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review4665 --- Ship it! >From my quick tests it seems to work properly. - Luigi On July 12, 2011, 5:59 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101921/ > --- > > (Updated July 12, 2011, 5:59 a.m.) > > > Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. > > > Summary > --- > > Preferred form for authors in kde docbooks is &author.name; > &author.name.mail; , where the entifies are defined in > kdelibs/kdoctools/customization/entities/contributor.entities. > > But using this form does not generated the email in the html output, it is > missing see bug 248576, apparently since several years (around 2004). > > > This addresses bug 248576. > http://bugs.kde.org/show_bug.cgi?id=248576 > > > Diffs > - > > kdoctools/customization/kde-ttlpg-online.xsl 523648b > kdoctools/customization/kde-ttlpg.xsl 78d4792 > > Diff: http://git.reviewboard.kde.org/r/101921/diff > > > Testing > --- > > Building kdelibs with the patch generates the email address in the html file, > tested with kdelibs/doc/sonnet/index.docbook > > > Thanks, > > Burkhard > >
Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review4647 --- Ship it! This fixes the problem for KMyMoney handbook. - Jack On July 12, 2011, 5:59 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101921/ > --- > > (Updated July 12, 2011, 5:59 a.m.) > > > Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. > > > Summary > --- > > Preferred form for authors in kde docbooks is &author.name; > &author.name.mail; , where the entifies are defined in > kdelibs/kdoctools/customization/entities/contributor.entities. > > But using this form does not generated the email in the html output, it is > missing see bug 248576, apparently since several years (around 2004). > > > This addresses bug 248576. > http://bugs.kde.org/show_bug.cgi?id=248576 > > > Diffs > - > > kdoctools/customization/kde-ttlpg-online.xsl 523648b > kdoctools/customization/kde-ttlpg.xsl 78d4792 > > Diff: http://git.reviewboard.kde.org/r/101921/diff > > > Testing > --- > > Building kdelibs with the patch generates the email address in the html file, > tested with kdelibs/doc/sonnet/index.docbook > > > Thanks, > > Burkhard > >
Re: Review Request: Generate email for docbook authors
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/ --- (Updated July 12, 2011, 5:59 a.m.) Review request for kdelibs, Tom Albers, Luigi Toscano, and Jack Ostroff. Changes --- Adding Jack Ostroff who found this problem with the KMyMoney handbook Summary --- Preferred form for authors in kde docbooks is &author.name; &author.name.mail; , where the entifies are defined in kdelibs/kdoctools/customization/entities/contributor.entities. But using this form does not generated the email in the html output, it is missing see bug 248576, apparently since several years (around 2004). This addresses bug 248576. http://bugs.kde.org/show_bug.cgi?id=248576 Diffs - kdoctools/customization/kde-ttlpg-online.xsl 523648b kdoctools/customization/kde-ttlpg.xsl 78d4792 Diff: http://git.reviewboard.kde.org/r/101921/diff Testing --- Building kdelibs with the patch generates the email address in the html file, tested with kdelibs/doc/sonnet/index.docbook Thanks, Burkhard
