Re: Review Request: qml based kwin shadow

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review25138
---


This review has been submitted with commit 
c58962b112627de29f06e4bf21a1dce0fccab0cc by Weng Xuetian to branch KDE/4.10.

- Commit Hook


On Jan. 8, 2013, 12:21 a.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 8, 2013, 12:21 a.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/IconTabBox.qml 23bb11b 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: qml based kwin shadow

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review25132
---

Ship it!


the duplication tells me we should someday add a shared base element for all 
the different kinds of TabBoxes.

Apart from the issue below, it's fine to go in. Thanks for taking care of it.


kwin/tabbox/qml/ShadowedSvgItem.qml


copyright missing


- Martin Gräßlin


On Jan. 8, 2013, 12:21 a.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 8, 2013, 12:21 a.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/IconTabBox.qml 23bb11b 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: qml based kwin shadow

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/
---

(Updated Jan. 8, 2013, 12:21 a.m.)


Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, 
Marco Martin, and Martin Gräßlin.


Changes
---

make sure shapeMask is cleared after possible theme change.


Description
---

This is a different solution solve problem in 
https://git.reviewboard.kde.org/r/108224/

1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.


Diffs (updated)
-

  kwin/tabbox/declarative.cpp 3bdcfac 
  kwin/tabbox/qml/CMakeLists.txt d4bc863 
  kwin/tabbox/qml/IconTabBox.qml 23bb11b 
  kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
  kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
  kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
  kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
  kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
  kwin/tabbox/qml/tabbox.qml 4176231 

Diff: http://git.reviewboard.kde.org/r/108243/diff/


Testing
---

all desktop tabbox is tested with Air and Slim Glow, composite and 
non-composite, no problem.


Thanks,

Xuetian Weng

Re: Review Request: qml based kwin shadow

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/
---

(Updated Jan. 7, 2013, 7:01 p.m.)


Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, 
Marco Martin, and Martin Gräßlin.


Changes
---

use prefix from frameSvg as shadow instead of multiple svg item


Description
---

This is a different solution solve problem in 
https://git.reviewboard.kde.org/r/108224/

1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.


Diffs (updated)
-

  kwin/tabbox/declarative.cpp 3bdcfac 
  kwin/tabbox/qml/CMakeLists.txt d4bc863 
  kwin/tabbox/qml/IconTabBox.qml 23bb11b 
  kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
  kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
  kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
  kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
  kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
  kwin/tabbox/qml/tabbox.qml 4176231 

Diff: http://git.reviewboard.kde.org/r/108243/diff/


Testing
---

all desktop tabbox is tested with Air and Slim Glow, composite and 
non-composite, no problem.


Thanks,

Xuetian Weng

Re: Review Request: qml based kwin shadow

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/
---

(Updated Jan. 7, 2013, 5:49 p.m.)


Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, 
Marco Martin, and Martin Gräßlin.


Changes
---

still multiple copy file for now.


Description
---

This is a different solution solve problem in 
https://git.reviewboard.kde.org/r/108224/

1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.


Diffs (updated)
-

  kwin/tabbox/declarative.cpp 3bdcfac 
  kwin/tabbox/qml/CMakeLists.txt d4bc863 
  kwin/tabbox/qml/IconTabBox.qml 23bb11b 
  kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
  kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
  kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
  kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
  kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
  kwin/tabbox/qml/tabbox.qml 4176231 

Diff: http://git.reviewboard.kde.org/r/108243/diff/


Testing
---

all desktop tabbox is tested with Air and Slim Glow, composite and 
non-composite, no problem.


Thanks,

Xuetian Weng

Re: Review Request: qml based kwin shadow

[Xuetian Weng]

> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote:
> > kwin/tabbox/qml/qmldir, line 2
> > 
> >
> > please don't include the IconTabBox in the qmldir. I consider it 
> > private API :-)

I saw IconTabBox is used twice.. so I just guess it should be put some where.

Actually no one objects, I would also like to consider that ShadowedSvgItem for 
private API in 4.10 .. and improve it to something really useful in KDE 4.10 
(current one is half-baked)


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review24924
---


On Jan. 7, 2013, 4:07 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 7, 2013, 4:07 p.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/IconTabBox.qml 23bb11b 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/qmldir PRE-CREATION 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: qml based kwin shadow

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/
---

(Updated Jan. 7, 2013, 4:07 p.m.)


Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, 
Marco Martin, and Martin Gräßlin.


Changes
---

so how about move them into org.kde.kwin.tabbox?

BTW, desktopchangeosd uses PlasmaCore.Dialog, so it doesn't have shadow problem 
I think.


Description
---

This is a different solution solve problem in 
https://git.reviewboard.kde.org/r/108224/

1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.


Diffs (updated)
-

  kwin/tabbox/declarative.cpp 3bdcfac 
  kwin/tabbox/qml/CMakeLists.txt d4bc863 
  kwin/tabbox/qml/IconTabBox.qml 23bb11b 
  kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
  kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
  kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
  kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
  kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
  kwin/tabbox/qml/qmldir PRE-CREATION 
  kwin/tabbox/qml/tabbox.qml 4176231 

Diff: http://git.reviewboard.kde.org/r/108243/diff/


Testing
---

all desktop tabbox is tested with Air and Slim Glow, composite and 
non-composite, no problem.


Thanks,

Xuetian Weng

Re: Review Request: qml based kwin shadow

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review24933
---



kwin/tabbox/qml/ShadowedSvgItem.qml


you could even just do a FrameSvg on the "shadow" prefix

then the child will be anchored to it using the shadow element sizes as 
margins for top,right,left etc

is simpler code and less qobjects in memory vs. a bit more pixmap memory, 
so has advantages and disadvantages so your call ;)


- Marco Martin


On Jan. 7, 2013, 5:49 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 7, 2013, 5:49 p.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/IconTabBox.qml 23bb11b 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: qml based kwin shadow

[Martin Gräßlin]

> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote:
> > kwin/tabbox/qml/qmldir, line 2
> > 
> >
> > please don't include the IconTabBox in the qmldir. I consider it 
> > private API :-)
> 
> Xuetian Weng wrote:
> I saw IconTabBox is used twice.. so I just guess it should be put some 
> where.
> 
> Actually no one objects, I would also like to consider that 
> ShadowedSvgItem for private API in 4.10 .. and improve it to something really 
> useful in KDE 4.10 (current one is half-baked)

that's of course fine with me (if you meant improving in 4.11 ;-). But then we 
maybe should not move it into a package and go for the multiple copy approach 
of your first patch for the 4.10 branch.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review24924
---


On Jan. 7, 2013, 4:07 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 7, 2013, 4:07 p.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/IconTabBox.qml 23bb11b 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/qmldir PRE-CREATION 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: qml based kwin shadow

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review24924
---


I need to think about whether I want to have it in org.kde.kwin.tabbox or 
org.kde.kwin. Even if the QML scripts work with Plasma.Dialog I'm not sure 
whether we should continue to use it or better have our own component which 
uses the background (and some other KWin specific adjustments). I just don't 
like the thought of KWin communicating with KWin through X :-) For 4.10 it 
shall be Plasma.Dialog there of course.


kwin/tabbox/qml/qmldir


please don't include the IconTabBox in the qmldir. I consider it private 
API :-)


- Martin Gräßlin


On Jan. 7, 2013, 4:07 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 7, 2013, 4:07 p.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/IconTabBox.qml 23bb11b 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/qmldir PRE-CREATION 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

Re: Review Request: qml based kwin shadow

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review24920
---


Approach seems fine to me (though I haven't tested it yet). I'm wondering 
whether this could become part of Plasma Components?

In case not we should move it somewhere to make it part of the "KWin 
components" as we also need that in the KWin scripts (e.g. desktop change OSD).


kwin/tabbox/declarative.cpp


nitpick: coding style
} else {



kwin/tabbox/declarative.cpp


all the variables are only set once, so maybe const them?



kwin/tabbox/declarative.cpp


watch the whitespaces

(in case you use any Kate-based editor: there's an option to only remove 
whitespaces on changed lines)


- Martin Gräßlin


On Jan. 7, 2013, 3:11 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> ---
> 
> (Updated Jan. 7, 2013, 3:11 p.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. 
> Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> This is a different solution solve problem in 
> https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> ---
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and 
> non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>