Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102234 --- Mr Leszek, I'm very sorry we failed to commit this 3 years ago when you proposed this patch. On the other hand you never answered Burkhard about his very valid concern of the new strings you're adding being basically untraslatable because they are not extracted to any .po file (and probably no catalog to translate them is loaded either). I'll give you some time to address that issue, but I can understand that you may very well not be interested anymore. If nothing has happened to this review request in 3 months I'll discard it. - Albert Astals Cid On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114437/ > --- > > (Updated Dec. 13, 2013, 3:37 p.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > --- > > This adds a right click context menu for PlasmaComponents.TextField which > allows to cut, copy and paste text. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f > > Diff: https://git.reviewboard.kde.org/r/114437/diff/ > > > Testing > --- > > > Thanks, > > Leszek Lesner > >
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. > > Sebastian Kügler wrote: > I'd just discard it. I don't think anybody is releasing kde-runtime > anyway, and the proper way to fix this is to do it in QtQuick component's > Label. Thanks for cleaning up, though! > > Albert Astals Cid wrote: > I do release kde-runtime > > > http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.12.1.tar.xz.mirrorlist Ah, okay. Up to you then. I think this patch is rather safe, but I wouldn't want to get support calls for a regression... - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102202 --- On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114437/ > --- > > (Updated Dec. 13, 2013, 3:37 p.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > --- > > This adds a right click context menu for PlasmaComponents.TextField which > allows to cut, copy and paste text. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f > > Diff: https://git.reviewboard.kde.org/r/114437/diff/ > > > Testing > --- > > > Thanks, > > Leszek Lesner > >
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. > > Sebastian Kügler wrote: > I'd just discard it. I don't think anybody is releasing kde-runtime > anyway, and the proper way to fix this is to do it in QtQuick component's > Label. Thanks for cleaning up, though! I do release kde-runtime http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.12.1.tar.xz.mirrorlist - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102202 --- On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114437/ > --- > > (Updated Dec. 13, 2013, 3:37 p.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > --- > > This adds a right click context menu for PlasmaComponents.TextField which > allows to cut, copy and paste text. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f > > Diff: https://git.reviewboard.kde.org/r/114437/diff/ > > > Testing > --- > > > Thanks, > > Leszek Lesner > >
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. I'd just discard it. I don't think anybody is releasing kde-runtime anyway, and the proper way to fix this is to do it in QtQuick component's Label. Thanks for cleaning up, though! - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102202 --- On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114437/ > --- > > (Updated Dec. 13, 2013, 3:37 p.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > --- > > This adds a right click context menu for PlasmaComponents.TextField which > allows to cut, copy and paste text. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f > > Diff: https://git.reviewboard.kde.org/r/114437/diff/ > > > Testing > --- > > > Thanks, > > Leszek Lesner > >
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102202 --- Sebas should I commited this? After 3 years i'm not sure kde-runtime is the best thing to update in it's almost frozen state. - Albert Astals Cid On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114437/ > --- > > (Updated Dec. 13, 2013, 3:37 p.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > --- > > This adds a right click context menu for PlasmaComponents.TextField which > allows to cut, copy and paste text. > > > Diffs > - > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f > > Diff: https://git.reviewboard.kde.org/r/114437/diff/ > > > Testing > --- > > > Thanks, > > Leszek Lesner > >
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45699 --- Ship it! Looks good. - Sebastian Kügler On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:37 p.m.) Review request for KDE Runtime. Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45652 --- Two comments inline. plasma/declarativeimports/plasmacomponents/qml/TextField.qml http://git.reviewboard.kde.org/r/114437/#comment32612 Use i18n() here plasma/declarativeimports/plasmacomponents/qml/TextField.qml http://git.reviewboard.kde.org/r/114437/#comment32613 i18n() here as well - Sebastian Kügler On Dec. 13, 2013, 3:01 p.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:01 p.m.) Review request for KDE Runtime. Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45654 --- plasma/declarativeimports/plasmacomponents/qml/TextField.qml http://git.reviewboard.kde.org/r/114437/#comment32615 ...and here as well :) - Lukáš Tinkl On Dec. 13, 2013, 4:01 p.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 4:01 p.m.) Review request for KDE Runtime. Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:35 p.m.) Review request for KDE Runtime. Changes --- Updated the diff to select text in textinput right after calling open upon the contextmenu. Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs (updated) - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:37 p.m.) Review request for KDE Runtime. Changes --- Use i18n() instead of qsTr() Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs (updated) - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45657 --- Where is the message extraction for these i18n() ? - Burkhard Lück On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:37 p.m.) Review request for KDE Runtime. Repository: kde-runtime Description --- This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. Diffs - plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f Diff: http://git.reviewboard.kde.org/r/114437/diff/ Testing --- Thanks, Leszek Lesner
