Re: Review Request 114473: Change modality of dialog in KRun::displayOpenWithDialog to Qt::WindowModal

2014-02-12 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114473/#review49638
---


This review has been submitted with commit 
6d99b077800b62c68370a1e916a64ffcbc2bb73d by Dawit Alemayehu to branch master.

- Commit Hook


On Dec. 22, 2013, 1:29 p.m., Dawit Alemayehu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114473/
 ---
 
 (Updated Dec. 22, 2013, 1:29 p.m.)
 
 
 Review request for kdelibs and David Faure.
 
 
 Bugs: 153421
 http://bugs.kde.org/show_bug.cgi?id=153421
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 The attached patch changes the KOpenWith dialog in 
 KRun::displayOpenWithDialog from blocking Konqueror windows when a user 
 clicks on OpenWith in the context menu or unknown file in the Dolphin part.
 
 
 Diffs
 -
 
   kio/kio/krun.cpp ad5656e 
 
 Diff: https://git.reviewboard.kde.org/r/114473/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dawit Alemayehu
 




Re: Review Request 114473: Change modality of dialog in KRun::displayOpenWithDialog to Qt::WindowModal

2013-12-22 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114473/#review46040
---


This review has been submitted with commit 
f44119a6271aeb142de83753a02ec5cef0bf4ac8 by Dawit Alemayehu to branch KDE/4.12.

- Commit Hook


On Dec. 15, 2013, 1:31 p.m., Dawit Alemayehu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114473/
 ---
 
 (Updated Dec. 15, 2013, 1:31 p.m.)
 
 
 Review request for kdelibs and David Faure.
 
 
 Bugs: 153421
 http://bugs.kde.org/show_bug.cgi?id=153421
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 The attached patch changes the KOpenWith dialog in 
 KRun::displayOpenWithDialog from blocking Konqueror windows when a user 
 clicks on OpenWith in the context menu or unknown file in the Dolphin part.
 
 
 Diffs
 -
 
   kio/kio/krun.cpp ad5656e 
 
 Diff: https://git.reviewboard.kde.org/r/114473/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dawit Alemayehu
 




Re: Review Request 114473: Change modality of dialog in KRun::displayOpenWithDialog to Qt::WindowModal

2013-12-22 Thread Dawit Alemayehu

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114473/
---

(Updated Dec. 22, 2013, 1:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Bugs: 153421
http://bugs.kde.org/show_bug.cgi?id=153421


Repository: kdelibs


Description
---

The attached patch changes the KOpenWith dialog in KRun::displayOpenWithDialog 
from blocking Konqueror windows when a user clicks on OpenWith in the context 
menu or unknown file in the Dolphin part.


Diffs
-

  kio/kio/krun.cpp ad5656e 

Diff: https://git.reviewboard.kde.org/r/114473/diff/


Testing
---


Thanks,

Dawit Alemayehu